[Buildroot] [PATCH v2] libubox: enable static build

[Buildroot] [PATCH v2] libubox: enable static build

[Rahul Jain]

upstream has added the support to build the static libraries.
update comment for BR2_STATIC_LIBS for other packages having
dependency on libubox.

Signed-off-by: Rahul Jain <Rahul.Jain@imgtec.com>
---
Changes V1 - V2:
 - Add comments in ubus and ustream-ssl Config.in file for 
   !BR2_STATIC_LIBS

 package/libubox/Config.in     | 4 ----
 package/ubus/Config.in        | 2 +-
 package/ustream-ssl/Config.in | 2 +-
 3 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/package/libubox/Config.in b/package/libubox/Config.in
index 25ef4bb..ba10f8d 100644
--- a/package/libubox/Config.in
+++ b/package/libubox/Config.in
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_LIBUBOX
 	bool "libubox"
-	depends on !BR2_STATIC_LIBS
 	help
 	  This library originates from the OpenWrt project to
 	  handle the configuration file infrastructure, but can
@@ -8,6 +7,3 @@ config BR2_PACKAGE_LIBUBOX
 	  than OpenWrt.
 
 	  http://nbd.name/gitweb.cgi?p=luci2/libubox.git;a=summary
-
-comment "libubox needs a toolchain w/ dynamic library"
-	depends on BR2_STATIC_LIBS
diff --git a/package/ubus/Config.in b/package/ubus/Config.in
index c14f6a8..15aac37 100644
--- a/package/ubus/Config.in
+++ b/package/ubus/Config.in
@@ -7,7 +7,7 @@ config BR2_PACKAGE_UBUS
 	select BR2_PACKAGE_LIBUBOX
 	select BR2_PACKAGE_JSON_C
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # json-c
-	depends on !BR2_STATIC_LIBS # libubox
+	depends on !BR2_STATIC_LIBS # no support to build static libraries
 	help
 	  IPC/RPC bus that allows communication between processes.
 
diff --git a/package/ustream-ssl/Config.in b/package/ustream-ssl/Config.in
index 540e436..7e9726f 100644
--- a/package/ustream-ssl/Config.in
+++ b/package/ustream-ssl/Config.in
@@ -1,6 +1,6 @@
 config BR2_PACKAGE_USTREAM_SSL
 	bool "ustream-ssl"
-	depends on !BR2_STATIC_LIBS #libubox
+	depends on !BR2_STATIC_LIBS # no support to build static libraries
 	select BR2_PACKAGE_LIBUBOX
 	select BR2_PACKAGE_OPENSSL if !BR2_PACKAGE_MBEDTLS
 	help
-- 
2.6.2

[Buildroot] [PATCH v2] libubox: enable static build

[Thomas Petazzoni]

Hello,

On Wed, 29 Mar 2017 16:21:00 +0530, Rahul Jain wrote:
> upstream has added the support to build the static libraries.
> update comment for BR2_STATIC_LIBS for other packages having
> dependency on libubox.
> 
> Signed-off-by: Rahul Jain <Rahul.Jain@imgtec.com>

Did you test this? libubox tries to unconditionally build a shared
library, so it breaks the build with a static only configuration. Try
this configuration with your patch applied:

BR2_arm=y
BR2_STATIC_LIBS=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-static-2017.02-rc1-70-g7612a7d.tar.bz2"
BR2_TOOLCHAIN_EXTERNAL_GCC_5=y
BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_10=y
BR2_TOOLCHAIN_EXTERNAL_LOCALE=y
# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
BR2_TOOLCHAIN_EXTERNAL_INET_RPC=y
BR2_TOOLCHAIN_EXTERNAL_CXX=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_LIBUBOX=y
# BR2_TARGET_ROOTFS_TAR is not set

BR2_STATIC_LIBS is not about being able to build a static library, it's
about using static libraries *only*.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com