* [PATCH 0/2] virtio: two small improvements
@ 2017-03-30 11:13 ` Cornelia Huck
0 siblings, 0 replies; 8+ messages in thread
From: Cornelia Huck @ 2017-03-30 11:13 UTC (permalink / raw)
To: mst; +Cc: Cornelia Huck, linux-kernel, virtualization
Just some stuff I noticed while looking at virtio patches.
Cornelia Huck (2):
MAINTAINERS: fix virtio file pattern
virtio: virtio_driver doc
MAINTAINERS | 2 +-
include/linux/virtio.h | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
--
2.8.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] MAINTAINERS: fix virtio file pattern
2017-03-30 11:13 ` Cornelia Huck
@ 2017-03-30 11:13 ` Cornelia Huck
-1 siblings, 0 replies; 8+ messages in thread
From: Cornelia Huck @ 2017-03-30 11:13 UTC (permalink / raw)
To: mst; +Cc: virtualization, linux-kernel, Cornelia Huck
The pattern did not catch include/linux/virtio.h.
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index a9ae6c1..f96b3f9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10902,7 +10902,7 @@ F: drivers/virtio/
F: tools/virtio/
F: drivers/net/virtio_net.c
F: drivers/block/virtio_blk.c
-F: include/linux/virtio_*.h
+F: include/linux/virtio*.h
F: include/uapi/linux/virtio_*.h
VIRTIO DRIVERS FOR S390
--
2.8.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/2] MAINTAINERS: fix virtio file pattern
@ 2017-03-30 11:13 ` Cornelia Huck
0 siblings, 0 replies; 8+ messages in thread
From: Cornelia Huck @ 2017-03-30 11:13 UTC (permalink / raw)
To: mst; +Cc: Cornelia Huck, linux-kernel, virtualization
The pattern did not catch include/linux/virtio.h.
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index a9ae6c1..f96b3f9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10902,7 +10902,7 @@ F: drivers/virtio/
F: tools/virtio/
F: drivers/net/virtio_net.c
F: drivers/block/virtio_blk.c
-F: include/linux/virtio_*.h
+F: include/linux/virtio*.h
F: include/uapi/linux/virtio_*.h
VIRTIO DRIVERS FOR S390
--
2.8.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] virtio: virtio_driver doc
2017-03-30 11:13 ` Cornelia Huck
(?)
(?)
@ 2017-03-30 11:13 ` Cornelia Huck
-1 siblings, 0 replies; 8+ messages in thread
From: Cornelia Huck @ 2017-03-30 11:13 UTC (permalink / raw)
To: mst; +Cc: virtualization, linux-kernel, Cornelia Huck
Add comments for the virtio_driver members that were not documented.
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
include/linux/virtio.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/linux/virtio.h b/include/linux/virtio.h
index 8f4d4bf..e80adf2 100644
--- a/include/linux/virtio.h
+++ b/include/linux/virtio.h
@@ -133,9 +133,13 @@ int virtio_device_restore(struct virtio_device *dev);
* @feature_table_legacy: same as feature_table but when working in legacy mode.
* @feature_table_size_legacy: number of entries in feature table legacy array.
* @probe: the function to call when a device is found. Returns 0 or -errno.
+ * @scan: optional function to call after successful probe; intended
+ * for virtio-scsi to invoke a scan.
* @remove: the function to call when a device is removed.
* @config_changed: optional function to call when the device configuration
* changes; may be called in interrupt context.
+ * @freeze: optional function to call during suspend/hibernation.
+ * @restore: optional function to call on resume.
*/
struct virtio_driver {
struct device_driver driver;
--
2.8.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/2] virtio: virtio_driver doc
2017-03-30 11:13 ` Cornelia Huck
` (2 preceding siblings ...)
(?)
@ 2017-03-30 11:13 ` Cornelia Huck
-1 siblings, 0 replies; 8+ messages in thread
From: Cornelia Huck @ 2017-03-30 11:13 UTC (permalink / raw)
To: mst; +Cc: Cornelia Huck, linux-kernel, virtualization
Add comments for the virtio_driver members that were not documented.
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
include/linux/virtio.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/linux/virtio.h b/include/linux/virtio.h
index 8f4d4bf..e80adf2 100644
--- a/include/linux/virtio.h
+++ b/include/linux/virtio.h
@@ -133,9 +133,13 @@ int virtio_device_restore(struct virtio_device *dev);
* @feature_table_legacy: same as feature_table but when working in legacy mode.
* @feature_table_size_legacy: number of entries in feature table legacy array.
* @probe: the function to call when a device is found. Returns 0 or -errno.
+ * @scan: optional function to call after successful probe; intended
+ * for virtio-scsi to invoke a scan.
* @remove: the function to call when a device is removed.
* @config_changed: optional function to call when the device configuration
* changes; may be called in interrupt context.
+ * @freeze: optional function to call during suspend/hibernation.
+ * @restore: optional function to call on resume.
*/
struct virtio_driver {
struct device_driver driver;
--
2.8.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 0/2] virtio: two small improvements
2017-03-30 11:13 ` Cornelia Huck
` (3 preceding siblings ...)
(?)
@ 2017-03-30 15:00 ` Michael S. Tsirkin
-1 siblings, 0 replies; 8+ messages in thread
From: Michael S. Tsirkin @ 2017-03-30 15:00 UTC (permalink / raw)
To: Cornelia Huck; +Cc: virtualization, linux-kernel
On Thu, Mar 30, 2017 at 01:13:31PM +0200, Cornelia Huck wrote:
> Just some stuff I noticed while looking at virtio patches.
Applied, thanks!
> Cornelia Huck (2):
> MAINTAINERS: fix virtio file pattern
> virtio: virtio_driver doc
>
> MAINTAINERS | 2 +-
> include/linux/virtio.h | 4 ++++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> --
> 2.8.4
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 0/2] virtio: two small improvements
2017-03-30 11:13 ` Cornelia Huck
` (4 preceding siblings ...)
(?)
@ 2017-03-30 15:00 ` Michael S. Tsirkin
-1 siblings, 0 replies; 8+ messages in thread
From: Michael S. Tsirkin @ 2017-03-30 15:00 UTC (permalink / raw)
To: Cornelia Huck; +Cc: linux-kernel, virtualization
On Thu, Mar 30, 2017 at 01:13:31PM +0200, Cornelia Huck wrote:
> Just some stuff I noticed while looking at virtio patches.
Applied, thanks!
> Cornelia Huck (2):
> MAINTAINERS: fix virtio file pattern
> virtio: virtio_driver doc
>
> MAINTAINERS | 2 +-
> include/linux/virtio.h | 4 ++++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> --
> 2.8.4
^ permalink raw reply [flat|nested] 8+ messages in thread