From: Andrew Morton <akpm@linux-foundation.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: kernel test robot <xiaolong.ye@intel.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Mel Gorman <mgorman@techsingularity.net>,
Johannes Weiner <hannes@cmpxchg.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
David Rientjes <rientjes@google.com>,
LKML <linux-kernel@vger.kernel.org>,
lkp@01.org
Subject: Re: [lkp-robot] [mm, page_alloc] b7ef62aa8a: BUG:kernel_hang_in_boot_stage
Date: Thu, 30 Mar 2017 15:40:26 -0700 [thread overview]
Message-ID: <20170330154026.3ca919cf3b93da81c25724c4@linux-foundation.org> (raw)
In-Reply-To: <59d71b35-d556-4fc9-ee2e-1574259282fd@suse.cz>
> > BUG: kernel hang in boot stage
>
> Thanks, I was able to reproduce and debug this.
> Andrew, please apply the following -fix. There will be conflicts on later
> patches, but with trivial resolution (pages -> free_pages). Thanks!
>
> ...
>
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -1977,6 +1977,9 @@ static void steal_suitable_fallback(struct zone *zone, struct page *page,
> goto single_page;
>
> pages = move_freepages_block(zone, page, start_type);
> + /* moving whole block can fail due to zone boundary conditions */
> + if (!pages)
> + goto single_page;
>
> /* Claim the whole block if over half of it is free */
> if (pages >= (1 << (pageblock_order-1)) ||
The result is a bit odd:
free_pages = move_freepages_block(zone, page, start_type,
&movable_pages);
/*
* Determine how many pages are compatible with our allocation.
* For movable allocation, it's the number of movable pages which
* we just obtained. For other types it's a bit more tricky.
*/
if (start_type == MIGRATE_MOVABLE) {
alike_pages = movable_pages;
} else {
/*
* If we are falling back a RECLAIMABLE or UNMOVABLE allocation
* to MOVABLE pageblock, consider all non-movable pages as
* compatible. If it's UNMOVABLE falling back to RECLAIMABLE or
* vice versa, be conservative since we can't distinguish the
* exact migratetype of non-movable pages.
*/
if (old_block_type == MIGRATE_MOVABLE)
alike_pages = pageblock_nr_pages
- (free_pages + movable_pages);
else
alike_pages = 0;
}
/* moving whole block can fail due to zone boundary conditions */
if (!free_pages)
goto single_page;
should we do `goto single_page' as soon as the move_freepages_block()
call fails?
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: lkp@lists.01.org
Subject: Re: [lkp-robot] [mm, page_alloc] b7ef62aa8a: BUG:kernel_hang_in_boot_stage
Date: Thu, 30 Mar 2017 15:40:26 -0700 [thread overview]
Message-ID: <20170330154026.3ca919cf3b93da81c25724c4@linux-foundation.org> (raw)
In-Reply-To: <59d71b35-d556-4fc9-ee2e-1574259282fd@suse.cz>
[-- Attachment #1: Type: text/plain, Size: 1788 bytes --]
> > BUG: kernel hang in boot stage
>
> Thanks, I was able to reproduce and debug this.
> Andrew, please apply the following -fix. There will be conflicts on later
> patches, but with trivial resolution (pages -> free_pages). Thanks!
>
> ...
>
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -1977,6 +1977,9 @@ static void steal_suitable_fallback(struct zone *zone, struct page *page,
> goto single_page;
>
> pages = move_freepages_block(zone, page, start_type);
> + /* moving whole block can fail due to zone boundary conditions */
> + if (!pages)
> + goto single_page;
>
> /* Claim the whole block if over half of it is free */
> if (pages >= (1 << (pageblock_order-1)) ||
The result is a bit odd:
free_pages = move_freepages_block(zone, page, start_type,
&movable_pages);
/*
* Determine how many pages are compatible with our allocation.
* For movable allocation, it's the number of movable pages which
* we just obtained. For other types it's a bit more tricky.
*/
if (start_type == MIGRATE_MOVABLE) {
alike_pages = movable_pages;
} else {
/*
* If we are falling back a RECLAIMABLE or UNMOVABLE allocation
* to MOVABLE pageblock, consider all non-movable pages as
* compatible. If it's UNMOVABLE falling back to RECLAIMABLE or
* vice versa, be conservative since we can't distinguish the
* exact migratetype of non-movable pages.
*/
if (old_block_type == MIGRATE_MOVABLE)
alike_pages = pageblock_nr_pages
- (free_pages + movable_pages);
else
alike_pages = 0;
}
/* moving whole block can fail due to zone boundary conditions */
if (!free_pages)
goto single_page;
should we do `goto single_page' as soon as the move_freepages_block()
call fails?
next prev parent reply other threads:[~2017-03-30 22:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 4:36 [lkp-robot] [mm, page_alloc] b7ef62aa8a: BUG:kernel_hang_in_boot_stage kernel test robot
2017-03-22 4:36 ` kernel test robot
2017-03-28 12:32 ` Vlastimil Babka
2017-03-28 12:32 ` Vlastimil Babka
2017-03-30 22:40 ` Andrew Morton [this message]
2017-03-30 22:40 ` Andrew Morton
2017-03-31 7:13 ` Vlastimil Babka
2017-03-31 7:13 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330154026.3ca919cf3b93da81c25724c4@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=mgorman@techsingularity.net \
--cc=rientjes@google.com \
--cc=sfr@canb.auug.org.au \
--cc=vbabka@suse.cz \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.