* [PATCH] drm/i915: disable KASAN for handlers @ 2017-03-30 9:46 ` Jiri Slaby 0 siblings, 0 replies; 11+ messages in thread From: Jiri Slaby @ 2017-03-30 9:46 UTC (permalink / raw) To: zhenyuw Cc: linux-kernel, Jiri Slaby, Martin Liska, Zhi Wang, Daniel Vetter, Jani Nikula, David Airlie, intel-gvt-dev, intel-gfx, dri-devel Handlers are currently the only blocker to compile the kernel with gcc 7 and KASAN+use-after-scope enabled: drivers/gpu/drm/i915/gvt/handlers.c:2200:1: error: the frame size of 43760 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] drivers/gpu/drm/i915/gvt/handlers.c:2402:1: error: the frame size of 9400 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] drivers/gpu/drm/i915/gvt/handlers.c:2628:1: error: the frame size of 11256 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] It is due to many expansions of MMIO_* macros in init_generic_mmio_info. INTEL_GVT_MMIO_OFFSET generates for each such line a __reg and an offset. There are too many for KASAN to keep up. So disable KASAN for this file. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Martin Liska <mliska@suse.cz> Cc: Zhenyu Wang <zhenyuw@linux.intel.com> Cc: Zhi Wang <zhi.a.wang@intel.com> Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: David Airlie <airlied@linux.ie> Cc: intel-gvt-dev@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/i915/gvt/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/gvt/Makefile b/drivers/gpu/drm/i915/gvt/Makefile index b123c20e2097..942f1849d194 100644 --- a/drivers/gpu/drm/i915/gvt/Makefile +++ b/drivers/gpu/drm/i915/gvt/Makefile @@ -6,3 +6,5 @@ GVT_SOURCE := gvt.o aperture_gm.o handlers.o vgpu.o trace_points.o firmware.o \ ccflags-y += -I$(src) -I$(src)/$(GVT_DIR) -Wall i915-y += $(addprefix $(GVT_DIR)/, $(GVT_SOURCE)) obj-$(CONFIG_DRM_I915_GVT_KVMGT) += $(GVT_DIR)/kvmgt.o + +KASAN_SANITIZE_handlers.o := n -- 2.12.2 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH] drm/i915: disable KASAN for handlers @ 2017-03-30 9:46 ` Jiri Slaby 0 siblings, 0 replies; 11+ messages in thread From: Jiri Slaby @ 2017-03-30 9:46 UTC (permalink / raw) To: zhenyuw Cc: intel-gvt-dev, Jiri Slaby, intel-gfx, linux-kernel, dri-devel, Daniel Vetter, Martin Liska, Zhi Wang Handlers are currently the only blocker to compile the kernel with gcc 7 and KASAN+use-after-scope enabled: drivers/gpu/drm/i915/gvt/handlers.c:2200:1: error: the frame size of 43760 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] drivers/gpu/drm/i915/gvt/handlers.c:2402:1: error: the frame size of 9400 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] drivers/gpu/drm/i915/gvt/handlers.c:2628:1: error: the frame size of 11256 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] It is due to many expansions of MMIO_* macros in init_generic_mmio_info. INTEL_GVT_MMIO_OFFSET generates for each such line a __reg and an offset. There are too many for KASAN to keep up. So disable KASAN for this file. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Martin Liska <mliska@suse.cz> Cc: Zhenyu Wang <zhenyuw@linux.intel.com> Cc: Zhi Wang <zhi.a.wang@intel.com> Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: David Airlie <airlied@linux.ie> Cc: intel-gvt-dev@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/i915/gvt/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/gvt/Makefile b/drivers/gpu/drm/i915/gvt/Makefile index b123c20e2097..942f1849d194 100644 --- a/drivers/gpu/drm/i915/gvt/Makefile +++ b/drivers/gpu/drm/i915/gvt/Makefile @@ -6,3 +6,5 @@ GVT_SOURCE := gvt.o aperture_gm.o handlers.o vgpu.o trace_points.o firmware.o \ ccflags-y += -I$(src) -I$(src)/$(GVT_DIR) -Wall i915-y += $(addprefix $(GVT_DIR)/, $(GVT_SOURCE)) obj-$(CONFIG_DRM_I915_GVT_KVMGT) += $(GVT_DIR)/kvmgt.o + +KASAN_SANITIZE_handlers.o := n -- 2.12.2 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 11+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: disable KASAN for handlers 2017-03-30 9:46 ` Jiri Slaby (?) @ 2017-03-30 11:50 ` Patchwork -1 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2017-03-30 11:50 UTC (permalink / raw) To: Jiri Slaby; +Cc: intel-gfx == Series Details == Series: drm/i915: disable KASAN for handlers URL : https://patchwork.freedesktop.org/series/22184/ State : success == Summary == Series 22184v1 drm/i915: disable KASAN for handlers https://patchwork.freedesktop.org/api/1.0/series/22184/revisions/1/mbox/ Test gem_exec_suspend: Subgroup basic-s4-devices: dmesg-warn -> PASS (fi-kbl-7560u) fdo#100125 Test kms_flip: Subgroup basic-flip-vs-wf_vblank: fail -> PASS (fi-skl-6770hq) fdo#99739 fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125 fdo#99739 https://bugs.freedesktop.org/show_bug.cgi?id=99739 fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time: 430s fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time: 423s fi-bsw-n3050 total:278 pass:239 dwarn:0 dfail:0 fail:0 skip:39 time: 579s fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time: 508s fi-bxt-t5700 total:278 pass:258 dwarn:0 dfail:0 fail:0 skip:20 time: 556s fi-byt-j1900 total:278 pass:251 dwarn:0 dfail:0 fail:0 skip:27 time: 481s fi-byt-n2820 total:278 pass:247 dwarn:0 dfail:0 fail:0 skip:31 time: 481s fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 415s fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 407s fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time: 422s fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 485s fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 462s fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 454s fi-kbl-7560u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 568s fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 452s fi-skl-6700hq total:278 pass:261 dwarn:0 dfail:0 fail:0 skip:17 time: 575s fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time: 456s fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 490s fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time: 433s fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time: 534s fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29 time: 407s 66e17cacf58689a0d6ca38138217e667d100a64a drm-tip: 2017y-03m-30d-10h-12m-59s UTC integration manifest 1c3a289 drm/i915: disable KASAN for handlers == Logs == For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4357/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: disable KASAN for handlers 2017-03-30 9:46 ` Jiri Slaby @ 2017-03-31 7:21 ` Zhenyu Wang -1 siblings, 0 replies; 11+ messages in thread From: Zhenyu Wang @ 2017-03-31 7:21 UTC (permalink / raw) To: Jiri Slaby Cc: linux-kernel, Martin Liska, Zhi Wang, Daniel Vetter, Jani Nikula, David Airlie, intel-gvt-dev, intel-gfx, dri-devel [-- Attachment #1: Type: text/plain, Size: 2083 bytes --] On 2017.03.30 11:46:27 +0200, Jiri Slaby wrote: > Handlers are currently the only blocker to compile the kernel with gcc 7 > and KASAN+use-after-scope enabled: > drivers/gpu/drm/i915/gvt/handlers.c:2200:1: error: the frame size of 43760 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] > drivers/gpu/drm/i915/gvt/handlers.c:2402:1: error: the frame size of 9400 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] > drivers/gpu/drm/i915/gvt/handlers.c:2628:1: error: the frame size of 11256 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] > > It is due to many expansions of MMIO_* macros in init_generic_mmio_info. > INTEL_GVT_MMIO_OFFSET generates for each such line a __reg and an > offset. There are too many for KASAN to keep up. > > So disable KASAN for this file. > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: Martin Liska <mliska@suse.cz> > Cc: Zhenyu Wang <zhenyuw@linux.intel.com> > Cc: Zhi Wang <zhi.a.wang@intel.com> > Cc: Daniel Vetter <daniel.vetter@intel.com> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: David Airlie <airlied@linux.ie> > Cc: intel-gvt-dev@lists.freedesktop.org > Cc: intel-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > --- > drivers/gpu/drm/i915/gvt/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gvt/Makefile b/drivers/gpu/drm/i915/gvt/Makefile > index b123c20e2097..942f1849d194 100644 > --- a/drivers/gpu/drm/i915/gvt/Makefile > +++ b/drivers/gpu/drm/i915/gvt/Makefile > @@ -6,3 +6,5 @@ GVT_SOURCE := gvt.o aperture_gm.o handlers.o vgpu.o trace_points.o firmware.o \ > ccflags-y += -I$(src) -I$(src)/$(GVT_DIR) -Wall > i915-y += $(addprefix $(GVT_DIR)/, $(GVT_SOURCE)) > obj-$(CONFIG_DRM_I915_GVT_KVMGT) += $(GVT_DIR)/kvmgt.o > + > +KASAN_SANITIZE_handlers.o := n > -- > 2.12.2 > Applied this, we'd better cleanup legacy usage to current i915 mmio reg define. Thanks! -- Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 163 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: disable KASAN for handlers @ 2017-03-31 7:21 ` Zhenyu Wang 0 siblings, 0 replies; 11+ messages in thread From: Zhenyu Wang @ 2017-03-31 7:21 UTC (permalink / raw) To: Jiri Slaby Cc: intel-gvt-dev, intel-gfx, linux-kernel, dri-devel, Daniel Vetter, Martin Liska, Zhi Wang [-- Attachment #1.1: Type: text/plain, Size: 2083 bytes --] On 2017.03.30 11:46:27 +0200, Jiri Slaby wrote: > Handlers are currently the only blocker to compile the kernel with gcc 7 > and KASAN+use-after-scope enabled: > drivers/gpu/drm/i915/gvt/handlers.c:2200:1: error: the frame size of 43760 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] > drivers/gpu/drm/i915/gvt/handlers.c:2402:1: error: the frame size of 9400 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] > drivers/gpu/drm/i915/gvt/handlers.c:2628:1: error: the frame size of 11256 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] > > It is due to many expansions of MMIO_* macros in init_generic_mmio_info. > INTEL_GVT_MMIO_OFFSET generates for each such line a __reg and an > offset. There are too many for KASAN to keep up. > > So disable KASAN for this file. > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: Martin Liska <mliska@suse.cz> > Cc: Zhenyu Wang <zhenyuw@linux.intel.com> > Cc: Zhi Wang <zhi.a.wang@intel.com> > Cc: Daniel Vetter <daniel.vetter@intel.com> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: David Airlie <airlied@linux.ie> > Cc: intel-gvt-dev@lists.freedesktop.org > Cc: intel-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > --- > drivers/gpu/drm/i915/gvt/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gvt/Makefile b/drivers/gpu/drm/i915/gvt/Makefile > index b123c20e2097..942f1849d194 100644 > --- a/drivers/gpu/drm/i915/gvt/Makefile > +++ b/drivers/gpu/drm/i915/gvt/Makefile > @@ -6,3 +6,5 @@ GVT_SOURCE := gvt.o aperture_gm.o handlers.o vgpu.o trace_points.o firmware.o \ > ccflags-y += -I$(src) -I$(src)/$(GVT_DIR) -Wall > i915-y += $(addprefix $(GVT_DIR)/, $(GVT_SOURCE)) > obj-$(CONFIG_DRM_I915_GVT_KVMGT) += $(GVT_DIR)/kvmgt.o > + > +KASAN_SANITIZE_handlers.o := n > -- > 2.12.2 > Applied this, we'd better cleanup legacy usage to current i915 mmio reg define. Thanks! -- Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 163 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: disable KASAN for handlers 2017-03-31 7:21 ` Zhenyu Wang @ 2017-03-31 10:29 ` Jani Nikula -1 siblings, 0 replies; 11+ messages in thread From: Jani Nikula @ 2017-03-31 10:29 UTC (permalink / raw) To: Zhenyu Wang, Jiri Slaby Cc: linux-kernel, Martin Liska, Zhi Wang, Daniel Vetter, David Airlie, intel-gvt-dev, intel-gfx, dri-devel, Arnd Bergmann On Fri, 31 Mar 2017, Zhenyu Wang <zhenyuw@linux.intel.com> wrote: > On 2017.03.30 11:46:27 +0200, Jiri Slaby wrote: >> Handlers are currently the only blocker to compile the kernel with gcc 7 >> and KASAN+use-after-scope enabled: >> drivers/gpu/drm/i915/gvt/handlers.c:2200:1: error: the frame size of 43760 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >> drivers/gpu/drm/i915/gvt/handlers.c:2402:1: error: the frame size of 9400 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >> drivers/gpu/drm/i915/gvt/handlers.c:2628:1: error: the frame size of 11256 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >> >> It is due to many expansions of MMIO_* macros in init_generic_mmio_info. >> INTEL_GVT_MMIO_OFFSET generates for each such line a __reg and an >> offset. There are too many for KASAN to keep up. >> >> So disable KASAN for this file. >> >> Signed-off-by: Jiri Slaby <jslaby@suse.cz> >> Cc: Martin Liska <mliska@suse.cz> >> Cc: Zhenyu Wang <zhenyuw@linux.intel.com> >> Cc: Zhi Wang <zhi.a.wang@intel.com> >> Cc: Daniel Vetter <daniel.vetter@intel.com> >> Cc: Jani Nikula <jani.nikula@linux.intel.com> >> Cc: David Airlie <airlied@linux.ie> >> Cc: intel-gvt-dev@lists.freedesktop.org >> Cc: intel-gfx@lists.freedesktop.org >> Cc: dri-devel@lists.freedesktop.org >> --- >> drivers/gpu/drm/i915/gvt/Makefile | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/gvt/Makefile b/drivers/gpu/drm/i915/gvt/Makefile >> index b123c20e2097..942f1849d194 100644 >> --- a/drivers/gpu/drm/i915/gvt/Makefile >> +++ b/drivers/gpu/drm/i915/gvt/Makefile >> @@ -6,3 +6,5 @@ GVT_SOURCE := gvt.o aperture_gm.o handlers.o vgpu.o trace_points.o firmware.o \ >> ccflags-y += -I$(src) -I$(src)/$(GVT_DIR) -Wall >> i915-y += $(addprefix $(GVT_DIR)/, $(GVT_SOURCE)) >> obj-$(CONFIG_DRM_I915_GVT_KVMGT) += $(GVT_DIR)/kvmgt.o >> + >> +KASAN_SANITIZE_handlers.o := n >> -- >> 2.12.2 >> > > Applied this, we'd better cleanup legacy usage to current i915 mmio > reg define. Thanks! Hmmh, that was a bit fast, there was a related discussion going in [1]. BR, Jani. [1] http://mid.mail-archive.com/20170320215713.3086140-1-arnd@arndb.de -- Jani Nikula, Intel Open Source Technology Center ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: disable KASAN for handlers @ 2017-03-31 10:29 ` Jani Nikula 0 siblings, 0 replies; 11+ messages in thread From: Jani Nikula @ 2017-03-31 10:29 UTC (permalink / raw) To: Zhenyu Wang, Jiri Slaby Cc: Arnd Bergmann, Martin Liska, intel-gfx, linux-kernel, dri-devel, Daniel Vetter, intel-gvt-dev, Zhi Wang On Fri, 31 Mar 2017, Zhenyu Wang <zhenyuw@linux.intel.com> wrote: > On 2017.03.30 11:46:27 +0200, Jiri Slaby wrote: >> Handlers are currently the only blocker to compile the kernel with gcc 7 >> and KASAN+use-after-scope enabled: >> drivers/gpu/drm/i915/gvt/handlers.c:2200:1: error: the frame size of 43760 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >> drivers/gpu/drm/i915/gvt/handlers.c:2402:1: error: the frame size of 9400 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >> drivers/gpu/drm/i915/gvt/handlers.c:2628:1: error: the frame size of 11256 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >> >> It is due to many expansions of MMIO_* macros in init_generic_mmio_info. >> INTEL_GVT_MMIO_OFFSET generates for each such line a __reg and an >> offset. There are too many for KASAN to keep up. >> >> So disable KASAN for this file. >> >> Signed-off-by: Jiri Slaby <jslaby@suse.cz> >> Cc: Martin Liska <mliska@suse.cz> >> Cc: Zhenyu Wang <zhenyuw@linux.intel.com> >> Cc: Zhi Wang <zhi.a.wang@intel.com> >> Cc: Daniel Vetter <daniel.vetter@intel.com> >> Cc: Jani Nikula <jani.nikula@linux.intel.com> >> Cc: David Airlie <airlied@linux.ie> >> Cc: intel-gvt-dev@lists.freedesktop.org >> Cc: intel-gfx@lists.freedesktop.org >> Cc: dri-devel@lists.freedesktop.org >> --- >> drivers/gpu/drm/i915/gvt/Makefile | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/gvt/Makefile b/drivers/gpu/drm/i915/gvt/Makefile >> index b123c20e2097..942f1849d194 100644 >> --- a/drivers/gpu/drm/i915/gvt/Makefile >> +++ b/drivers/gpu/drm/i915/gvt/Makefile >> @@ -6,3 +6,5 @@ GVT_SOURCE := gvt.o aperture_gm.o handlers.o vgpu.o trace_points.o firmware.o \ >> ccflags-y += -I$(src) -I$(src)/$(GVT_DIR) -Wall >> i915-y += $(addprefix $(GVT_DIR)/, $(GVT_SOURCE)) >> obj-$(CONFIG_DRM_I915_GVT_KVMGT) += $(GVT_DIR)/kvmgt.o >> + >> +KASAN_SANITIZE_handlers.o := n >> -- >> 2.12.2 >> > > Applied this, we'd better cleanup legacy usage to current i915 mmio > reg define. Thanks! Hmmh, that was a bit fast, there was a related discussion going in [1]. BR, Jani. [1] http://mid.mail-archive.com/20170320215713.3086140-1-arnd@arndb.de -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: disable KASAN for handlers 2017-03-31 10:29 ` Jani Nikula @ 2017-03-31 11:23 ` Arnd Bergmann -1 siblings, 0 replies; 11+ messages in thread From: Arnd Bergmann @ 2017-03-31 11:23 UTC (permalink / raw) To: Jani Nikula Cc: Zhenyu Wang, Jiri Slaby, Linux Kernel Mailing List, Martin Liska, Zhi Wang, Daniel Vetter, David Airlie, intel-gvt-dev, intel-gfx, dri-devel On Fri, Mar 31, 2017 at 12:29 PM, Jani Nikula <jani.nikula@linux.intel.com> wrote: > On Fri, 31 Mar 2017, Zhenyu Wang <zhenyuw@linux.intel.com> wrote: >> On 2017.03.30 11:46:27 +0200, Jiri Slaby wrote: >>> Handlers are currently the only blocker to compile the kernel with gcc 7 >>> and KASAN+use-after-scope enabled: >>> drivers/gpu/drm/i915/gvt/handlers.c:2200:1: error: the frame size of 43760 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >>> drivers/gpu/drm/i915/gvt/handlers.c:2402:1: error: the frame size of 9400 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >>> drivers/gpu/drm/i915/gvt/handlers.c:2628:1: error: the frame size of 11256 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >>> >>> It is due to many expansions of MMIO_* macros in init_generic_mmio_info. >>> INTEL_GVT_MMIO_OFFSET generates for each such line a __reg and an >>> offset. There are too many for KASAN to keep up. >>> >>> So disable KASAN for this file. >>> >>> Signed-off-by: Jiri Slaby <jslaby@suse.cz> >>> Cc: Martin Liska <mliska@suse.cz> >>> Cc: Zhenyu Wang <zhenyuw@linux.intel.com> >>> Cc: Zhi Wang <zhi.a.wang@intel.com> >>> Cc: Daniel Vetter <daniel.vetter@intel.com> >>> Cc: Jani Nikula <jani.nikula@linux.intel.com> >>> Cc: David Airlie <airlied@linux.ie> >>> Cc: intel-gvt-dev@lists.freedesktop.org >>> Cc: intel-gfx@lists.freedesktop.org >>> Cc: dri-devel@lists.freedesktop.org >>> --- >>> drivers/gpu/drm/i915/gvt/Makefile | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/i915/gvt/Makefile b/drivers/gpu/drm/i915/gvt/Makefile >>> index b123c20e2097..942f1849d194 100644 >>> --- a/drivers/gpu/drm/i915/gvt/Makefile >>> +++ b/drivers/gpu/drm/i915/gvt/Makefile >>> @@ -6,3 +6,5 @@ GVT_SOURCE := gvt.o aperture_gm.o handlers.o vgpu.o trace_points.o firmware.o \ >>> ccflags-y += -I$(src) -I$(src)/$(GVT_DIR) -Wall >>> i915-y += $(addprefix $(GVT_DIR)/, $(GVT_SOURCE)) >>> obj-$(CONFIG_DRM_I915_GVT_KVMGT) += $(GVT_DIR)/kvmgt.o >>> + >>> +KASAN_SANITIZE_handlers.o := n >>> -- >>> 2.12.2 >>> >> >> Applied this, we'd better cleanup legacy usage to current i915 mmio >> reg define. Thanks! > > Hmmh, that was a bit fast, there was a related discussion going in [1]. > > BR, > Jani. > > > [1] http://mid.mail-archive.com/20170320215713.3086140-1-arnd@arndb.de Sorry about that, it looked like I never replied to your last mail. There is also a related problem that I had sent another fix for: https://patchwork.kernel.org/patch/9601349/ I still think that my two patches are correct and they should both be applied. Arnd ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: disable KASAN for handlers @ 2017-03-31 11:23 ` Arnd Bergmann 0 siblings, 0 replies; 11+ messages in thread From: Arnd Bergmann @ 2017-03-31 11:23 UTC (permalink / raw) To: Jani Nikula Cc: intel-gvt-dev, David Airlie, Jiri Slaby, intel-gfx, Linux Kernel Mailing List, dri-devel, Daniel Vetter, Martin Liska On Fri, Mar 31, 2017 at 12:29 PM, Jani Nikula <jani.nikula@linux.intel.com> wrote: > On Fri, 31 Mar 2017, Zhenyu Wang <zhenyuw@linux.intel.com> wrote: >> On 2017.03.30 11:46:27 +0200, Jiri Slaby wrote: >>> Handlers are currently the only blocker to compile the kernel with gcc 7 >>> and KASAN+use-after-scope enabled: >>> drivers/gpu/drm/i915/gvt/handlers.c:2200:1: error: the frame size of 43760 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >>> drivers/gpu/drm/i915/gvt/handlers.c:2402:1: error: the frame size of 9400 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >>> drivers/gpu/drm/i915/gvt/handlers.c:2628:1: error: the frame size of 11256 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >>> >>> It is due to many expansions of MMIO_* macros in init_generic_mmio_info. >>> INTEL_GVT_MMIO_OFFSET generates for each such line a __reg and an >>> offset. There are too many for KASAN to keep up. >>> >>> So disable KASAN for this file. >>> >>> Signed-off-by: Jiri Slaby <jslaby@suse.cz> >>> Cc: Martin Liska <mliska@suse.cz> >>> Cc: Zhenyu Wang <zhenyuw@linux.intel.com> >>> Cc: Zhi Wang <zhi.a.wang@intel.com> >>> Cc: Daniel Vetter <daniel.vetter@intel.com> >>> Cc: Jani Nikula <jani.nikula@linux.intel.com> >>> Cc: David Airlie <airlied@linux.ie> >>> Cc: intel-gvt-dev@lists.freedesktop.org >>> Cc: intel-gfx@lists.freedesktop.org >>> Cc: dri-devel@lists.freedesktop.org >>> --- >>> drivers/gpu/drm/i915/gvt/Makefile | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/i915/gvt/Makefile b/drivers/gpu/drm/i915/gvt/Makefile >>> index b123c20e2097..942f1849d194 100644 >>> --- a/drivers/gpu/drm/i915/gvt/Makefile >>> +++ b/drivers/gpu/drm/i915/gvt/Makefile >>> @@ -6,3 +6,5 @@ GVT_SOURCE := gvt.o aperture_gm.o handlers.o vgpu.o trace_points.o firmware.o \ >>> ccflags-y += -I$(src) -I$(src)/$(GVT_DIR) -Wall >>> i915-y += $(addprefix $(GVT_DIR)/, $(GVT_SOURCE)) >>> obj-$(CONFIG_DRM_I915_GVT_KVMGT) += $(GVT_DIR)/kvmgt.o >>> + >>> +KASAN_SANITIZE_handlers.o := n >>> -- >>> 2.12.2 >>> >> >> Applied this, we'd better cleanup legacy usage to current i915 mmio >> reg define. Thanks! > > Hmmh, that was a bit fast, there was a related discussion going in [1]. > > BR, > Jani. > > > [1] http://mid.mail-archive.com/20170320215713.3086140-1-arnd@arndb.de Sorry about that, it looked like I never replied to your last mail. There is also a related problem that I had sent another fix for: https://patchwork.kernel.org/patch/9601349/ I still think that my two patches are correct and they should both be applied. Arnd _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: disable KASAN for handlers 2017-03-31 11:23 ` Arnd Bergmann @ 2017-07-18 5:48 ` Jiri Slaby -1 siblings, 0 replies; 11+ messages in thread From: Jiri Slaby @ 2017-07-18 5:48 UTC (permalink / raw) To: Arnd Bergmann, Jani Nikula Cc: Zhenyu Wang, Jiri Slaby, Linux Kernel Mailing List, Martin Liska, Zhi Wang, Daniel Vetter, David Airlie, intel-gvt-dev, intel-gfx, dri-devel On 03/31/2017, 01:23 PM, Arnd Bergmann wrote: > On Fri, Mar 31, 2017 at 12:29 PM, Jani Nikula > <jani.nikula@linux.intel.com> wrote: >> On Fri, 31 Mar 2017, Zhenyu Wang <zhenyuw@linux.intel.com> wrote: >>> On 2017.03.30 11:46:27 +0200, Jiri Slaby wrote: >>>> Handlers are currently the only blocker to compile the kernel with gcc 7 >>>> and KASAN+use-after-scope enabled: >>>> drivers/gpu/drm/i915/gvt/handlers.c:2200:1: error: the frame size of 43760 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >>>> drivers/gpu/drm/i915/gvt/handlers.c:2402:1: error: the frame size of 9400 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >>>> drivers/gpu/drm/i915/gvt/handlers.c:2628:1: error: the frame size of 11256 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >>>> >>>> It is due to many expansions of MMIO_* macros in init_generic_mmio_info. >>>> INTEL_GVT_MMIO_OFFSET generates for each such line a __reg and an >>>> offset. There are too many for KASAN to keep up. >>>> >>>> So disable KASAN for this file. >>>> >>>> Signed-off-by: Jiri Slaby <jslaby@suse.cz> >>>> Cc: Martin Liska <mliska@suse.cz> >>>> Cc: Zhenyu Wang <zhenyuw@linux.intel.com> >>>> Cc: Zhi Wang <zhi.a.wang@intel.com> >>>> Cc: Daniel Vetter <daniel.vetter@intel.com> >>>> Cc: Jani Nikula <jani.nikula@linux.intel.com> >>>> Cc: David Airlie <airlied@linux.ie> >>>> Cc: intel-gvt-dev@lists.freedesktop.org >>>> Cc: intel-gfx@lists.freedesktop.org >>>> Cc: dri-devel@lists.freedesktop.org >>>> --- >>>> drivers/gpu/drm/i915/gvt/Makefile | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/drivers/gpu/drm/i915/gvt/Makefile b/drivers/gpu/drm/i915/gvt/Makefile >>>> index b123c20e2097..942f1849d194 100644 >>>> --- a/drivers/gpu/drm/i915/gvt/Makefile >>>> +++ b/drivers/gpu/drm/i915/gvt/Makefile >>>> @@ -6,3 +6,5 @@ GVT_SOURCE := gvt.o aperture_gm.o handlers.o vgpu.o trace_points.o firmware.o \ >>>> ccflags-y += -I$(src) -I$(src)/$(GVT_DIR) -Wall >>>> i915-y += $(addprefix $(GVT_DIR)/, $(GVT_SOURCE)) >>>> obj-$(CONFIG_DRM_I915_GVT_KVMGT) += $(GVT_DIR)/kvmgt.o >>>> + >>>> +KASAN_SANITIZE_handlers.o := n >>>> -- >>>> 2.12.2 >>>> >>> >>> Applied this, we'd better cleanup legacy usage to current i915 mmio >>> reg define. Thanks! >> >> Hmmh, that was a bit fast, there was a related discussion going in [1]. >> >> BR, >> Jani. >> >> >> [1] http://mid.mail-archive.com/20170320215713.3086140-1-arnd@arndb.de > > Sorry about that, it looked like I never replied to your last mail. > > There is also a related problem that I had sent another fix for: > https://patchwork.kernel.org/patch/9601349/ > > I still think that my two patches are correct and they should both be applied. Hi, have they been applied yet? Or was this fixed some other way? thanks, -- js suse labs ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: disable KASAN for handlers @ 2017-07-18 5:48 ` Jiri Slaby 0 siblings, 0 replies; 11+ messages in thread From: Jiri Slaby @ 2017-07-18 5:48 UTC (permalink / raw) To: Arnd Bergmann, Jani Nikula Cc: intel-gvt-dev, Jiri Slaby, intel-gfx, Linux Kernel Mailing List, dri-devel, Daniel Vetter, Martin Liska, Zhi Wang On 03/31/2017, 01:23 PM, Arnd Bergmann wrote: > On Fri, Mar 31, 2017 at 12:29 PM, Jani Nikula > <jani.nikula@linux.intel.com> wrote: >> On Fri, 31 Mar 2017, Zhenyu Wang <zhenyuw@linux.intel.com> wrote: >>> On 2017.03.30 11:46:27 +0200, Jiri Slaby wrote: >>>> Handlers are currently the only blocker to compile the kernel with gcc 7 >>>> and KASAN+use-after-scope enabled: >>>> drivers/gpu/drm/i915/gvt/handlers.c:2200:1: error: the frame size of 43760 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >>>> drivers/gpu/drm/i915/gvt/handlers.c:2402:1: error: the frame size of 9400 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >>>> drivers/gpu/drm/i915/gvt/handlers.c:2628:1: error: the frame size of 11256 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >>>> >>>> It is due to many expansions of MMIO_* macros in init_generic_mmio_info. >>>> INTEL_GVT_MMIO_OFFSET generates for each such line a __reg and an >>>> offset. There are too many for KASAN to keep up. >>>> >>>> So disable KASAN for this file. >>>> >>>> Signed-off-by: Jiri Slaby <jslaby@suse.cz> >>>> Cc: Martin Liska <mliska@suse.cz> >>>> Cc: Zhenyu Wang <zhenyuw@linux.intel.com> >>>> Cc: Zhi Wang <zhi.a.wang@intel.com> >>>> Cc: Daniel Vetter <daniel.vetter@intel.com> >>>> Cc: Jani Nikula <jani.nikula@linux.intel.com> >>>> Cc: David Airlie <airlied@linux.ie> >>>> Cc: intel-gvt-dev@lists.freedesktop.org >>>> Cc: intel-gfx@lists.freedesktop.org >>>> Cc: dri-devel@lists.freedesktop.org >>>> --- >>>> drivers/gpu/drm/i915/gvt/Makefile | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/drivers/gpu/drm/i915/gvt/Makefile b/drivers/gpu/drm/i915/gvt/Makefile >>>> index b123c20e2097..942f1849d194 100644 >>>> --- a/drivers/gpu/drm/i915/gvt/Makefile >>>> +++ b/drivers/gpu/drm/i915/gvt/Makefile >>>> @@ -6,3 +6,5 @@ GVT_SOURCE := gvt.o aperture_gm.o handlers.o vgpu.o trace_points.o firmware.o \ >>>> ccflags-y += -I$(src) -I$(src)/$(GVT_DIR) -Wall >>>> i915-y += $(addprefix $(GVT_DIR)/, $(GVT_SOURCE)) >>>> obj-$(CONFIG_DRM_I915_GVT_KVMGT) += $(GVT_DIR)/kvmgt.o >>>> + >>>> +KASAN_SANITIZE_handlers.o := n >>>> -- >>>> 2.12.2 >>>> >>> >>> Applied this, we'd better cleanup legacy usage to current i915 mmio >>> reg define. Thanks! >> >> Hmmh, that was a bit fast, there was a related discussion going in [1]. >> >> BR, >> Jani. >> >> >> [1] http://mid.mail-archive.com/20170320215713.3086140-1-arnd@arndb.de > > Sorry about that, it looked like I never replied to your last mail. > > There is also a related problem that I had sent another fix for: > https://patchwork.kernel.org/patch/9601349/ > > I still think that my two patches are correct and they should both be applied. Hi, have they been applied yet? Or was this fixed some other way? thanks, -- js suse labs _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2017-07-18 5:48 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-03-30 9:46 [PATCH] drm/i915: disable KASAN for handlers Jiri Slaby 2017-03-30 9:46 ` Jiri Slaby 2017-03-30 11:50 ` ✓ Fi.CI.BAT: success for " Patchwork 2017-03-31 7:21 ` [PATCH] " Zhenyu Wang 2017-03-31 7:21 ` Zhenyu Wang 2017-03-31 10:29 ` Jani Nikula 2017-03-31 10:29 ` Jani Nikula 2017-03-31 11:23 ` Arnd Bergmann 2017-03-31 11:23 ` Arnd Bergmann 2017-07-18 5:48 ` Jiri Slaby 2017-07-18 5:48 ` Jiri Slaby
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.