All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@linuxdriverproject.org, Tycho Andersen <tycho@tycho.ws>
Subject: Re: [PATCH RFC] remove custom Michael MIC implementation
Date: Fri, 31 Mar 2017 09:58:51 +0200	[thread overview]
Message-ID: <20170331075851.GB1435@katana> (raw)
In-Reply-To: <1490935659-7196-1-git-send-email-me@tobin.cc>

[-- Attachment #1: Type: text/plain, Size: 862 bytes --]


> The code is untested, I have hardware in the mail.

Cool!

> If any one is interested and has any comments I would really like to
> hear them. I am open to all suggestions (even down to trivial coding
> style issues).

I'll just repeat that the key move to get this driver out of staging is
to get away from the WEXT interface to CFG80211. Otherwise no chance
that wireless maintainers will even look at it. This is a huge change
but once it is done, features like Michael MIC come with it for free
(from what I recall, I am not a wireless expert myself).

Without the CFG80211 conversion, replacing the Michael custom
implementation with the in-kernel one makes the driver a tad better and
is good exercise. However, it will sadly not help to get the driver out
of staging.

But if you want a clean WEXT driver first, this is a step in the right
direction.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2017-03-31  7:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-31  4:47 [PATCH RFC] remove custom Michael MIC implementation Tobin C. Harding
2017-03-31  4:47 ` [PATCH RFC] staging: ks7010: " Tobin C. Harding
2017-03-31  5:16   ` Joe Perches
2017-03-31  9:37     ` Tobin C. Harding
2017-03-31  7:58 ` Wolfram Sang [this message]
2017-03-31 10:21   ` [PATCH RFC] " Tobin C. Harding
2017-03-31 10:42     ` Wolfram Sang
2017-04-01 10:40       ` Tobin C. Harding
2017-04-26 23:23       ` Tobin C. Harding
2017-04-28  6:09         ` Wolfram Sang
2017-04-03  5:19     ` Kalle Valo
2017-04-03  9:03       ` Tobin C. Harding
2017-04-03  9:50         ` Toke Høiland-Jørgensen
2017-04-03 10:15           ` Arend Van Spriel
2017-04-03 21:39             ` Tobin C. Harding
2017-04-04 21:31               ` Arend Van Spriel
2017-04-05  1:18                 ` Tobin C. Harding
2017-04-03  9:55         ` Kalle Valo
2017-04-03 12:13         ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170331075851.GB1435@katana \
    --to=wsa@the-dreams.de \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@tobin.cc \
    --cc=tycho@tycho.ws \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.