All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	Cyrille Pitchen <cyrille.pitchen@atmel.com>,
	linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] mtd: physmap_of: really fix the physmap add-ons
Date: Fri, 31 Mar 2017 10:04:51 +0200	[thread overview]
Message-ID: <20170331100451.069a76ab@bbrezillon> (raw)
In-Reply-To: <20170330153639.26819-1-linus.walleij@linaro.org>

On Thu, 30 Mar 2017 17:36:39 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:

> The current way of building the of_physmap add-ons result in just
> the add-on being in the object code, and not the actual core
> implementation and regress the Gemini and Versatile.
> 
> Bake the physmap_of.o object by baking physmap_of_core.o and
> adding the Versatile and/or Gemini add-ons to the final object.
> Rename the source file physmap_of_core.c to get the desired
> build components.
> 
> Suggested-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Fixes: 4f04f68e1598 ("mtd: physmap_of: fixup gemini/versatile dependencies")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> ---
> ChangeLog v2->v3:
> - Build and bake the final object in an elegant way suggested
>   by Boris.
> ---
>  drivers/mtd/maps/Makefile                            | 10 ++++------
>  drivers/mtd/maps/{physmap_of.c => physmap_of_core.c} |  0
>  2 files changed, 4 insertions(+), 6 deletions(-)
>  rename drivers/mtd/maps/{physmap_of.c => physmap_of_core.c} (100%)
> 
> diff --git a/drivers/mtd/maps/Makefile b/drivers/mtd/maps/Makefile
> index aef1846b4de2..5a09a72ab112 100644
> --- a/drivers/mtd/maps/Makefile
> +++ b/drivers/mtd/maps/Makefile
> @@ -17,12 +17,10 @@ obj-$(CONFIG_MTD_CK804XROM)	+= ck804xrom.o
>  obj-$(CONFIG_MTD_TSUNAMI)	+= tsunami_flash.o
>  obj-$(CONFIG_MTD_PXA2XX)	+= pxa2xx-flash.o
>  obj-$(CONFIG_MTD_PHYSMAP)	+= physmap.o
> -ifdef CONFIG_MTD_PHYSMAP_OF_VERSATILE
> -physmap_of-objs += physmap_of_versatile.o
> -endif
> -ifdef CONFIG_MTD_PHYSMAP_OF_GEMINI
> -physmap_of-objs += physmap_of_gemini.o
> -endif
> +physmap_of-objs-y		+= physmap_of_core.o
> +physmap_of-objs-$(CONFIG_MTD_PHYSMAP_OF_VERSATILE) += physmap_of_versatile.o
> +physmap_of-objs-$(CONFIG_MTD_PHYSMAP_OF_GEMINI) += physmap_of_gemini.o
> +physmap_of-objs			:= $(physmap_of-objs-y)
>  obj-$(CONFIG_MTD_PHYSMAP_OF)	+= physmap_of.o
>  obj-$(CONFIG_MTD_PISMO)		+= pismo.o
>  obj-$(CONFIG_MTD_PMC_MSP_EVM)   += pmcmsp-flash.o
> diff --git a/drivers/mtd/maps/physmap_of.c b/drivers/mtd/maps/physmap_of_core.c
> similarity index 100%
> rename from drivers/mtd/maps/physmap_of.c
> rename to drivers/mtd/maps/physmap_of_core.c

WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] mtd: physmap_of: really fix the physmap add-ons
Date: Fri, 31 Mar 2017 10:04:51 +0200	[thread overview]
Message-ID: <20170331100451.069a76ab@bbrezillon> (raw)
In-Reply-To: <20170330153639.26819-1-linus.walleij@linaro.org>

On Thu, 30 Mar 2017 17:36:39 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:

> The current way of building the of_physmap add-ons result in just
> the add-on being in the object code, and not the actual core
> implementation and regress the Gemini and Versatile.
> 
> Bake the physmap_of.o object by baking physmap_of_core.o and
> adding the Versatile and/or Gemini add-ons to the final object.
> Rename the source file physmap_of_core.c to get the desired
> build components.
> 
> Suggested-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Fixes: 4f04f68e1598 ("mtd: physmap_of: fixup gemini/versatile dependencies")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> ---
> ChangeLog v2->v3:
> - Build and bake the final object in an elegant way suggested
>   by Boris.
> ---
>  drivers/mtd/maps/Makefile                            | 10 ++++------
>  drivers/mtd/maps/{physmap_of.c => physmap_of_core.c} |  0
>  2 files changed, 4 insertions(+), 6 deletions(-)
>  rename drivers/mtd/maps/{physmap_of.c => physmap_of_core.c} (100%)
> 
> diff --git a/drivers/mtd/maps/Makefile b/drivers/mtd/maps/Makefile
> index aef1846b4de2..5a09a72ab112 100644
> --- a/drivers/mtd/maps/Makefile
> +++ b/drivers/mtd/maps/Makefile
> @@ -17,12 +17,10 @@ obj-$(CONFIG_MTD_CK804XROM)	+= ck804xrom.o
>  obj-$(CONFIG_MTD_TSUNAMI)	+= tsunami_flash.o
>  obj-$(CONFIG_MTD_PXA2XX)	+= pxa2xx-flash.o
>  obj-$(CONFIG_MTD_PHYSMAP)	+= physmap.o
> -ifdef CONFIG_MTD_PHYSMAP_OF_VERSATILE
> -physmap_of-objs += physmap_of_versatile.o
> -endif
> -ifdef CONFIG_MTD_PHYSMAP_OF_GEMINI
> -physmap_of-objs += physmap_of_gemini.o
> -endif
> +physmap_of-objs-y		+= physmap_of_core.o
> +physmap_of-objs-$(CONFIG_MTD_PHYSMAP_OF_VERSATILE) += physmap_of_versatile.o
> +physmap_of-objs-$(CONFIG_MTD_PHYSMAP_OF_GEMINI) += physmap_of_gemini.o
> +physmap_of-objs			:= $(physmap_of-objs-y)
>  obj-$(CONFIG_MTD_PHYSMAP_OF)	+= physmap_of.o
>  obj-$(CONFIG_MTD_PISMO)		+= pismo.o
>  obj-$(CONFIG_MTD_PMC_MSP_EVM)   += pmcmsp-flash.o
> diff --git a/drivers/mtd/maps/physmap_of.c b/drivers/mtd/maps/physmap_of_core.c
> similarity index 100%
> rename from drivers/mtd/maps/physmap_of.c
> rename to drivers/mtd/maps/physmap_of_core.c

  reply	other threads:[~2017-03-31  8:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-30 15:36 [PATCH v3] mtd: physmap_of: really fix the physmap add-ons Linus Walleij
2017-03-30 15:36 ` Linus Walleij
2017-03-31  8:04 ` Boris Brezillon [this message]
2017-03-31  8:04   ` Boris Brezillon
2017-04-19 20:07   ` Brian Norris
2017-04-19 20:07     ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170331100451.069a76ab@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@atmel.com \
    --cc=dwmw2@infradead.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.