* [PATCH] selftests: add a generic testsuite for ethernet device @ 2017-03-31 12:57 Corentin Labbe 2017-03-31 12:57 ` Corentin Labbe 0 siblings, 1 reply; 7+ messages in thread From: Corentin Labbe @ 2017-03-31 12:57 UTC (permalink / raw) To: davem, shuah; +Cc: linux-kernel, netdev, linux-kselftest, Corentin Labbe Hello My original intent was to add network test to the kernelci project. Since they use kselftests, they forwarded me to this. This patch add a basic network test suite which do: - bring up netdev - change mac address - try some ethtool commands - bring down netdev The test is non disruptive, so that an already used network interface will not be modified (mac/IP address for example). Regards Corentin Labbe (1): selftests: add a generic testsuite for ethernet device tools/testing/selftests/net/Makefile | 2 +- tools/testing/selftests/net/netdevice.sh | 185 +++++++++++++++++++++++++++++++ 2 files changed, 186 insertions(+), 1 deletion(-) create mode 100755 tools/testing/selftests/net/netdevice.sh -- 2.10.2 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] selftests: add a generic testsuite for ethernet device 2017-03-31 12:57 [PATCH] selftests: add a generic testsuite for ethernet device Corentin Labbe @ 2017-03-31 12:57 ` Corentin Labbe 2017-03-31 14:12 ` Andrew Lunn 0 siblings, 1 reply; 7+ messages in thread From: Corentin Labbe @ 2017-03-31 12:57 UTC (permalink / raw) To: davem, shuah; +Cc: linux-kernel, netdev, linux-kselftest, Corentin Labbe This patch add a generic testsuite for testing ethernet network device driver. Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> --- tools/testing/selftests/net/Makefile | 2 +- tools/testing/selftests/net/netdevice.sh | 185 +++++++++++++++++++++++++++++++ 2 files changed, 186 insertions(+), 1 deletion(-) create mode 100755 tools/testing/selftests/net/netdevice.sh diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile index fbfe5d0..35cbb4c 100644 --- a/tools/testing/selftests/net/Makefile +++ b/tools/testing/selftests/net/Makefile @@ -5,7 +5,7 @@ CFLAGS += -I../../../../usr/include/ reuseport_bpf_numa: LDFLAGS += -lnuma -TEST_PROGS := run_netsocktests run_afpackettests test_bpf.sh +TEST_PROGS := run_netsocktests run_afpackettests test_bpf.sh netdevice.sh TEST_GEN_FILES = socket TEST_GEN_FILES += psock_fanout psock_tpacket TEST_GEN_FILES += reuseport_bpf reuseport_bpf_cpu reuseport_bpf_numa diff --git a/tools/testing/selftests/net/netdevice.sh b/tools/testing/selftests/net/netdevice.sh new file mode 100755 index 0000000..89ba827 --- /dev/null +++ b/tools/testing/selftests/net/netdevice.sh @@ -0,0 +1,185 @@ +#!/bin/sh +# +# This test is for checking network interface +# For the moment it tests only ethernet interface (but wifi could be easily added) +# +# We assume that all network driver are loaded +# if not they probably have failed earlier in the boot process and their logged error will be catched by another test +# + +# this function will try to up the interface +# if already up, nothing done +# arg1: network interface name +kci_net_start() +{ + netdev=$1 + + ip link show "$netdev" |grep -q UP + if [ $? -eq 0 ];then + echo "SKIP: interface $netdev already up" + return 0 + fi + + ip link set "$netdev" up + if [ $? -ne 0 ];then + echo "FAIL: Fail to up $netdev" + return 1 + else + echo "PASS: set interface $netdev up" + NETDEV_STARTED=1 + fi + return 0 +} + +# this function will try to setup an IP and MAC address on a network interface +# Doing nothing if the interface was already up +# arg1: network interface name +kci_net_setup() +{ + netdev=$1 + + # do nothing if the interface was already up + if [ $NETDEV_STARTED -eq 0 ];then + return 0 + fi + + ip link set dev $netdev address 02:03:04:05:06:07 + if [ $? -ne 0 ];then + echo "FAIL: Cannot set MAC address to $netdev" + return 1 + fi + echo "PASS: set MAC address to $netdev" + + #check that the interface did not already have an IP + ip address show "$netdev" |grep '^[[:space:]]*inet' + if [ $? -eq 0 ];then + echo "SKIP: $netdev already have an IP" + return 0 + fi + + # TODO what ipaddr to set ? DHCP ? + echo "SKIP: set IP address to $netdev" + return 0 +} + +# test an ethtool command +# arg1: return code for not supported (see ethtool code source) +# arg2: summary of the command +# arg3: command to execute +kci_netdev_ethtool_test() +{ + if [ $# -le 2 ];then + echo "SKIP: invalid number of arguments" + return 1 + fi + $3 >/dev/null + ret=$? + if [ $ret -ne 0 ];then + if [ $ret -eq "$1" ];then + echo "SKIP: ethtool $2 $netdev not supported" + else + echo "FAIL: ethtool $2 $netdev" + return 1 + fi + else + echo "PASS: ethtool $2 $netdev" + fi + return 0 +} + +# test ethtool commands +# arg1: network interface name +kci_netdev_ethtool() +{ + netdev=$1 + + #check presence of ethtool + ethtool --version 2>/dev/null >/dev/null + if [ $? -ne 0 ];then + echo "SKIP: ethtool not present" + return 1 + fi + + TMP_ETHTOOL_FEATURES="$(mktemp)" + if [ ! -e "$TMP_ETHTOOL_FEATURES" ];then + echo "SKIP: Cannot create a tmp file" + return 1 + fi + + ethtool -k "$netdev" > "$TMP_ETHTOOL_FEATURES" + if [ $? -ne 0 ];then + echo "FAIL: ethtool -k $netdev" + rm "$TMP_ETHTOOL_FEATURES" + return 1 + fi + #TODO for each non fixed features, try to turn them on/off + rm "$TMP_ETHTOOL_FEATURES" + + kci_netdev_ethtool_test 74 'dump' "ethtool -d $netdev" + kci_netdev_ethtool_test 94 'stats' "ethtool -S $netdev" + return 0 +} + +# stop a netdev +# arg1: network interface name +kci_netdev_stop() +{ + netdev=$1 + + if [ $NETDEV_STARTED -eq 0 ];then + echo "SKIP: interface $netdev kept up" + return 0 + fi + + ip link set "$netdev" down + if [ $? -ne 0 ];then + echo "FAIL: stop $netdev" + return 1 + fi + echo "PASS: interface $netdev stop" + return 0 +} + +# run all test on a netdev +# arg1: network interface name +kci_test_netdev() +{ + netdev=$1 + + NETDEV_STARTED=0 + kci_net_start "$netdev" + + kci_net_setup "$netdev" + + kci_netdev_ethtool "$netdev" + + kci_netdev_stop "$netdev" + return 0 +} + +#check for needed privileges +if [ "$(id -u)" -ne 0 ];then + echo "SKIP: Need root privileges" + exit 0 +fi + +ip -Version 2>/dev/null >/dev/null +if [ $? -ne 0 ];then + echo "SKIP: Could not run test without the ip tool" + exit 0 +fi + +TMP_LIST_NETDEV="$(mktemp)" +if [ ! -e "$TMP_LIST_NETDEV" ];then + echo "FAIL: Cannot create a tmp file" + exit 1 +fi + +ls /sys/class/net/ |grep -vE '^lo|^tun' | grep -E '^eth|enp[0-9]s[0-9]' > "$TMP_LIST_NETDEV" +while read netdev +do + kci_test_netdev "$netdev" +done < "$TMP_LIST_NETDEV" + +rm "$TMP_LIST_NETDEV" +exit 0 -- 2.10.2 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] selftests: add a generic testsuite for ethernet device 2017-03-31 12:57 ` Corentin Labbe @ 2017-03-31 14:12 ` Andrew Lunn 2017-04-03 13:15 ` Corentin Labbe 0 siblings, 1 reply; 7+ messages in thread From: Andrew Lunn @ 2017-03-31 14:12 UTC (permalink / raw) To: Corentin Labbe; +Cc: davem, shuah, linux-kernel, netdev, linux-kselftest On Fri, Mar 31, 2017 at 02:57:52PM +0200, Corentin Labbe wrote: > This patch add a generic testsuite for testing ethernet network device driver. > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > --- > tools/testing/selftests/net/Makefile | 2 +- > tools/testing/selftests/net/netdevice.sh | 185 +++++++++++++++++++++++++++++++ > 2 files changed, 186 insertions(+), 1 deletion(-) > create mode 100755 tools/testing/selftests/net/netdevice.sh > > diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile > index fbfe5d0..35cbb4c 100644 > --- a/tools/testing/selftests/net/Makefile > +++ b/tools/testing/selftests/net/Makefile > @@ -5,7 +5,7 @@ CFLAGS += -I../../../../usr/include/ > > reuseport_bpf_numa: LDFLAGS += -lnuma > > -TEST_PROGS := run_netsocktests run_afpackettests test_bpf.sh > +TEST_PROGS := run_netsocktests run_afpackettests test_bpf.sh netdevice.sh > TEST_GEN_FILES = socket > TEST_GEN_FILES += psock_fanout psock_tpacket > TEST_GEN_FILES += reuseport_bpf reuseport_bpf_cpu reuseport_bpf_numa > diff --git a/tools/testing/selftests/net/netdevice.sh b/tools/testing/selftests/net/netdevice.sh > new file mode 100755 > index 0000000..89ba827 > --- /dev/null > +++ b/tools/testing/selftests/net/netdevice.sh > @@ -0,0 +1,185 @@ > +#!/bin/sh > +# > +# This test is for checking network interface > +# For the moment it tests only ethernet interface (but wifi could be easily added) > +# > +# We assume that all network driver are loaded > +# if not they probably have failed earlier in the boot process and their logged error will be catched by another test > +# > + Hi Corentin Nice to see some basic tests. > +# this function will try to up the interface > +# if already up, nothing done > +# arg1: network interface name > +kci_net_start() > +{ > + netdev=$1 > + > + ip link show "$netdev" |grep -q UP > + if [ $? -eq 0 ];then > + echo "SKIP: interface $netdev already up" > + return 0 > + fi > + > + ip link set "$netdev" up > + if [ $? -ne 0 ];then > + echo "FAIL: Fail to up $netdev" > + return 1 > + else > + echo "PASS: set interface $netdev up" > + NETDEV_STARTED=1 > + fi This is going to be problematic. 3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN mode DEFAULT group default qlen 1000 link/ether 8e:01:30:d5:63:ff brd ff:ff:ff:ff:ff:ff 4: lan1@eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000 link/ether 8e:01:30:d5:63:ff brd ff:ff:ff:ff:ff:ff lan1 has eth1 as its master interface. If you try to up lan1 while eth1 is down: # ip link set lan1 up RTNETLINK answers: Network is down > + > +ls /sys/class/net/ |grep -vE '^lo|^tun' | grep -E '^eth|enp[0-9]s[0-9]' > "$TMP_LIST_NETDEV" > +while read netdev > +do > + kci_test_netdev "$netdev" > +done < "$TMP_LIST_NETDEV" Because of the grep, on this board, you won't actually test lan1. Which is a shame. It would be nice to test it, and the other interfaces like it. Rather than going on the order ls gives you, could you order it based on the ifnum? The master has to exist before a slave can be created. Hence the master has a lower ifnum than the slave. So bring the interfaces up in ifnum order, and down in reverse order. Thanks Andrew ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] selftests: add a generic testsuite for ethernet device 2017-03-31 14:12 ` Andrew Lunn @ 2017-04-03 13:15 ` Corentin Labbe 2017-04-03 13:27 ` Andrew Lunn 0 siblings, 1 reply; 7+ messages in thread From: Corentin Labbe @ 2017-04-03 13:15 UTC (permalink / raw) To: Andrew Lunn; +Cc: davem, shuah, linux-kernel, netdev, linux-kselftest On Fri, Mar 31, 2017 at 04:12:41PM +0200, Andrew Lunn wrote: > On Fri, Mar 31, 2017 at 02:57:52PM +0200, Corentin Labbe wrote: > > This patch add a generic testsuite for testing ethernet network device driver. > > > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > > --- > > tools/testing/selftests/net/Makefile | 2 +- > > tools/testing/selftests/net/netdevice.sh | 185 +++++++++++++++++++++++++++++++ > > 2 files changed, 186 insertions(+), 1 deletion(-) > > create mode 100755 tools/testing/selftests/net/netdevice.sh > > > > diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile > > index fbfe5d0..35cbb4c 100644 > > --- a/tools/testing/selftests/net/Makefile > > +++ b/tools/testing/selftests/net/Makefile > > @@ -5,7 +5,7 @@ CFLAGS += -I../../../../usr/include/ > > > > reuseport_bpf_numa: LDFLAGS += -lnuma > > > > -TEST_PROGS := run_netsocktests run_afpackettests test_bpf.sh > > +TEST_PROGS := run_netsocktests run_afpackettests test_bpf.sh netdevice.sh > > TEST_GEN_FILES = socket > > TEST_GEN_FILES += psock_fanout psock_tpacket > > TEST_GEN_FILES += reuseport_bpf reuseport_bpf_cpu reuseport_bpf_numa > > diff --git a/tools/testing/selftests/net/netdevice.sh b/tools/testing/selftests/net/netdevice.sh > > new file mode 100755 > > index 0000000..89ba827 > > --- /dev/null > > +++ b/tools/testing/selftests/net/netdevice.sh > > @@ -0,0 +1,185 @@ > > +#!/bin/sh > > +# > > +# This test is for checking network interface > > +# For the moment it tests only ethernet interface (but wifi could be easily added) > > +# > > +# We assume that all network driver are loaded > > +# if not they probably have failed earlier in the boot process and their logged error will be catched by another test > > +# > > + > > Hi Corentin > > Nice to see some basic tests. > > > +# this function will try to up the interface > > +# if already up, nothing done > > +# arg1: network interface name > > +kci_net_start() > > +{ > > + netdev=$1 > > + > > + ip link show "$netdev" |grep -q UP > > + if [ $? -eq 0 ];then > > + echo "SKIP: interface $netdev already up" > > + return 0 > > + fi > > + > > + ip link set "$netdev" up > > + if [ $? -ne 0 ];then > > + echo "FAIL: Fail to up $netdev" > > + return 1 > > + else > > + echo "PASS: set interface $netdev up" > > + NETDEV_STARTED=1 > > + fi > > This is going to be problematic. > > 3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN mode DEFAULT group default qlen 1000 > link/ether 8e:01:30:d5:63:ff brd ff:ff:ff:ff:ff:ff > 4: lan1@eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000 > link/ether 8e:01:30:d5:63:ff brd ff:ff:ff:ff:ff:ff > > lan1 has eth1 as its master interface. If you try to up lan1 while eth1 is down: > > # ip link set lan1 up > RTNETLINK answers: Network is down > > > + > > +ls /sys/class/net/ |grep -vE '^lo|^tun' | grep -E '^eth|enp[0-9]s[0-9]' > "$TMP_LIST_NETDEV" > > +while read netdev > > +do > > + kci_test_netdev "$netdev" > > +done < "$TMP_LIST_NETDEV" > > Because of the grep, on this board, you won't actually test > lan1. Which is a shame. It would be nice to test it, and the other > interfaces like it. > > Rather than going on the order ls gives you, could you order it based > on the ifnum? The master has to exist before a slave can be > created. Hence the master has a lower ifnum than the slave. So bring > the interfaces up in ifnum order, and down in reverse order. > > Thanks > Andrew By ifnum, you mean by the order that "ip link" gives ? Regards ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] selftests: add a generic testsuite for ethernet device 2017-04-03 13:15 ` Corentin Labbe @ 2017-04-03 13:27 ` Andrew Lunn 2017-04-04 7:56 ` Corentin Labbe 0 siblings, 1 reply; 7+ messages in thread From: Andrew Lunn @ 2017-04-03 13:27 UTC (permalink / raw) To: Corentin Labbe; +Cc: davem, shuah, linux-kernel, netdev, linux-kselftest > By ifnum, you mean by the order that "ip link" gives ? I've not checked if it remains in order as interfaces are hot plugged/unplugged. But i guess you are running tests direct after boot, and unplugs/replugs are unlikely? Andrew ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] selftests: add a generic testsuite for ethernet device 2017-04-03 13:27 ` Andrew Lunn @ 2017-04-04 7:56 ` Corentin Labbe 2017-04-04 12:22 ` Andrew Lunn 0 siblings, 1 reply; 7+ messages in thread From: Corentin Labbe @ 2017-04-04 7:56 UTC (permalink / raw) To: Andrew Lunn; +Cc: davem, shuah, linux-kernel, netdev, linux-kselftest On Mon, Apr 03, 2017 at 03:27:41PM +0200, Andrew Lunn wrote: > > By ifnum, you mean by the order that "ip link" gives ? > > I've not checked if it remains in order as interfaces are hot > plugged/unplugged. But i guess you are running tests direct after > boot, and unplugs/replugs are unlikely? > Yes the ideal run is just after boot, but the test need to succeed in all case. For handling vlan, I think the best way is to detect the master interface by looking the "@master". So when testing a vlan interface, the test would just up also the masteri interface. So I will drop using "ls /sys/clas/net/" and directly use output of ip Regards ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] selftests: add a generic testsuite for ethernet device 2017-04-04 7:56 ` Corentin Labbe @ 2017-04-04 12:22 ` Andrew Lunn 0 siblings, 0 replies; 7+ messages in thread From: Andrew Lunn @ 2017-04-04 12:22 UTC (permalink / raw) To: Corentin Labbe; +Cc: davem, shuah, linux-kernel, netdev, linux-kselftest On Tue, Apr 04, 2017 at 09:56:04AM +0200, Corentin Labbe wrote: > On Mon, Apr 03, 2017 at 03:27:41PM +0200, Andrew Lunn wrote: > > > By ifnum, you mean by the order that "ip link" gives ? > > > > I've not checked if it remains in order as interfaces are hot > > plugged/unplugged. But i guess you are running tests direct after > > boot, and unplugs/replugs are unlikely? > > > > Yes the ideal run is just after boot, but the test need to succeed in all case. > > For handling vlan, I think the best way is to detect the master interface by looking the "@master". Hi Corentin In my case, these are DSA interfaces. Documentation/networking/dsa/dsa.txt > So when testing a vlan interface, the test would just up also the masteri interface. That will work for DSA. I know kernelci.org has at least two boards with Ethernet switches that will have such interfaces. So it is great to test them. Thanks Andrew ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-04-04 12:23 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-03-31 12:57 [PATCH] selftests: add a generic testsuite for ethernet device Corentin Labbe 2017-03-31 12:57 ` Corentin Labbe 2017-03-31 14:12 ` Andrew Lunn 2017-04-03 13:15 ` Corentin Labbe 2017-04-03 13:27 ` Andrew Lunn 2017-04-04 7:56 ` Corentin Labbe 2017-04-04 12:22 ` Andrew Lunn
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.