All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: axboe@kernel.dk, martin.petersen@oracle.com, agk@redhat.com,
	snitzer@redhat.com, shli@kernel.org, philipp.reisner@linbit.com,
	lars.ellenberg@linbit.com
Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
	drbd-dev@lists.linbit.com, dm-devel@redhat.com,
	linux-raid@vger.kernel.org
Subject: [PATCH 13/25] block_dev: use blkdev_issue_zerout for hole punches
Date: Fri, 31 Mar 2017 18:33:01 +0200	[thread overview]
Message-ID: <20170331163313.31821-14-hch@lst.de> (raw)
In-Reply-To: <20170331163313.31821-1-hch@lst.de>

This gets us support for non-discard efficient write of zeroes (e.g. NVMe)
and prepare for removing the discard_zeroes_data flag.

Also remove a pointless discard support check, which is done in
blkdev_issue_discard already.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/block_dev.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/fs/block_dev.c b/fs/block_dev.c
index 2f704c3a816f..e405d8e58e31 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -2069,7 +2069,6 @@ static long blkdev_fallocate(struct file *file, int mode, loff_t start,
 			     loff_t len)
 {
 	struct block_device *bdev = I_BDEV(bdev_file_inode(file));
-	struct request_queue *q = bdev_get_queue(bdev);
 	struct address_space *mapping;
 	loff_t end = start + len - 1;
 	loff_t isize;
@@ -2108,15 +2107,10 @@ static long blkdev_fallocate(struct file *file, int mode, loff_t start,
 					    GFP_KERNEL, BLKDEV_ZERO_NOUNMAP);
 		break;
 	case FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE:
-		/* Only punch if the device can do zeroing discard. */
-		if (!blk_queue_discard(q) || !q->limits.discard_zeroes_data)
-			return -EOPNOTSUPP;
-		error = blkdev_issue_discard(bdev, start >> 9, len >> 9,
-					     GFP_KERNEL, 0);
+		error = blkdev_issue_zeroout(bdev, start >> 9, len >> 9,
+					     GFP_KERNEL, BLKDEV_ZERO_NOFALLBACK);
 		break;
 	case FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE | FALLOC_FL_NO_HIDE_STALE:
-		if (!blk_queue_discard(q))
-			return -EOPNOTSUPP;
 		error = blkdev_issue_discard(bdev, start >> 9, len >> 9,
 					     GFP_KERNEL, 0);
 		break;
-- 
2.11.0

  parent reply	other threads:[~2017-03-31 16:33 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-31 16:32 always use REQ_OP_WRITE_ZEROES for zeroing offload Christoph Hellwig
2017-03-31 16:32 ` [PATCH 01/25] ѕd: split sd_setup_discard_cmnd Christoph Hellwig
2017-04-05 11:42   ` Martin K. Petersen
2017-03-31 16:32 ` [PATCH 02/25] block: renumber REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-04-05 11:43   ` Martin K. Petersen
2017-03-31 16:32 ` [PATCH 03/25] block: implement splitting of REQ_OP_WRITE_ZEROES bios Christoph Hellwig
     [not found]   ` <20170331163313.31821-4-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:43     ` Martin K. Petersen
2017-04-05 11:43       ` Martin K. Petersen
2017-03-31 16:32 ` [PATCH 04/25] sd: implement REQ_OP_WRITE_ZEROES Christoph Hellwig
     [not found]   ` <20170331163313.31821-5-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:44     ` Martin K. Petersen
2017-04-05 11:44       ` Martin K. Petersen
2017-03-31 16:32 ` [PATCH 05/25] md: support REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-03-31 16:32 ` [PATCH 06/25] dm io: discards don't take a payload Christoph Hellwig
2017-03-31 16:32 ` [PATCH 07/25] dm: support REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-03-31 16:32 ` [PATCH 08/25] dm kcopyd: switch to use REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-03-31 16:32 ` [PATCH 09/25] block: stop using blkdev_issue_write_same for zeroing Christoph Hellwig
     [not found]   ` <20170331163313.31821-10-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:45     ` Martin K. Petersen
2017-04-05 11:45       ` Martin K. Petersen
2017-03-31 16:32 ` [PATCH 10/25] block: add a flags argument to (__)blkdev_issue_zeroout Christoph Hellwig
     [not found]   ` <20170331163313.31821-11-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:46     ` Martin K. Petersen
2017-04-05 11:46       ` Martin K. Petersen
2017-03-31 16:32 ` [PATCH 11/25] block: add a REQ_UNMAP flag for REQ_OP_WRITE_ZEROES Christoph Hellwig
     [not found]   ` <20170331163313.31821-12-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:46     ` Martin K. Petersen
2017-04-05 11:46       ` Martin K. Petersen
2017-03-31 16:33 ` [PATCH 12/25] block: add a new BLKDEV_ZERO_NOFALLBACK flag Christoph Hellwig
     [not found]   ` <20170331163313.31821-13-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:47     ` Martin K. Petersen
2017-04-05 11:47       ` Martin K. Petersen
2017-03-31 16:33 ` Christoph Hellwig [this message]
     [not found]   ` <20170331163313.31821-14-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:48     ` [PATCH 13/25] block_dev: use blkdev_issue_zerout for hole punches Martin K. Petersen
2017-04-05 11:48       ` Martin K. Petersen
2017-03-31 16:33 ` [PATCH 14/25] sd: implement unmapping Write Zeroes Christoph Hellwig
     [not found]   ` <20170331163313.31821-15-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:48     ` Martin K. Petersen
2017-04-05 11:48       ` Martin K. Petersen
2017-03-31 16:33 ` [PATCH 15/25] nvme: implement REQ_OP_WRITE_ZEROES Christoph Hellwig
     [not found]   ` <20170331163313.31821-16-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:49     ` Martin K. Petersen
2017-04-05 11:49       ` Martin K. Petersen
2017-03-31 16:33 ` [PATCH 16/25] zram: " Christoph Hellwig
2017-03-31 16:33 ` [PATCH 17/25] loop: " Christoph Hellwig
2017-03-31 16:33 ` [PATCH 18/25] brd: remove discard support Christoph Hellwig
2017-03-31 16:33 ` [PATCH 19/25] rbd: remove the discard_zeroes_data flag Christoph Hellwig
2017-03-31 16:33 ` [PATCH 20/25] rsxx: " Christoph Hellwig
2017-03-31 16:33 ` [PATCH 21/25] mmc: " Christoph Hellwig
2017-03-31 16:33 ` [PATCH 22/25] block: stop using discards for zeroing Christoph Hellwig
     [not found]   ` <20170331163313.31821-23-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:55     ` Martin K. Petersen
2017-04-05 11:55       ` Martin K. Petersen
2017-03-31 16:33 ` [PATCH 23/25] drbd: make intelligent use of blkdev_issue_zeroout Christoph Hellwig
2017-03-31 16:33 ` [PATCH 24/25] drbd: implement REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-03-31 16:33 ` [PATCH 25/25] block: remove the discard_zeroes_data flag Christoph Hellwig
     [not found]   ` <20170331163313.31821-26-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:56     ` Martin K. Petersen
2017-04-05 11:56       ` Martin K. Petersen
2017-04-03  6:06 ` always use REQ_OP_WRITE_ZEROES for zeroing offload Hannes Reinecke
2017-04-03  6:06   ` Hannes Reinecke
     [not found] ` <20170331163313.31821-1-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:40   ` Martin K. Petersen
2017-04-05 11:40     ` Martin K. Petersen
     [not found]     ` <yq1vaqjt74b.fsf-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-04-05 12:08       ` Christoph Hellwig
2017-04-05 12:08         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170331163313.31821-14-hch@lst.de \
    --to=hch@lst.de \
    --cc=agk@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=drbd-dev@lists.linbit.com \
    --cc=lars.ellenberg@linbit.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=philipp.reisner@linbit.com \
    --cc=shli@kernel.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.