All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: "Martin K. Petersen"
	<martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
	linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	philipp.reisner-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org,
	linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	lars.ellenberg-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org,
	shli-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
	agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org
Subject: Re: always use REQ_OP_WRITE_ZEROES for zeroing offload
Date: Wed, 5 Apr 2017 14:08:26 +0200	[thread overview]
Message-ID: <20170405120826.GA2275@lst.de> (raw)
In-Reply-To: <yq1vaqjt74b.fsf-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

On Wed, Apr 05, 2017 at 07:40:36AM -0400, Martin K. Petersen wrote:
> > This series makes REQ_OP_WRITE_ZEROES the only zeroing offload
> > supported by the block layer, and switches existing implementations
> > of REQ_OP_DISCARD that correctly set discard_zeroes_data to it,
> > removes incorrect discard_zeroes_data, and also switches WRITE SAME
> > based zeroing in SCSI to this new method.
> 
> Very, very nice. I think this is the correct approach.
> 
> I'm going to send two follow-up patches that allow us to use UNMAP for
> discards and WRITE SAME w/ UNMAP for zeroout. That appears to be the
> preferred configuration for most storage devices.

Thanks, I'll resend it with your nitpicks fixed, your follow on
patches tacked on and the various reviewed-by tags in a bit.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
	axboe@kernel.dk, agk@redhat.com, snitzer@redhat.com,
	shli@kernel.org, philipp.reisner@linbit.com,
	lars.ellenberg@linbit.com, linux-block@vger.kernel.org,
	linux-scsi@vger.kernel.org, drbd-dev@lists.linbit.com,
	dm-devel@redhat.com, linux-raid@vger.kernel.org
Subject: Re: always use REQ_OP_WRITE_ZEROES for zeroing offload
Date: Wed, 5 Apr 2017 14:08:26 +0200	[thread overview]
Message-ID: <20170405120826.GA2275@lst.de> (raw)
In-Reply-To: <yq1vaqjt74b.fsf@oracle.com>

On Wed, Apr 05, 2017 at 07:40:36AM -0400, Martin K. Petersen wrote:
> > This series makes REQ_OP_WRITE_ZEROES the only zeroing offload
> > supported by the block layer, and switches existing implementations
> > of REQ_OP_DISCARD that correctly set discard_zeroes_data to it,
> > removes incorrect discard_zeroes_data, and also switches WRITE SAME
> > based zeroing in SCSI to this new method.
> 
> Very, very nice. I think this is the correct approach.
> 
> I'm going to send two follow-up patches that allow us to use UNMAP for
> discards and WRITE SAME w/ UNMAP for zeroout. That appears to be the
> preferred configuration for most storage devices.

Thanks, I'll resend it with your nitpicks fixed, your follow on
patches tacked on and the various reviewed-by tags in a bit.

  parent reply	other threads:[~2017-04-05 12:08 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-31 16:32 always use REQ_OP_WRITE_ZEROES for zeroing offload Christoph Hellwig
2017-03-31 16:32 ` [PATCH 01/25] ѕd: split sd_setup_discard_cmnd Christoph Hellwig
2017-04-05 11:42   ` Martin K. Petersen
2017-03-31 16:32 ` [PATCH 02/25] block: renumber REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-04-05 11:43   ` Martin K. Petersen
2017-03-31 16:32 ` [PATCH 03/25] block: implement splitting of REQ_OP_WRITE_ZEROES bios Christoph Hellwig
     [not found]   ` <20170331163313.31821-4-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:43     ` Martin K. Petersen
2017-04-05 11:43       ` Martin K. Petersen
2017-03-31 16:32 ` [PATCH 04/25] sd: implement REQ_OP_WRITE_ZEROES Christoph Hellwig
     [not found]   ` <20170331163313.31821-5-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:44     ` Martin K. Petersen
2017-04-05 11:44       ` Martin K. Petersen
2017-03-31 16:32 ` [PATCH 05/25] md: support REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-03-31 16:32 ` [PATCH 06/25] dm io: discards don't take a payload Christoph Hellwig
2017-03-31 16:32 ` [PATCH 07/25] dm: support REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-03-31 16:32 ` [PATCH 08/25] dm kcopyd: switch to use REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-03-31 16:32 ` [PATCH 09/25] block: stop using blkdev_issue_write_same for zeroing Christoph Hellwig
     [not found]   ` <20170331163313.31821-10-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:45     ` Martin K. Petersen
2017-04-05 11:45       ` Martin K. Petersen
2017-03-31 16:32 ` [PATCH 10/25] block: add a flags argument to (__)blkdev_issue_zeroout Christoph Hellwig
     [not found]   ` <20170331163313.31821-11-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:46     ` Martin K. Petersen
2017-04-05 11:46       ` Martin K. Petersen
2017-03-31 16:32 ` [PATCH 11/25] block: add a REQ_UNMAP flag for REQ_OP_WRITE_ZEROES Christoph Hellwig
     [not found]   ` <20170331163313.31821-12-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:46     ` Martin K. Petersen
2017-04-05 11:46       ` Martin K. Petersen
2017-03-31 16:33 ` [PATCH 12/25] block: add a new BLKDEV_ZERO_NOFALLBACK flag Christoph Hellwig
     [not found]   ` <20170331163313.31821-13-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:47     ` Martin K. Petersen
2017-04-05 11:47       ` Martin K. Petersen
2017-03-31 16:33 ` [PATCH 13/25] block_dev: use blkdev_issue_zerout for hole punches Christoph Hellwig
     [not found]   ` <20170331163313.31821-14-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:48     ` Martin K. Petersen
2017-04-05 11:48       ` Martin K. Petersen
2017-03-31 16:33 ` [PATCH 14/25] sd: implement unmapping Write Zeroes Christoph Hellwig
     [not found]   ` <20170331163313.31821-15-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:48     ` Martin K. Petersen
2017-04-05 11:48       ` Martin K. Petersen
2017-03-31 16:33 ` [PATCH 15/25] nvme: implement REQ_OP_WRITE_ZEROES Christoph Hellwig
     [not found]   ` <20170331163313.31821-16-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:49     ` Martin K. Petersen
2017-04-05 11:49       ` Martin K. Petersen
2017-03-31 16:33 ` [PATCH 16/25] zram: " Christoph Hellwig
2017-03-31 16:33 ` [PATCH 17/25] loop: " Christoph Hellwig
2017-03-31 16:33 ` [PATCH 18/25] brd: remove discard support Christoph Hellwig
2017-03-31 16:33 ` [PATCH 19/25] rbd: remove the discard_zeroes_data flag Christoph Hellwig
2017-03-31 16:33 ` [PATCH 20/25] rsxx: " Christoph Hellwig
2017-03-31 16:33 ` [PATCH 21/25] mmc: " Christoph Hellwig
2017-03-31 16:33 ` [PATCH 22/25] block: stop using discards for zeroing Christoph Hellwig
     [not found]   ` <20170331163313.31821-23-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:55     ` Martin K. Petersen
2017-04-05 11:55       ` Martin K. Petersen
2017-03-31 16:33 ` [PATCH 23/25] drbd: make intelligent use of blkdev_issue_zeroout Christoph Hellwig
2017-03-31 16:33 ` [PATCH 24/25] drbd: implement REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-03-31 16:33 ` [PATCH 25/25] block: remove the discard_zeroes_data flag Christoph Hellwig
     [not found]   ` <20170331163313.31821-26-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:56     ` Martin K. Petersen
2017-04-05 11:56       ` Martin K. Petersen
2017-04-03  6:06 ` always use REQ_OP_WRITE_ZEROES for zeroing offload Hannes Reinecke
2017-04-03  6:06   ` Hannes Reinecke
     [not found] ` <20170331163313.31821-1-hch-jcswGhMUV9g@public.gmane.org>
2017-04-05 11:40   ` Martin K. Petersen
2017-04-05 11:40     ` Martin K. Petersen
     [not found]     ` <yq1vaqjt74b.fsf-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-04-05 12:08       ` Christoph Hellwig [this message]
2017-04-05 12:08         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170405120826.GA2275@lst.de \
    --to=hch-jcswghmuv9g@public.gmane.org \
    --cc=agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
    --cc=dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org \
    --cc=lars.ellenberg-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org \
    --cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=philipp.reisner-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org \
    --cc=shli-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.