From: Al Viro <viro@ZenIV.linux.org.uk>
To: Joe Perches <joe@perches.com>
Cc: Chewie Lin <linsh@oregonstate.edu>,
greg@kroah.com, forest@alittletooquiet.net,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning
Date: Sat, 1 Apr 2017 05:08:42 +0100 [thread overview]
Message-ID: <20170401040842.GF29622@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1491018770.27353.35.camel@perches.com>
On Fri, Mar 31, 2017 at 08:52:50PM -0700, Joe Perches wrote:
> > MILD SUGGESTION: don't spell the function name out in format strings;
> > "this_function: foo is %d", n
> > might be better off as
> > "%s: foo is %d", __func__, n
> > in case you ever move it to another function or rename your function.
>
> Thank you sir, may I have another.
>
> checkpatch messages are single line.
Too bad... Incidentally, being able to get more detailed explanation of
a warning might be a serious improvement, especially if it contains
the rationale. Hell, something like TeX handling of errors might be
a good idea - warning printed, offered actions include 'give more help',
'continue', 'exit', 'from now on suppress this kind of warning', 'from
now on just dump this kind of warning into log and keep going', 'from
now on dump all warnings into log and keep going'.
And yes, I'm serious about having something like "mild suggestion" as
possible severity - people are using that thing to look for potential
improvements to make and 'such and such change might be useful for such
and such reasons' is a lot more useful than 'this needs to be thus because
it must be thus or I'll keep warning'.
next prev parent reply other threads:[~2017-04-01 4:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 1:59 [PATCH] eudyptula challenge Chewie Lin
2017-04-01 1:59 ` [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin
2017-04-01 2:15 ` Randy Dunlap
2017-04-01 2:45 ` Joe Perches
2017-04-01 3:18 ` Chewie Lin
2017-04-01 3:33 ` Joe Perches
2017-04-01 2:16 ` Joe Perches
2017-04-01 3:32 ` Al Viro
2017-04-01 3:36 ` Joe Perches
2017-04-01 3:46 ` Al Viro
2017-04-01 3:52 ` Joe Perches
2017-04-01 4:08 ` Al Viro [this message]
2017-04-01 4:27 ` Joe Perches
2017-04-01 4:33 ` Chewie Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170401040842.GF29622@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=greg@kroah.com \
--cc=joe@perches.com \
--cc=linsh@oregonstate.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.