From: Randy Dunlap <rdunlap@infradead.org>
To: Chewie Lin <linsh@oregonstate.edu>,
greg@kroah.com, forest@alittletooquiet.net,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning
Date: Fri, 31 Mar 2017 19:15:06 -0700 [thread overview]
Message-ID: <861e5179-270f-ce93-4d9c-9732945bf8c1@infradead.org> (raw)
In-Reply-To: <20170401015919.9181-2-linsh@oregonstate.edu>
On 03/31/17 18:59, Chewie Lin wrote:
> Replace string with formatted arguments in the dev_warn() call. It removes
> the checkpatch warning:
>
> WARNING: Prefer using "%s", __func__ to embedded function names
> #417: FILE: main_usb.c:417:
> + "usb_device_reset fail status=%d\n", status);
>
> total: 0 errors, 1 warnings, 1058 lines checked
>
> And after fix:
>
> main_usb.c has no obvious style problems and is ready for submission.
>
> Signed-off-by: Chewie Lin <linsh@oregonstate.edu>
> ---
> drivers/staging/vt6656/main_usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> index 9e074e9..2d9e7af 100644
> --- a/drivers/staging/vt6656/main_usb.c
> +++ b/drivers/staging/vt6656/main_usb.c
> @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
> status = usb_reset_device(priv->usb);
> if (status)
> dev_warn(&priv->usb->dev,
> - "usb_device_reset fail status=%d\n", status);
> + "%s=%d\n", "usb_device_reset fail status", status);
> }
>
> static void vnt_free_int_bufs(struct vnt_private *priv)
>
As other people have said:
This function is usb_device_reset(). If that function name string is to be
used in the message, it should be done so by using __func__.
See http://marc.info/?l=linux-driver-devel&m=149095639202492&w=2
Or is the called (failing) function name is to be kept in the message (as it
is currently), then the message should contain "usb_reset_device" instead of
"usb_device_reset". See http://marc.info/?l=linux-driver-devel&m=149098680312723&w=2
--
~Randy
next prev parent reply other threads:[~2017-04-01 2:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 1:59 [PATCH] eudyptula challenge Chewie Lin
2017-04-01 1:59 ` [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin
2017-04-01 2:15 ` Randy Dunlap [this message]
2017-04-01 2:45 ` Joe Perches
2017-04-01 3:18 ` Chewie Lin
2017-04-01 3:33 ` Joe Perches
2017-04-01 2:16 ` Joe Perches
2017-04-01 3:32 ` Al Viro
2017-04-01 3:36 ` Joe Perches
2017-04-01 3:46 ` Al Viro
2017-04-01 3:52 ` Joe Perches
2017-04-01 4:08 ` Al Viro
2017-04-01 4:27 ` Joe Perches
2017-04-01 4:33 ` Chewie Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=861e5179-270f-ce93-4d9c-9732945bf8c1@infradead.org \
--to=rdunlap@infradead.org \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=greg@kroah.com \
--cc=linsh@oregonstate.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.