* [PATCH] ldso: don't discard sysmbols for DODEBUG builds
@ 2017-03-31 18:22 Vineet Gupta
2017-04-03 3:24 ` [uclibc-ng-devel] " Waldemar Brodkorb
0 siblings, 1 reply; 2+ messages in thread
From: Vineet Gupta @ 2017-03-31 18:22 UTC (permalink / raw)
To: linux-snps-arc
the --discard-* toggles take away the symbols which comes in the way
when staring at objdumps for debugging low level issues
So don't discard symbols for DODEBUG builds
before
-----
3388: j_s.d [blink]
338a: add_s sp,sp,0x18
338c: b.d 332c <_dl_add_elf_hash_table+0x50>
3390: mov_s r2,0
3392: nop_s
3394: push_s blink <--- function not called out
3396: st.aw r13,[sp,-20]
339a: std r14r15,[sp,4]
339e: std r16r17,[sp,12]
after
-----
3388: j_s.d [blink]
338a: add_s sp,sp,0x18
338c: b.d 332c <_dl_add_elf_hash_table+0x50>
3390: mov_s r2,0
3392: nop_s
00003394 <add_ldso.isra.9>:
3394: push_s blink
3396: st.aw r13,[sp,-20]
339a: std r14r15,[sp,4]
339e: std r16r17,[sp,12]
Signed-off-by: Vineet Gupta <vgupta at synopsys.com>
---
ldso/ldso/Makefile.in | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/ldso/ldso/Makefile.in b/ldso/ldso/Makefile.in
index 320e4488ba22..acb1a5b2ac15 100644
--- a/ldso/ldso/Makefile.in
+++ b/ldso/ldso/Makefile.in
@@ -51,8 +51,11 @@ LDFLAGS-$(UCLIBC_LDSO_NAME).so := $(LDFLAGS_NOSTRIP) -Wl,-z,defs
endif
LDFLAGS-$(UCLIBC_LDSO_NAME).so += -Wl,-e,$(SYMBOL_PREFIX)_start \
-Wl,-z,now -Wl,-Bsymbolic \
- -Wl,--export-dynamic $(CFLAG_-Wl--sort-common) -Wl,--discard-locals \
- $(CFLAG_-Wl--discard-all) -Wl,--no-undefined
+ -Wl,--export-dynamic $(CFLAG_-Wl--sort-common) -Wl,--no-undefined
+
+ifneq ($(DODEBUG),y)
+ LDFLAGS-$(UCLIBC_LDSO_NAME).so += -Wl,--discard-locals $(CFLAG_-Wl--discard-all)
+endif
LDFLAGS-$(LDSO_PRELINK_SUPPORT)-$(UCLIBC_LDSO_NAME).so += -Wl,-defsym=$(SYMBOL_PREFIX)_begin=0
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [uclibc-ng-devel] [PATCH] ldso: don't discard sysmbols for DODEBUG builds
2017-03-31 18:22 [PATCH] ldso: don't discard sysmbols for DODEBUG builds Vineet Gupta
@ 2017-04-03 3:24 ` Waldemar Brodkorb
0 siblings, 0 replies; 2+ messages in thread
From: Waldemar Brodkorb @ 2017-04-03 3:24 UTC (permalink / raw)
To: linux-snps-arc
Hi Vineet,
Vineet Gupta wrote,
> the --discard-* toggles take away the symbols which comes in the way
> when staring at objdumps for debugging low level issues
>
> So don't discard symbols for DODEBUG builds
Applied and pushed,
Thanks
Waldemar
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-03 3:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-31 18:22 [PATCH] ldso: don't discard sysmbols for DODEBUG builds Vineet Gupta
2017-04-03 3:24 ` [uclibc-ng-devel] " Waldemar Brodkorb
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.