[bug report] drm/amd/powerplay: add Vega10 powerplay support (v5)

* [bug report] drm/amd/powerplay: add Vega10 powerplay support (v5)
@ 2017-04-03 19:38 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2017-04-03 19:38 UTC (permalink / raw)
  To: JinHuiEric.Huang-5C7GfCeVMHo; +Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

Hello Eric Huang,

The patch f83a9991648b: "drm/amd/powerplay: add Vega10 powerplay
support (v5)" from Mar 6, 2017, leads to the following static checker
warning:

	drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_processpptables.c:436 get_gfxclk_voltage_dependency_table()
	warn: mask and shift to zero

drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_processpptables.c
   428  
   429          for (i = 0; i < clk_table->count; i++) {
   430                  clk_table->entries[i].vddInd =
   431                                  clk_dep_table->entries[i].ucVddInd;
   432                  clk_table->entries[i].clk =
   433                                  le32_to_cpu(clk_dep_table->entries[i].ulClk);
   434                  clk_table->entries[i].cks_enable =
   435                                  (((clk_dep_table->entries[i].usCKSVOffsetandDisable & 0x80)
   436                                                  >> 15) == 0) ? 1 : 0;

We aways set .cks_enable to true because 0x80 >> 15 is zero.

   437                  clk_table->entries[i].cks_voffset =
   438                                  (clk_dep_table->entries[i].usCKSVOffsetandDisable & 0x7F);
   439                  clk_table->entries[i].sclk_offset =
   440                                  clk_dep_table->entries[i].usAVFSOffset;
   441          }
   442  

regards,
dan carpenter
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] only message in thread