From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Patrick Menschel <menschel.p@posteo.de>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
wens@csie.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-can@vger.kernel.org
Subject: Re: [PATCH v3 2/4] ARM: dts: sun4i: Add can0_pins_a pinctrl settings
Date: Tue, 4 Apr 2017 17:40:55 +0200 [thread overview]
Message-ID: <20170404154055.ccteyn3eeviciwvh@lukather> (raw)
In-Reply-To: <1491238814-4888-3-git-send-email-menschel.p@posteo.de>
[-- Attachment #1: Type: text/plain, Size: 965 bytes --]
On Mon, Apr 03, 2017 at 07:00:12PM +0200, Patrick Menschel wrote:
> The A10 SoC has an on-board CAN controller. This patch adds the
> pinctrl settings for pins PH20 and PH21.
>
> This patch is adapted from the description in
> Documentation/devicetree/bindings/net/can/sun4i_can.txt
>
> Signed-off-by: Patrick Menschel <menschel.p@posteo.de>
> ---
> arch/arm/boot/dts/sun4i-a10.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
> index 7c559e7..f7dced4 100644
> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> @@ -974,6 +974,11 @@
> #interrupt-cells = <3>;
> #gpio-cells = <3>;
>
> + can0_pins_a: can0@0 {
> + pins = "PH20","PH21";
You need a space after the comma here. Fixed and applied.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/4] ARM: dts: sun4i: Add can0_pins_a pinctrl settings
Date: Tue, 4 Apr 2017 17:40:55 +0200 [thread overview]
Message-ID: <20170404154055.ccteyn3eeviciwvh@lukather> (raw)
In-Reply-To: <1491238814-4888-3-git-send-email-menschel.p@posteo.de>
On Mon, Apr 03, 2017 at 07:00:12PM +0200, Patrick Menschel wrote:
> The A10 SoC has an on-board CAN controller. This patch adds the
> pinctrl settings for pins PH20 and PH21.
>
> This patch is adapted from the description in
> Documentation/devicetree/bindings/net/can/sun4i_can.txt
>
> Signed-off-by: Patrick Menschel <menschel.p@posteo.de>
> ---
> arch/arm/boot/dts/sun4i-a10.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
> index 7c559e7..f7dced4 100644
> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> @@ -974,6 +974,11 @@
> #interrupt-cells = <3>;
> #gpio-cells = <3>;
>
> + can0_pins_a: can0 at 0 {
> + pins = "PH20","PH21";
You need a space after the comma here. Fixed and applied.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170404/773f44d3/attachment.sig>
next prev parent reply other threads:[~2017-04-04 15:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 17:00 [PATCH v3 0/4] ARM: dts: sunxi: Add CAN node and can0_pins_a pinctrl settings Patrick Menschel
2017-04-03 17:00 ` Patrick Menschel
[not found] ` <1491238814-4888-1-git-send-email-menschel.p-1KBjaw7Xf1+zQB+pC5nmwQ@public.gmane.org>
2017-04-03 17:00 ` [PATCH v3 1/4] ARM: dts: sun4i: Add CAN node Patrick Menschel
2017-04-03 17:00 ` Patrick Menschel
2017-04-03 17:00 ` Patrick Menschel
[not found] ` <1491238814-4888-2-git-send-email-menschel.p-1KBjaw7Xf1+zQB+pC5nmwQ@public.gmane.org>
2017-04-04 15:40 ` Maxime Ripard
2017-04-04 15:40 ` Maxime Ripard
2017-04-04 15:40 ` Maxime Ripard
2017-04-04 16:54 ` Patrick Menschel
2017-04-04 16:54 ` Patrick Menschel
2017-04-03 17:00 ` [PATCH v3 2/4] ARM: dts: sun4i: Add can0_pins_a pinctrl settings Patrick Menschel
2017-04-03 17:00 ` Patrick Menschel
2017-04-04 15:40 ` Maxime Ripard [this message]
2017-04-04 15:40 ` Maxime Ripard
2017-04-03 17:00 ` [PATCH v3 3/4] ARM: dts: sun7i: Add CAN node Patrick Menschel
2017-04-03 17:00 ` Patrick Menschel
2017-04-03 17:00 ` [PATCH v3 4/4] ARM: dts: sun7i: Add can0_pins_a pinctrl settings Patrick Menschel
2017-04-03 17:00 ` Patrick Menschel
[not found] ` <1491238814-4888-5-git-send-email-menschel.p-1KBjaw7Xf1+zQB+pC5nmwQ@public.gmane.org>
2017-04-04 15:43 ` Maxime Ripard
2017-04-04 15:43 ` Maxime Ripard
2017-04-04 15:43 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170404154055.ccteyn3eeviciwvh@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=menschel.p@posteo.de \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.