* [U-Boot] [PATCH] spl: Kconfig: SPL_MMC_SUPPORT depends on GENERIC_MMC
@ 2017-03-18 5:05 Alexandru Gagniuc
2017-03-21 0:04 ` [U-Boot] " Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Alexandru Gagniuc @ 2017-03-18 5:05 UTC (permalink / raw)
To: u-boot
spl_mmc.c calls mmc_initialize(). This symbol is provided in
drivers/mmc/mmc.c when CONFIG_GENERIC_MMC is enabled.
Signed-off-by: Alexandru Gagniuc <alex.g@adaptrum.com>
---
common/spl/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/common/spl/Kconfig b/common/spl/Kconfig
index 60ae60c..0b2b7ff 100644
--- a/common/spl/Kconfig
+++ b/common/spl/Kconfig
@@ -354,6 +354,7 @@ config SPL_LIBGENERIC_SUPPORT
config SPL_MMC_SUPPORT
bool "Support MMC"
depends on SPL
+ depends on GENERIC_MMC
help
Enable support for MMC (Multimedia Card) within SPL. This enables
the MMC protocol implementation and allows any enabled drivers to
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] spl: Kconfig: SPL_MMC_SUPPORT depends on GENERIC_MMC
2017-03-18 5:05 [U-Boot] [PATCH] spl: Kconfig: SPL_MMC_SUPPORT depends on GENERIC_MMC Alexandru Gagniuc
@ 2017-03-21 0:04 ` Tom Rini
2017-03-27 19:13 ` Alexandru Gagniuc
0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2017-03-21 0:04 UTC (permalink / raw)
To: u-boot
On Fri, Mar 17, 2017 at 10:05:40PM -0700, Alexandru Gagniuc wrote:
> spl_mmc.c calls mmc_initialize(). This symbol is provided in
> drivers/mmc/mmc.c when CONFIG_GENERIC_MMC is enabled.
>
> Signed-off-by: Alexandru Gagniuc <alex.g@adaptrum.com>
> ---
> common/spl/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> index 60ae60c..0b2b7ff 100644
> --- a/common/spl/Kconfig
> +++ b/common/spl/Kconfig
> @@ -354,6 +354,7 @@ config SPL_LIBGENERIC_SUPPORT
> config SPL_MMC_SUPPORT
> bool "Support MMC"
> depends on SPL
> + depends on GENERIC_MMC
> help
> Enable support for MMC (Multimedia Card) within SPL. This enables
> the MMC protocol implementation and allows any enabled drivers to
This isn't 100% right as it breaks some sunxi boards as-is, CHIP (which
indeed doesn't do MMC) and Nintendo_NES_Classic_Edition.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170320/b8d202b1/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] spl: Kconfig: SPL_MMC_SUPPORT depends on GENERIC_MMC
2017-03-21 0:04 ` [U-Boot] " Tom Rini
@ 2017-03-27 19:13 ` Alexandru Gagniuc
2017-04-04 15:10 ` Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Alexandru Gagniuc @ 2017-03-27 19:13 UTC (permalink / raw)
To: u-boot
On 03/20/2017 05:04 PM, Tom Rini wrote:
> On Fri, Mar 17, 2017 at 10:05:40PM -0700, Alexandru Gagniuc wrote:
>
>> spl_mmc.c calls mmc_initialize(). This symbol is provided in
>> drivers/mmc/mmc.c when CONFIG_GENERIC_MMC is enabled.
>>
>> Signed-off-by: Alexandru Gagniuc <alex.g@adaptrum.com>
>> ---
>> common/spl/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/common/spl/Kconfig b/common/spl/Kconfig
>> index 60ae60c..0b2b7ff 100644
>> --- a/common/spl/Kconfig
>> +++ b/common/spl/Kconfig
>> @@ -354,6 +354,7 @@ config SPL_LIBGENERIC_SUPPORT
>> config SPL_MMC_SUPPORT
>> bool "Support MMC"
>> depends on SPL
>> + depends on GENERIC_MMC
>> help
>> Enable support for MMC (Multimedia Card) within SPL. This enables
>> the MMC protocol implementation and allows any enabled drivers to
>
> This isn't 100% right as it breaks some sunxi boards as-is, CHIP (which
> indeed doesn't do MMC) and Nintendo_NES_Classic_Edition.
How exactly does it break things? Do you have a link to build test
results. If I don't know what's broken, I can't fix it.
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] spl: Kconfig: SPL_MMC_SUPPORT depends on GENERIC_MMC
2017-03-27 19:13 ` Alexandru Gagniuc
@ 2017-04-04 15:10 ` Tom Rini
2017-04-04 17:02 ` [U-Boot] [PATCH] " Alexandru Gagniuc
0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2017-04-04 15:10 UTC (permalink / raw)
To: u-boot
On Mon, Mar 27, 2017 at 12:13:04PM -0700, Alexandru Gagniuc wrote:
> On 03/20/2017 05:04 PM, Tom Rini wrote:
> >On Fri, Mar 17, 2017 at 10:05:40PM -0700, Alexandru Gagniuc wrote:
> >
> >>spl_mmc.c calls mmc_initialize(). This symbol is provided in
> >>drivers/mmc/mmc.c when CONFIG_GENERIC_MMC is enabled.
> >>
> >>Signed-off-by: Alexandru Gagniuc <alex.g@adaptrum.com>
> >>---
> >> common/spl/Kconfig | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >>diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> >>index 60ae60c..0b2b7ff 100644
> >>--- a/common/spl/Kconfig
> >>+++ b/common/spl/Kconfig
> >>@@ -354,6 +354,7 @@ config SPL_LIBGENERIC_SUPPORT
> >> config SPL_MMC_SUPPORT
> >> bool "Support MMC"
> >> depends on SPL
> >>+ depends on GENERIC_MMC
> >> help
> >> Enable support for MMC (Multimedia Card) within SPL. This enables
> >> the MMC protocol implementation and allows any enabled drivers to
> >
> >This isn't 100% right as it breaks some sunxi boards as-is, CHIP (which
> >indeed doesn't do MMC) and Nintendo_NES_Classic_Edition.
>
> How exactly does it break things? Do you have a link to build test
> results. If I don't know what's broken, I can't fix it.
If you build one of those platforms (which just needs a regular ARM
toolchain), you'll see it. I don't have the logs around, sorry.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170404/1b8d9a61/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] spl: Kconfig: SPL_MMC_SUPPORT depends on GENERIC_MMC
2017-04-04 15:10 ` Tom Rini
@ 2017-04-04 17:02 ` Alexandru Gagniuc
2017-04-09 1:15 ` [U-Boot] " Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Alexandru Gagniuc @ 2017-04-04 17:02 UTC (permalink / raw)
To: u-boot
spl_mmc.c calls mmc_initialize(). This symbol is provided in
drivers/mmc/mmc.c when CONFIG_GENERIC_MMC is enabled.
The sunxi Kconfig case is an oddball because it redefines
SPL_MMC_SUPPORT.
Signed-off-by: Alexandru Gagniuc <alex.g@adaptrum.com>
---
Changes since v1:
* Applied same dependency logic to sunxi Kconfig file
board/sunxi/Kconfig | 2 ++
common/spl/Kconfig | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig
index 37b4252..bc01930 100644
--- a/board/sunxi/Kconfig
+++ b/board/sunxi/Kconfig
@@ -3,6 +3,7 @@ if ARCH_SUNXI
config IDENT_STRING
default " Allwinner Technology"
+# FIXME: Should not redefine these Kconfig symbols
config PRE_CONSOLE_BUFFER
default y
@@ -19,6 +20,7 @@ config SPL_LIBGENERIC_SUPPORT
default y
config SPL_MMC_SUPPORT
+ depends on SPL && GENERIC_MMC
default y
config SPL_POWER_SUPPORT
diff --git a/common/spl/Kconfig b/common/spl/Kconfig
index 6752b5c..ea6fbb6 100644
--- a/common/spl/Kconfig
+++ b/common/spl/Kconfig
@@ -371,7 +371,7 @@ config SPL_LIBGENERIC_SUPPORT
config SPL_MMC_SUPPORT
bool "Support MMC"
- depends on SPL
+ depends on SPL && GENERIC_MMC
help
Enable support for MMC (Multimedia Card) within SPL. This enables
the MMC protocol implementation and allows any enabled drivers to
--
2.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] spl: Kconfig: SPL_MMC_SUPPORT depends on GENERIC_MMC
2017-04-04 17:02 ` [U-Boot] [PATCH] " Alexandru Gagniuc
@ 2017-04-09 1:15 ` Tom Rini
0 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2017-04-09 1:15 UTC (permalink / raw)
To: u-boot
On Tue, Apr 04, 2017 at 10:02:58AM -0700, Alexandru Gagniuc wrote:
> spl_mmc.c calls mmc_initialize(). This symbol is provided in
> drivers/mmc/mmc.c when CONFIG_GENERIC_MMC is enabled.
> The sunxi Kconfig case is an oddball because it redefines
> SPL_MMC_SUPPORT.
>
> Signed-off-by: Alexandru Gagniuc <alex.g@adaptrum.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170408/ff51f4c1/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-09 1:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-18 5:05 [U-Boot] [PATCH] spl: Kconfig: SPL_MMC_SUPPORT depends on GENERIC_MMC Alexandru Gagniuc
2017-03-21 0:04 ` [U-Boot] " Tom Rini
2017-03-27 19:13 ` Alexandru Gagniuc
2017-04-04 15:10 ` Tom Rini
2017-04-04 17:02 ` [U-Boot] [PATCH] " Alexandru Gagniuc
2017-04-09 1:15 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.