* [Buildroot] [PATCH 01/11] package: remove trailing whitespace
@ 2017-04-04 22:50 Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 02/11] package: remove empty line at end of file Ricardo Martincoski
` (10 more replies)
0 siblings, 11 replies; 17+ messages in thread
From: Ricardo Martincoski @ 2017-04-04 22:50 UTC (permalink / raw)
To: buildroot
Occurrences were searched using [1]:
check-package --include-only TrailingSpace $(find * -type f)
and manually removed.
[1] http://patchwork.ozlabs.org/patch/729666/
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
build-tested with:
$ echo BR2_GOOGLE_BREAKPAD_ENABLE=y > host-google-breakpad.config
$ support/scripts/test-pkg -c host-google-breakpad.config \
-d /home/builds/test-pkg -p host-google-breakpad
49 builds, 29 skipped, 0 failed
---
package/google-breakpad/google-breakpad.mk | 2 +-
package/leafnode2/leafnode2.mk | 2 +-
package/mbedtls/Config.in | 2 +-
package/protobuf/Config.in | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/package/google-breakpad/google-breakpad.mk b/package/google-breakpad/google-breakpad.mk
index fd5a45d87..191ee5bec 100644
--- a/package/google-breakpad/google-breakpad.mk
+++ b/package/google-breakpad/google-breakpad.mk
@@ -15,7 +15,7 @@ GOOGLE_BREAKPAD_LICENSE = BSD-3-Clause
GOOGLE_BREAKPAD_LICENSE_FILES = LICENSE
GOOGLE_BREAKPAD_DEPENDENCIES = host-google-breakpad linux-syscall-support
-HOST_GOOGLE_BREAKPAD_DEPENDENCIES = host-linux-syscall-support
+HOST_GOOGLE_BREAKPAD_DEPENDENCIES = host-linux-syscall-support
# Avoid using depot-tools to download this file.
define HOST_GOOGLE_BREAKPAD_LSS
diff --git a/package/leafnode2/leafnode2.mk b/package/leafnode2/leafnode2.mk
index 92039c13c..4a920ccf9 100644
--- a/package/leafnode2/leafnode2.mk
+++ b/package/leafnode2/leafnode2.mk
@@ -16,7 +16,7 @@ LEAFNODE2_CONF_ENV = \
# --enable-runas-user use 'news' as default but the configure stop
# if news doesn't exist on the build host.
-# Use 'root' while cross-compiling
+# Use 'root' while cross-compiling
LEAFNODE2_CONF_OPTS = \
--sysconfdir=/etc/leafnode2 \
--enable-spooldir=/var/spool/news \
diff --git a/package/mbedtls/Config.in b/package/mbedtls/Config.in
index ed63f2da5..8836984cb 100644
--- a/package/mbedtls/Config.in
+++ b/package/mbedtls/Config.in
@@ -23,7 +23,7 @@ config BR2_PACKAGE_MBEDTLS_COMPRESSION
help
Enable support for compression of the content data before it
enters the secure channel as described in RFC 3749.
-
+
Warning: TLS compression may make you vulnerable to the CRIME
attack. You should not enable it unless you know for sure CRIME
and similar attacks are not applicable to your particular
diff --git a/package/protobuf/Config.in b/package/protobuf/Config.in
index bccf258f6..bece56c29 100644
--- a/package/protobuf/Config.in
+++ b/package/protobuf/Config.in
@@ -11,7 +11,7 @@
#
# Since protobuf most likely only uses the 1, 2 and 4-byte variants, it
# *could* technically build with gcc 4.7. This is probably not a big deal,
-# and we can live with requiring gcc 4.8 on PowerPC to build protobuf.
+# and we can live with requiring gcc 4.8 on PowerPC to build protobuf.
#
# The SPARC64 build fails due to a missing definition of Atomic64. This
# has been fixed on the master branch but the build still breaks due to
--
2.11.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH 02/11] package: remove empty line at end of file
2017-04-04 22:50 [Buildroot] [PATCH 01/11] package: remove trailing whitespace Ricardo Martincoski
@ 2017-04-04 22:50 ` Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 03/11] package: remove consecutive empty lines Ricardo Martincoski
` (9 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Ricardo Martincoski @ 2017-04-04 22:50 UTC (permalink / raw)
To: buildroot
Occurrences were searched using [1]:
check-package --include-only EmptyLastLine $(find * -type f)
and manually removed.
[1] http://patchwork.ozlabs.org/patch/729666/
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
package/acpica/acpica.hash | 1 -
package/cbootimage/cbootimage.mk | 1 -
package/freescale-imx/imx-kobs/Config.in | 1 -
package/freescale-imx/imx-lib/Config.in | 1 -
package/guile/Config.in | 1 -
package/libcli/Config.in | 1 -
package/libfreeimage/libfreeimage.mk | 1 -
package/ljsyscall/Config.in | 1 -
package/lua-csnappy/Config.in | 1 -
package/luasql-sqlite3/Config.in | 1 -
package/netsnmp/netsnmp.hash | 1 -
package/perl-netaddr-ip/Config.in | 1 -
package/ptpd2/Config.in | 1 -
package/python-cbor/Config.in | 1 -
package/python-iniparse/python-iniparse.hash | 1 -
package/python-lxml/Config.in.host | 1 -
package/python3/python3.hash | 1 -
package/ts4900-fpga/Config.in | 1 -
package/x11r7/xdriver_xf86-video-imx-viv/xdriver_xf86-video-imx-viv.mk | 1 -
19 files changed, 19 deletions(-)
diff --git a/package/acpica/acpica.hash b/package/acpica/acpica.hash
index 8f1c08a67..71c110ba8 100644
--- a/package/acpica/acpica.hash
+++ b/package/acpica/acpica.hash
@@ -1,3 +1,2 @@
# locally computed hash
sha256 dfb33db5599bd48134dbd6e50c8804099be0cf1c35d98975a6cb84dabca78b67 acpica-unix2-20161117.tar.gz
-
diff --git a/package/cbootimage/cbootimage.mk b/package/cbootimage/cbootimage.mk
index 22a6e5331..40a248aed 100644
--- a/package/cbootimage/cbootimage.mk
+++ b/package/cbootimage/cbootimage.mk
@@ -12,4 +12,3 @@ CBOOTIMAGE_AUTORECONF = YES
$(eval $(autotools-package))
$(eval $(host-autotools-package))
-
diff --git a/package/freescale-imx/imx-kobs/Config.in b/package/freescale-imx/imx-kobs/Config.in
index fc2344ed0..61be9f26d 100644
--- a/package/freescale-imx/imx-kobs/Config.in
+++ b/package/freescale-imx/imx-kobs/Config.in
@@ -7,4 +7,3 @@ config BR2_PACKAGE_IMX_KOBS
This library is provided by Freescale as-is and doesn't have
an upstream.
-
diff --git a/package/freescale-imx/imx-lib/Config.in b/package/freescale-imx/imx-lib/Config.in
index 3b0f7a921..368770504 100644
--- a/package/freescale-imx/imx-lib/Config.in
+++ b/package/freescale-imx/imx-lib/Config.in
@@ -13,4 +13,3 @@ config BR2_PACKAGE_IMX_LIB
This library is provided by Freescale as-is and doesn't have
an upstream.
-
diff --git a/package/guile/Config.in b/package/guile/Config.in
index e0f657127..c26c296e4 100644
--- a/package/guile/Config.in
+++ b/package/guile/Config.in
@@ -19,4 +19,3 @@ config BR2_PACKAGE_GUILE
comment "guile needs a uClibc or glibc toolchain w/ threads, wchar, dynamic library"
depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || \
BR2_STATIC_LIBS || BR2_TOOLCHAIN_USES_MUSL
-
diff --git a/package/libcli/Config.in b/package/libcli/Config.in
index e20afb0e0..3b625c364 100644
--- a/package/libcli/Config.in
+++ b/package/libcli/Config.in
@@ -8,4 +8,3 @@ config BR2_PACKAGE_LIBCLI
tree.
http://sites.dparrish.com/libcli
-
diff --git a/package/libfreeimage/libfreeimage.mk b/package/libfreeimage/libfreeimage.mk
index cd73f5a8e..0ca23933a 100644
--- a/package/libfreeimage/libfreeimage.mk
+++ b/package/libfreeimage/libfreeimage.mk
@@ -30,4 +30,3 @@ define LIBFREEIMAGE_INSTALL_TARGET_CMDS
endef
$(eval $(generic-package))
-
diff --git a/package/ljsyscall/Config.in b/package/ljsyscall/Config.in
index 149e71d3f..d78591ec9 100644
--- a/package/ljsyscall/Config.in
+++ b/package/ljsyscall/Config.in
@@ -9,4 +9,3 @@ config BR2_PACKAGE_LJSYSCALL
comment "ljsyscall needs LuaJIT"
depends on !BR2_PACKAGE_LUAJIT
-
diff --git a/package/lua-csnappy/Config.in b/package/lua-csnappy/Config.in
index 0562277a0..54d68a2e1 100644
--- a/package/lua-csnappy/Config.in
+++ b/package/lua-csnappy/Config.in
@@ -5,4 +5,3 @@ config BR2_PACKAGE_LUA_CSNAPPY
which implements the Google's Snappy (de)compressor.
http://fperrad.github.io/lua-csnappy/
-
diff --git a/package/luasql-sqlite3/Config.in b/package/luasql-sqlite3/Config.in
index 3bd73f3ba..483d6a0f3 100644
--- a/package/luasql-sqlite3/Config.in
+++ b/package/luasql-sqlite3/Config.in
@@ -6,4 +6,3 @@ config BR2_PACKAGE_LUASQL_SQLITE3
LuaSQL is a simple interface from Lua to a DBMS.
http://www.keplerproject.org/luasql
-
diff --git a/package/netsnmp/netsnmp.hash b/package/netsnmp/netsnmp.hash
index 2c18441fe..fc7792602 100644
--- a/package/netsnmp/netsnmp.hash
+++ b/package/netsnmp/netsnmp.hash
@@ -1,4 +1,3 @@
# From http://sourceforge.net/projects/net-snmp/files/net-snmp/5.7.3/
md5 d4a3459e1577d0efa8d96ca70a885e53 net-snmp-5.7.3.tar.gz
sha1 97dc25077257680815de44e34128d365c76bd839 net-snmp-5.7.3.tar.gz
-
diff --git a/package/perl-netaddr-ip/Config.in b/package/perl-netaddr-ip/Config.in
index 152583008..d4061e1df 100644
--- a/package/perl-netaddr-ip/Config.in
+++ b/package/perl-netaddr-ip/Config.in
@@ -4,4 +4,3 @@ config BR2_PACKAGE_PERL_NETADDR_IP
Manages IPv4 and IPv6 addresses and subnets
https://metacpan.org/release/NetAddr-IP
-
diff --git a/package/ptpd2/Config.in b/package/ptpd2/Config.in
index e88a9bb1a..406276af3 100644
--- a/package/ptpd2/Config.in
+++ b/package/ptpd2/Config.in
@@ -6,4 +6,3 @@ config BR2_PACKAGE_PTPD2
(PTP) as defined by the IEEE-1588-2008.
https://github.com/ptpd/ptpd
-
diff --git a/package/python-cbor/Config.in b/package/python-cbor/Config.in
index 2d0962d59..403fab3f0 100644
--- a/package/python-cbor/Config.in
+++ b/package/python-cbor/Config.in
@@ -4,4 +4,3 @@ config BR2_PACKAGE_PYTHON_CBOR
RFC 7049 - Concise Binary Object Representation.
https://pypi.python.org/pypi/cbor
-
diff --git a/package/python-iniparse/python-iniparse.hash b/package/python-iniparse/python-iniparse.hash
index d7d8e9336..f1f803823 100644
--- a/package/python-iniparse/python-iniparse.hash
+++ b/package/python-iniparse/python-iniparse.hash
@@ -1,4 +1,3 @@
# md5 from https://pypi.python.org/pypi?:action=show_md5&digest=5e573e9e9733d97623881ce9bbe5eca6, sha256 locally computed
md5 5e573e9e9733d97623881ce9bbe5eca6 iniparse-0.4.tar.gz
sha256 abc1ee12d2cfb2506109072d6c21e40b6c75a3fe90a9c924327d80bc0d99c054 iniparse-0.4.tar.gz
-
diff --git a/package/python-lxml/Config.in.host b/package/python-lxml/Config.in.host
index 580e440e1..7bf1e4859 100644
--- a/package/python-lxml/Config.in.host
+++ b/package/python-lxml/Config.in.host
@@ -5,4 +5,3 @@ config BR2_PACKAGE_HOST_PYTHON_LXML
libxml2 and libxslt.
http://lxml.de/
-
diff --git a/package/python3/python3.hash b/package/python3/python3.hash
index 694b09be1..26d08dee4 100644
--- a/package/python3/python3.hash
+++ b/package/python3/python3.hash
@@ -2,4 +2,3 @@
md5 692b4fc3a2ba0d54d1495d4ead5b0b5c Python-3.6.1.tar.xz
# Locally computed
sha256 a01810ddfcec216bcdb357a84bfaafdfaa0ca42bbdaa4cb7ff74f5a9961e4041 Python-3.6.1.tar.xz
-
diff --git a/package/ts4900-fpga/Config.in b/package/ts4900-fpga/Config.in
index 7910631bc..77a73b5ae 100644
--- a/package/ts4900-fpga/Config.in
+++ b/package/ts4900-fpga/Config.in
@@ -9,4 +9,3 @@ config BR2_PACKAGE_TS4900_FPGA
script expects to find it in the /boot folder.
http://wiki.embeddedarm.com/wiki/TS-4900#FPGA_Changelog
-
diff --git a/package/x11r7/xdriver_xf86-video-imx-viv/xdriver_xf86-video-imx-viv.mk b/package/x11r7/xdriver_xf86-video-imx-viv/xdriver_xf86-video-imx-viv.mk
index 2a3e99745..b31d98fbf 100644
--- a/package/x11r7/xdriver_xf86-video-imx-viv/xdriver_xf86-video-imx-viv.mk
+++ b/package/x11r7/xdriver_xf86-video-imx-viv/xdriver_xf86-video-imx-viv.mk
@@ -33,4 +33,3 @@ define XDRIVER_XF86_VIDEO_IMX_VIV_INSTALL_TARGET_CMDS
endef
$(eval $(generic-package))
-
--
2.11.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH 03/11] package: remove consecutive empty lines
2017-04-04 22:50 [Buildroot] [PATCH 01/11] package: remove trailing whitespace Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 02/11] package: remove empty line at end of file Ricardo Martincoski
@ 2017-04-04 22:50 ` Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 04/11] package: normalize separator size to 80 Ricardo Martincoski
` (8 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Ricardo Martincoski @ 2017-04-04 22:50 UTC (permalink / raw)
To: buildroot
Occurrences were searched using [1]:
check-package --include-only ConsecutiveEmptyLines $(find * -type f)
and manually removed.
[1] http://patchwork.ozlabs.org/patch/729666/
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
package/amd-catalyst/amd-catalyst.mk | 2 --
package/bcusdk/bcusdk.mk | 1 -
package/dhcp/Config.in | 1 -
package/docker-engine/docker-engine.mk | 1 -
package/efl/Config.in | 1 -
package/ffmpeg/ffmpeg.mk | 1 -
package/gcc/gcc-final/gcc-final.mk | 1 -
package/glibc/glibc.mk | 1 -
package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 1 -
package/linux-zigbee/Config.in | 1 -
package/ltp-testsuite/ltp-testsuite.mk | 1 -
package/ne10/ne10.mk | 1 -
package/network-manager/network-manager.mk | 1 -
package/opencv3/Config.in | 1 -
package/openocd/openocd.mk | 1 -
package/oracle-mysql/oracle-mysql.mk | 1 -
package/qt/qt.mk | 2 --
package/qt5/qt5location/qt5location.mk | 1 -
package/qt5/qt5quickcontrols/qt5quickcontrols.mk | 1 -
package/rpcbind/rpcbind.mk | 1 -
package/rrdtool/rrdtool.mk | 1 -
package/rt-tests/Config.in | 1 -
package/x11vnc/x11vnc.mk | 1 -
23 files changed, 25 deletions(-)
diff --git a/package/amd-catalyst/amd-catalyst.mk b/package/amd-catalyst/amd-catalyst.mk
index 5636f81c9..d4f5d1cc3 100644
--- a/package/amd-catalyst/amd-catalyst.mk
+++ b/package/amd-catalyst/amd-catalyst.mk
@@ -16,7 +16,6 @@ AMD_CATALYST_SUFFIX = $(if $(BR2_x86_64),_64)
AMD_CATALYST_ARCH_DIR = $(@D)/arch/x86$(AMD_CATALYST_SUFFIX)
AMD_CATALYST_LIB_SUFFIX = $(if $(BR2_x86_64),64)
-
define AMD_CATALYST_EXTRACT_CMDS
unzip -q $(DL_DIR)/$(AMD_CATALYST_SOURCE) -d $(@D)
$(SHELL) $(@D)/AMD-Catalyst-$(AMD_CATALYST_VERSION)-Linux-installer-$(AMD_CATALYST_VERBOSE_VER)-x86.x86_64.run --extract $(@D)
@@ -102,7 +101,6 @@ define AMD_CATALYST_INSTALL_XORG
$(INSTALL) -D -m 0644 package/amd-catalyst/20-fglrx.conf \
$(TARGET_DIR)/etc/X11/xorg.conf.d/20-fglrx.conf
-
# Common files: containing binary profiles about GPUs,
# required by the fglrx_drv xorg driver
$(INSTALL) -d $(TARGET_DIR)/etc/ati
diff --git a/package/bcusdk/bcusdk.mk b/package/bcusdk/bcusdk.mk
index 12f41eac8..f99dd70cb 100644
--- a/package/bcusdk/bcusdk.mk
+++ b/package/bcusdk/bcusdk.mk
@@ -24,7 +24,6 @@ BCUSDK_DEPENDENCIES = \
libpthsem \
$(if $(BR2_PACKAGE_ARGP_STANDALONE),argp-standalone)
-
define BCUSDK_REMOVE_EXAMPLES
$(RM) -rf $(TARGET_DIR)/usr/share/bcusdk
endef
diff --git a/package/dhcp/Config.in b/package/dhcp/Config.in
index 4a3049584..d09256aad 100644
--- a/package/dhcp/Config.in
+++ b/package/dhcp/Config.in
@@ -26,7 +26,6 @@ config BR2_PACKAGE_DHCP_RELAY
help
DHCP relay agent from the ISC DHCP distribution.
-
config BR2_PACKAGE_DHCP_CLIENT
bool "dhcp client"
help
diff --git a/package/docker-engine/docker-engine.mk b/package/docker-engine/docker-engine.mk
index 5ff595e64..db2653a3d 100644
--- a/package/docker-engine/docker-engine.mk
+++ b/package/docker-engine/docker-engine.mk
@@ -34,7 +34,6 @@ DOCKER_ENGINE_GLDFLAGS_DOCKER += -extldflags '-static'
endif
endif
-
DOCKER_ENGINE_BUILD_TAGS = cgo exclude_graphdriver_zfs autogen
DOCKER_ENGINE_BUILD_TARGETS = docker
diff --git a/package/efl/Config.in b/package/efl/Config.in
index 960f2752c..b9c4334c2 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -135,7 +135,6 @@ config BR2_PACKAGE_EFL_HAS_RECOMMENDED_CONFIG
BR2_PACKAGE_EFL_PULSEAUDIO && \
BR2_PACKAGE_EFL_UTIL_LINUX_LIBMOUNT
-
comment "Warning: one of the recommended option for EFL is not enabled"
depends on !BR2_PACKAGE_EFL_HAS_RECOMMENDED_CONFIG
diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk
index f1a1e0df8..348bc8212 100644
--- a/package/ffmpeg/ffmpeg.mk
+++ b/package/ffmpeg/ffmpeg.mk
@@ -473,7 +473,6 @@ else ifneq ($(call qstrip,$(BR2_GCC_TARGET_ARCH)),)
FFMPEG_CONF_OPTS += --cpu=$(BR2_GCC_TARGET_ARCH)
endif
-
FFMPEG_CONF_OPTS += $(call qstrip,$(BR2_PACKAGE_FFMPEG_EXTRACONF))
# Override FFMPEG_CONFIGURE_CMDS: FFmpeg does not support --target and others
diff --git a/package/gcc/gcc-final/gcc-final.mk b/package/gcc/gcc-final/gcc-final.mk
index a15d837a8..e8d2e18fe 100644
--- a/package/gcc/gcc-final/gcc-final.mk
+++ b/package/gcc/gcc-final/gcc-final.mk
@@ -50,7 +50,6 @@ define HOST_GCC_FINAL_CONFIGURE_CMDS
)
endef
-
# Languages supported by the cross-compiler
GCC_FINAL_CROSS_LANGUAGES-y = c
GCC_FINAL_CROSS_LANGUAGES-$(BR2_INSTALL_LIBSTDCPP) += c++
diff --git a/package/glibc/glibc.mk b/package/glibc/glibc.mk
index 58cb3d46c..58ffa6cb8 100644
--- a/package/glibc/glibc.mk
+++ b/package/glibc/glibc.mk
@@ -94,7 +94,6 @@ define GLIBC_CONFIGURE_CMDS
$(GLIBC_ADD_MISSING_STUB_H)
endef
-
#
# We also override the install to target commands since we only want
# to install the libraries, and nothing more.
diff --git a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
index 69bb7163f..6bf159d2e 100644
--- a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
+++ b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
@@ -24,7 +24,6 @@ GST1_PLUGINS_GOOD_CONF_OPTS = \
--disable-esd \
--disable-esdtest
-
# Options which require currently unpackaged libraries
GST1_PLUGINS_GOOD_CONF_OPTS += \
--disable-jack \
diff --git a/package/linux-zigbee/Config.in b/package/linux-zigbee/Config.in
index fc21faa44..ff2b0f7c9 100644
--- a/package/linux-zigbee/Config.in
+++ b/package/linux-zigbee/Config.in
@@ -40,7 +40,6 @@ config BR2_PACKAGE_LINUX_ZIGBEE_TESTS
Enable this option to install the Linux-ZigBee test programs
to the target.
-
config BR2_PACKAGE_LINUX_ZIGBEE_OLD_KERNEL_COMPAT
bool "compatibility with older kernels"
help
diff --git a/package/ltp-testsuite/ltp-testsuite.mk b/package/ltp-testsuite/ltp-testsuite.mk
index cd9a34528..7f26bd2a5 100644
--- a/package/ltp-testsuite/ltp-testsuite.mk
+++ b/package/ltp-testsuite/ltp-testsuite.mk
@@ -68,5 +68,4 @@ endef
LTP_TESTSUITE_POST_PATCH_HOOKS += LTP_TESTSUITE_REMOVE_UNSUPPORTED
endif
-
$(eval $(autotools-package))
diff --git a/package/ne10/ne10.mk b/package/ne10/ne10.mk
index 63a79e75f..cb303bd7b 100644
--- a/package/ne10/ne10.mk
+++ b/package/ne10/ne10.mk
@@ -32,7 +32,6 @@ define NE10_INSTALL_STAGING_CMDS
$(NE10_INSTALL_STAGING_SHARED_LIB)
endef
-
define NE10_INSTALL_TARGET_CMDS
cp -dpf $(@D)/modules/libNE10*.so* $(TARGET_DIR)/usr/lib/
endef
diff --git a/package/network-manager/network-manager.mk b/package/network-manager/network-manager.mk
index 0815bdd6a..6adc9b1ab 100644
--- a/package/network-manager/network-manager.mk
+++ b/package/network-manager/network-manager.mk
@@ -22,7 +22,6 @@ NETWORK_MANAGER_CONF_ENV = \
ac_cv_file__etc_redhat_release=no \
ac_cv_file__etc_SuSE_release=no
-
NETWORK_MANAGER_CONF_OPTS = \
--disable-tests \
--disable-qt \
diff --git a/package/opencv3/Config.in b/package/opencv3/Config.in
index 4c00bf1b9..ee589f950 100644
--- a/package/opencv3/Config.in
+++ b/package/opencv3/Config.in
@@ -130,7 +130,6 @@ comment "opengl support needs an OpenGL provider"
endif # BR2_PACKAGE_OPENCV3_LIB_HIGHGUI
-
config BR2_PACKAGE_OPENCV3_LIB_IMGCODECS
bool "imgcodecs"
select BR2_PACKAGE_OPENCV3_LIB_IMGPROC
diff --git a/package/openocd/openocd.mk b/package/openocd/openocd.mk
index 8407bbcbd..911d31168 100644
--- a/package/openocd/openocd.mk
+++ b/package/openocd/openocd.mk
@@ -113,6 +113,5 @@ endef
OPENOCD_POST_BUILD_HOOKS += OPENOCD_FIX_VERSION_TEXI
HOST_OPENOCD_POST_BUILD_HOOKS += OPENOCD_FIX_VERSION_TEXI
-
$(eval $(autotools-package))
$(eval $(host-autotools-package))
diff --git a/package/oracle-mysql/oracle-mysql.mk b/package/oracle-mysql/oracle-mysql.mk
index 45a71fac6..4307008d4 100644
--- a/package/oracle-mysql/oracle-mysql.mk
+++ b/package/oracle-mysql/oracle-mysql.mk
@@ -125,7 +125,6 @@ ORACLE_MYSQL_CONF_OPTS += \
--without-server
endif
-
define ORACLE_MYSQL_REMOVE_TEST_PROGS
rm -rf $(TARGET_DIR)/usr/mysql-test $(TARGET_DIR)/usr/sql-bench
endef
diff --git a/package/qt/qt.mk b/package/qt/qt.mk
index 1fdb1bf70..2580ee7c0 100644
--- a/package/qt/qt.mk
+++ b/package/qt/qt.mk
@@ -79,7 +79,6 @@ else
QT_CONFIGURE_OPTS += -no-glib
endif
-
### Pixel depths
QT_PIXEL_DEPTHS = # empty
ifeq ($(BR2_PACKAGE_QT_PIXEL_DEPTH_1),y)
@@ -547,7 +546,6 @@ define QT_BUILD_CMDS
$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
endef
-
# Build the list of libraries and plugins to install to the target
QT_INSTALL_LIBS += QtCore
diff --git a/package/qt5/qt5location/qt5location.mk b/package/qt5/qt5location/qt5location.mk
index 24b26b2db..96263e89b 100644
--- a/package/qt5/qt5location/qt5location.mk
+++ b/package/qt5/qt5location/qt5location.mk
@@ -62,5 +62,4 @@ define QT5LOCATION_INSTALL_TARGET_CMDS
$(QT5LOCATION_INSTALL_TARGET_QMLS)
endef
-
$(eval $(generic-package))
diff --git a/package/qt5/qt5quickcontrols/qt5quickcontrols.mk b/package/qt5/qt5quickcontrols/qt5quickcontrols.mk
index 0f11b79ca..d28993244 100644
--- a/package/qt5/qt5quickcontrols/qt5quickcontrols.mk
+++ b/package/qt5/qt5quickcontrols/qt5quickcontrols.mk
@@ -30,7 +30,6 @@ define QT5QUICKCONTROLS_INSTALL_STAGING_CMDS
$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) install
endef
-
ifeq ($(BR2_PACKAGE_QT5DECLARATIVE_QUICK)$(BR2_PACKAGE_QT5BASE_WIDGETS),yy)
define QT5QUICKCONTROLS_INSTALL_TARGET_PRIVATEWIDGETS
cp -dpfr $(STAGING_DIR)/usr/qml/QtQuick/PrivateWidgets $(TARGET_DIR)/usr/qml/QtQuick
diff --git a/package/rpcbind/rpcbind.mk b/package/rpcbind/rpcbind.mk
index 28deb50ef..cf2e81dbb 100644
--- a/package/rpcbind/rpcbind.mk
+++ b/package/rpcbind/rpcbind.mk
@@ -36,5 +36,4 @@ define RPCBIND_INSTALL_INIT_SYSV
$(TARGET_DIR)/etc/init.d/S30rpcbind
endef
-
$(eval $(autotools-package))
diff --git a/package/rrdtool/rrdtool.mk b/package/rrdtool/rrdtool.mk
index 84c7bb7ac..028b7cbbb 100644
--- a/package/rrdtool/rrdtool.mk
+++ b/package/rrdtool/rrdtool.mk
@@ -25,7 +25,6 @@ RRDTOOL_CONF_OPTS = \
--disable-ruby \
--disable-tcl
-
ifeq ($(BR2_NEEDS_GETTEXT),y)
RRDTOOL_DEPENDENCIES += gettext
endif
diff --git a/package/rt-tests/Config.in b/package/rt-tests/Config.in
index b39856d34..23e911b9f 100644
--- a/package/rt-tests/Config.in
+++ b/package/rt-tests/Config.in
@@ -23,7 +23,6 @@ config BR2_PACKAGE_RT_TESTS
http://rt.wiki.kernel.org
-
comment "rt-tests may not work on MIPS with an external uClibc toolchain"
depends on BR2_PACKAGE_RT_TESTS
depends on BR2_TOOLCHAIN_EXTERNAL_UCLIBC
diff --git a/package/x11vnc/x11vnc.mk b/package/x11vnc/x11vnc.mk
index 561d7bf13..9f4af1258 100644
--- a/package/x11vnc/x11vnc.mk
+++ b/package/x11vnc/x11vnc.mk
@@ -61,5 +61,4 @@ else
X11VNC_CONF_OPTS += --without-zlib
endif
-
$(eval $(autotools-package))
--
2.11.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH 04/11] package: normalize separator size to 80
2017-04-04 22:50 [Buildroot] [PATCH 01/11] package: remove trailing whitespace Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 02/11] package: remove empty line at end of file Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 03/11] package: remove consecutive empty lines Ricardo Martincoski
@ 2017-04-04 22:50 ` Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 05/11] package: add missing empty line after header Ricardo Martincoski
` (7 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Ricardo Martincoski @ 2017-04-04 22:50 UTC (permalink / raw)
To: buildroot
Occurrences were searched using [1]:
check-package --include-only PackageHeader $(find * -type f)
and manually fixed to comply to [2].
[1] http://patchwork.ozlabs.org/patch/729669/
[2] http://nightly.buildroot.org/#writing-rules-mk
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
package/cxxtest/cxxtest.mk | 4 ++--
package/fwup/fwup.mk | 4 ++--
package/python-docutils/python-docutils.mk | 4 ++--
package/python-simpleaudio/python-simpleaudio.mk | 4 ++--
package/rabbitmq-server/rabbitmq-server.mk | 4 ++--
package/trousers/trousers.mk | 4 ++--
package/udpxy/udpxy.mk | 2 +-
7 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/package/cxxtest/cxxtest.mk b/package/cxxtest/cxxtest.mk
index 4ea9adf6a..7d494c8f1 100644
--- a/package/cxxtest/cxxtest.mk
+++ b/package/cxxtest/cxxtest.mk
@@ -1,8 +1,8 @@
-#######################################################################################
+################################################################################
#
# cxxtest
#
-#######################################################################################
+################################################################################
CXXTEST_VERSION = 4.4
CXXTEST_SITE = https://github.com/CxxTest/cxxtest/releases/download/$(CXXTEST_VERSION)
diff --git a/package/fwup/fwup.mk b/package/fwup/fwup.mk
index d87bdca96..0c2b0f919 100644
--- a/package/fwup/fwup.mk
+++ b/package/fwup/fwup.mk
@@ -1,8 +1,8 @@
-#############################################################
+################################################################################
#
# fwup
#
-#############################################################
+################################################################################
FWUP_VERSION = v0.8.2
FWUP_SITE = $(call github,fhunleth,fwup,$(FWUP_VERSION))
diff --git a/package/python-docutils/python-docutils.mk b/package/python-docutils/python-docutils.mk
index a42b34b0e..1ce259bd1 100644
--- a/package/python-docutils/python-docutils.mk
+++ b/package/python-docutils/python-docutils.mk
@@ -1,8 +1,8 @@
-#############################################################
+################################################################################
#
# python-docutils
#
-#############################################################
+################################################################################
PYTHON_DOCUTILS_VERSION = 0.13.1
PYTHON_DOCUTILS_SOURCE = docutils-$(PYTHON_DOCUTILS_VERSION).tar.gz
diff --git a/package/python-simpleaudio/python-simpleaudio.mk b/package/python-simpleaudio/python-simpleaudio.mk
index b9562ee6b..24ec067da 100644
--- a/package/python-simpleaudio/python-simpleaudio.mk
+++ b/package/python-simpleaudio/python-simpleaudio.mk
@@ -1,8 +1,8 @@
-#############################################################
+################################################################################
#
# python-simpleaudio
#
-#############################################################
+################################################################################
PYTHON_SIMPLEAUDIO_VERSION = 1.0.1
PYTHON_SIMPLEAUDIO_SOURCE = simpleaudio-$(PYTHON_SIMPLEAUDIO_VERSION).tar.gz
diff --git a/package/rabbitmq-server/rabbitmq-server.mk b/package/rabbitmq-server/rabbitmq-server.mk
index f4671ae3c..6df770793 100644
--- a/package/rabbitmq-server/rabbitmq-server.mk
+++ b/package/rabbitmq-server/rabbitmq-server.mk
@@ -1,8 +1,8 @@
-#############################################################
+################################################################################
#
# rabbitmq-server
#
-#############################################################
+################################################################################
RABBITMQ_SERVER_VERSION = 3.6.6
RABBITMQ_SERVER_SITE = http://www.rabbitmq.com/releases/rabbitmq-server/v$(RABBITMQ_SERVER_VERSION)
diff --git a/package/trousers/trousers.mk b/package/trousers/trousers.mk
index e6d564a88..e49c2ac14 100644
--- a/package/trousers/trousers.mk
+++ b/package/trousers/trousers.mk
@@ -1,8 +1,8 @@
-#############################################################
+################################################################################
#
# trousers
#
-##############################################################
+################################################################################
TROUSERS_VERSION = 0.3.13
TROUSERS_SITE = http://downloads.sourceforge.net/project/trousers/trousers/$(TROUSERS_VERSION)
diff --git a/package/udpxy/udpxy.mk b/package/udpxy/udpxy.mk
index 36b9afd10..22467948a 100644
--- a/package/udpxy/udpxy.mk
+++ b/package/udpxy/udpxy.mk
@@ -2,7 +2,7 @@
#
# udpxy
#
-#################################################################################
+################################################################################
UDPXY_VERSION = 1.0.23-9-prod
UDPXY_SOURCE = udpxy.$(UDPXY_VERSION).tar.gz
--
2.11.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH 05/11] package: add missing empty line after header
2017-04-04 22:50 [Buildroot] [PATCH 01/11] package: remove trailing whitespace Ricardo Martincoski
` (2 preceding siblings ...)
2017-04-04 22:50 ` [Buildroot] [PATCH 04/11] package: normalize separator size to 80 Ricardo Martincoski
@ 2017-04-04 22:50 ` Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 06/11] package: remove trailing backslash Ricardo Martincoski
` (6 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Ricardo Martincoski @ 2017-04-04 22:50 UTC (permalink / raw)
To: buildroot
Occurrences were searched using [1]:
check-package --include-only PackageHeader $(find * -type f)
and manually fixed to comply to [2].
[1] http://patchwork.ozlabs.org/patch/729669/
[2] http://nightly.buildroot.org/#writing-rules-mk
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
package/grantlee/grantlee.mk | 1 +
package/lesstif/lesstif.mk | 1 +
2 files changed, 2 insertions(+)
diff --git a/package/grantlee/grantlee.mk b/package/grantlee/grantlee.mk
index 812603b82..575b63fef 100644
--- a/package/grantlee/grantlee.mk
+++ b/package/grantlee/grantlee.mk
@@ -3,6 +3,7 @@
# grantlee
#
################################################################################
+
GRANTLEE_VERSION = 5.1.0
GRANTLEE_SITE = http://downloads.grantlee.org
GRANTLEE_INSTALL_STAGING = YES
diff --git a/package/lesstif/lesstif.mk b/package/lesstif/lesstif.mk
index 3d381fff8..933dd1337 100644
--- a/package/lesstif/lesstif.mk
+++ b/package/lesstif/lesstif.mk
@@ -3,6 +3,7 @@
# lesstif
#
################################################################################
+
LESSTIF_VERSION = 0.95.2
LESSTIF_SOURCE = lesstif-$(LESSTIF_VERSION).tar.bz2
LESSTIF_SITE = http://downloads.sourceforge.net/project/lesstif/lesstif/$(LESSTIF_VERSION)
--
2.11.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH 06/11] package: remove trailing backslash
2017-04-04 22:50 [Buildroot] [PATCH 01/11] package: remove trailing whitespace Ricardo Martincoski
` (3 preceding siblings ...)
2017-04-04 22:50 ` [Buildroot] [PATCH 05/11] package: add missing empty line after header Ricardo Martincoski
@ 2017-04-04 22:50 ` Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 07/11] python-pylibftdi: check hash Ricardo Martincoski
` (5 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Ricardo Martincoski @ 2017-04-04 22:50 UTC (permalink / raw)
To: buildroot
Occurrences were searched using [1]:
check-package --include-only TrailingBackslash $(find * -type f)
and manually removed.
[1] http://patchwork.ozlabs.org/patch/729669/
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
package/cegui06/cegui06.mk | 4 ++--
package/celt051/celt051.mk | 2 +-
package/flannel/flannel.mk | 2 +-
package/hostapd/hostapd.mk | 2 +-
package/jimtcl/jimtcl.mk | 2 +-
package/libnice/libnice.mk | 2 +-
package/nvidia-driver/nvidia-driver.mk | 10 +++++-----
package/parted/parted.mk | 2 +-
package/redis/redis.mk | 2 +-
package/spice/spice.mk | 4 ++--
package/tiff/tiff.mk | 2 +-
package/uclibc/uclibc.mk | 2 +-
package/vlc/vlc.mk | 2 +-
13 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/package/cegui06/cegui06.mk b/package/cegui06/cegui06.mk
index 43d3b09dd..8b2c886c7 100644
--- a/package/cegui06/cegui06.mk
+++ b/package/cegui06/cegui06.mk
@@ -16,7 +16,7 @@ CEGUI06_INSTALL_STAGING = YES
CEGUI06_DEPENDENCIES = \
expat \
freetype \
- pcre \
+ pcre
CEGUI06_CONF_OPTS = \
--enable-expat \
@@ -31,6 +31,6 @@ CEGUI06_CONF_OPTS = \
--disable-samples \
--disable-lua-module \
--disable-toluacegui \
- --disable-external-toluapp \
+ --disable-external-toluapp
$(eval $(autotools-package))
diff --git a/package/celt051/celt051.mk b/package/celt051/celt051.mk
index 6074c4939..a5b6f47a0 100644
--- a/package/celt051/celt051.mk
+++ b/package/celt051/celt051.mk
@@ -25,6 +25,6 @@ CELT051_CONF_OPTS = \
--disable-static-modes \
--disable-assertions \
--disable-oggtest \
- --with-ogg=$(STAGING_DIR)/usr \
+ --with-ogg=$(STAGING_DIR)/usr
$(eval $(autotools-package))
diff --git a/package/flannel/flannel.mk b/package/flannel/flannel.mk
index 18c0af160..8393c5992 100644
--- a/package/flannel/flannel.mk
+++ b/package/flannel/flannel.mk
@@ -20,7 +20,7 @@ FLANNEL_MAKE_ENV = \
CGO_ENABLED=1
FLANNEL_GLDFLAGS = \
- -X github.com/coreos/flannel/version.Version=$(FLANNEL_VERSION) \
+ -X github.com/coreos/flannel/version.Version=$(FLANNEL_VERSION)
ifeq ($(BR2_STATIC_LIBS),y)
FLANNEL_GLDFLAGS += -extldflags '-static'
diff --git a/package/hostapd/hostapd.mk b/package/hostapd/hostapd.mk
index cf651f8d1..dc28d1323 100644
--- a/package/hostapd/hostapd.mk
+++ b/package/hostapd/hostapd.mk
@@ -51,7 +51,7 @@ endif
ifeq ($(BR2_PACKAGE_HOSTAPD_EAP),y)
HOSTAPD_CONFIG_ENABLE += \
CONFIG_EAP \
- CONFIG_RADIUS_SERVER \
+ CONFIG_RADIUS_SERVER
# Enable both TLS v1.1 (CONFIG_TLSV11) and v1.2 (CONFIG_TLSV12)
HOSTAPD_CONFIG_ENABLE += CONFIG_TLSV1
diff --git a/package/jimtcl/jimtcl.mk b/package/jimtcl/jimtcl.mk
index 78517c4f4..cdbf8ae47 100644
--- a/package/jimtcl/jimtcl.mk
+++ b/package/jimtcl/jimtcl.mk
@@ -17,7 +17,7 @@ JIMTCL_HEADERS_TO_INSTALL = \
jim-signal.h \
jim-subcmd.h \
jim-win32compat.h \
- jim-config.h \
+ jim-config.h
ifeq ($(BR2_PACKAGE_TCL),)
define JIMTCL_LINK_TCLSH
diff --git a/package/libnice/libnice.mk b/package/libnice/libnice.mk
index 5ec2b6151..6afcb7635 100644
--- a/package/libnice/libnice.mk
+++ b/package/libnice/libnice.mk
@@ -14,6 +14,6 @@ LIBNICE_INSTALL_STAGING = YES
LIBNICE_AUTORECONF = YES
LIBNICE_CONF_OPTS = \
--without-gstreamer \
- --without-gstreamer-0.10 \
+ --without-gstreamer-0.10
$(eval $(autotools-package))
diff --git a/package/nvidia-driver/nvidia-driver.mk b/package/nvidia-driver/nvidia-driver.mk
index cb9b7faec..0d0311001 100644
--- a/package/nvidia-driver/nvidia-driver.mk
+++ b/package/nvidia-driver/nvidia-driver.mk
@@ -43,18 +43,18 @@ NVIDIA_DRIVER_PROVIDES = libgl libegl libgles
NVIDIA_DRIVER_LIBS_GL = \
libGLX.so.0 \
libGL.so.$(NVIDIA_DRIVER_VERSION) \
- libGLX_nvidia.so.$(NVIDIA_DRIVER_VERSION) \
+ libGLX_nvidia.so.$(NVIDIA_DRIVER_VERSION)
NVIDIA_DRIVER_LIBS_EGL = \
libEGL.so.1 \
libGLdispatch.so.0 \
- libEGL_nvidia.so.$(NVIDIA_DRIVER_VERSION) \
+ libEGL_nvidia.so.$(NVIDIA_DRIVER_VERSION)
NVIDIA_DRIVER_LIBS_GLES = \
libGLESv1_CM.so.1 \
libGLESv2.so.2 \
libGLESv1_CM_nvidia.so.$(NVIDIA_DRIVER_VERSION) \
- libGLESv2_nvidia.so.$(NVIDIA_DRIVER_VERSION) \
+ libGLESv2_nvidia.so.$(NVIDIA_DRIVER_VERSION)
NVIDIA_DRIVER_LIBS_MISC = \
libnvidia-eglcore.so.$(NVIDIA_DRIVER_VERSION) \
@@ -63,13 +63,13 @@ NVIDIA_DRIVER_LIBS_MISC = \
libnvidia-glsi.so.$(NVIDIA_DRIVER_VERSION) \
tls/libnvidia-tls.so.$(NVIDIA_DRIVER_VERSION) \
libvdpau_nvidia.so.$(NVIDIA_DRIVER_VERSION) \
- libnvidia-ml.so.$(NVIDIA_DRIVER_VERSION) \
+ libnvidia-ml.so.$(NVIDIA_DRIVER_VERSION)
NVIDIA_DRIVER_LIBS = \
$(NVIDIA_DRIVER_LIBS_GL) \
$(NVIDIA_DRIVER_LIBS_EGL) \
$(NVIDIA_DRIVER_LIBS_GLES) \
- $(NVIDIA_DRIVER_LIBS_MISC) \
+ $(NVIDIA_DRIVER_LIBS_MISC)
# Install the gl.pc file
define NVIDIA_DRIVER_INSTALL_GL_DEV
diff --git a/package/parted/parted.mk b/package/parted/parted.mk
index f88143bc2..fb4987fd5 100644
--- a/package/parted/parted.mk
+++ b/package/parted/parted.mk
@@ -36,7 +36,7 @@ endif
HOST_PARTED_DEPENDENCIES = host-pkgconf host-util-linux
HOST_PARTED_CONF_OPTS += \
--without-readline \
- --disable-device-mapper \
+ --disable-device-mapper
$(eval $(autotools-package))
$(eval $(host-autotools-package))
diff --git a/package/redis/redis.mk b/package/redis/redis.mk
index 679862093..3f4956cf3 100644
--- a/package/redis/redis.mk
+++ b/package/redis/redis.mk
@@ -23,7 +23,7 @@ endif
# instead.
REDIS_BUILDOPTS = $(TARGET_CONFIGURE_OPTS) \
LDFLAGS="$(TARGET_LDFLAGS) $(REDIS_LIBATOMIC)" \
- PREFIX=$(TARGET_DIR)/usr MALLOC=libc \
+ PREFIX=$(TARGET_DIR)/usr MALLOC=libc
define REDIS_BUILD_CMDS
$(TARGET_MAKE_ENV) $(MAKE) $(REDIS_BUILDOPTS) -C $(@D)
diff --git a/package/spice/spice.mk b/package/spice/spice.mk
index 047453848..086f5d6bb 100644
--- a/package/spice/spice.mk
+++ b/package/spice/spice.mk
@@ -18,7 +18,7 @@ SPICE_DEPENDENCIES = \
openssl \
pixman \
python-pyparsing \
- spice-protocol \
+ spice-protocol
# We disable everything for now, because the dependency tree can become
# quite deep if we try to enable some features, and I have not tested that.
@@ -26,7 +26,7 @@ SPICE_CONF_OPTS = \
--disable-opengl \
--disable-smartcard \
--disable-automated-tests \
- --without-sasl \
+ --without-sasl
SPICE_DEPENDENCIES += host-pkgconf
diff --git a/package/tiff/tiff.mk b/package/tiff/tiff.mk
index ffb1a425c..e5b01db88 100644
--- a/package/tiff/tiff.mk
+++ b/package/tiff/tiff.mk
@@ -11,7 +11,7 @@ TIFF_LICENSE_FILES = COPYRIGHT
TIFF_INSTALL_STAGING = YES
TIFF_CONF_OPTS = \
--disable-cxx \
- --without-x \
+ --without-x
TIFF_DEPENDENCIES = host-pkgconf
diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk
index b1e611293..44c23a788 100644
--- a/package/uclibc/uclibc.mk
+++ b/package/uclibc/uclibc.mk
@@ -35,7 +35,7 @@ UCLIBC_KCONFIG_OPTS = \
$(UCLIBC_MAKE_FLAGS) \
PREFIX=$(STAGING_DIR) \
DEVEL_PREFIX=/usr/ \
- RUNTIME_PREFIX=$(STAGING_DIR)/ \
+ RUNTIME_PREFIX=$(STAGING_DIR)/
UCLIBC_TARGET_ARCH = $(call qstrip,$(BR2_UCLIBC_TARGET_ARCH))
diff --git a/package/vlc/vlc.mk b/package/vlc/vlc.mk
index 6fc77348f..36b5fd3ea 100644
--- a/package/vlc/vlc.mk
+++ b/package/vlc/vlc.mk
@@ -61,7 +61,7 @@ VLC_CONF_OPTS += \
--disable-mfx \
--disable-vdpau \
--disable-addonmanagermodules \
- --enable-run-as-root \
+ --enable-run-as-root
# Uses __atomic_fetch_add_4
ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
--
2.11.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH 07/11] python-pylibftdi: check hash
2017-04-04 22:50 [Buildroot] [PATCH 01/11] package: remove trailing whitespace Ricardo Martincoski
` (4 preceding siblings ...)
2017-04-04 22:50 ` [Buildroot] [PATCH 06/11] package: remove trailing backslash Ricardo Martincoski
@ 2017-04-04 22:50 ` Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 08/11] python-pylibftdi: use package name for .mk file Ricardo Martincoski
` (4 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Ricardo Martincoski @ 2017-04-04 22:50 UTC (permalink / raw)
To: buildroot
Currently the hash is not checked, returning this message:
WARNING: no hash file for pylibftdi-0.15.0.tar.gz
Rename the .hash file to use the package name.
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
From get-developers:
Cc: Christian Kellermann <christian.kellermann@solectrix.de>
Cc: Yegor Yefremov <yegorslists@googlemail.com>
---
package/python-pylibftdi/{python-libftdi.hash => python-pylibftdi.hash} | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename package/python-pylibftdi/{python-libftdi.hash => python-pylibftdi.hash} (100%)
diff --git a/package/python-pylibftdi/python-libftdi.hash b/package/python-pylibftdi/python-pylibftdi.hash
similarity index 100%
rename from package/python-pylibftdi/python-libftdi.hash
rename to package/python-pylibftdi/python-pylibftdi.hash
--
2.11.0
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH 08/11] python-pylibftdi: use package name for .mk file
2017-04-04 22:50 [Buildroot] [PATCH 01/11] package: remove trailing whitespace Ricardo Martincoski
` (5 preceding siblings ...)
2017-04-04 22:50 ` [Buildroot] [PATCH 07/11] python-pylibftdi: check hash Ricardo Martincoski
@ 2017-04-04 22:50 ` Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 09/11] tesseract-ocr: fix typo in variable name Ricardo Martincoski
` (3 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Ricardo Martincoski @ 2017-04-04 22:50 UTC (permalink / raw)
To: buildroot
Found using [1]:
check-package --include-only TypoInPackageVariable $(find * -type f)
and manually fixed.
[1] http://patchwork.ozlabs.org/patch/729672/
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
From get-developers:
Cc: Christian Kellermann <christian.kellermann@solectrix.de>
Cc: Yegor Yefremov <yegorslists@googlemail.com>
---
package/python-pylibftdi/{python-libftdi.mk => python-pylibftdi.mk} | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
rename package/python-pylibftdi/{python-libftdi.mk => python-pylibftdi.mk} (96%)
diff --git a/package/python-pylibftdi/python-libftdi.mk b/package/python-pylibftdi/python-pylibftdi.mk
similarity index 96%
rename from package/python-pylibftdi/python-libftdi.mk
rename to package/python-pylibftdi/python-pylibftdi.mk
index b375abb4e..0a5887b2e 100644
--- a/package/python-pylibftdi/python-libftdi.mk
+++ b/package/python-pylibftdi/python-pylibftdi.mk
@@ -1,6 +1,6 @@
################################################################################
#
-# python-libftdi
+# python-pylibftdi
#
################################################################################
--
2.11.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH 09/11] tesseract-ocr: fix typo in variable name
2017-04-04 22:50 [Buildroot] [PATCH 01/11] package: remove trailing whitespace Ricardo Martincoski
` (6 preceding siblings ...)
2017-04-04 22:50 ` [Buildroot] [PATCH 08/11] python-pylibftdi: use package name for .mk file Ricardo Martincoski
@ 2017-04-04 22:50 ` Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 10/11] gst1-plugins-base: remove legacy freetype handling Ricardo Martincoski
` (2 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Ricardo Martincoski @ 2017-04-04 22:50 UTC (permalink / raw)
To: buildroot
TESSERACT_OCF_CONF_OPTS
^
Found using [1]:
check-package --include-only TypoInPackageVariable $(find * -type f)
and manually fixed.
[1] http://patchwork.ozlabs.org/patch/729672/
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
From get-developers:
Cc: Gilles Talis <gilles.talis@gmail.com>
build-tested using:
$ echo BR2_PACKAGE_TESSERACT_OCR=y > tesseract-ocr.config
$ test-pkg -c tesseract-ocr.config -d /tmp/pkg/ -p tesseract-ocr
49 builds, 10 skipped, 0 failed
---
package/tesseract-ocr/tesseract-ocr.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/tesseract-ocr/tesseract-ocr.mk b/package/tesseract-ocr/tesseract-ocr.mk
index 76ca930d8..9e315b239 100644
--- a/package/tesseract-ocr/tesseract-ocr.mk
+++ b/package/tesseract-ocr/tesseract-ocr.mk
@@ -20,7 +20,7 @@ TESSERACT_OCR_DEPENDENCIES = leptonica host-pkgconf
TESSERACT_OCR_INSTALL_STAGING = YES
TESSERACT_OCR_CONF_ENV = \
LIBLEPT_HEADERSDIR=$(STAGING_DIR)/usr/include/leptonica
-TESSERACT_OCF_CONF_OPTS = \
+TESSERACT_OCR_CONF_OPTS = \
--disable-opencl
# Language data files download
--
2.11.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH 10/11] gst1-plugins-base: remove legacy freetype handling
2017-04-04 22:50 [Buildroot] [PATCH 01/11] package: remove trailing whitespace Ricardo Martincoski
` (7 preceding siblings ...)
2017-04-04 22:50 ` [Buildroot] [PATCH 09/11] tesseract-ocr: fix typo in variable name Ricardo Martincoski
@ 2017-04-04 22:50 ` Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 11/11] gst-plugins-base: fix handling of freetype Ricardo Martincoski
2017-04-06 20:45 ` [Buildroot] [PATCH 01/11] package: remove trailing whitespace Thomas Petazzoni
10 siblings, 0 replies; 17+ messages in thread
From: Ricardo Martincoski @ 2017-04-04 22:50 UTC (permalink / raw)
To: buildroot
In 2010 commit 32d319e6f "gst-plugins-base: ensure <stdint.h> is used"
introduced a typo (missing backslash) that made the code ineffective.
In 2013 commit f8e7fdcd3 "gst1-plugins-base: add gstreamer1 base
plugins" copied the code.
It can be confirmed by looking at the output of:
$ make printvars | grep '^GST1_PLUGINS_BASE_CONF_ENV\|^FT2_CONFIG'
FT2_CONFIG=/bin/false ac_cv_header_stdint_t="stdint.h"
GST1_PLUGINS_BASE_CONF_ENV=
Direct use of freetype was dropped in version 1.7.2 by upstream [1], so
remove the code instead of fixing it.
Found using [2]:
check-package --include-only Indent $(find * -type f)
and manually removed.
[1] https://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=183610c035dd6955c9b3540b940aec50474af031
[2] http://patchwork.ozlabs.org/patch/729669/
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
From get-developers:
Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk | 7 -------
1 file changed, 7 deletions(-)
diff --git a/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk b/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk
index 8da1f4220..08f53f75c 100644
--- a/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk
+++ b/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk
@@ -11,13 +11,6 @@ GST1_PLUGINS_BASE_INSTALL_STAGING = YES
GST1_PLUGINS_BASE_LICENSE_FILES = COPYING.LIB
GST1_PLUGINS_BASE_LICENSE = LGPL-2.0+, LGPL-2.1+
-# freetype is only used by examples, but if it is not found
-# and the host has a freetype-config script, then the host
-# include dirs are added to the search path causing trouble
-GST1_PLUGINS_BASE_CONF_ENV =
- FT2_CONFIG=/bin/false \
- ac_cv_header_stdint_t="stdint.h"
-
# gio_unix_2_0 is only used for tests
GST1_PLUGINS_BASE_CONF_OPTS = \
--disable-examples \
--
2.11.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH 11/11] gst-plugins-base: fix handling of freetype
2017-04-04 22:50 [Buildroot] [PATCH 01/11] package: remove trailing whitespace Ricardo Martincoski
` (8 preceding siblings ...)
2017-04-04 22:50 ` [Buildroot] [PATCH 10/11] gst1-plugins-base: remove legacy freetype handling Ricardo Martincoski
@ 2017-04-04 22:50 ` Ricardo Martincoski
2017-04-06 20:46 ` Thomas Petazzoni
2017-04-06 20:45 ` [Buildroot] [PATCH 01/11] package: remove trailing whitespace Thomas Petazzoni
10 siblings, 1 reply; 17+ messages in thread
From: Ricardo Martincoski @ 2017-04-04 22:50 UTC (permalink / raw)
To: buildroot
In 2010 commit 32d319e6f "gst-plugins-base: ensure <stdint.h> is used"
introduced a typo (missing backslash) that made the code ineffective.
It can be confirmed by looking at the output of:
$ make printvars | grep '^GST_PLUGINS_BASE_CONF_ENV\|^FT2_CONFIG'
FT2_CONFIG=/bin/false ac_cv_header_stdint_t="stdint.h"
GST_PLUGINS_BASE_CONF_ENV=
Add the missing backslash to fix the code.
While at it, fix the indentation to use one tab instead of two.
The (end of the) diff of config.log confirms the code is still needed
when the host has freetype-config installed:
1704c1702
< configure:22348: result: make use of stdint.h in _stdint.h (assuming C99 compatible system)
---
> configure:22348: result: make use of stdint.h in _stdint.h
2499,2500c2497
< configure:31316: found /usr/bin/freetype-config
< configure:31329: result: /usr/bin/freetype-config
---
> configure:31329: result: /bin/false
2820c2817
< ac_cv_path_FT2_CONFIG='/usr/bin/freetype-config'
---
> ac_cv_path_FT2_CONFIG='/bin/false'
2849d2845
< ac_cv_stdint_result='(assuming C99 compatible system)'
2996,2998c2992,2994
< FT2_CFLAGS='-I/usr/include/freetype2'
< FT2_CONFIG='/usr/bin/freetype-config'
< FT2_LIBS='-lfreetype'
---
> FT2_CFLAGS=''
> FT2_CONFIG='/bin/false'
> FT2_LIBS=''
Found using [1]:
check-package --include-only Indent $(find * -type f)
and manually fixed.
[1] http://patchwork.ozlabs.org/patch/729669/
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
From get-developers:
---
package/gstreamer/gst-plugins-base/gst-plugins-base.mk | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/gstreamer/gst-plugins-base/gst-plugins-base.mk b/package/gstreamer/gst-plugins-base/gst-plugins-base.mk
index fc3b2036a..735314365 100644
--- a/package/gstreamer/gst-plugins-base/gst-plugins-base.mk
+++ b/package/gstreamer/gst-plugins-base/gst-plugins-base.mk
@@ -14,9 +14,9 @@ GST_PLUGINS_BASE_LICENSE_FILES = COPYING COPYING.LIB
# freetype is only used by examples, but if it is not found
# and the host has a freetype-config script, then the host
# include dirs are added to the search path causing trouble
-GST_PLUGINS_BASE_CONF_ENV =
- FT2_CONFIG=/bin/false \
- ac_cv_header_stdint_t="stdint.h"
+GST_PLUGINS_BASE_CONF_ENV = \
+ FT2_CONFIG=/bin/false \
+ ac_cv_header_stdint_t="stdint.h"
GST_PLUGINS_BASE_CONF_OPTS = \
--disable-examples \
--
2.11.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH 01/11] package: remove trailing whitespace
2017-04-04 22:50 [Buildroot] [PATCH 01/11] package: remove trailing whitespace Ricardo Martincoski
` (9 preceding siblings ...)
2017-04-04 22:50 ` [Buildroot] [PATCH 11/11] gst-plugins-base: fix handling of freetype Ricardo Martincoski
@ 2017-04-06 20:45 ` Thomas Petazzoni
10 siblings, 0 replies; 17+ messages in thread
From: Thomas Petazzoni @ 2017-04-06 20:45 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 4 Apr 2017 19:50:09 -0300, Ricardo Martincoski wrote:
> Occurrences were searched using [1]:
> check-package --include-only TrailingSpace $(find * -type f)
> and manually removed.
>
> [1] http://patchwork.ozlabs.org/patch/729666/
>
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> ---
> build-tested with:
> $ echo BR2_GOOGLE_BREAKPAD_ENABLE=y > host-google-breakpad.config
> $ support/scripts/test-pkg -c host-google-breakpad.config \
> -d /home/builds/test-pkg -p host-google-breakpad
> 49 builds, 29 skipped, 0 failed
> ---
> package/google-breakpad/google-breakpad.mk | 2 +-
> package/leafnode2/leafnode2.mk | 2 +-
> package/mbedtls/Config.in | 2 +-
> package/protobuf/Config.in | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
I've applied patches 1 to 10, but left patch 11 unapplied for now. I'll
reply to patch 11 to explain why.
Thanks a lot for doing this great cleanup series, much appreciated!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH 11/11] gst-plugins-base: fix handling of freetype
2017-04-04 22:50 ` [Buildroot] [PATCH 11/11] gst-plugins-base: fix handling of freetype Ricardo Martincoski
@ 2017-04-06 20:46 ` Thomas Petazzoni
2017-04-11 22:59 ` [Buildroot] [PATCH v2] " Ricardo Martincoski
0 siblings, 1 reply; 17+ messages in thread
From: Thomas Petazzoni @ 2017-04-06 20:46 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 4 Apr 2017 19:50:19 -0300, Ricardo Martincoski wrote:
> In 2010 commit 32d319e6f "gst-plugins-base: ensure <stdint.h> is used"
> introduced a typo (missing backslash) that made the code ineffective.
>
> It can be confirmed by looking at the output of:
> $ make printvars | grep '^GST_PLUGINS_BASE_CONF_ENV\|^FT2_CONFIG'
> FT2_CONFIG=/bin/false ac_cv_header_stdint_t="stdint.h"
> GST_PLUGINS_BASE_CONF_ENV=
>
> Add the missing backslash to fix the code.
> While at it, fix the indentation to use one tab instead of two.
>
> The (end of the) diff of config.log confirms the code is still needed
> when the host has freetype-config installed:
> 1704c1702
> < configure:22348: result: make use of stdint.h in _stdint.h (assuming C99 compatible system)
> ---
> > configure:22348: result: make use of stdint.h in _stdint.h
> 2499,2500c2497
> < configure:31316: found /usr/bin/freetype-config
> < configure:31329: result: /usr/bin/freetype-config
> ---
> > configure:31329: result: /bin/false
> 2820c2817
> < ac_cv_path_FT2_CONFIG='/usr/bin/freetype-config'
> ---
> > ac_cv_path_FT2_CONFIG='/bin/false'
> 2849d2845
> < ac_cv_stdint_result='(assuming C99 compatible system)'
> 2996,2998c2992,2994
> < FT2_CFLAGS='-I/usr/include/freetype2'
> < FT2_CONFIG='/usr/bin/freetype-config'
> < FT2_LIBS='-lfreetype'
> ---
> > FT2_CFLAGS=''
> > FT2_CONFIG='/bin/false'
> > FT2_LIBS=''
The patch looks good, but this diff format is really unreadable. Could
you regenerate it with "diff -u" so that it becomes readable?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v2] gst-plugins-base: fix handling of freetype
2017-04-06 20:46 ` Thomas Petazzoni
@ 2017-04-11 22:59 ` Ricardo Martincoski
2017-04-12 12:41 ` Arnout Vandecappelle
` (2 more replies)
0 siblings, 3 replies; 17+ messages in thread
From: Ricardo Martincoski @ 2017-04-11 22:59 UTC (permalink / raw)
To: buildroot
In 2010 commit 32d319e6f "gst-plugins-base: ensure <stdint.h> is used"
introduced a typo (missing backslash) that made the code ineffective.
It can be confirmed by looking at the output of:
$ make printvars | grep '^GST_PLUGINS_BASE_CONF_ENV\|^FT2_CONFIG'
FT2_CONFIG=/bin/false ac_cv_header_stdint_t="stdint.h"
GST_PLUGINS_BASE_CONF_ENV=
Add the missing backslash to fix the code.
While at it, fix the indentation to use one tab instead of two.
The (end of the) diff of config.log confirms the code is still needed
when the host has freetype-config installed:
@@ -1674,10 +1674,8 @@
configure:21882: checking for emmintrin.h
configure:21882: result: no
configure:21894: checking for stdint types
-configure:21917: /tmp/gst/output/host/usr/bin/i686-pc-linux-gnu-gcc -std=gnu99 -c conftest.c >&5
-configure:21917: $? = 0
configure:21961: result: stdint.h (shortcircuit)
-configure:22348: result: make use of stdint.h in _stdint.h (assuming C99 compatible system)
+configure:22348: result: make use of stdint.h in _stdint.h
configure:22359: checking for localtime_r
configure:22359: /tmp/gst/output/host/usr/bin/i686-pc-linux-gnu-gcc -std=gnu99 -o conftest -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 conftest.c >&5
configure:22359: $? = 0
@@ -2468,8 +2466,7 @@
Package 'freetype2', required by 'world', not found
configure:31257: result: no
configure:31298: checking for freetype-config
-configure:31316: found /usr/bin/freetype-config
-configure:31329: result: /usr/bin/freetype-config
+configure:31329: result: /bin/false
configure:31339: checking for FreeType - version >= 2.0.9
configure:31427: result: yes
configure:32250: creating ./config.status
@@ -2789,7 +2786,7 @@
ac_cv_objext='o'
ac_cv_path_EGREP='/bin/grep -E'
ac_cv_path_FGREP='/bin/grep -F'
-ac_cv_path_FT2_CONFIG='/usr/bin/freetype-config'
+ac_cv_path_FT2_CONFIG='/bin/false'
ac_cv_path_GMSGFMT='/tmp/gst/output/host/usr/bin/msgfmt'
ac_cv_path_GREP='/bin/grep'
ac_cv_path_MSGFMT='/tmp/gst/output/host/usr/bin/msgfmt'
@@ -2818,7 +2815,6 @@
ac_cv_prog_cxx_g='yes'
ac_cv_prog_make_make_set='yes'
ac_cv_stdint_message='using gnu compiler i686-pc-linux-gnu-gcc (Sourcery CodeBench Lite 2012.09-62) 4.7.2'
-ac_cv_stdint_result='(assuming C99 compatible system)'
ac_cv_sys_file_offset_bits='no'
ac_cv_sys_largefile_CC='no'
ac_cv_sys_largefile_source='no'
@@ -2965,9 +2961,9 @@
EXEEXT=''
FFLAGS=' -Os '
FGREP='/bin/grep -F'
-FT2_CFLAGS='-I/usr/include/freetype2'
-FT2_CONFIG='/usr/bin/freetype-config'
-FT2_LIBS='-lfreetype'
+FT2_CFLAGS=''
+FT2_CONFIG='/bin/false'
+FT2_LIBS=''
GCOV=''
GCOV_CFLAGS=''
GCOV_LIBS=''
Detected by check-package.
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
Changes v1 -> v2:
- make the diff in commit message readable using 'diff -u' (Thomas);
- check-package is now merged, so remove URL from commit message;
Thomas,
I was unsure what to do with the long lines, so I pasted the raw
output. Please feel free to ask me to respin or to tweak the message
yourself. Below is the link [1] to the config.log files.
[1] https://gist.github.com/ricardo-martincoski/d9c27b7f589b35313f676357fc1037ac/archive/12363aac7be1adf9e62c2c20aa1aeefc18212dbb.zip
Regards,
Ricardo
---
package/gstreamer/gst-plugins-base/gst-plugins-base.mk | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/gstreamer/gst-plugins-base/gst-plugins-base.mk b/package/gstreamer/gst-plugins-base/gst-plugins-base.mk
index fc3b2036a..735314365 100644
--- a/package/gstreamer/gst-plugins-base/gst-plugins-base.mk
+++ b/package/gstreamer/gst-plugins-base/gst-plugins-base.mk
@@ -14,9 +14,9 @@ GST_PLUGINS_BASE_LICENSE_FILES = COPYING COPYING.LIB
# freetype is only used by examples, but if it is not found
# and the host has a freetype-config script, then the host
# include dirs are added to the search path causing trouble
-GST_PLUGINS_BASE_CONF_ENV =
- FT2_CONFIG=/bin/false \
- ac_cv_header_stdint_t="stdint.h"
+GST_PLUGINS_BASE_CONF_ENV = \
+ FT2_CONFIG=/bin/false \
+ ac_cv_header_stdint_t="stdint.h"
GST_PLUGINS_BASE_CONF_OPTS = \
--disable-examples \
--
2.11.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v2] gst-plugins-base: fix handling of freetype
2017-04-11 22:59 ` [Buildroot] [PATCH v2] " Ricardo Martincoski
@ 2017-04-12 12:41 ` Arnout Vandecappelle
2017-04-12 19:06 ` Thomas Petazzoni
2017-04-24 19:20 ` Peter Korsgaard
2 siblings, 0 replies; 17+ messages in thread
From: Arnout Vandecappelle @ 2017-04-12 12:41 UTC (permalink / raw)
To: buildroot
On 12-04-17 00:59, Ricardo Martincoski wrote:
> In 2010 commit 32d319e6f "gst-plugins-base: ensure <stdint.h> is used"
> introduced a typo (missing backslash) that made the code ineffective.
>
> It can be confirmed by looking at the output of:
> $ make printvars | grep '^GST_PLUGINS_BASE_CONF_ENV\|^FT2_CONFIG'
> FT2_CONFIG=/bin/false ac_cv_header_stdint_t="stdint.h"
> GST_PLUGINS_BASE_CONF_ENV=
>
> Add the missing backslash to fix the code.
> While at it, fix the indentation to use one tab instead of two.
>
> The (end of the) diff of config.log confirms the code is still needed
> when the host has freetype-config installed:
[snip]
> @@ -2818,7 +2815,6 @@
> ac_cv_prog_cxx_g='yes'
> ac_cv_prog_make_make_set='yes'
> ac_cv_stdint_message='using gnu compiler i686-pc-linux-gnu-gcc (Sourcery CodeBench Lite 2012.09-62) 4.7.2'
> -ac_cv_stdint_result='(assuming C99 compatible system)'
Apparently the ac_cv_header_stdint_t assigment wasn't really needed then,
because it hasn't changed. But OK, that's for a separate patch.
> ac_cv_sys_file_offset_bits='no'
> ac_cv_sys_largefile_CC='no'
> ac_cv_sys_largefile_source='no'
> @@ -2965,9 +2961,9 @@
> EXEEXT=''
> FFLAGS=' -Os '
> FGREP='/bin/grep -F'
> -FT2_CFLAGS='-I/usr/include/freetype2'
> -FT2_CONFIG='/usr/bin/freetype-config'
> -FT2_LIBS='-lfreetype'
> +FT2_CFLAGS=''
> +FT2_CONFIG='/bin/false'
> +FT2_LIBS=''
> GCOV=''
> GCOV_CFLAGS=''
> GCOV_LIBS=''
>
> Detected by check-package.
>
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
[snip]
> diff --git a/package/gstreamer/gst-plugins-base/gst-plugins-base.mk b/package/gstreamer/gst-plugins-base/gst-plugins-base.mk
> index fc3b2036a..735314365 100644
> --- a/package/gstreamer/gst-plugins-base/gst-plugins-base.mk
> +++ b/package/gstreamer/gst-plugins-base/gst-plugins-base.mk
> @@ -14,9 +14,9 @@ GST_PLUGINS_BASE_LICENSE_FILES = COPYING COPYING.LIB
> # freetype is only used by examples, but if it is not found
> # and the host has a freetype-config script, then the host
> # include dirs are added to the search path causing trouble
Note that the autobuilders don't catch this because they don't have
freetype-config installed...
Regards,
Arnout
> -GST_PLUGINS_BASE_CONF_ENV =
> - FT2_CONFIG=/bin/false \
> - ac_cv_header_stdint_t="stdint.h"
> +GST_PLUGINS_BASE_CONF_ENV = \
> + FT2_CONFIG=/bin/false \
> + ac_cv_header_stdint_t="stdint.h"
>
> GST_PLUGINS_BASE_CONF_OPTS = \
> --disable-examples \
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v2] gst-plugins-base: fix handling of freetype
2017-04-11 22:59 ` [Buildroot] [PATCH v2] " Ricardo Martincoski
2017-04-12 12:41 ` Arnout Vandecappelle
@ 2017-04-12 19:06 ` Thomas Petazzoni
2017-04-24 19:20 ` Peter Korsgaard
2 siblings, 0 replies; 17+ messages in thread
From: Thomas Petazzoni @ 2017-04-12 19:06 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 11 Apr 2017 19:59:13 -0300, Ricardo Martincoski wrote:
> In 2010 commit 32d319e6f "gst-plugins-base: ensure <stdint.h> is used"
> introduced a typo (missing backslash) that made the code ineffective.
>
> It can be confirmed by looking at the output of:
> $ make printvars | grep '^GST_PLUGINS_BASE_CONF_ENV\|^FT2_CONFIG'
> FT2_CONFIG=/bin/false ac_cv_header_stdint_t="stdint.h"
> GST_PLUGINS_BASE_CONF_ENV=
>
> Add the missing backslash to fix the code.
> While at it, fix the indentation to use one tab instead of two.
>
> The (end of the) diff of config.log confirms the code is still needed
> when the host has freetype-config installed:
> @@ -1674,10 +1674,8 @@
> configure:21882: checking for emmintrin.h
> configure:21882: result: no
> configure:21894: checking for stdint types
> -configure:21917: /tmp/gst/output/host/usr/bin/i686-pc-linux-gnu-gcc -std=gnu99 -c conftest.c >&5
> -configure:21917: $? = 0
> configure:21961: result: stdint.h (shortcircuit)
> -configure:22348: result: make use of stdint.h in _stdint.h (assuming C99 compatible system)
> +configure:22348: result: make use of stdint.h in _stdint.h
> configure:22359: checking for localtime_r
> configure:22359: /tmp/gst/output/host/usr/bin/i686-pc-linux-gnu-gcc -std=gnu99 -o conftest -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 conftest.c >&5
> configure:22359: $? = 0
> @@ -2468,8 +2466,7 @@
> Package 'freetype2', required by 'world', not found
> configure:31257: result: no
> configure:31298: checking for freetype-config
> -configure:31316: found /usr/bin/freetype-config
> -configure:31329: result: /usr/bin/freetype-config
> +configure:31329: result: /bin/false
> configure:31339: checking for FreeType - version >= 2.0.9
> configure:31427: result: yes
> configure:32250: creating ./config.status
> @@ -2789,7 +2786,7 @@
> ac_cv_objext='o'
> ac_cv_path_EGREP='/bin/grep -E'
> ac_cv_path_FGREP='/bin/grep -F'
> -ac_cv_path_FT2_CONFIG='/usr/bin/freetype-config'
> +ac_cv_path_FT2_CONFIG='/bin/false'
> ac_cv_path_GMSGFMT='/tmp/gst/output/host/usr/bin/msgfmt'
> ac_cv_path_GREP='/bin/grep'
> ac_cv_path_MSGFMT='/tmp/gst/output/host/usr/bin/msgfmt'
> @@ -2818,7 +2815,6 @@
> ac_cv_prog_cxx_g='yes'
> ac_cv_prog_make_make_set='yes'
> ac_cv_stdint_message='using gnu compiler i686-pc-linux-gnu-gcc (Sourcery CodeBench Lite 2012.09-62) 4.7.2'
> -ac_cv_stdint_result='(assuming C99 compatible system)'
> ac_cv_sys_file_offset_bits='no'
> ac_cv_sys_largefile_CC='no'
> ac_cv_sys_largefile_source='no'
> @@ -2965,9 +2961,9 @@
> EXEEXT=''
> FFLAGS=' -Os '
> FGREP='/bin/grep -F'
> -FT2_CFLAGS='-I/usr/include/freetype2'
> -FT2_CONFIG='/usr/bin/freetype-config'
> -FT2_LIBS='-lfreetype'
> +FT2_CFLAGS=''
> +FT2_CONFIG='/bin/false'
> +FT2_LIBS=''
> GCOV=''
> GCOV_CFLAGS=''
> GCOV_LIBS=''
>
> Detected by check-package.
>
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> Changes v1 -> v2:
> - make the diff in commit message readable using 'diff -u' (Thomas);
> - check-package is now merged, so remove URL from commit message;
Applied to master, thanks.
Peter: I guess we probably want this one in the LTS branch as well.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH v2] gst-plugins-base: fix handling of freetype
2017-04-11 22:59 ` [Buildroot] [PATCH v2] " Ricardo Martincoski
2017-04-12 12:41 ` Arnout Vandecappelle
2017-04-12 19:06 ` Thomas Petazzoni
@ 2017-04-24 19:20 ` Peter Korsgaard
2 siblings, 0 replies; 17+ messages in thread
From: Peter Korsgaard @ 2017-04-24 19:20 UTC (permalink / raw)
To: buildroot
>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:
> In 2010 commit 32d319e6f "gst-plugins-base: ensure <stdint.h> is used"
> introduced a typo (missing backslash) that made the code ineffective.
> It can be confirmed by looking at the output of:
> $ make printvars | grep '^GST_PLUGINS_BASE_CONF_ENV\|^FT2_CONFIG'
> FT2_CONFIG=/bin/false ac_cv_header_stdint_t="stdint.h"
> GST_PLUGINS_BASE_CONF_ENV=
> Add the missing backslash to fix the code.
> While at it, fix the indentation to use one tab instead of two.
> The (end of the) diff of config.log confirms the code is still needed
> when the host has freetype-config installed:
> @@ -1674,10 +1674,8 @@
> configure:21882: checking for emmintrin.h
> configure:21882: result: no
> configure:21894: checking for stdint types
> -configure:21917: /tmp/gst/output/host/usr/bin/i686-pc-linux-gnu-gcc -std=gnu99 -c conftest.c >&5
> -configure:21917: $? = 0
> configure:21961: result: stdint.h (shortcircuit)
> -configure:22348: result: make use of stdint.h in _stdint.h (assuming C99 compatible system)
> +configure:22348: result: make use of stdint.h in _stdint.h
> configure:22359: checking for localtime_r
> configure:22359: /tmp/gst/output/host/usr/bin/i686-pc-linux-gnu-gcc -std=gnu99 -o conftest -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 conftest.c >&5
> configure:22359: $? = 0
> @@ -2468,8 +2466,7 @@
> Package 'freetype2', required by 'world', not found
> configure:31257: result: no
> configure:31298: checking for freetype-config
> -configure:31316: found /usr/bin/freetype-config
> -configure:31329: result: /usr/bin/freetype-config
> +configure:31329: result: /bin/false
> configure:31339: checking for FreeType - version >= 2.0.9
> configure:31427: result: yes
> configure:32250: creating ./config.status
> @@ -2789,7 +2786,7 @@
> ac_cv_objext='o'
> ac_cv_path_EGREP='/bin/grep -E'
> ac_cv_path_FGREP='/bin/grep -F'
> -ac_cv_path_FT2_CONFIG='/usr/bin/freetype-config'
> +ac_cv_path_FT2_CONFIG='/bin/false'
> ac_cv_path_GMSGFMT='/tmp/gst/output/host/usr/bin/msgfmt'
> ac_cv_path_GREP='/bin/grep'
> ac_cv_path_MSGFMT='/tmp/gst/output/host/usr/bin/msgfmt'
> @@ -2818,7 +2815,6 @@
> ac_cv_prog_cxx_g='yes'
> ac_cv_prog_make_make_set='yes'
> ac_cv_stdint_message='using gnu compiler i686-pc-linux-gnu-gcc (Sourcery CodeBench Lite 2012.09-62) 4.7.2'
> -ac_cv_stdint_result='(assuming C99 compatible system)'
> ac_cv_sys_file_offset_bits='no'
> ac_cv_sys_largefile_CC='no'
> ac_cv_sys_largefile_source='no'
> @@ -2965,9 +2961,9 @@
> EXEEXT=''
> FFLAGS=' -Os '
> FGREP='/bin/grep -F'
> -FT2_CFLAGS='-I/usr/include/freetype2'
> -FT2_CONFIG='/usr/bin/freetype-config'
> -FT2_LIBS='-lfreetype'
> +FT2_CFLAGS=''
> +FT2_CONFIG='/bin/false'
> +FT2_LIBS=''
> GCOV=''
> GCOV_CFLAGS=''
> GCOV_LIBS=''
> Detected by check-package.
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> Changes v1 -> v2:
> - make the diff in commit message readable using 'diff -u' (Thomas);
> - check-package is now merged, so remove URL from commit message;
> Thomas,
> I was unsure what to do with the long lines, so I pasted the raw
> output. Please feel free to ask me to respin or to tweak the message
> yourself. Below is the link [1] to the config.log files.
> [1] https://gist.github.com/ricardo-martincoski/d9c27b7f589b35313f676357fc1037ac/archive/12363aac7be1adf9e62c2c20aa1aeefc18212dbb.zip
Committed to 2017.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2017-04-24 19:20 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-04 22:50 [Buildroot] [PATCH 01/11] package: remove trailing whitespace Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 02/11] package: remove empty line at end of file Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 03/11] package: remove consecutive empty lines Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 04/11] package: normalize separator size to 80 Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 05/11] package: add missing empty line after header Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 06/11] package: remove trailing backslash Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 07/11] python-pylibftdi: check hash Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 08/11] python-pylibftdi: use package name for .mk file Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 09/11] tesseract-ocr: fix typo in variable name Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 10/11] gst1-plugins-base: remove legacy freetype handling Ricardo Martincoski
2017-04-04 22:50 ` [Buildroot] [PATCH 11/11] gst-plugins-base: fix handling of freetype Ricardo Martincoski
2017-04-06 20:46 ` Thomas Petazzoni
2017-04-11 22:59 ` [Buildroot] [PATCH v2] " Ricardo Martincoski
2017-04-12 12:41 ` Arnout Vandecappelle
2017-04-12 19:06 ` Thomas Petazzoni
2017-04-24 19:20 ` Peter Korsgaard
2017-04-06 20:45 ` [Buildroot] [PATCH 01/11] package: remove trailing whitespace Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.