* [PATCH] nvme/pci: Don't set reserved SQ create flags
@ 2017-04-04 22:18 Keith Busch
2017-04-05 6:11 ` Christoph Hellwig
2017-04-05 8:07 ` Sagi Grimberg
0 siblings, 2 replies; 3+ messages in thread
From: Keith Busch @ 2017-04-04 22:18 UTC (permalink / raw)
The QPRIO field is only valid if weighted round robin arbitration is used,
and this driver doesn't enable that controller configuration option.
Signed-off-by: Keith Busch <keith.busch at intel.com>
---
drivers/nvme/host/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 26a5fd0..4eb0815 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -812,7 +812,7 @@ static int adapter_alloc_sq(struct nvme_dev *dev, u16 qid,
struct nvme_queue *nvmeq)
{
struct nvme_command c;
- int flags = NVME_QUEUE_PHYS_CONTIG | NVME_SQ_PRIO_MEDIUM;
+ int flags = NVME_QUEUE_PHYS_CONTIG;
/*
* Note: we (ab)use the fact the the prp fields survive if no data
--
2.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] nvme/pci: Don't set reserved SQ create flags
2017-04-04 22:18 [PATCH] nvme/pci: Don't set reserved SQ create flags Keith Busch
@ 2017-04-05 6:11 ` Christoph Hellwig
2017-04-05 8:07 ` Sagi Grimberg
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2017-04-05 6:11 UTC (permalink / raw)
Oops..
Looks good:
Reviewed-by: Christoph Hellwig <hch at lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] nvme/pci: Don't set reserved SQ create flags
2017-04-04 22:18 [PATCH] nvme/pci: Don't set reserved SQ create flags Keith Busch
2017-04-05 6:11 ` Christoph Hellwig
@ 2017-04-05 8:07 ` Sagi Grimberg
1 sibling, 0 replies; 3+ messages in thread
From: Sagi Grimberg @ 2017-04-05 8:07 UTC (permalink / raw)
Looks good,
Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-05 8:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-04 22:18 [PATCH] nvme/pci: Don't set reserved SQ create flags Keith Busch
2017-04-05 6:11 ` Christoph Hellwig
2017-04-05 8:07 ` Sagi Grimberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.