All of lore.kernel.org
 help / color / mirror / Atom feed
From: Punit Agrawal <punit.agrawal@arm.com>
To: catalin.marinas@arm.com, will.deacon@arm.com,
	akpm@linux-foundation.org, mark.rutland@arm.com
Cc: Punit Agrawal <punit.agrawal@arm.com>,
	linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, tbaicar@codeaurora.org,
	kirill.shutemov@linux.intel.com, mike.kravetz@oracle.com,
	hillf.zj@alibaba-inc.com, steve.capper@arm.com,
	David Woods <dwoods@mellanox.com>
Subject: [PATCH v2 4/9] arm64: hugetlb: Override huge_pte_clear() to support contiguous hugepages
Date: Wed,  5 Apr 2017 14:37:17 +0100	[thread overview]
Message-ID: <20170405133722.6406-5-punit.agrawal@arm.com> (raw)
In-Reply-To: <20170405133722.6406-1-punit.agrawal@arm.com>

The default huge_pte_clear() implementation does not clear contiguous
page table entries when it encounters contiguous hugepages that are
supported on arm64.

Fix this by overriding the default implementation to clear all the
entries associated with contiguous hugepages.

Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
Cc: David Woods <dwoods@mellanox.com>
---
 arch/arm64/mm/hugetlbpage.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c
index 009648c4500f..53bda26c6e8f 100644
--- a/arch/arm64/mm/hugetlbpage.c
+++ b/arch/arm64/mm/hugetlbpage.c
@@ -243,6 +243,22 @@ pte_t arch_make_huge_pte(pte_t entry, struct vm_area_struct *vma,
 	return entry;
 }
 
+void huge_pte_clear(struct mm_struct *mm, unsigned long addr,
+		    pte_t *ptep, unsigned long sz)
+{
+	int ncontig, i;
+	size_t pgsize;
+
+	if (sz == PUD_SIZE || sz == PMD_SIZE) {
+		pte_clear(mm, addr, ptep);
+		return;
+	}
+
+	ncontig = find_num_contig(mm, addr, ptep, &pgsize);
+	for (i = 0; i < ncontig; i++, addr += pgsize, ptep++)
+		pte_clear(mm, addr, ptep);
+}
+
 pte_t huge_ptep_get_and_clear(struct mm_struct *mm,
 			      unsigned long addr, pte_t *ptep)
 {
-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: Punit Agrawal <punit.agrawal@arm.com>
To: catalin.marinas@arm.com, will.deacon@arm.com,
	akpm@linux-foundation.org, mark.rutland@arm.com
Cc: Punit Agrawal <punit.agrawal@arm.com>,
	linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, tbaicar@codeaurora.org,
	kirill.shutemov@linux.intel.com, mike.kravetz@oracle.com,
	hillf.zj@alibaba-inc.com, steve.capper@arm.com,
	David Woods <dwoods@mellanox.com>
Subject: [PATCH v2 4/9] arm64: hugetlb: Override huge_pte_clear() to support contiguous hugepages
Date: Wed,  5 Apr 2017 14:37:17 +0100	[thread overview]
Message-ID: <20170405133722.6406-5-punit.agrawal@arm.com> (raw)
In-Reply-To: <20170405133722.6406-1-punit.agrawal@arm.com>

The default huge_pte_clear() implementation does not clear contiguous
page table entries when it encounters contiguous hugepages that are
supported on arm64.

Fix this by overriding the default implementation to clear all the
entries associated with contiguous hugepages.

Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
Cc: David Woods <dwoods@mellanox.com>
---
 arch/arm64/mm/hugetlbpage.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c
index 009648c4500f..53bda26c6e8f 100644
--- a/arch/arm64/mm/hugetlbpage.c
+++ b/arch/arm64/mm/hugetlbpage.c
@@ -243,6 +243,22 @@ pte_t arch_make_huge_pte(pte_t entry, struct vm_area_struct *vma,
 	return entry;
 }
 
+void huge_pte_clear(struct mm_struct *mm, unsigned long addr,
+		    pte_t *ptep, unsigned long sz)
+{
+	int ncontig, i;
+	size_t pgsize;
+
+	if (sz == PUD_SIZE || sz == PMD_SIZE) {
+		pte_clear(mm, addr, ptep);
+		return;
+	}
+
+	ncontig = find_num_contig(mm, addr, ptep, &pgsize);
+	for (i = 0; i < ncontig; i++, addr += pgsize, ptep++)
+		pte_clear(mm, addr, ptep);
+}
+
 pte_t huge_ptep_get_and_clear(struct mm_struct *mm,
 			      unsigned long addr, pte_t *ptep)
 {
-- 
2.11.0

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: punit.agrawal@arm.com (Punit Agrawal)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/9] arm64: hugetlb: Override huge_pte_clear() to support contiguous hugepages
Date: Wed,  5 Apr 2017 14:37:17 +0100	[thread overview]
Message-ID: <20170405133722.6406-5-punit.agrawal@arm.com> (raw)
In-Reply-To: <20170405133722.6406-1-punit.agrawal@arm.com>

The default huge_pte_clear() implementation does not clear contiguous
page table entries when it encounters contiguous hugepages that are
supported on arm64.

Fix this by overriding the default implementation to clear all the
entries associated with contiguous hugepages.

Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
Cc: David Woods <dwoods@mellanox.com>
---
 arch/arm64/mm/hugetlbpage.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c
index 009648c4500f..53bda26c6e8f 100644
--- a/arch/arm64/mm/hugetlbpage.c
+++ b/arch/arm64/mm/hugetlbpage.c
@@ -243,6 +243,22 @@ pte_t arch_make_huge_pte(pte_t entry, struct vm_area_struct *vma,
 	return entry;
 }
 
+void huge_pte_clear(struct mm_struct *mm, unsigned long addr,
+		    pte_t *ptep, unsigned long sz)
+{
+	int ncontig, i;
+	size_t pgsize;
+
+	if (sz == PUD_SIZE || sz == PMD_SIZE) {
+		pte_clear(mm, addr, ptep);
+		return;
+	}
+
+	ncontig = find_num_contig(mm, addr, ptep, &pgsize);
+	for (i = 0; i < ncontig; i++, addr += pgsize, ptep++)
+		pte_clear(mm, addr, ptep);
+}
+
 pte_t huge_ptep_get_and_clear(struct mm_struct *mm,
 			      unsigned long addr, pte_t *ptep)
 {
-- 
2.11.0

  parent reply	other threads:[~2017-04-05 13:39 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05 13:37 [PATCH v2 0/9] Support swap entries for contiguous pte hugepages Punit Agrawal
2017-04-05 13:37 ` Punit Agrawal
2017-04-05 13:37 ` Punit Agrawal
2017-04-05 13:37 ` [PATCH v2 1/9] mm/hugetlb: add size parameter to huge_pte_offset() Punit Agrawal
2017-04-05 13:37   ` Punit Agrawal
2017-04-05 13:37   ` Punit Agrawal
2017-04-05 13:37 ` [PATCH v2 2/9] arm64: hugetlbpages: Support handling swap entries in huge_pte_offset() Punit Agrawal
2017-04-05 13:37   ` Punit Agrawal
2017-04-05 13:37   ` Punit Agrawal
2017-04-05 13:37 ` [PATCH v2 3/9] mm/hugetlb: Allow architectures to override huge_pte_clear() Punit Agrawal
2017-04-05 13:37   ` Punit Agrawal
2017-04-05 13:37   ` Punit Agrawal
2017-04-05 13:37 ` Punit Agrawal [this message]
2017-04-05 13:37   ` [PATCH v2 4/9] arm64: hugetlb: Override huge_pte_clear() to support contiguous hugepages Punit Agrawal
2017-04-05 13:37   ` Punit Agrawal
2017-04-06  5:37   ` kbuild test robot
2017-04-06  5:37     ` kbuild test robot
2017-04-06  5:37     ` kbuild test robot
2017-04-05 13:37 ` [PATCH v2 5/9] mm/hugetlb: Introduce set_huge_swap_pte_at() helper Punit Agrawal
2017-04-05 13:37   ` Punit Agrawal
2017-04-05 13:37   ` Punit Agrawal
2017-04-05 13:37 ` [PATCH v2 6/9] mm: rmap: Use correct helper when poisoning hugepages Punit Agrawal
2017-04-05 13:37   ` Punit Agrawal
2017-04-05 13:37   ` Punit Agrawal
2017-04-06  1:25   ` kbuild test robot
2017-04-06  1:25     ` kbuild test robot
2017-04-06  1:25     ` kbuild test robot
2017-04-05 13:37 ` [PATCH v2 7/9] arm64: hugetlb: Override set_huge_swap_pte_at() to support contiguous hugepages Punit Agrawal
2017-04-05 13:37   ` Punit Agrawal
2017-04-05 13:37   ` Punit Agrawal
2017-04-05 13:37 ` [PATCH v2 8/9] arm64: hwpoison: add VM_FAULT_HWPOISON[_LARGE] handling Punit Agrawal
2017-04-05 13:37   ` Punit Agrawal
2017-04-05 13:37   ` Punit Agrawal
2017-04-05 13:37 ` [PATCH v2 9/9] arm64: kconfig: allow support for memory failure handling Punit Agrawal
2017-04-05 13:37   ` Punit Agrawal
2017-04-05 13:37   ` Punit Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170405133722.6406-5-punit.agrawal@arm.com \
    --to=punit.agrawal@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=dwoods@mellanox.com \
    --cc=hillf.zj@alibaba-inc.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mark.rutland@arm.com \
    --cc=mike.kravetz@oracle.com \
    --cc=steve.capper@arm.com \
    --cc=tbaicar@codeaurora.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.