From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Keith Busch <keith.busch@intel.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/5] nvme: move ->retries setup to nvme_setup_cmd
Date: Wed, 5 Apr 2017 16:50:22 +0200 [thread overview]
Message-ID: <20170405145022.GA5521@lst.de> (raw)
In-Reply-To: <20170405144334.GO3941@linux-x5ow.site>
On Wed, Apr 05, 2017 at 04:43:34PM +0200, Johannes Thumshirn wrote:
> On Wed, Apr 05, 2017 at 04:18:52PM +0200, Christoph Hellwig wrote:
> > This way we get the behavior right for the non-PCIe transports.
>
> Could you please share a bit of your minds inner workings for us mere mortals?
It's initialized to zero the first time the command is submitted
and will then be incremented when queueing a retry.
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/5] nvme: move ->retries setup to nvme_setup_cmd
Date: Wed, 5 Apr 2017 16:50:22 +0200 [thread overview]
Message-ID: <20170405145022.GA5521@lst.de> (raw)
In-Reply-To: <20170405144334.GO3941@linux-x5ow.site>
On Wed, Apr 05, 2017@04:43:34PM +0200, Johannes Thumshirn wrote:
> On Wed, Apr 05, 2017@04:18:52PM +0200, Christoph Hellwig wrote:
> > This way we get the behavior right for the non-PCIe transports.
>
> Could you please share a bit of your minds inner workings for us mere mortals?
It's initialized to zero the first time the command is submitted
and will then be incremented when queueing a retry.
next prev parent reply other threads:[~2017-04-05 14:50 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 14:18 ->retries fixups Christoph Hellwig
2017-04-05 14:18 ` Christoph Hellwig
2017-04-05 14:18 ` [PATCH 1/5] nvme: move ->retries setup to nvme_setup_cmd Christoph Hellwig
2017-04-05 14:18 ` Christoph Hellwig
2017-04-05 14:43 ` Johannes Thumshirn
2017-04-05 14:43 ` Johannes Thumshirn
2017-04-05 14:43 ` Johannes Thumshirn
2017-04-05 14:50 ` Christoph Hellwig [this message]
2017-04-05 14:50 ` Christoph Hellwig
2017-04-05 14:18 ` [PATCH 2/5] nvme: cleanup nvme_req_needs_retry Christoph Hellwig
2017-04-05 14:18 ` Christoph Hellwig
2017-04-05 14:42 ` Johannes Thumshirn
2017-04-05 14:42 ` Johannes Thumshirn
2017-04-05 14:42 ` Johannes Thumshirn
2017-04-05 14:18 ` [PATCH 3/5] nvme: mark nvme_max_retries static Christoph Hellwig
2017-04-05 14:18 ` Christoph Hellwig
2017-04-05 14:44 ` Johannes Thumshirn
2017-04-05 14:44 ` Johannes Thumshirn
2017-04-05 14:44 ` Johannes Thumshirn
2017-04-05 14:18 ` [PATCH 4/5] nvme: move the retries count to struct nvme_request Christoph Hellwig
2017-04-05 14:18 ` Christoph Hellwig
2017-04-05 14:45 ` Johannes Thumshirn
2017-04-05 14:45 ` Johannes Thumshirn
2017-04-05 14:45 ` Johannes Thumshirn
2017-04-05 15:14 ` Keith Busch
2017-04-05 15:14 ` Keith Busch
2017-04-05 15:25 ` Christoph Hellwig
2017-04-05 15:25 ` Christoph Hellwig
2017-04-06 8:35 ` 廖亨权
2017-04-06 8:38 ` Christoph Hellwig
2017-04-06 8:38 ` Christoph Hellwig
2017-04-05 14:18 ` [PATCH 5/5] block, scsi: move the retries field to struct scsi_request Christoph Hellwig
2017-04-05 14:18 ` Christoph Hellwig
2017-04-05 14:46 ` Johannes Thumshirn
2017-04-05 14:46 ` Johannes Thumshirn
2017-04-05 14:46 ` Johannes Thumshirn
2017-04-05 17:18 ->retries fixups V2 Christoph Hellwig
2017-04-05 17:18 ` [PATCH 1/5] nvme: move ->retries setup to nvme_setup_cmd Christoph Hellwig
2017-04-05 17:18 ` Christoph Hellwig
2017-04-05 17:32 ` Sagi Grimberg
2017-04-05 17:32 ` Sagi Grimberg
2017-04-06 8:55 ` Johannes Thumshirn
2017-04-06 8:55 ` Johannes Thumshirn
2017-04-06 8:55 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170405145022.GA5521@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.