* [PATCH] net: ethernet: wiznet: avoid format string exposure
@ 2017-04-05 21:39 Kees Cook
2017-04-06 20:38 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Kees Cook @ 2017-04-05 21:39 UTC (permalink / raw)
To: linux-kernel
Cc: David S. Miller, Akinobu Mita, Eric Dumazet, Tejun Heo,
Florian Westphal, Bhaktipriya Shridhar, Masahiro Yamada, netdev
While unlikely, this makes sure any format strings in the device name
can't exposure information via the resulting workqueue name.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/net/ethernet/wiznet/w5100.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/wiznet/w5100.c b/drivers/net/ethernet/wiznet/w5100.c
index f90267f0519f..2bdfb39215e9 100644
--- a/drivers/net/ethernet/wiznet/w5100.c
+++ b/drivers/net/ethernet/wiznet/w5100.c
@@ -1152,7 +1152,8 @@ int w5100_probe(struct device *dev, const struct w5100_ops *ops,
if (err < 0)
goto err_register;
- priv->xfer_wq = alloc_workqueue(netdev_name(ndev), WQ_MEM_RECLAIM, 0);
+ priv->xfer_wq = alloc_workqueue("%s", WQ_MEM_RECLAIM, 0,
+ netdev_name(ndev));
if (!priv->xfer_wq) {
err = -ENOMEM;
goto err_wq;
--
2.7.4
--
Kees Cook
Pixel Security
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ethernet: wiznet: avoid format string exposure
2017-04-05 21:39 [PATCH] net: ethernet: wiznet: avoid format string exposure Kees Cook
@ 2017-04-06 20:38 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-04-06 20:38 UTC (permalink / raw)
To: keescook
Cc: linux-kernel, akinobu.mita, edumazet, tj, fw, bhaktipriya96,
yamada.masahiro, netdev
From: Kees Cook <keescook@chromium.org>
Date: Wed, 5 Apr 2017 14:39:35 -0700
> While unlikely, this makes sure any format strings in the device name
> can't exposure information via the resulting workqueue name.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-06 20:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-05 21:39 [PATCH] net: ethernet: wiznet: avoid format string exposure Kees Cook
2017-04-06 20:38 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.