* [GIT PULL] Allwinner clock fixes for 4.11, bis
@ 2017-04-06 7:41 ` Maxime Ripard
0 siblings, 0 replies; 10+ messages in thread
From: Maxime Ripard @ 2017-04-06 7:41 UTC (permalink / raw)
To: Mike Turquette, Stephen Boyd
Cc: Chen-Yu Tsai, Maxime Ripard, linux-arm-kernel, linux-clk
[-- Attachment #1: Type: text/plain, Size: 1625 bytes --]
Hi Mike, Stephen,
Please pull the following changes for one of the 4.11-rc's
Thanks!
Maxime
The following changes since commit b467e08a15563dede0d37d3233baa24fb97a7310:
clk: sunxi-ng: fix recalc_rate formula of NKMP clocks (2017-03-20 10:34:05 +0100)
are available in the git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git tags/sunxi-clk-fixes-for-4.11-2
for you to fetch changes up to d054a839a0986136374d49f9f9fbc264abae9c4c:
clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER (2017-03-27 13:37:05 +0200)
----------------------------------------------------------------
Allwinner clock fixes for 4.11, bis
A few patches to fix a build error and a few minor typos and bugs in the
sunxi-ng code
----------------------------------------------------------------
Chen-Yu Tsai (3):
clk: sunxi-ng: use 1 as fallback for minimum multiplier
clk: sunxi-ng: Fix round_rate/set_rate multiplier minimum mismatch
clk: sunxi-ng: a80: Fix audio PLL comment not matching actual code
Tobias Regnery (1):
clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER
drivers/clk/sunxi-ng/Kconfig | 1 +
drivers/clk/sunxi-ng/ccu-sun9i-a80.c | 3 +--
drivers/clk/sunxi-ng/ccu_nk.c | 8 ++++----
drivers/clk/sunxi-ng/ccu_nkm.c | 8 ++++----
drivers/clk/sunxi-ng/ccu_nkmp.c | 8 ++++----
drivers/clk/sunxi-ng/ccu_nm.c | 4 ++--
6 files changed, 16 insertions(+), 16 deletions(-)
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [GIT PULL] Allwinner clock fixes for 4.11, bis
@ 2017-04-06 7:41 ` Maxime Ripard
0 siblings, 0 replies; 10+ messages in thread
From: Maxime Ripard @ 2017-04-06 7:41 UTC (permalink / raw)
To: linux-arm-kernel
Hi Mike, Stephen,
Please pull the following changes for one of the 4.11-rc's
Thanks!
Maxime
The following changes since commit b467e08a15563dede0d37d3233baa24fb97a7310:
clk: sunxi-ng: fix recalc_rate formula of NKMP clocks (2017-03-20 10:34:05 +0100)
are available in the git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git tags/sunxi-clk-fixes-for-4.11-2
for you to fetch changes up to d054a839a0986136374d49f9f9fbc264abae9c4c:
clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER (2017-03-27 13:37:05 +0200)
----------------------------------------------------------------
Allwinner clock fixes for 4.11, bis
A few patches to fix a build error and a few minor typos and bugs in the
sunxi-ng code
----------------------------------------------------------------
Chen-Yu Tsai (3):
clk: sunxi-ng: use 1 as fallback for minimum multiplier
clk: sunxi-ng: Fix round_rate/set_rate multiplier minimum mismatch
clk: sunxi-ng: a80: Fix audio PLL comment not matching actual code
Tobias Regnery (1):
clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER
drivers/clk/sunxi-ng/Kconfig | 1 +
drivers/clk/sunxi-ng/ccu-sun9i-a80.c | 3 +--
drivers/clk/sunxi-ng/ccu_nk.c | 8 ++++----
drivers/clk/sunxi-ng/ccu_nkm.c | 8 ++++----
drivers/clk/sunxi-ng/ccu_nkmp.c | 8 ++++----
drivers/clk/sunxi-ng/ccu_nm.c | 4 ++--
6 files changed, 16 insertions(+), 16 deletions(-)
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170406/a5ee35fa/attachment-0001.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [GIT PULL] Allwinner clock fixes for 4.11, bis
2017-04-06 7:41 ` Maxime Ripard
@ 2017-04-06 23:10 ` Stephen Boyd
-1 siblings, 0 replies; 10+ messages in thread
From: Stephen Boyd @ 2017-04-06 23:10 UTC (permalink / raw)
To: Maxime Ripard; +Cc: Mike Turquette, Chen-Yu Tsai, linux-arm-kernel, linux-clk
On 04/06, Maxime Ripard wrote:
> Hi Mike, Stephen,
>
> Please pull the following changes for one of the 4.11-rc's
>
> Thanks!
> Maxime
>
> The following changes since commit b467e08a15563dede0d37d3233baa24fb97a7310:
>
> clk: sunxi-ng: fix recalc_rate formula of NKMP clocks (2017-03-20 10:34:05 +0100)
>
> are available in the git repository at:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git tags/sunxi-clk-fixes-for-4.11-2
>
> for you to fetch changes up to d054a839a0986136374d49f9f9fbc264abae9c4c:
>
> clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER (2017-03-27 13:37:05 +0200)
>
> ----------------------------------------------------------------
> Allwinner clock fixes for 4.11, bis
>
> A few patches to fix a build error and a few minor typos and bugs in the
> sunxi-ng code
>
> ----------------------------------------------------------------
> Chen-Yu Tsai (3):
> clk: sunxi-ng: use 1 as fallback for minimum multiplier
> clk: sunxi-ng: Fix round_rate/set_rate multiplier minimum mismatch
> clk: sunxi-ng: a80: Fix audio PLL comment not matching actual code
>
> Tobias Regnery (1):
> clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER
>
Two of these are fixes for regressions in v4.10? Why are these
critical for the v4.11 release? The comment patch is totally
bogus, it's not fixing any sort of regression that is causing
problems for people so I'm not sure why it was put into this pull
request. Am I right in assuming that the only real patch we need
out of here is the last one for the build error from randconfigs?
If so I can cherry-pick that from the branch into fixes and the
rest can go the next merge window.
Not pulling for now.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 10+ messages in thread
* [GIT PULL] Allwinner clock fixes for 4.11, bis
@ 2017-04-06 23:10 ` Stephen Boyd
0 siblings, 0 replies; 10+ messages in thread
From: Stephen Boyd @ 2017-04-06 23:10 UTC (permalink / raw)
To: linux-arm-kernel
On 04/06, Maxime Ripard wrote:
> Hi Mike, Stephen,
>
> Please pull the following changes for one of the 4.11-rc's
>
> Thanks!
> Maxime
>
> The following changes since commit b467e08a15563dede0d37d3233baa24fb97a7310:
>
> clk: sunxi-ng: fix recalc_rate formula of NKMP clocks (2017-03-20 10:34:05 +0100)
>
> are available in the git repository at:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git tags/sunxi-clk-fixes-for-4.11-2
>
> for you to fetch changes up to d054a839a0986136374d49f9f9fbc264abae9c4c:
>
> clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER (2017-03-27 13:37:05 +0200)
>
> ----------------------------------------------------------------
> Allwinner clock fixes for 4.11, bis
>
> A few patches to fix a build error and a few minor typos and bugs in the
> sunxi-ng code
>
> ----------------------------------------------------------------
> Chen-Yu Tsai (3):
> clk: sunxi-ng: use 1 as fallback for minimum multiplier
> clk: sunxi-ng: Fix round_rate/set_rate multiplier minimum mismatch
> clk: sunxi-ng: a80: Fix audio PLL comment not matching actual code
>
> Tobias Regnery (1):
> clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER
>
Two of these are fixes for regressions in v4.10? Why are these
critical for the v4.11 release? The comment patch is totally
bogus, it's not fixing any sort of regression that is causing
problems for people so I'm not sure why it was put into this pull
request. Am I right in assuming that the only real patch we need
out of here is the last one for the build error from randconfigs?
If so I can cherry-pick that from the branch into fixes and the
rest can go the next merge window.
Not pulling for now.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [GIT PULL] Allwinner clock fixes for 4.11, bis
2017-04-06 23:10 ` Stephen Boyd
@ 2017-04-10 8:00 ` Maxime Ripard
-1 siblings, 0 replies; 10+ messages in thread
From: Maxime Ripard @ 2017-04-10 8:00 UTC (permalink / raw)
To: Stephen Boyd; +Cc: Mike Turquette, Chen-Yu Tsai, linux-arm-kernel, linux-clk
[-- Attachment #1: Type: text/plain, Size: 2526 bytes --]
On Thu, Apr 06, 2017 at 04:10:03PM -0700, Stephen Boyd wrote:
> On 04/06, Maxime Ripard wrote:
> > Hi Mike, Stephen,
> >
> > Please pull the following changes for one of the 4.11-rc's
> >
> > Thanks!
> > Maxime
> >
> > The following changes since commit b467e08a15563dede0d37d3233baa24fb97a7310:
> >
> > clk: sunxi-ng: fix recalc_rate formula of NKMP clocks (2017-03-20 10:34:05 +0100)
> >
> > are available in the git repository at:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git tags/sunxi-clk-fixes-for-4.11-2
> >
> > for you to fetch changes up to d054a839a0986136374d49f9f9fbc264abae9c4c:
> >
> > clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER (2017-03-27 13:37:05 +0200)
> >
> > ----------------------------------------------------------------
> > Allwinner clock fixes for 4.11, bis
> >
> > A few patches to fix a build error and a few minor typos and bugs in the
> > sunxi-ng code
> >
> > ----------------------------------------------------------------
> > Chen-Yu Tsai (3):
> > clk: sunxi-ng: use 1 as fallback for minimum multiplier
> > clk: sunxi-ng: Fix round_rate/set_rate multiplier minimum mismatch
> > clk: sunxi-ng: a80: Fix audio PLL comment not matching actual code
> >
> > Tobias Regnery (1):
> > clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER
> >
>
> Two of these are fixes for regressions in v4.10? Why are these
> critical for the v4.11 release? The comment patch is totally
> bogus, it's not fixing any sort of regression that is causing
> problems for people so I'm not sure why it was put into this pull
> request. Am I right in assuming that the only real patch we need
> out of here is the last one for the build error from randconfigs?
> If so I can cherry-pick that from the branch into fixes and the
> rest can go the next merge window.
>
> Not pulling for now.
Actually, all of them but the comment fix are real fix.
"clk: sunxi-ng: use 1 as fallback for minimum multiplier" can lead to
a multiplier set to 0 in some cases (depending on the rate asked for),
and "clk: sunxi-ng: Fix round_rate/set_rate multiplier minimum
mismatch" will prevent inconsistensies in factors selection between
round_rate and set_rate.
So, yes, they are not critical fixes in the sense that it will fix a
panic. but still those are bugs.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [GIT PULL] Allwinner clock fixes for 4.11, bis
@ 2017-04-10 8:00 ` Maxime Ripard
0 siblings, 0 replies; 10+ messages in thread
From: Maxime Ripard @ 2017-04-10 8:00 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Apr 06, 2017 at 04:10:03PM -0700, Stephen Boyd wrote:
> On 04/06, Maxime Ripard wrote:
> > Hi Mike, Stephen,
> >
> > Please pull the following changes for one of the 4.11-rc's
> >
> > Thanks!
> > Maxime
> >
> > The following changes since commit b467e08a15563dede0d37d3233baa24fb97a7310:
> >
> > clk: sunxi-ng: fix recalc_rate formula of NKMP clocks (2017-03-20 10:34:05 +0100)
> >
> > are available in the git repository at:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git tags/sunxi-clk-fixes-for-4.11-2
> >
> > for you to fetch changes up to d054a839a0986136374d49f9f9fbc264abae9c4c:
> >
> > clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER (2017-03-27 13:37:05 +0200)
> >
> > ----------------------------------------------------------------
> > Allwinner clock fixes for 4.11, bis
> >
> > A few patches to fix a build error and a few minor typos and bugs in the
> > sunxi-ng code
> >
> > ----------------------------------------------------------------
> > Chen-Yu Tsai (3):
> > clk: sunxi-ng: use 1 as fallback for minimum multiplier
> > clk: sunxi-ng: Fix round_rate/set_rate multiplier minimum mismatch
> > clk: sunxi-ng: a80: Fix audio PLL comment not matching actual code
> >
> > Tobias Regnery (1):
> > clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER
> >
>
> Two of these are fixes for regressions in v4.10? Why are these
> critical for the v4.11 release? The comment patch is totally
> bogus, it's not fixing any sort of regression that is causing
> problems for people so I'm not sure why it was put into this pull
> request. Am I right in assuming that the only real patch we need
> out of here is the last one for the build error from randconfigs?
> If so I can cherry-pick that from the branch into fixes and the
> rest can go the next merge window.
>
> Not pulling for now.
Actually, all of them but the comment fix are real fix.
"clk: sunxi-ng: use 1 as fallback for minimum multiplier" can lead to
a multiplier set to 0 in some cases (depending on the rate asked for),
and "clk: sunxi-ng: Fix round_rate/set_rate multiplier minimum
mismatch" will prevent inconsistensies in factors selection between
round_rate and set_rate.
So, yes, they are not critical fixes in the sense that it will fix a
panic. but still those are bugs.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170410/a36df8cf/attachment.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [GIT PULL] Allwinner clock fixes for 4.11, bis
2017-04-10 8:00 ` Maxime Ripard
@ 2017-04-10 18:24 ` Stephen Boyd
-1 siblings, 0 replies; 10+ messages in thread
From: Stephen Boyd @ 2017-04-10 18:24 UTC (permalink / raw)
To: Maxime Ripard; +Cc: Mike Turquette, Chen-Yu Tsai, linux-arm-kernel, linux-clk
On 04/10, Maxime Ripard wrote:
> On Thu, Apr 06, 2017 at 04:10:03PM -0700, Stephen Boyd wrote:
> > On 04/06, Maxime Ripard wrote:
> > > Hi Mike, Stephen,
> > >
> > > Please pull the following changes for one of the 4.11-rc's
> > >
> > > Thanks!
> > > Maxime
> > >
> > > The following changes since commit b467e08a15563dede0d37d3233baa24fb97a7310:
> > >
> > > clk: sunxi-ng: fix recalc_rate formula of NKMP clocks (2017-03-20 10:34:05 +0100)
> > >
> > > are available in the git repository at:
> > >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git tags/sunxi-clk-fixes-for-4.11-2
> > >
> > > for you to fetch changes up to d054a839a0986136374d49f9f9fbc264abae9c4c:
> > >
> > > clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER (2017-03-27 13:37:05 +0200)
> > >
> > > ----------------------------------------------------------------
> > > Allwinner clock fixes for 4.11, bis
> > >
> > > A few patches to fix a build error and a few minor typos and bugs in the
> > > sunxi-ng code
> > >
> > > ----------------------------------------------------------------
> > > Chen-Yu Tsai (3):
> > > clk: sunxi-ng: use 1 as fallback for minimum multiplier
> > > clk: sunxi-ng: Fix round_rate/set_rate multiplier minimum mismatch
> > > clk: sunxi-ng: a80: Fix audio PLL comment not matching actual code
> > >
> > > Tobias Regnery (1):
> > > clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER
> > >
> >
> > Two of these are fixes for regressions in v4.10? Why are these
> > critical for the v4.11 release? The comment patch is totally
> > bogus, it's not fixing any sort of regression that is causing
> > problems for people so I'm not sure why it was put into this pull
> > request. Am I right in assuming that the only real patch we need
> > out of here is the last one for the build error from randconfigs?
> > If so I can cherry-pick that from the branch into fixes and the
> > rest can go the next merge window.
> >
> > Not pulling for now.
>
> Actually, all of them but the comment fix are real fix.
>
> "clk: sunxi-ng: use 1 as fallback for minimum multiplier" can lead to
> a multiplier set to 0 in some cases (depending on the rate asked for),
> and "clk: sunxi-ng: Fix round_rate/set_rate multiplier minimum
> mismatch" will prevent inconsistensies in factors selection between
> round_rate and set_rate.
>
> So, yes, they are not critical fixes in the sense that it will fix a
> panic. but still those are bugs.
Ok so it sounds like we agree that this can all wait until v4.12.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 10+ messages in thread
* [GIT PULL] Allwinner clock fixes for 4.11, bis
@ 2017-04-10 18:24 ` Stephen Boyd
0 siblings, 0 replies; 10+ messages in thread
From: Stephen Boyd @ 2017-04-10 18:24 UTC (permalink / raw)
To: linux-arm-kernel
On 04/10, Maxime Ripard wrote:
> On Thu, Apr 06, 2017 at 04:10:03PM -0700, Stephen Boyd wrote:
> > On 04/06, Maxime Ripard wrote:
> > > Hi Mike, Stephen,
> > >
> > > Please pull the following changes for one of the 4.11-rc's
> > >
> > > Thanks!
> > > Maxime
> > >
> > > The following changes since commit b467e08a15563dede0d37d3233baa24fb97a7310:
> > >
> > > clk: sunxi-ng: fix recalc_rate formula of NKMP clocks (2017-03-20 10:34:05 +0100)
> > >
> > > are available in the git repository at:
> > >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git tags/sunxi-clk-fixes-for-4.11-2
> > >
> > > for you to fetch changes up to d054a839a0986136374d49f9f9fbc264abae9c4c:
> > >
> > > clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER (2017-03-27 13:37:05 +0200)
> > >
> > > ----------------------------------------------------------------
> > > Allwinner clock fixes for 4.11, bis
> > >
> > > A few patches to fix a build error and a few minor typos and bugs in the
> > > sunxi-ng code
> > >
> > > ----------------------------------------------------------------
> > > Chen-Yu Tsai (3):
> > > clk: sunxi-ng: use 1 as fallback for minimum multiplier
> > > clk: sunxi-ng: Fix round_rate/set_rate multiplier minimum mismatch
> > > clk: sunxi-ng: a80: Fix audio PLL comment not matching actual code
> > >
> > > Tobias Regnery (1):
> > > clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER
> > >
> >
> > Two of these are fixes for regressions in v4.10? Why are these
> > critical for the v4.11 release? The comment patch is totally
> > bogus, it's not fixing any sort of regression that is causing
> > problems for people so I'm not sure why it was put into this pull
> > request. Am I right in assuming that the only real patch we need
> > out of here is the last one for the build error from randconfigs?
> > If so I can cherry-pick that from the branch into fixes and the
> > rest can go the next merge window.
> >
> > Not pulling for now.
>
> Actually, all of them but the comment fix are real fix.
>
> "clk: sunxi-ng: use 1 as fallback for minimum multiplier" can lead to
> a multiplier set to 0 in some cases (depending on the rate asked for),
> and "clk: sunxi-ng: Fix round_rate/set_rate multiplier minimum
> mismatch" will prevent inconsistensies in factors selection between
> round_rate and set_rate.
>
> So, yes, they are not critical fixes in the sense that it will fix a
> panic. but still those are bugs.
Ok so it sounds like we agree that this can all wait until v4.12.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [GIT PULL] Allwinner clock fixes for 4.11, bis
2017-04-10 18:24 ` Stephen Boyd
@ 2017-04-19 16:06 ` Stephen Boyd
-1 siblings, 0 replies; 10+ messages in thread
From: Stephen Boyd @ 2017-04-19 16:06 UTC (permalink / raw)
To: Maxime Ripard; +Cc: Mike Turquette, Chen-Yu Tsai, linux-arm-kernel, linux-clk
On 04/10, Stephen Boyd wrote:
> On 04/10, Maxime Ripard wrote:
> > On Thu, Apr 06, 2017 at 04:10:03PM -0700, Stephen Boyd wrote:
> > > On 04/06, Maxime Ripard wrote:
> > > > Hi Mike, Stephen,
> > > >
> > > > Please pull the following changes for one of the 4.11-rc's
> > > >
> > > > Thanks!
> > > > Maxime
> > > >
> > > > The following changes since commit b467e08a15563dede0d37d3233baa24fb97a7310:
> > > >
> > > > clk: sunxi-ng: fix recalc_rate formula of NKMP clocks (2017-03-20 10:34:05 +0100)
> > > >
> > > > are available in the git repository at:
> > > >
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git tags/sunxi-clk-fixes-for-4.11-2
> > > >
> > > > for you to fetch changes up to d054a839a0986136374d49f9f9fbc264abae9c4c:
> > > >
> > > > clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER (2017-03-27 13:37:05 +0200)
> > > >
> > > > ----------------------------------------------------------------
> > > > Allwinner clock fixes for 4.11, bis
> > > >
> > > > A few patches to fix a build error and a few minor typos and bugs in the
> > > > sunxi-ng code
> > > >
> > > > ----------------------------------------------------------------
> > > > Chen-Yu Tsai (3):
> > > > clk: sunxi-ng: use 1 as fallback for minimum multiplier
> > > > clk: sunxi-ng: Fix round_rate/set_rate multiplier minimum mismatch
> > > > clk: sunxi-ng: a80: Fix audio PLL comment not matching actual code
> > > >
> > > > Tobias Regnery (1):
> > > > clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER
> > > >
> > >
> > > Two of these are fixes for regressions in v4.10? Why are these
> > > critical for the v4.11 release? The comment patch is totally
> > > bogus, it's not fixing any sort of regression that is causing
> > > problems for people so I'm not sure why it was put into this pull
> > > request. Am I right in assuming that the only real patch we need
> > > out of here is the last one for the build error from randconfigs?
> > > If so I can cherry-pick that from the branch into fixes and the
> > > rest can go the next merge window.
> > >
> > > Not pulling for now.
> >
> > Actually, all of them but the comment fix are real fix.
> >
> > "clk: sunxi-ng: use 1 as fallback for minimum multiplier" can lead to
> > a multiplier set to 0 in some cases (depending on the rate asked for),
> > and "clk: sunxi-ng: Fix round_rate/set_rate multiplier minimum
> > mismatch" will prevent inconsistensies in factors selection between
> > round_rate and set_rate.
> >
> > So, yes, they are not critical fixes in the sense that it will fix a
> > panic. but still those are bugs.
>
> Ok so it sounds like we agree that this can all wait until v4.12.
>
Will you resend the few patches in here that aren't in the redone
PR for fixes or the PR for v4.12?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 10+ messages in thread
* [GIT PULL] Allwinner clock fixes for 4.11, bis
@ 2017-04-19 16:06 ` Stephen Boyd
0 siblings, 0 replies; 10+ messages in thread
From: Stephen Boyd @ 2017-04-19 16:06 UTC (permalink / raw)
To: linux-arm-kernel
On 04/10, Stephen Boyd wrote:
> On 04/10, Maxime Ripard wrote:
> > On Thu, Apr 06, 2017 at 04:10:03PM -0700, Stephen Boyd wrote:
> > > On 04/06, Maxime Ripard wrote:
> > > > Hi Mike, Stephen,
> > > >
> > > > Please pull the following changes for one of the 4.11-rc's
> > > >
> > > > Thanks!
> > > > Maxime
> > > >
> > > > The following changes since commit b467e08a15563dede0d37d3233baa24fb97a7310:
> > > >
> > > > clk: sunxi-ng: fix recalc_rate formula of NKMP clocks (2017-03-20 10:34:05 +0100)
> > > >
> > > > are available in the git repository at:
> > > >
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git tags/sunxi-clk-fixes-for-4.11-2
> > > >
> > > > for you to fetch changes up to d054a839a0986136374d49f9f9fbc264abae9c4c:
> > > >
> > > > clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER (2017-03-27 13:37:05 +0200)
> > > >
> > > > ----------------------------------------------------------------
> > > > Allwinner clock fixes for 4.11, bis
> > > >
> > > > A few patches to fix a build error and a few minor typos and bugs in the
> > > > sunxi-ng code
> > > >
> > > > ----------------------------------------------------------------
> > > > Chen-Yu Tsai (3):
> > > > clk: sunxi-ng: use 1 as fallback for minimum multiplier
> > > > clk: sunxi-ng: Fix round_rate/set_rate multiplier minimum mismatch
> > > > clk: sunxi-ng: a80: Fix audio PLL comment not matching actual code
> > > >
> > > > Tobias Regnery (1):
> > > > clk: sunxi-ng: fix build error without CONFIG_RESET_CONTROLLER
> > > >
> > >
> > > Two of these are fixes for regressions in v4.10? Why are these
> > > critical for the v4.11 release? The comment patch is totally
> > > bogus, it's not fixing any sort of regression that is causing
> > > problems for people so I'm not sure why it was put into this pull
> > > request. Am I right in assuming that the only real patch we need
> > > out of here is the last one for the build error from randconfigs?
> > > If so I can cherry-pick that from the branch into fixes and the
> > > rest can go the next merge window.
> > >
> > > Not pulling for now.
> >
> > Actually, all of them but the comment fix are real fix.
> >
> > "clk: sunxi-ng: use 1 as fallback for minimum multiplier" can lead to
> > a multiplier set to 0 in some cases (depending on the rate asked for),
> > and "clk: sunxi-ng: Fix round_rate/set_rate multiplier minimum
> > mismatch" will prevent inconsistensies in factors selection between
> > round_rate and set_rate.
> >
> > So, yes, they are not critical fixes in the sense that it will fix a
> > panic. but still those are bugs.
>
> Ok so it sounds like we agree that this can all wait until v4.12.
>
Will you resend the few patches in here that aren't in the redone
PR for fixes or the PR for v4.12?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-04-19 16:06 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-06 7:41 [GIT PULL] Allwinner clock fixes for 4.11, bis Maxime Ripard
2017-04-06 7:41 ` Maxime Ripard
2017-04-06 23:10 ` Stephen Boyd
2017-04-06 23:10 ` Stephen Boyd
2017-04-10 8:00 ` Maxime Ripard
2017-04-10 8:00 ` Maxime Ripard
2017-04-10 18:24 ` Stephen Boyd
2017-04-10 18:24 ` Stephen Boyd
2017-04-19 16:06 ` Stephen Boyd
2017-04-19 16:06 ` Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.