Re: [Qemu-devel] [Qemu-block] [PATCH v2 for-2.10 09/16] block/qcow2: Generalize preallocate()

From: Stefan Hajnoczi <stefanha@gmail.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
	qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 for-2.10 09/16] block/qcow2: Generalize preallocate()
Date: Thu, 6 Apr 2017 13:35:01 +0100	[thread overview]
Message-ID: <20170406123501.GJ21895@stefanha-x1.localdomain> (raw)
In-Reply-To: <20170403160936.28293-10-mreitz@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 925 bytes --]

On Mon, Apr 03, 2017 at 06:09:29PM +0200, Max Reitz wrote:
> This patch adds two new parameters to the preallocate() function so we
> will be able to use it not just for preallocating a new image but also
> for preallocated image growth.
> 
> The offset parameter allows the caller to specify a virtual offset from
> which to start preallocating. For newly created images this is always 0,
> but for preallocating growth this will be the old image length.
> 
> The new_length parameter specifies the supposed new length of the image
> (basically the "end offset" for preallocation). During image truncation,
> bdrv_getlength() will return the old image length so we cannot rely on
> its return value then.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  block/qcow2.c | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]