From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org> To: Jacek Anaszewski <jacek.anaszewski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: Felix Brack <fb-GovowT2ENgg@public.gmane.org>, rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, riku.voipio-X3B1VOXEql0@public.gmane.org, linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH v2] Extend pca9532 device tree support Date: Thu, 6 Apr 2017 17:50:05 +0200 [thread overview] Message-ID: <20170406155005.GA10363@amd> (raw) In-Reply-To: <b54c77d5-b4f7-9517-8c5b-9200c766204a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> [-- Attachment #1: Type: text/plain, Size: 2495 bytes --] Hi! > > diff --git a/Documentation/devicetree/bindings/leds/leds-pca9532.txt b/Documentation/devicetree/bindings/leds/leds-pca9532.txt > > index 198f3ba..8374075 100644 > > --- a/Documentation/devicetree/bindings/leds/leds-pca9532.txt > > +++ b/Documentation/devicetree/bindings/leds/leds-pca9532.txt > > @@ -17,6 +17,8 @@ Optional sub-node properties: > > - label: see Documentation/devicetree/bindings/leds/common.txt > > - type: Output configuration, see dt-bindings/leds/leds-pca9532.h (default NONE) > > - linux,default-trigger: see Documentation/devicetree/bindings/leds/common.txt > > + - default-state: see Documentation/devicetree/bindings/leds/common.txt > > + This property is only valid for sub-nodes of type <PCA9532_TYPE_LED>. > > > > Example: > > #include <dt-bindings/leds/leds-pca9532.h> > > @@ -33,6 +35,14 @@ Example: > > label = "pca:green:power"; > > type = <PCA9532_TYPE_LED>; > > }; > > + kernel-booting { > > + type = <PCA9532_TYPE_LED>; > > + default-state = "on"; > > + }; > > + sys-stat { > > + type = <PCA9532_TYPE_LED>; > > + default-state = "keep"; // don't touch, was set by U-Boot > > + }; > > Adjusted above indentation to match the preceding lines. > > @@ -475,6 +494,16 @@ pca9532_of_populate_pdata(struct device *dev, struct device_node *np) > > of_property_read_u32(child, "type", &pdata->leds[i].type); > > of_property_read_string(child, "linux,default-trigger", > > &pdata->leds[i].default_trigger); > > + if (!of_property_read_string(child, "default-state", &state)) { > > + if (!strcmp(state, "on")) > > + pdata->leds[i].state = PCA9532_ON; > > + else if (!strcmp(state, "keep")) > > + pdata->leds[i].state = PCA9532_KEEP; > > + else if (!strcmp(state, "pwm0")) > > + pdata->leds[i].state = PCA9532_PWM0; > > + else if (!strcmp(state, "pwm1")) > > + pdata->leds[i].state = PCA9532_PWM1; > > + } > > if (++i >= maxleds) { > > of_node_put(child); > > break; This seems to look for "pwm0" and "pwm1" strings, which do not seem to be documented. Plus... is it useful to have default-state? We already have default trigger. If we keep the value by default (on PC, we do something like that) this patch should not be neccessary? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz> To: Jacek Anaszewski <jacek.anaszewski@gmail.com> Cc: Felix Brack <fb@ltec.ch>, rpurdie@rpsys.net, mark.rutland@arm.com, riku.voipio@iki.fi, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Extend pca9532 device tree support Date: Thu, 6 Apr 2017 17:50:05 +0200 [thread overview] Message-ID: <20170406155005.GA10363@amd> (raw) In-Reply-To: <b54c77d5-b4f7-9517-8c5b-9200c766204a@gmail.com> [-- Attachment #1: Type: text/plain, Size: 2495 bytes --] Hi! > > diff --git a/Documentation/devicetree/bindings/leds/leds-pca9532.txt b/Documentation/devicetree/bindings/leds/leds-pca9532.txt > > index 198f3ba..8374075 100644 > > --- a/Documentation/devicetree/bindings/leds/leds-pca9532.txt > > +++ b/Documentation/devicetree/bindings/leds/leds-pca9532.txt > > @@ -17,6 +17,8 @@ Optional sub-node properties: > > - label: see Documentation/devicetree/bindings/leds/common.txt > > - type: Output configuration, see dt-bindings/leds/leds-pca9532.h (default NONE) > > - linux,default-trigger: see Documentation/devicetree/bindings/leds/common.txt > > + - default-state: see Documentation/devicetree/bindings/leds/common.txt > > + This property is only valid for sub-nodes of type <PCA9532_TYPE_LED>. > > > > Example: > > #include <dt-bindings/leds/leds-pca9532.h> > > @@ -33,6 +35,14 @@ Example: > > label = "pca:green:power"; > > type = <PCA9532_TYPE_LED>; > > }; > > + kernel-booting { > > + type = <PCA9532_TYPE_LED>; > > + default-state = "on"; > > + }; > > + sys-stat { > > + type = <PCA9532_TYPE_LED>; > > + default-state = "keep"; // don't touch, was set by U-Boot > > + }; > > Adjusted above indentation to match the preceding lines. > > @@ -475,6 +494,16 @@ pca9532_of_populate_pdata(struct device *dev, struct device_node *np) > > of_property_read_u32(child, "type", &pdata->leds[i].type); > > of_property_read_string(child, "linux,default-trigger", > > &pdata->leds[i].default_trigger); > > + if (!of_property_read_string(child, "default-state", &state)) { > > + if (!strcmp(state, "on")) > > + pdata->leds[i].state = PCA9532_ON; > > + else if (!strcmp(state, "keep")) > > + pdata->leds[i].state = PCA9532_KEEP; > > + else if (!strcmp(state, "pwm0")) > > + pdata->leds[i].state = PCA9532_PWM0; > > + else if (!strcmp(state, "pwm1")) > > + pdata->leds[i].state = PCA9532_PWM1; > > + } > > if (++i >= maxleds) { > > of_node_put(child); > > break; This seems to look for "pwm0" and "pwm1" strings, which do not seem to be documented. Plus... is it useful to have default-state? We already have default trigger. If we keep the value by default (on PC, we do something like that) this patch should not be neccessary? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-04-06 15:50 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-30 13:33 [PATCH v2] Extend pca9532 device tree support Felix Brack 2017-04-02 14:41 ` Jacek Anaszewski [not found] ` <b54c77d5-b4f7-9517-8c5b-9200c766204a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-04-06 15:50 ` Pavel Machek [this message] 2017-04-06 15:50 ` Pavel Machek 2017-04-06 19:00 ` Jacek Anaszewski 2017-04-06 19:00 ` Jacek Anaszewski [not found] ` <a8509d26-6e35-e2f7-9784-90f3c54accbf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-04-07 8:22 ` Felix Brack 2017-04-07 8:22 ` Felix Brack [not found] ` <ec012568-f540-4e87-d8c4-4065fbcd1c2a-GovowT2ENgg@public.gmane.org> 2017-04-07 11:57 ` default-state LED property (was Re: [PATCH v2] Extend pca9532 device tree support) Pavel Machek 2017-04-07 11:57 ` Pavel Machek 2017-04-09 12:37 ` [PATCH v2] Extend pca9532 device tree support Jacek Anaszewski 2017-04-09 12:37 ` Jacek Anaszewski [not found] ` <2f3815ab-71e1-b63d-aba8-167e11f719de-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-04-09 13:11 ` Felix Brack 2017-04-09 13:11 ` Felix Brack
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170406155005.GA10363@amd \ --to=pavel-+zi9xunit7i@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=fb-GovowT2ENgg@public.gmane.org \ --cc=jacek.anaszewski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=riku.voipio-X3B1VOXEql0@public.gmane.org \ --cc=rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.