Re: [PATCH 3/5] drm/i915: Generate the engine name based on the instance number

From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org,
	Paulo Zanoni <paulo.r.zanoni@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 3/5] drm/i915: Generate the engine name based on the instance number
Date: Thu, 6 Apr 2017 19:10:58 +0100	[thread overview]
Message-ID: <20170406181058.GM10496@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <7d5c8e0e-ea14-5706-d04a-5ff2a2018bed@linux.intel.com>

On Thu, Apr 06, 2017 at 07:02:10PM +0100, Tvrtko Ursulin wrote:
> 
> On 05/04/2017 10:30, Oscar Mateo wrote:
> >@@ -100,6 +100,7 @@
> > {
> > 	const struct engine_info *info = &intel_engines[id];
> > 	struct intel_engine_cs *engine;
> >+	char instance[3] = "";
> >
> > 	GEM_BUG_ON(dev_priv->engine[id]);
> > 	engine = kzalloc(sizeof(*engine), GFP_KERNEL);
> >@@ -108,7 +109,10 @@
> >
> > 	engine->id = id;
> > 	engine->i915 = dev_priv;
> >-	engine->name = info->name;
> >+	/* For historical reasons the engines are called: name, name2... */
> >+	if (info->instance)
> >+		snprintf(instance, sizeof(instance), "%u", info->instance + 1);
> >+	snprintf(engine->name, sizeof(engine->name), "%s%s", info->name, instance);
> 
> Since Chris has recently renamed all the engines, I'd say who cares
> about the numbering scheme. Just drop it for simplicity.

Seconded. class0 is ok, or if you are being fancy only use the classN
format if there are multiples in the class. Though kiss says just use
classN and be done with it.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx