All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sahid Orentino Ferdjaoui <sferdjao@redhat.com>
To: weiqi <weiqi4@huawei.com>
Cc: kraxel@redhat.com, arei.gonglei@huawei.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] vnc: simple clean up
Date: Fri, 7 Apr 2017 10:45:24 +0200	[thread overview]
Message-ID: <20170407084524.GB26482@redhat> (raw)
In-Reply-To: <1491548338-15128-1-git-send-email-weiqi4@huawei.com>

On Fri, Apr 07, 2017 at 02:58:58PM +0800, weiqi wrote:
> From: Wei Qi <weiqi4@huawei.com>
> 
> It is unnecessary to assign 'packed_bytes' to 'estimated_bytes', because 'estimated_bytes' unused after assignment.
> 
> Signed-off-by: Wei Qi <weiqi4@huawei.com>
> ---
>  ui/vnc-enc-zrle.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-By: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@redhat.com>

> 
> diff --git a/ui/vnc-enc-zrle.c b/ui/vnc-enc-zrle.c
> index 5489870..fd63d4f 100644
> --- a/ui/vnc-enc-zrle.c
> +++ b/ui/vnc-enc-zrle.c
> @@ -163,7 +163,6 @@ static void zrle_choose_palette_rle(VncState *vs, int w, int h,
>              if (packed_bytes < estimated_bytes) {
>                  *use_rle = false;
>                  *use_palette = true;
> -                estimated_bytes = packed_bytes;

I verified that 'estimated_bytes' is well a local variable defined in
'zrle_choose_palette_rle(...)'.

>              }
>          }
>      }
> -- 
> 1.8.3.1
> 
> 

      reply	other threads:[~2017-04-07  8:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-07  6:58 [Qemu-devel] [PATCH 2/3] vnc: simple clean up weiqi
2017-04-07  8:45 ` Sahid Orentino Ferdjaoui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170407084524.GB26482@redhat \
    --to=sferdjao@redhat.com \
    --cc=arei.gonglei@huawei.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=weiqi4@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.