* [Qemu-devel] [PATCH 2/3] vnc: simple clean up
@ 2017-04-07 6:58 weiqi
2017-04-07 8:45 ` Sahid Orentino Ferdjaoui
0 siblings, 1 reply; 2+ messages in thread
From: weiqi @ 2017-04-07 6:58 UTC (permalink / raw)
To: kraxel; +Cc: qemu-devel, arei.gonglei, Wei Qi
From: Wei Qi <weiqi4@huawei.com>
It is unnecessary to assign 'packed_bytes' to 'estimated_bytes', because 'estimated_bytes' unused after assignment.
Signed-off-by: Wei Qi <weiqi4@huawei.com>
---
ui/vnc-enc-zrle.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/ui/vnc-enc-zrle.c b/ui/vnc-enc-zrle.c
index 5489870..fd63d4f 100644
--- a/ui/vnc-enc-zrle.c
+++ b/ui/vnc-enc-zrle.c
@@ -163,7 +163,6 @@ static void zrle_choose_palette_rle(VncState *vs, int w, int h,
if (packed_bytes < estimated_bytes) {
*use_rle = false;
*use_palette = true;
- estimated_bytes = packed_bytes;
}
}
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH 2/3] vnc: simple clean up
2017-04-07 6:58 [Qemu-devel] [PATCH 2/3] vnc: simple clean up weiqi
@ 2017-04-07 8:45 ` Sahid Orentino Ferdjaoui
0 siblings, 0 replies; 2+ messages in thread
From: Sahid Orentino Ferdjaoui @ 2017-04-07 8:45 UTC (permalink / raw)
To: weiqi; +Cc: kraxel, arei.gonglei, qemu-devel
On Fri, Apr 07, 2017 at 02:58:58PM +0800, weiqi wrote:
> From: Wei Qi <weiqi4@huawei.com>
>
> It is unnecessary to assign 'packed_bytes' to 'estimated_bytes', because 'estimated_bytes' unused after assignment.
>
> Signed-off-by: Wei Qi <weiqi4@huawei.com>
> ---
> ui/vnc-enc-zrle.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-By: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@redhat.com>
>
> diff --git a/ui/vnc-enc-zrle.c b/ui/vnc-enc-zrle.c
> index 5489870..fd63d4f 100644
> --- a/ui/vnc-enc-zrle.c
> +++ b/ui/vnc-enc-zrle.c
> @@ -163,7 +163,6 @@ static void zrle_choose_palette_rle(VncState *vs, int w, int h,
> if (packed_bytes < estimated_bytes) {
> *use_rle = false;
> *use_palette = true;
> - estimated_bytes = packed_bytes;
I verified that 'estimated_bytes' is well a local variable defined in
'zrle_choose_palette_rle(...)'.
> }
> }
> }
> --
> 1.8.3.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-07 8:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-07 6:58 [Qemu-devel] [PATCH 2/3] vnc: simple clean up weiqi
2017-04-07 8:45 ` Sahid Orentino Ferdjaoui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.