* [PATCH] fbida: Fix compile-host-path error
@ 2017-04-07 21:36 Marek Vasut
2017-04-09 18:56 ` Khem Raj
2017-04-28 15:28 ` Marek Vasut
0 siblings, 2 replies; 4+ messages in thread
From: Marek Vasut @ 2017-04-07 21:36 UTC (permalink / raw)
To: openembedded-devel; +Cc: Marek Vasut
Remove the explicit reference to /usr/local/* in Variables.mk.
This is completely bogus and causes failure during cross-compilation.
Signed-off-by: Marek Vasut <marex@denx.de>
---
meta-oe/recipes-graphics/fbida/fbida_2.10.bb | 4 ++-
.../fbida/files/0001-Avoid-using-host-path.patch | 34 ++++++++++++++++++++++
2 files changed, 37 insertions(+), 1 deletion(-)
create mode 100644 meta-oe/recipes-graphics/fbida/files/0001-Avoid-using-host-path.patch
diff --git a/meta-oe/recipes-graphics/fbida/fbida_2.10.bb b/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
index c14fc9b68..459a1e8d2 100644
--- a/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
+++ b/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
@@ -10,7 +10,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
DEPENDS = "virtual/libiconv jpeg fontconfig freetype libexif"
-SRC_URI = "https://www.kraxel.org/releases/fbida/fbida-${PV}.tar.gz"
+SRC_URI = "https://www.kraxel.org/releases/fbida/fbida-${PV}.tar.gz \
+ file://0001-Avoid-using-host-path.patch \
+ "
SRC_URI[md5sum] = "09460b964b58c2e39b665498eca29018"
SRC_URI[sha256sum] = "7a5a3aac61b40a6a2bbf716d270a46e2f8e8d5c97e314e927d41398a4d0b6cb6"
diff --git a/meta-oe/recipes-graphics/fbida/files/0001-Avoid-using-host-path.patch b/meta-oe/recipes-graphics/fbida/files/0001-Avoid-using-host-path.patch
new file mode 100644
index 000000000..cdf2c25d3
--- /dev/null
+++ b/meta-oe/recipes-graphics/fbida/files/0001-Avoid-using-host-path.patch
@@ -0,0 +1,34 @@
+From 8d8fa9f22d9f6a95523bac63ac3af724faf5ff92 Mon Sep 17 00:00:00 2001
+From: Marek Vasut <marex@denx.de>
+Date: Fri, 7 Apr 2017 23:26:09 +0200
+Subject: [PATCH] Avoid using host-path
+
+Remove the explicit reference to /usr/local/* , this is completely
+bogus and causes trouble during cross-compilation.
+
+Signed-off-by: Marek Vasut <marex@denx.de>
+Upstream-Status: Inappropriate [upstream requires this]
+---
+ mk/Variables.mk | 6 ------
+ 1 file changed, 6 deletions(-)
+
+diff --git a/mk/Variables.mk b/mk/Variables.mk
+index 99f787c..3ffd87a 100644
+--- a/mk/Variables.mk
++++ b/mk/Variables.mk
+@@ -42,12 +42,6 @@ CFLAGS += -Wall -Wmissing-prototypes -Wstrict-prototypes \
+ -Wpointer-arith -Wunused
+ CXXFLAGS += -Wall -Wpointer-arith -Wunused
+
+-# add /usr/local to the search path if something is in there ...
+-ifneq ($(wildcard /usr/local/include/*.h),)
+- CFLAGS += -I/usr/local/include
+- LDFLAGS += -L/usr/local/$(LIB)
+-endif
+-
+ # fixup include path for $(srcdir) != "."
+ ifneq ($(srcdir),.)
+ CFLAGS += -I. -I$(srcdir)
+--
+2.11.0
+
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fbida: Fix compile-host-path error
2017-04-07 21:36 [PATCH] fbida: Fix compile-host-path error Marek Vasut
@ 2017-04-09 18:56 ` Khem Raj
2017-04-09 20:55 ` Marek Vasut
2017-04-28 15:28 ` Marek Vasut
1 sibling, 1 reply; 4+ messages in thread
From: Khem Raj @ 2017-04-09 18:56 UTC (permalink / raw)
To: Marek Vasut, openembedded-devel
On Fri, Apr 7, 2017 at 2:37 PM Marek Vasut <marex@denx.de> wrote:
> Remove the explicit reference to /usr/local/* in Variables.mk.
> This is completely bogus and causes failure during cross-compilation.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> meta-oe/recipes-graphics/fbida/fbida_2.10.bb | 4 ++-
> .../fbida/files/0001-Avoid-using-host-path.patch | 34
> ++++++++++++++++++++++
> 2 files changed, 37 insertions(+), 1 deletion(-)
> create mode 100644
> meta-oe/recipes-graphics/fbida/files/0001-Avoid-using-host-path.patch
>
> diff --git a/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
> b/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
> index c14fc9b68..459a1e8d2 100644
> --- a/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
> +++ b/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
> @@ -10,7 +10,9 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
>
> DEPENDS = "virtual/libiconv jpeg fontconfig freetype libexif"
>
> -SRC_URI = "https://www.kraxel.org/releases/fbida/fbida-${PV}.tar.gz"
> +SRC_URI = "https://www.kraxel.org/releases/fbida/fbida-${PV}.tar.gz \
> + file://0001-Avoid-using-host-path.patch \
> + "
> SRC_URI[md5sum] = "09460b964b58c2e39b665498eca29018"
> SRC_URI[sha256sum] =
> "7a5a3aac61b40a6a2bbf716d270a46e2f8e8d5c97e314e927d41398a4d0b6cb6"
>
> diff --git
> a/meta-oe/recipes-graphics/fbida/files/0001-Avoid-using-host-path.patch
> b/meta-oe/recipes-graphics/fbida/files/0001-Avoid-using-host-path.patch
> new file mode 100644
> index 000000000..cdf2c25d3
> --- /dev/null
> +++ b/meta-oe/recipes-graphics/fbida/files/0001-Avoid-using-host-path.patch
> @@ -0,0 +1,34 @@
> +From 8d8fa9f22d9f6a95523bac63ac3af724faf5ff92 Mon Sep 17 00:00:00 2001
> +From: Marek Vasut <marex@denx.de>
> +Date: Fri, 7 Apr 2017 23:26:09 +0200
> +Subject: [PATCH] Avoid using host-path
> +
> +Remove the explicit reference to /usr/local/* , this is completely
> +bogus and causes trouble during cross-compilation.
> +
> +Signed-off-by: Marek Vasut <marex@denx.de>
> +Upstream-Status: Inappropriate [upstream requires this]
This status is confusing
> +---
> + mk/Variables.mk | 6 ------
> + 1 file changed, 6 deletions(-)
> +
> +diff --git a/mk/Variables.mk b/mk/Variables.mk
> +index 99f787c..3ffd87a 100644
> +--- a/mk/Variables.mk
> ++++ b/mk/Variables.mk
> +@@ -42,12 +42,6 @@ CFLAGS += -Wall -Wmissing-prototypes
> -Wstrict-prototypes \
> + -Wpointer-arith -Wunused
> + CXXFLAGS += -Wall -Wpointer-arith -Wunused
> +
> +-# add /usr/local to the search path if something is in there ...
> +-ifneq ($(wildcard /usr/local/include/*.h),)
> +- CFLAGS += -I/usr/local/include
> +- LDFLAGS += -L/usr/local/$(LIB)
> +-endif
> +-
> + # fixup include path for $(srcdir) != "."
> + ifneq ($(srcdir),.)
> + CFLAGS += -I. -I$(srcdir)
> +--
> +2.11.0
> +
> --
> 2.11.0
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fbida: Fix compile-host-path error
2017-04-09 18:56 ` Khem Raj
@ 2017-04-09 20:55 ` Marek Vasut
0 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2017-04-09 20:55 UTC (permalink / raw)
To: Khem Raj, openembedded-devel
On 04/09/2017 08:56 PM, Khem Raj wrote:
> On Fri, Apr 7, 2017 at 2:37 PM Marek Vasut <marex@denx.de> wrote:
>
>> Remove the explicit reference to /usr/local/* in Variables.mk.
>> This is completely bogus and causes failure during cross-compilation.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> ---
>> meta-oe/recipes-graphics/fbida/fbida_2.10.bb | 4 ++-
>> .../fbida/files/0001-Avoid-using-host-path.patch | 34
>> ++++++++++++++++++++++
>> 2 files changed, 37 insertions(+), 1 deletion(-)
>> create mode 100644
>> meta-oe/recipes-graphics/fbida/files/0001-Avoid-using-host-path.patch
>>
>> diff --git a/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
>> b/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
>> index c14fc9b68..459a1e8d2 100644
>> --- a/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
>> +++ b/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
>> @@ -10,7 +10,9 @@ LIC_FILES_CHKSUM =
>> "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
>>
>> DEPENDS = "virtual/libiconv jpeg fontconfig freetype libexif"
>>
>> -SRC_URI = "https://www.kraxel.org/releases/fbida/fbida-${PV}.tar.gz"
>> +SRC_URI = "https://www.kraxel.org/releases/fbida/fbida-${PV}.tar.gz \
>> + file://0001-Avoid-using-host-path.patch \
>> + "
>> SRC_URI[md5sum] = "09460b964b58c2e39b665498eca29018"
>> SRC_URI[sha256sum] =
>> "7a5a3aac61b40a6a2bbf716d270a46e2f8e8d5c97e314e927d41398a4d0b6cb6"
>>
>> diff --git
>> a/meta-oe/recipes-graphics/fbida/files/0001-Avoid-using-host-path.patch
>> b/meta-oe/recipes-graphics/fbida/files/0001-Avoid-using-host-path.patch
>> new file mode 100644
>> index 000000000..cdf2c25d3
>> --- /dev/null
>> +++ b/meta-oe/recipes-graphics/fbida/files/0001-Avoid-using-host-path.patch
>> @@ -0,0 +1,34 @@
>> +From 8d8fa9f22d9f6a95523bac63ac3af724faf5ff92 Mon Sep 17 00:00:00 2001
>> +From: Marek Vasut <marex@denx.de>
>> +Date: Fri, 7 Apr 2017 23:26:09 +0200
>> +Subject: [PATCH] Avoid using host-path
>> +
>> +Remove the explicit reference to /usr/local/* , this is completely
>> +bogus and causes trouble during cross-compilation.
>> +
>> +Signed-off-by: Marek Vasut <marex@denx.de>
>> +Upstream-Status: Inappropriate [upstream requires this]
>
>
> This status is confusing
This comment is confusing.
Hint: What do you expect me to put in there ?
Anyway, this fixes a bug, so feel free to tweak it and apply .
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fbida: Fix compile-host-path error
2017-04-07 21:36 [PATCH] fbida: Fix compile-host-path error Marek Vasut
2017-04-09 18:56 ` Khem Raj
@ 2017-04-28 15:28 ` Marek Vasut
1 sibling, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2017-04-28 15:28 UTC (permalink / raw)
To: openembedded-devel
On 04/07/2017 11:36 PM, Marek Vasut wrote:
> Remove the explicit reference to /usr/local/* in Variables.mk.
> This is completely bogus and causes failure during cross-compilation.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
Can we have this applied so that the package stops failing to build ? Thanks
> ---
> meta-oe/recipes-graphics/fbida/fbida_2.10.bb | 4 ++-
> .../fbida/files/0001-Avoid-using-host-path.patch | 34 ++++++++++++++++++++++
> 2 files changed, 37 insertions(+), 1 deletion(-)
> create mode 100644 meta-oe/recipes-graphics/fbida/files/0001-Avoid-using-host-path.patch
>
> diff --git a/meta-oe/recipes-graphics/fbida/fbida_2.10.bb b/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
> index c14fc9b68..459a1e8d2 100644
> --- a/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
> +++ b/meta-oe/recipes-graphics/fbida/fbida_2.10.bb
> @@ -10,7 +10,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
>
> DEPENDS = "virtual/libiconv jpeg fontconfig freetype libexif"
>
> -SRC_URI = "https://www.kraxel.org/releases/fbida/fbida-${PV}.tar.gz"
> +SRC_URI = "https://www.kraxel.org/releases/fbida/fbida-${PV}.tar.gz \
> + file://0001-Avoid-using-host-path.patch \
> + "
> SRC_URI[md5sum] = "09460b964b58c2e39b665498eca29018"
> SRC_URI[sha256sum] = "7a5a3aac61b40a6a2bbf716d270a46e2f8e8d5c97e314e927d41398a4d0b6cb6"
>
> diff --git a/meta-oe/recipes-graphics/fbida/files/0001-Avoid-using-host-path.patch b/meta-oe/recipes-graphics/fbida/files/0001-Avoid-using-host-path.patch
> new file mode 100644
> index 000000000..cdf2c25d3
> --- /dev/null
> +++ b/meta-oe/recipes-graphics/fbida/files/0001-Avoid-using-host-path.patch
> @@ -0,0 +1,34 @@
> +From 8d8fa9f22d9f6a95523bac63ac3af724faf5ff92 Mon Sep 17 00:00:00 2001
> +From: Marek Vasut <marex@denx.de>
> +Date: Fri, 7 Apr 2017 23:26:09 +0200
> +Subject: [PATCH] Avoid using host-path
> +
> +Remove the explicit reference to /usr/local/* , this is completely
> +bogus and causes trouble during cross-compilation.
> +
> +Signed-off-by: Marek Vasut <marex@denx.de>
> +Upstream-Status: Inappropriate [upstream requires this]
> +---
> + mk/Variables.mk | 6 ------
> + 1 file changed, 6 deletions(-)
> +
> +diff --git a/mk/Variables.mk b/mk/Variables.mk
> +index 99f787c..3ffd87a 100644
> +--- a/mk/Variables.mk
> ++++ b/mk/Variables.mk
> +@@ -42,12 +42,6 @@ CFLAGS += -Wall -Wmissing-prototypes -Wstrict-prototypes \
> + -Wpointer-arith -Wunused
> + CXXFLAGS += -Wall -Wpointer-arith -Wunused
> +
> +-# add /usr/local to the search path if something is in there ...
> +-ifneq ($(wildcard /usr/local/include/*.h),)
> +- CFLAGS += -I/usr/local/include
> +- LDFLAGS += -L/usr/local/$(LIB)
> +-endif
> +-
> + # fixup include path for $(srcdir) != "."
> + ifneq ($(srcdir),.)
> + CFLAGS += -I. -I$(srcdir)
> +--
> +2.11.0
> +
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-28 15:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-07 21:36 [PATCH] fbida: Fix compile-host-path error Marek Vasut
2017-04-09 18:56 ` Khem Raj
2017-04-09 20:55 ` Marek Vasut
2017-04-28 15:28 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.