From: Greg KH <gregkh@linuxfoundation.org>
To: Prasant Jalan <prasant.jalan@gmail.com>
Cc: forest@alittletooquiet.net, arushisinghal19971997@gmail.com,
devel@driverdev.osuosl.org, johannes.berg@intel.com,
linux-kernel@vger.kernel.org, michael.schacht.hansen@gmail.com
Subject: Re: [PATCH v2] staging: vt6656: fixed an indentation coding style issue
Date: Sat, 8 Apr 2017 12:50:53 +0200 [thread overview]
Message-ID: <20170408105053.GA19860@kroah.com> (raw)
In-Reply-To: <1490443848-5985-1-git-send-email-prasant.jalan@gmail.com>
On Sat, Mar 25, 2017 at 05:40:48PM +0530, Prasant Jalan wrote:
>
> Replacing spaces with tabs for indetation to fix checkpatch.pl error
> "code indent should use tabs where possible".
>
>
> Signed-off-by: Prasant Jalan <prasant.jalan@gmail.com>
> ---
>
> v2:
> - improved changelog comments
> - fixed only one issue
>
>
> drivers/staging/vt6656/rxtx.c | 35 +++++++++++++++++++----------------
> 1 file changed, 19 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
> index 1835cd1..7ebd1ee 100644
> --- a/drivers/staging/vt6656/rxtx.c
> +++ b/drivers/staging/vt6656/rxtx.c
> @@ -114,7 +114,7 @@ static __le16 vnt_time_stamp_off(struct vnt_private *priv, u16 rate)
> }
>
> static u32 vnt_get_rsvtime(struct vnt_private *priv, u8 pkt_type,
> - u32 frame_length, u16 rate, int need_ack)
> + u32 frame_length, u16 rate, int need_ack)
No, it should look like:
u32 frame_length, u16 rate, int need_ack)
Please fix them up that way.
thanks,
greg k-h
next prev parent reply other threads:[~2017-04-08 10:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-25 12:10 [PATCH v2] staging: vt6656: fixed an indentation coding style issue Prasant Jalan
[not found] ` <CA+XqjF9=VwTnp19cnwNpnDZ1a7HKOxcaL6BqJa5rcZNBrf-yjQ@mail.gmail.com>
2017-03-25 12:58 ` Prasant Jalan
2017-04-08 10:50 ` Greg KH [this message]
2017-03-27 23:32 Prasant Jalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170408105053.GA19860@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arushisinghal19971997@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.schacht.hansen@gmail.com \
--cc=prasant.jalan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.