All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] staging: vt6656: fixed an indentation coding style issue
@ 2017-03-25 12:10 Prasant Jalan
       [not found] ` <CA+XqjF9=VwTnp19cnwNpnDZ1a7HKOxcaL6BqJa5rcZNBrf-yjQ@mail.gmail.com>
  2017-04-08 10:50 ` Greg KH
  0 siblings, 2 replies; 4+ messages in thread
From: Prasant Jalan @ 2017-03-25 12:10 UTC (permalink / raw)
  To: forest
  Cc: gregkh, arushisinghal19971997, johannes.berg,
	michael.schacht.hansen, devel, linux-kernel, Prasant Jalan


Replacing spaces with tabs for indetation to fix checkpatch.pl error
"code indent should use tabs where possible".


Signed-off-by: Prasant Jalan <prasant.jalan@gmail.com>
---

  v2:
    - improved changelog comments
    - fixed only one issue


 drivers/staging/vt6656/rxtx.c | 35 +++++++++++++++++++----------------
 1 file changed, 19 insertions(+), 16 deletions(-)

diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
index 1835cd1..7ebd1ee 100644
--- a/drivers/staging/vt6656/rxtx.c
+++ b/drivers/staging/vt6656/rxtx.c
@@ -114,7 +114,7 @@ static __le16 vnt_time_stamp_off(struct vnt_private *priv, u16 rate)
 }
 
 static u32 vnt_get_rsvtime(struct vnt_private *priv, u8 pkt_type,
-	                    u32 frame_length, u16 rate, int need_ack)
+				u32 frame_length, u16 rate, int need_ack)
 {
 	u32 data_time, ack_time;
 
@@ -135,14 +135,16 @@ static u32 vnt_get_rsvtime(struct vnt_private *priv, u8 pkt_type,
 }
 
 static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type,
-	                             u32 frame_length, u16 rate, int need_ack)
+					u32 frame_length, u16 rate,
+					int need_ack)
 {
 	return cpu_to_le16((u16)vnt_get_rsvtime(priv, pkt_type,
 		frame_length, rate, need_ack));
 }
 
 static __le16 vnt_get_rtscts_rsvtime_le(struct vnt_private *priv,
-	                                 u8 rsv_type, u8 pkt_type, u32 frame_length, u16 current_rate)
+					u8 rsv_type, u8 pkt_type,
+					u32 frame_length, u16 current_rate)
 {
 	u32 rrv_time, rts_time, cts_time, ack_time, data_time;
 
@@ -160,19 +162,19 @@ static __le16 vnt_get_rtscts_rsvtime_le(struct vnt_private *priv,
 		rts_time = vnt_get_frame_time(priv->preamble_type,
 			pkt_type, 20, priv->top_cck_basic_rate);
 		cts_time = vnt_get_frame_time(priv->preamble_type, pkt_type,
-			                      14, priv->top_cck_basic_rate);
+						14, priv->top_cck_basic_rate);
 		ack_time = vnt_get_frame_time(priv->preamble_type, pkt_type,
-			                      14, priv->top_ofdm_basic_rate);
+						14, priv->top_ofdm_basic_rate);
 	} else if (rsv_type == 2) {
 		rts_time = vnt_get_frame_time(priv->preamble_type, pkt_type,
-			                      20, priv->top_ofdm_basic_rate);
+						20, priv->top_ofdm_basic_rate);
 		cts_time = ack_time = vnt_get_frame_time(priv->preamble_type,
 			pkt_type, 14, priv->top_ofdm_basic_rate);
 	} else if (rsv_type == 3) {
 		cts_time = vnt_get_frame_time(priv->preamble_type, pkt_type,
-			                      14, priv->top_cck_basic_rate);
+						14, priv->top_cck_basic_rate);
 		ack_time = vnt_get_frame_time(priv->preamble_type, pkt_type,
-			                      14, priv->top_ofdm_basic_rate);
+						14, priv->top_ofdm_basic_rate);
 
 		rrv_time = cts_time + ack_time + data_time + 2 * priv->sifs;
 
@@ -227,7 +229,8 @@ static __le16 vnt_get_rtscts_duration_le(struct vnt_usb_send_context *context,
 	case RTSDUR_AA_F0:
 	case RTSDUR_AA_F1:
 		cts_time = vnt_get_frame_time(priv->preamble_type,
-				              pkt_type, 14, priv->top_ofdm_basic_rate);
+						pkt_type, 14,
+						priv->top_ofdm_basic_rate);
 		dur_time = cts_time + 2 * priv->sifs +
 			vnt_get_rsvtime(priv, pkt_type,
 					frame_length, rate, need_ack);
@@ -410,7 +413,7 @@ static u16 vnt_rxtx_rts_g_head(struct vnt_usb_send_context *tx_context,
 	u16 current_rate = tx_context->tx_rate;
 
 	vnt_get_phy_field(priv, rts_frame_len, priv->top_cck_basic_rate,
-		          PK_TYPE_11B, &buf->b);
+				PK_TYPE_11B, &buf->b);
 	vnt_get_phy_field(priv, rts_frame_len, priv->top_ofdm_basic_rate,
 			  tx_context->pkt_type, &buf->a);
 
@@ -437,7 +440,7 @@ static u16 vnt_rxtx_rts_g_fb_head(struct vnt_usb_send_context *tx_context,
 	u16 rts_frame_len = 20;
 
 	vnt_get_phy_field(priv, rts_frame_len, priv->top_cck_basic_rate,
-		          PK_TYPE_11B, &buf->b);
+				PK_TYPE_11B, &buf->b);
 	vnt_get_phy_field(priv, rts_frame_len, priv->top_ofdm_basic_rate,
 			  tx_context->pkt_type, &buf->a);
 
@@ -683,9 +686,9 @@ static u16 vnt_rxtx_ab(struct vnt_usb_send_context *tx_context,
 }
 
 static u16 vnt_generate_tx_parameter(struct vnt_usb_send_context *tx_context,
-	                              struct vnt_tx_buffer *tx_buffer,
-	                              struct vnt_mic_hdr **mic_hdr, u32 need_mic,
-	                              bool need_rts)
+					struct vnt_tx_buffer *tx_buffer,
+					struct vnt_mic_hdr **mic_hdr,
+					u32 need_mic, bool need_rts)
 {
 
 	if (tx_context->pkt_type == PK_TYPE_11GB ||
@@ -1024,7 +1027,7 @@ static int vnt_beacon_xmit(struct vnt_private *priv,
 
 		/* Get SignalField,ServiceField,Length */
 		vnt_get_phy_field(priv, frame_size, current_rate,
-			          PK_TYPE_11A, &short_head->ab);
+					PK_TYPE_11A, &short_head->ab);
 
 		/* Get Duration and TimeStampOff */
 		short_head->duration = vnt_get_duration_le(priv,
@@ -1101,7 +1104,7 @@ int vnt_beacon_make(struct vnt_private *priv, struct ieee80211_vif *vif)
 }
 
 int vnt_beacon_enable(struct vnt_private *priv, struct ieee80211_vif *vif,
-	               struct ieee80211_bss_conf *conf)
+			struct ieee80211_bss_conf *conf)
 {
 	vnt_mac_reg_bits_off(priv, MAC_REG_TCR, TCR_AUTOBCNTX);
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] staging: vt6656: fixed an indentation coding style issue
       [not found] ` <CA+XqjF9=VwTnp19cnwNpnDZ1a7HKOxcaL6BqJa5rcZNBrf-yjQ@mail.gmail.com>
@ 2017-03-25 12:58   ` Prasant Jalan
  0 siblings, 0 replies; 4+ messages in thread
From: Prasant Jalan @ 2017-03-25 12:58 UTC (permalink / raw)
  To: Arushi Singhal
  Cc: forest, Greg KH, johannes.berg, Michael Hansen, driverdevel, LKML

On Sat, Mar 25, 2017 at 6:01 PM, Arushi Singhal
<arushisinghal19971997@gmail.com> wrote:
>
>
> On Sat, Mar 25, 2017 at 5:40 PM, Prasant Jalan <prasant.jalan@gmail.com>
> wrote:
>>
>>
>> Replacing spaces with tabs for indetation to fix checkpatch.pl error
>> "code indent should use tabs where possible".
>
> I think the commit message should be much more clear as for "code
> indentation"
> you are even adding and deleting spaces.
>>
>>

Hi Arushi,

Thanks for comments and sorry to bother with a coding style fix patch.
I'm just trying to learn and felt its an easy one.

I did not understand your comment "adding and deleting spaces".
I'm only deleting spaces and replacing it with tabs.
I'm not adding spaces. Could you please clarify.

Regards, Prasant

>>
>> Signed-off-by: Prasant Jalan <prasant.jalan@gmail.com>
>> ---
>>
>>   v2:
>>     - improved changelog comments
>>     - fixed only one issue
>>
>>
>>  drivers/staging/vt6656/rxtx.c | 35 +++++++++++++++++++----------------
>>  1 file changed, 19 insertions(+), 16 deletions(-)
>>
>> diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
>> index 1835cd1..7ebd1ee 100644
>> --- a/drivers/staging/vt6656/rxtx.c
>> +++ b/drivers/staging/vt6656/rxtx.c
>> @@ -114,7 +114,7 @@ static __le16 vnt_time_stamp_off(struct vnt_private
>> *priv, u16 rate)
>>  }
>>
>>  static u32 vnt_get_rsvtime(struct vnt_private *priv, u8 pkt_type,
>> -                           u32 frame_length, u16 rate, int need_ack)
>> +                               u32 frame_length, u16 rate, int need_ack)
>>  {
>>         u32 data_time, ack_time;
>>
>> @@ -135,14 +135,16 @@ static u32 vnt_get_rsvtime(struct vnt_private *priv,
>> u8 pkt_type,
>>  }
>>
>>  static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8
>> pkt_type,
>> -                                    u32 frame_length, u16 rate, int
>> need_ack)
>> +                                       u32 frame_length, u16 rate,
>> +                                       int need_ack)
>>  {
>>         return cpu_to_le16((u16)vnt_get_rsvtime(priv, pkt_type,
>>                 frame_length, rate, need_ack));
>>  }
>>
>>  static __le16 vnt_get_rtscts_rsvtime_le(struct vnt_private *priv,
>> -                                        u8 rsv_type, u8 pkt_type, u32
>> frame_length, u16 current_rate)
>> +                                       u8 rsv_type, u8 pkt_type,
>> +                                       u32 frame_length, u16
>> current_rate)
>>  {
>>         u32 rrv_time, rts_time, cts_time, ack_time, data_time;
>>
>> @@ -160,19 +162,19 @@ static __le16 vnt_get_rtscts_rsvtime_le(struct
>> vnt_private *priv,
>>                 rts_time = vnt_get_frame_time(priv->preamble_type,
>>                         pkt_type, 20, priv->top_cck_basic_rate);
>>                 cts_time = vnt_get_frame_time(priv->preamble_type,
>> pkt_type,
>> -                                             14,
>> priv->top_cck_basic_rate);
>> +                                               14,
>> priv->top_cck_basic_rate);
>>                 ack_time = vnt_get_frame_time(priv->preamble_type,
>> pkt_type,
>> -                                             14,
>> priv->top_ofdm_basic_rate);
>> +                                               14,
>> priv->top_ofdm_basic_rate);
>>         } else if (rsv_type == 2) {
>>                 rts_time = vnt_get_frame_time(priv->preamble_type,
>> pkt_type,
>> -                                             20,
>> priv->top_ofdm_basic_rate);
>> +                                               20,
>> priv->top_ofdm_basic_rate);
>>                 cts_time = ack_time =
>> vnt_get_frame_time(priv->preamble_type,
>>                         pkt_type, 14, priv->top_ofdm_basic_rate);
>>         } else if (rsv_type == 3) {
>>                 cts_time = vnt_get_frame_time(priv->preamble_type,
>> pkt_type,
>> -                                             14,
>> priv->top_cck_basic_rate);
>> +                                               14,
>> priv->top_cck_basic_rate);
>>                 ack_time = vnt_get_frame_time(priv->preamble_type,
>> pkt_type,
>> -                                             14,
>> priv->top_ofdm_basic_rate);
>> +                                               14,
>> priv->top_ofdm_basic_rate);
>>
>>                 rrv_time = cts_time + ack_time + data_time + 2 *
>> priv->sifs;
>>
>> @@ -227,7 +229,8 @@ static __le16 vnt_get_rtscts_duration_le(struct
>> vnt_usb_send_context *context,
>>         case RTSDUR_AA_F0:
>>         case RTSDUR_AA_F1:
>>                 cts_time = vnt_get_frame_time(priv->preamble_type,
>> -                                             pkt_type, 14,
>> priv->top_ofdm_basic_rate);
>> +                                               pkt_type, 14,
>> +
>> priv->top_ofdm_basic_rate);
>>                 dur_time = cts_time + 2 * priv->sifs +
>>                         vnt_get_rsvtime(priv, pkt_type,
>>                                         frame_length, rate, need_ack);
>> @@ -410,7 +413,7 @@ static u16 vnt_rxtx_rts_g_head(struct
>> vnt_usb_send_context *tx_context,
>>         u16 current_rate = tx_context->tx_rate;
>>
>>         vnt_get_phy_field(priv, rts_frame_len, priv->top_cck_basic_rate,
>> -                         PK_TYPE_11B, &buf->b);
>> +                               PK_TYPE_11B, &buf->b);
>>         vnt_get_phy_field(priv, rts_frame_len, priv->top_ofdm_basic_rate,
>>                           tx_context->pkt_type, &buf->a);
>>
>> @@ -437,7 +440,7 @@ static u16 vnt_rxtx_rts_g_fb_head(struct
>> vnt_usb_send_context *tx_context,
>>         u16 rts_frame_len = 20;
>>
>>         vnt_get_phy_field(priv, rts_frame_len, priv->top_cck_basic_rate,
>> -                         PK_TYPE_11B, &buf->b);
>> +                               PK_TYPE_11B, &buf->b);
>>         vnt_get_phy_field(priv, rts_frame_len, priv->top_ofdm_basic_rate,
>>                           tx_context->pkt_type, &buf->a);
>>
>> @@ -683,9 +686,9 @@ static u16 vnt_rxtx_ab(struct vnt_usb_send_context
>> *tx_context,
>>  }
>>
>>  static u16 vnt_generate_tx_parameter(struct vnt_usb_send_context
>> *tx_context,
>> -                                     struct vnt_tx_buffer *tx_buffer,
>> -                                     struct vnt_mic_hdr **mic_hdr, u32
>> need_mic,
>> -                                     bool need_rts)
>> +                                       struct vnt_tx_buffer *tx_buffer,
>> +                                       struct vnt_mic_hdr **mic_hdr,
>> +                                       u32 need_mic, bool need_rts)
>>  {
>>
>>         if (tx_context->pkt_type == PK_TYPE_11GB ||
>> @@ -1024,7 +1027,7 @@ static int vnt_beacon_xmit(struct vnt_private *priv,
>>
>>                 /* Get SignalField,ServiceField,Length */
>>                 vnt_get_phy_field(priv, frame_size, current_rate,
>> -                                 PK_TYPE_11A, &short_head->ab);
>> +                                       PK_TYPE_11A, &short_head->ab);
>>
>>                 /* Get Duration and TimeStampOff */
>>                 short_head->duration = vnt_get_duration_le(priv,
>> @@ -1101,7 +1104,7 @@ int vnt_beacon_make(struct vnt_private *priv, struct
>> ieee80211_vif *vif)
>>  }
>>
>>  int vnt_beacon_enable(struct vnt_private *priv, struct ieee80211_vif
>> *vif,
>> -                      struct ieee80211_bss_conf *conf)
>> +                       struct ieee80211_bss_conf *conf)
>>  {
>>         vnt_mac_reg_bits_off(priv, MAC_REG_TCR, TCR_AUTOBCNTX);
>>
>> --
>> 2.7.4
>>
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] staging: vt6656: fixed an indentation coding style issue
  2017-03-25 12:10 [PATCH v2] staging: vt6656: fixed an indentation coding style issue Prasant Jalan
       [not found] ` <CA+XqjF9=VwTnp19cnwNpnDZ1a7HKOxcaL6BqJa5rcZNBrf-yjQ@mail.gmail.com>
@ 2017-04-08 10:50 ` Greg KH
  1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2017-04-08 10:50 UTC (permalink / raw)
  To: Prasant Jalan
  Cc: forest, arushisinghal19971997, devel, johannes.berg,
	linux-kernel, michael.schacht.hansen

On Sat, Mar 25, 2017 at 05:40:48PM +0530, Prasant Jalan wrote:
> 
> Replacing spaces with tabs for indetation to fix checkpatch.pl error
> "code indent should use tabs where possible".
> 
> 
> Signed-off-by: Prasant Jalan <prasant.jalan@gmail.com>
> ---
> 
>   v2:
>     - improved changelog comments
>     - fixed only one issue
> 
> 
>  drivers/staging/vt6656/rxtx.c | 35 +++++++++++++++++++----------------
>  1 file changed, 19 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
> index 1835cd1..7ebd1ee 100644
> --- a/drivers/staging/vt6656/rxtx.c
> +++ b/drivers/staging/vt6656/rxtx.c
> @@ -114,7 +114,7 @@ static __le16 vnt_time_stamp_off(struct vnt_private *priv, u16 rate)
>  }
>  
>  static u32 vnt_get_rsvtime(struct vnt_private *priv, u8 pkt_type,
> -	                    u32 frame_length, u16 rate, int need_ack)
> +				u32 frame_length, u16 rate, int need_ack)

No, it should look like:

			      u32 frame_length, u16 rate, int need_ack)

Please fix them up that way.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] staging: vt6656: fixed an indentation coding style issue
@ 2017-03-27 23:32 Prasant Jalan
  0 siblings, 0 replies; 4+ messages in thread
From: Prasant Jalan @ 2017-03-27 23:32 UTC (permalink / raw)
  To: Arushi Singhal
  Cc: forest, Greg KH, johannes.berg, Michael Hansen, driverdevel, LKML

On Sat, Mar 25, 2017 at 6:28 PM, Prasant Jalan <prasant.jalan@gmail.com> wrote:
> On Sat, Mar 25, 2017 at 6:01 PM, Arushi Singhal
> <arushisinghal19971997@gmail.com> wrote:
>>
>>
>> On Sat, Mar 25, 2017 at 5:40 PM, Prasant Jalan <prasant.jalan@gmail.com>
>> wrote:
>>>
>>>
>>> Replacing spaces with tabs for indetation to fix checkpatch.pl error
>>> "code indent should use tabs where possible".
>>
>> I think the commit message should be much more clear as for "code
>> indentation"
>> you are even adding and deleting spaces.
>>>
>>>
>
> Hi Arushi,
>
> Thanks for comments and sorry to bother with a coding style fix patch.
> I'm just trying to learn and felt its an easy one.
>
> I did not understand your comment "adding and deleting spaces".
> I'm only deleting spaces and replacing it with tabs.
> I'm not adding spaces. Could you please clarify.
>
> Regards, Prasant
>
>>>
>>> Signed-off-by: Prasant Jalan <prasant.jalan@gmail.com>
>>> ---
>>>
>>>   v2:
>>>     - improved changelog comments
>>>     - fixed only one issue
>>>
>>>
>>>  drivers/staging/vt6656/rxtx.c | 35 +++++++++++++++++++----------------
>>>  1 file changed, 19 insertions(+), 16 deletions(-)
>>>
>>> diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
>>> index 1835cd1..7ebd1ee 100644
>>> --- a/drivers/staging/vt6656/rxtx.c
>>> +++ b/drivers/staging/vt6656/rxtx.c
>>> @@ -114,7 +114,7 @@ static __le16 vnt_time_stamp_off(struct vnt_private
>>> *priv, u16 rate)
>>>  }
>>>
>>>  static u32 vnt_get_rsvtime(struct vnt_private *priv, u8 pkt_type,
>>> -                           u32 frame_length, u16 rate, int need_ack)
>>> +                               u32 frame_length, u16 rate, int need_ack)
>>>  {
>>>         u32 data_time, ack_time;
>>>
>>> @@ -135,14 +135,16 @@ static u32 vnt_get_rsvtime(struct vnt_private *priv,
>>> u8 pkt_type,
>>>  }
>>>
>>>  static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8
>>> pkt_type,
>>> -                                    u32 frame_length, u16 rate, int
>>> need_ack)
>>> +                                       u32 frame_length, u16 rate,
>>> +                                       int need_ack)
>>>  {
>>>         return cpu_to_le16((u16)vnt_get_rsvtime(priv, pkt_type,
>>>                 frame_length, rate, need_ack));
>>>  }
>>>
>>>  static __le16 vnt_get_rtscts_rsvtime_le(struct vnt_private *priv,
>>> -                                        u8 rsv_type, u8 pkt_type, u32
>>> frame_length, u16 current_rate)
>>> +                                       u8 rsv_type, u8 pkt_type,
>>> +                                       u32 frame_length, u16
>>> current_rate)
>>>  {
>>>         u32 rrv_time, rts_time, cts_time, ack_time, data_time;
>>>
>>> @@ -160,19 +162,19 @@ static __le16 vnt_get_rtscts_rsvtime_le(struct
>>> vnt_private *priv,
>>>                 rts_time = vnt_get_frame_time(priv->preamble_type,
>>>                         pkt_type, 20, priv->top_cck_basic_rate);
>>>                 cts_time = vnt_get_frame_time(priv->preamble_type,
>>> pkt_type,
>>> -                                             14,
>>> priv->top_cck_basic_rate);
>>> +                                               14,
>>> priv->top_cck_basic_rate);
>>>                 ack_time = vnt_get_frame_time(priv->preamble_type,
>>> pkt_type,
>>> -                                             14,
>>> priv->top_ofdm_basic_rate);
>>> +                                               14,
>>> priv->top_ofdm_basic_rate);
>>>         } else if (rsv_type == 2) {
>>>                 rts_time = vnt_get_frame_time(priv->preamble_type,
>>> pkt_type,
>>> -                                             20,
>>> priv->top_ofdm_basic_rate);
>>> +                                               20,
>>> priv->top_ofdm_basic_rate);
>>>                 cts_time = ack_time =
>>> vnt_get_frame_time(priv->preamble_type,
>>>                         pkt_type, 14, priv->top_ofdm_basic_rate);
>>>         } else if (rsv_type == 3) {
>>>                 cts_time = vnt_get_frame_time(priv->preamble_type,
>>> pkt_type,
>>> -                                             14,
>>> priv->top_cck_basic_rate);
>>> +                                               14,
>>> priv->top_cck_basic_rate);
>>>                 ack_time = vnt_get_frame_time(priv->preamble_type,
>>> pkt_type,
>>> -                                             14,
>>> priv->top_ofdm_basic_rate);
>>> +                                               14,
>>> priv->top_ofdm_basic_rate);
>>>
>>>                 rrv_time = cts_time + ack_time + data_time + 2 *
>>> priv->sifs;
>>>
>>> @@ -227,7 +229,8 @@ static __le16 vnt_get_rtscts_duration_le(struct
>>> vnt_usb_send_context *context,
>>>         case RTSDUR_AA_F0:
>>>         case RTSDUR_AA_F1:
>>>                 cts_time = vnt_get_frame_time(priv->preamble_type,
>>> -                                             pkt_type, 14,
>>> priv->top_ofdm_basic_rate);
>>> +                                               pkt_type, 14,
>>> +
>>> priv->top_ofdm_basic_rate);
>>>                 dur_time = cts_time + 2 * priv->sifs +
>>>                         vnt_get_rsvtime(priv, pkt_type,
>>>                                         frame_length, rate, need_ack);
>>> @@ -410,7 +413,7 @@ static u16 vnt_rxtx_rts_g_head(struct
>>> vnt_usb_send_context *tx_context,
>>>         u16 current_rate = tx_context->tx_rate;
>>>
>>>         vnt_get_phy_field(priv, rts_frame_len, priv->top_cck_basic_rate,
>>> -                         PK_TYPE_11B, &buf->b);
>>> +                               PK_TYPE_11B, &buf->b);
>>>         vnt_get_phy_field(priv, rts_frame_len, priv->top_ofdm_basic_rate,
>>>                           tx_context->pkt_type, &buf->a);
>>>
>>> @@ -437,7 +440,7 @@ static u16 vnt_rxtx_rts_g_fb_head(struct
>>> vnt_usb_send_context *tx_context,
>>>         u16 rts_frame_len = 20;
>>>
>>>         vnt_get_phy_field(priv, rts_frame_len, priv->top_cck_basic_rate,
>>> -                         PK_TYPE_11B, &buf->b);
>>> +                               PK_TYPE_11B, &buf->b);
>>>         vnt_get_phy_field(priv, rts_frame_len, priv->top_ofdm_basic_rate,
>>>                           tx_context->pkt_type, &buf->a);
>>>
>>> @@ -683,9 +686,9 @@ static u16 vnt_rxtx_ab(struct vnt_usb_send_context
>>> *tx_context,
>>>  }
>>>
>>>  static u16 vnt_generate_tx_parameter(struct vnt_usb_send_context
>>> *tx_context,
>>> -                                     struct vnt_tx_buffer *tx_buffer,
>>> -                                     struct vnt_mic_hdr **mic_hdr, u32
>>> need_mic,
>>> -                                     bool need_rts)
>>> +                                       struct vnt_tx_buffer *tx_buffer,
>>> +                                       struct vnt_mic_hdr **mic_hdr,
>>> +                                       u32 need_mic, bool need_rts)
>>>  {
>>>
>>>         if (tx_context->pkt_type == PK_TYPE_11GB ||
>>> @@ -1024,7 +1027,7 @@ static int vnt_beacon_xmit(struct vnt_private *priv,
>>>
>>>                 /* Get SignalField,ServiceField,Length */
>>>                 vnt_get_phy_field(priv, frame_size, current_rate,
>>> -                                 PK_TYPE_11A, &short_head->ab);
>>> +                                       PK_TYPE_11A, &short_head->ab);
>>>
>>>                 /* Get Duration and TimeStampOff */
>>>                 short_head->duration = vnt_get_duration_le(priv,
>>> @@ -1101,7 +1104,7 @@ int vnt_beacon_make(struct vnt_private *priv, struct
>>> ieee80211_vif *vif)
>>>  }
>>>
>>>  int vnt_beacon_enable(struct vnt_private *priv, struct ieee80211_vif
>>> *vif,
>>> -                      struct ieee80211_bss_conf *conf)
>>> +                       struct ieee80211_bss_conf *conf)
>>>  {
>>>         vnt_mac_reg_bits_off(priv, MAC_REG_TCR, TCR_AUTOBCNTX);
>>>
>>> --
>>> 2.7.4
>>>
>>


Hi,

A gentle reminder about my patch (sorry again to bother with a coding
style fix only patch).

Regards, Prasant

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-08 10:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-25 12:10 [PATCH v2] staging: vt6656: fixed an indentation coding style issue Prasant Jalan
     [not found] ` <CA+XqjF9=VwTnp19cnwNpnDZ1a7HKOxcaL6BqJa5rcZNBrf-yjQ@mail.gmail.com>
2017-03-25 12:58   ` Prasant Jalan
2017-04-08 10:50 ` Greg KH
2017-03-27 23:32 Prasant Jalan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.