[PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[Wolfram Sang]

Simon,

as Ulf picked up the driver patches for HS200 support, it is now safe to pick
up the DTS patches, I'd say? I rebased them to the dt-for-4.11 branch.

All the best,

   Wolfram


Wolfram Sang (2):
  arm64: dts: r8a7795: enable HS200 for eMMC
  arm64: dts: r8a7796: enable HS200 for eMMC

 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 1 +
 arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 1 +
 2 files changed, 2 insertions(+)

-- 
2.10.2

[PATCH RESEND 1/2] arm64: dts: r8a7795: enable HS200 for eMMC

[Wolfram Sang]

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
index bcaf4008d32d00..b68514041fc4f6 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
@@ -452,6 +452,7 @@
 	vmmc-supply = <&reg_3p3v>;
 	vqmmc-supply = <&reg_1p8v>;
 	bus-width = <8>;
+	mmc-hs200-1_8v;
 	non-removable;
 	status = "okay";
 };
-- 
2.10.2

[PATCH RESEND 2/2] arm64: dts: r8a7796: enable HS200 for eMMC

[Wolfram Sang]

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
index f35e96ca7d6050..5fa6e91953d494 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
@@ -184,6 +184,7 @@
 	vmmc-supply = <&reg_3p3v>;
 	vqmmc-supply = <&reg_1p8v>;
 	bus-width = <8>;
+	mmc-hs200-1_8v;
 	non-removable;
 	status = "okay";
 };
-- 
2.10.2

Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]

On Wed, Jan 04, 2017 at 06:39:52PM +0100, Wolfram Sang wrote:
> Simon,
> 
> as Ulf picked up the driver patches for HS200 support, it is now safe to pick
> up the DTS patches, I'd say? I rebased them to the dt-for-4.11 branch.
> 
> All the best,
> 
>    Wolfram
> 
> 
> Wolfram Sang (2):
>   arm64: dts: r8a7795: enable HS200 for eMMC
>   arm64: dts: r8a7796: enable HS200 for eMMC
> 
>  arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 1 +
>  arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 1 +
>  2 files changed, 2 insertions(+)

Ping :)


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[Simon Horman]

On Thu, Jan 12, 2017 at 11:43:53PM +0100, Wolfram Sang wrote:
> On Wed, Jan 04, 2017 at 06:39:52PM +0100, Wolfram Sang wrote:
> > Simon,
> > 
> > as Ulf picked up the driver patches for HS200 support, it is now safe to pick
> > up the DTS patches, I'd say? I rebased them to the dt-for-4.11 branch.
> > 
> > All the best,
> > 
> >    Wolfram
> > 
> > 
> > Wolfram Sang (2):
> >   arm64: dts: r8a7795: enable HS200 for eMMC
> >   arm64: dts: r8a7796: enable HS200 for eMMC
> > 
> >  arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 1 +
> >  arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 1 +
> >  2 files changed, 2 insertions(+)
> 
> Ping :)

Sorry for missing these.
I have queued them up for v4.11.

Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 75 bytes --]

> Sorry for missing these.
> I have queued them up for v4.11.

Thank you!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[Simon Horman]

On Fri, Jan 13, 2017 at 09:39:28AM +0100, Wolfram Sang wrote:
> > Sorry for missing these.
> > I have queued them up for v4.11.
> 
> Thank you!

On my r8a7796/salvator-x I see the following with this series applied:

sh_mobile_sdhi ee140000.sd: timeout waiting for hardware interrupt (CMD13)

I am currently thinking in terms of dropping this series from v4.11
so we can revisit it for v4.12.

Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

On Thu, Jan 26, 2017 at 11:01:17AM +0100, Simon Horman wrote:
> On Fri, Jan 13, 2017 at 09:39:28AM +0100, Wolfram Sang wrote:
> > > Sorry for missing these.
> > > I have queued them up for v4.11.
> > 
> > Thank you!
> 
> On my r8a7796/salvator-x I see the following with this series applied:
> 
> sh_mobile_sdhi ee140000.sd: timeout waiting for hardware interrupt (CMD13)

Do you have the HS200 enablement patches in that branch? They are
currently in -next.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[Simon Horman]

On Thu, Jan 26, 2017 at 11:03:56AM +0100, Wolfram Sang wrote:
> On Thu, Jan 26, 2017 at 11:01:17AM +0100, Simon Horman wrote:
> > On Fri, Jan 13, 2017 at 09:39:28AM +0100, Wolfram Sang wrote:
> > > > Sorry for missing these.
> > > > I have queued them up for v4.11.
> > > 
> > > Thank you!
> > 
> > On my r8a7796/salvator-x I see the following with this series applied:
> > 
> > sh_mobile_sdhi ee140000.sd: timeout waiting for hardware interrupt (CMD13)
> 
> Do you have the HS200 enablement patches in that branch? They are
> currently in -next.

I tried mmc/next (but didn't notice anything special there).
Which patches should I be looking for?

Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 547 bytes --]


> > Do you have the HS200 enablement patches in that branch? They are
> > currently in -next.
> 
> I tried mmc/next (but didn't notice anything special there).
> Which patches should I be looking for?

The series starting with 59c21074b582aa ("mmc: sh_mobile_sdhi: simplify
accessing DT data") up to 8c81459fa8adec ("mmc: sh_mobile_sdhi: enable
HS200").

Do you already fetch from Ulf's kernel.org tree? He switched away from
the Linaro tree for MMC for a while. I only realized when he complained
that he can't apply my patches.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[Simon Horman]

On Thu, Jan 26, 2017 at 12:36:57PM +0100, Wolfram Sang wrote:
> 
> > > Do you have the HS200 enablement patches in that branch? They are
> > > currently in -next.
> > 
> > I tried mmc/next (but didn't notice anything special there).
> > Which patches should I be looking for?
> 
> The series starting with 59c21074b582aa ("mmc: sh_mobile_sdhi: simplify
> accessing DT data") up to 8c81459fa8adec ("mmc: sh_mobile_sdhi: enable
> HS200").
> 
> Do you already fetch from Ulf's kernel.org tree? He switched away from
> the Linaro tree for MMC for a while. I only realized when he complained
> that he can't apply my patches.

Thanks, I had not realised that. I've pulled the kernel.org tree.

Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]


> > Do you already fetch from Ulf's kernel.org tree? He switched away from
> > the Linaro tree for MMC for a while. I only realized when he complained

"since a while" not "for a while", of course.

> Thanks, I had not realised that. I've pulled the kernel.org tree.

So, there is hope for the patches to be in v4.11? :)


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[Geert Uytterhoeven]

Hi Wolfram,

On Thu, Jan 26, 2017 at 11:03 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Thu, Jan 26, 2017 at 11:01:17AM +0100, Simon Horman wrote:
>> On Fri, Jan 13, 2017 at 09:39:28AM +0100, Wolfram Sang wrote:
>> > > Sorry for missing these.
>> > > I have queued them up for v4.11.
>> >
>> > Thank you!
>>
>> On my r8a7796/salvator-x I see the following with this series applied:
>>
>> sh_mobile_sdhi ee140000.sd: timeout waiting for hardware interrupt (CMD13)
>
> Do you have the HS200 enablement patches in that branch? They are
> currently in -next.

I saw the same thing with renesas-devel last week, only on M3-W.
The same kernel on H3 didn't spew such messages.
According to Shimoda-san, it was due to different eMMCs on H3 and M3-W.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[Simon Horman]

On Thu, Jan 26, 2017 at 02:54:53PM +0100, Wolfram Sang wrote:
> 
> > > Do you already fetch from Ulf's kernel.org tree? He switched away from
> > > the Linaro tree for MMC for a while. I only realized when he complained
> 
> "since a while" not "for a while", of course.
> 
> > Thanks, I had not realised that. I've pulled the kernel.org tree.

I have tested with "the new mmc/next" and things seem better.
The problem does not appear to manifest in light testing.

> So, there is hope for the patches to be in v4.11? :)

On Thu, Jan 26, 2017 at 02:58:58PM +0100, Geert Uytterhoeven wrote:
> Hi Wolfram,
> 
> On Thu, Jan 26, 2017 at 11:03 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
> > On Thu, Jan 26, 2017 at 11:01:17AM +0100, Simon Horman wrote:
> >> On Fri, Jan 13, 2017 at 09:39:28AM +0100, Wolfram Sang wrote:
> >> > > Sorry for missing these.
> >> > > I have queued them up for v4.11.
> >> >
> >> > Thank you!
> >>
> >> On my r8a7796/salvator-x I see the following with this series applied:
> >>
> >> sh_mobile_sdhi ee140000.sd: timeout waiting for hardware interrupt (CMD13)
> >
> > Do you have the HS200 enablement patches in that branch? They are
> > currently in -next.
> 
> I saw the same thing with renesas-devel last week, only on M3-W.
> The same kernel on H3 didn't spew such messages.
> According to Shimoda-san, it was due to different eMMCs on H3 and M3-W.

Thanks, my interpretation of that is that the H3 patch of this series is fine.

I am still of a mind to drop the M3-W patch of this series because unless
we can control the order that things are merged into Linus's tree
there will be a temporary regression there. Moreover I'm not very excited
about renesas-next having regressed.

Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 716 bytes --]


> I have tested with "the new mmc/next" and things seem better.

Good. The issue you saw is expected when you have not the enablement
patches in place.

> I am still of a mind to drop the M3-W patch of this series because unless
> we can control the order that things are merged into Linus's tree
> there will be a temporary regression there. Moreover I'm not very excited
> about renesas-next having regressed.

I have not heard of a regression. Geert, did you report that? Did I miss
that? As you can see, I did test the patches with M3 as well:

http://elinux.org/Tests:eMMC-HS

and Jinso test team (Duc-san) confirmed it works for them with H3 and
M3-W. In private communication, though.

Regards,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[Geert Uytterhoeven]

Hi Wolfram,

On Thu, Jan 26, 2017 at 3:16 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>> I have tested with "the new mmc/next" and things seem better.
>
> Good. The issue you saw is expected when you have not the enablement
> patches in place.
>
>> I am still of a mind to drop the M3-W patch of this series because unless
>> we can control the order that things are merged into Linus's tree
>> there will be a temporary regression there. Moreover I'm not very excited
>> about renesas-next having regressed.
>
> I have not heard of a regression. Geert, did you report that? Did I miss
> that? As you can see, I did test the patches with M3 as well:
>
> http://elinux.org/Tests:eMMC-HS
>
> and Jinso test team (Duc-san) confirmed it works for them with H3 and
> M3-W. In private communication, though.

The issue happened with renesas-devel, i.e. without those patches.
It was mentioned during last core meeting, so have a look at that log.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]


> The issue happened with renesas-devel, i.e. without those patches.
> It was mentioned during last core meeting, so have a look at that log.

No need to. As I said, the behaviour is expected without the patches.
Thanks for the update!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[Simon Horman]

On Thu, Jan 26, 2017 at 03:16:57PM +0100, Wolfram Sang wrote:
> 
> > I have tested with "the new mmc/next" and things seem better.
> 
> Good. The issue you saw is expected when you have not the enablement
> patches in place.
> 
> > I am still of a mind to drop the M3-W patch of this series because unless
> > we can control the order that things are merged into Linus's tree
> > there will be a temporary regression there. Moreover I'm not very excited
> > about renesas-next having regressed.
> 
> I have not heard of a regression. Geert, did you report that? Did I miss
> that? As you can see, I did test the patches with M3 as well:
> 
> http://elinux.org/Tests:eMMC-HS
> 
> and Jinso test team (Duc-san) confirmed it works for them with H3 and
> M3-W. In private communication, though.

The problem I see is the following logged to the console
(which makes the console semi-unusable).

sh_mobile_sdhi ee140000.sd: timeout waiting for hardware interrupt (CMD13)

I'm on IRC if you'd like to chat there.

Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]


> The problem I see is the following logged to the console
> (which makes the console semi-unusable).
> 
> sh_mobile_sdhi ee140000.sd: timeout waiting for hardware interrupt (CMD13)

Just to make sure: with the HS200 enablement patches present?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[Simon Horman]

On Thu, Jan 26, 2017 at 09:17:02PM +0100, Wolfram Sang wrote:
> 
> > The problem I see is the following logged to the console
> > (which makes the console semi-unusable).
> > 
> > sh_mobile_sdhi ee140000.sd: timeout waiting for hardware interrupt (CMD13)
> 
> Just to make sure: with the HS200 enablement patches present?

Using renesas-next without mmc-next I see the problem above on the M3-W.
Using renesas-next with mmc-next I do not see the problem above.
Using v4.10-rc2 I also do not see the problem above.

So I believe we should delay the integration change, which is currently in
renesas-next, until the driver change in mmc-next hits Linus's tree.

Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]


> Using renesas-next without mmc-next I see the problem above on the M3-W.
> Using renesas-next with mmc-next I do not see the problem above.
> Using v4.10-rc2 I also do not see the problem above.

OK. So there is no problem with the code, at least.

> So I believe we should delay the integration change, which is currently in
> renesas-next, until the driver change in mmc-next hits Linus's tree.

Whatever you do, H3 and M3-W should be treated equally IMO.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[Simon Horman]

On Fri, Jan 27, 2017 at 08:27:28AM +0100, Wolfram Sang wrote:
> 
> > Using renesas-next without mmc-next I see the problem above on the M3-W.
> > Using renesas-next with mmc-next I do not see the problem above.
> > Using v4.10-rc2 I also do not see the problem above.
> 
> OK. So there is no problem with the code, at least.
> 
> > So I believe we should delay the integration change, which is currently in
> > renesas-next, until the driver change in mmc-next hits Linus's tree.
> 
> Whatever you do, H3 and M3-W should be treated equally IMO.

Sure, that is reasonable. This is what I plan to do:

1. Drop this series from v4.11
2. Re-queue them for v4.12 once the driver changes hit an rc release
   - Please ping me one that happens

Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 981 bytes --]

Hi Simon,

On Fri, Jan 27, 2017 at 09:16:08AM +0100, Simon Horman wrote:
> On Fri, Jan 27, 2017 at 08:27:28AM +0100, Wolfram Sang wrote:
> > 
> > > Using renesas-next without mmc-next I see the problem above on the M3-W.
> > > Using renesas-next with mmc-next I do not see the problem above.
> > > Using v4.10-rc2 I also do not see the problem above.
> > 
> > OK. So there is no problem with the code, at least.
> > 
> > > So I believe we should delay the integration change, which is currently in
> > > renesas-next, until the driver change in mmc-next hits Linus's tree.
> > 
> > Whatever you do, H3 and M3-W should be treated equally IMO.
> 
> Sure, that is reasonable. This is what I plan to do:
> 
> 1. Drop this series from v4.11
> 2. Re-queue them for v4.12 once the driver changes hit an rc release
>    - Please ping me one that happens

Ping :) Do I need to resend? If so, what branch should I base this on?

Have a nice weekend,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 136 bytes --]

>    - Please ping me one that happens

Well, to ease and speed up things, I'll simply resend in a minute based
on arm64-dt-for-v4.12.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]