* [PATCH] drm/amdgpu: Fix firmware UCODE_ID_STORAGE issue
@ 2017-04-10 6:45 Trigger Huang
[not found] ` <1491806749-15101-1-git-send-email-trigger.huang-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Trigger Huang @ 2017-04-10 6:45 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: ray.huang-5C7GfCeVMHo, Trigger Huang
In Tonga's virtualization environment, for firmware UCODE_ID_STORAGE,
there is no actual firmware data, but we still need alloc a BO and
tell the BO's mc address to HW, or world switch will hang on VFs.
Signed-off-by: Trigger Huang <trigger.huang@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
index a1891c9..b7307b0 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
@@ -383,7 +383,7 @@ int amdgpu_ucode_init_bo(struct amdgpu_device *adev)
* ucode info here
*/
if (adev->firmware.load_type != AMDGPU_FW_LOAD_PSP)
- adev->firmware.max_ucodes = AMDGPU_UCODE_ID_MAXIMUM - 4;
+ adev->firmware.max_ucodes = AMDGPU_UCODE_ID_MAXIMUM - 3;
else
adev->firmware.max_ucodes = AMDGPU_UCODE_ID_MAXIMUM;
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: Fix firmware UCODE_ID_STORAGE issue
[not found] ` <1491806749-15101-1-git-send-email-trigger.huang-5C7GfCeVMHo@public.gmane.org>
@ 2017-04-10 6:52 ` Huang Rui
2017-04-11 5:44 ` 答复: " Liu, Monk
2017-04-11 5:36 ` Yu, Xiangliang
1 sibling, 1 reply; 4+ messages in thread
From: Huang Rui @ 2017-04-10 6:52 UTC (permalink / raw)
To: Trigger Huang; +Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On Mon, Apr 10, 2017 at 02:45:49PM +0800, Trigger Huang wrote:
> In Tonga's virtualization environment, for firmware UCODE_ID_STORAGE,
> there is no actual firmware data, but we still need alloc a BO and
> tell the BO's mc address to HW, or world switch will hang on VFs.
>
> Signed-off-by: Trigger Huang <trigger.huang@amd.com>
> ---
Acked-by: Huang Rui <ray.huang@amd.com>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c b/drivers/gpu/drm/amd/
> amdgpu/amdgpu_ucode.c
> index a1891c9..b7307b0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> @@ -383,7 +383,7 @@ int amdgpu_ucode_init_bo(struct amdgpu_device *adev)
> * ucode info here
> */
> if (adev->firmware.load_type != AMDGPU_FW_LOAD_PSP)
> - adev->firmware.max_ucodes = AMDGPU_UCODE_ID_MAXIMUM - 4;
> + adev->firmware.max_ucodes = AMDGPU_UCODE_ID_MAXIMUM - 3;
> else
> adev->firmware.max_ucodes = AMDGPU_UCODE_ID_MAXIMUM;
>
> --
> 2.7.4
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] drm/amdgpu: Fix firmware UCODE_ID_STORAGE issue
[not found] ` <1491806749-15101-1-git-send-email-trigger.huang-5C7GfCeVMHo@public.gmane.org>
2017-04-10 6:52 ` Huang Rui
@ 2017-04-11 5:36 ` Yu, Xiangliang
1 sibling, 0 replies; 4+ messages in thread
From: Yu, Xiangliang @ 2017-04-11 5:36 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Huang, Ray, Huang, Trigger
Reviewed-by: Xiangliang Yu <Xiangliang.Yu@amd.com>
> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf
> Of Trigger Huang
> Sent: Monday, April 10, 2017 2:46 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Huang, Ray <Ray.Huang@amd.com>; Huang, Trigger
> <Trigger.Huang@amd.com>
> Subject: [PATCH] drm/amdgpu: Fix firmware UCODE_ID_STORAGE issue
>
> In Tonga's virtualization environment, for firmware UCODE_ID_STORAGE,
> there is no actual firmware data, but we still need alloc a BO and tell the BO's
> mc address to HW, or world switch will hang on VFs.
>
> Signed-off-by: Trigger Huang <trigger.huang@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> index a1891c9..b7307b0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> @@ -383,7 +383,7 @@ int amdgpu_ucode_init_bo(struct amdgpu_device
> *adev)
> * ucode info here
> */
> if (adev->firmware.load_type != AMDGPU_FW_LOAD_PSP)
> - adev->firmware.max_ucodes =
> AMDGPU_UCODE_ID_MAXIMUM - 4;
> + adev->firmware.max_ucodes =
> AMDGPU_UCODE_ID_MAXIMUM - 3;
> else
> adev->firmware.max_ucodes =
> AMDGPU_UCODE_ID_MAXIMUM;
>
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* 答复: [PATCH] drm/amdgpu: Fix firmware UCODE_ID_STORAGE issue
2017-04-10 6:52 ` Huang Rui
@ 2017-04-11 5:44 ` Liu, Monk
0 siblings, 0 replies; 4+ messages in thread
From: Liu, Monk @ 2017-04-11 5:44 UTC (permalink / raw)
To: Huang, Ray, Huang, Trigger; +Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Don't change bare-metal logic, so please use amdgpu_sriov_vf() to differentiate -4 or -4 for the ID_MAXIMUM
With that addressed, this patch is :
Reviewed-by: Monk Liu <monk.liu@amd.com>
-----邮件原件-----
发件人: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] 代表 Huang Rui
发送时间: Monday, April 10, 2017 2:52 PM
收件人: Huang, Trigger <Trigger.Huang@amd.com>
抄送: amd-gfx@lists.freedesktop.org
主题: Re: [PATCH] drm/amdgpu: Fix firmware UCODE_ID_STORAGE issue
On Mon, Apr 10, 2017 at 02:45:49PM +0800, Trigger Huang wrote:
> In Tonga's virtualization environment, for firmware UCODE_ID_STORAGE,
> there is no actual firmware data, but we still need alloc a BO and
> tell the BO's mc address to HW, or world switch will hang on VFs.
>
> Signed-off-by: Trigger Huang <trigger.huang@amd.com>
> ---
Acked-by: Huang Rui <ray.huang@amd.com>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> b/drivers/gpu/drm/amd/ amdgpu/amdgpu_ucode.c index a1891c9..b7307b0
> 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> @@ -383,7 +383,7 @@ int amdgpu_ucode_init_bo(struct amdgpu_device *adev)
> * ucode info here
> */
> if (adev->firmware.load_type != AMDGPU_FW_LOAD_PSP)
> - adev->firmware.max_ucodes = AMDGPU_UCODE_ID_MAXIMUM - 4;
> + adev->firmware.max_ucodes = AMDGPU_UCODE_ID_MAXIMUM -
> + 3;
> else
> adev->firmware.max_ucodes = AMDGPU_UCODE_ID_MAXIMUM;
>
> --
> 2.7.4
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-11 5:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-10 6:45 [PATCH] drm/amdgpu: Fix firmware UCODE_ID_STORAGE issue Trigger Huang
[not found] ` <1491806749-15101-1-git-send-email-trigger.huang-5C7GfCeVMHo@public.gmane.org>
2017-04-10 6:52 ` Huang Rui
2017-04-11 5:44 ` 答复: " Liu, Monk
2017-04-11 5:36 ` Yu, Xiangliang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.