[Qemu-devel] [PATCH] Removed trailing newline from error_report()

[Qemu-devel] [PATCH] Removed trailing newline from error_report()

[Ishani Chugh]

Signed-off-by: Ishani Chugh <chugh.ishani@research.iiit.ac.in>
---
 target/arm/kvm64.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c
index 6111109..a16abc8 100644
--- a/target/arm/kvm64.c
+++ b/target/arm/kvm64.c
@@ -940,7 +940,7 @@ bool kvm_arm_handle_debug(CPUState *cs, struct kvm_debug_exit_arch *debug_exit)
              * single step at this point so something has gone wrong.
              */
             error_report("%s: guest single-step while debugging unsupported"
-                         " (%"PRIx64", %"PRIx32")\n",
+                         " (%"PRIx64", %"PRIx32")",
                          __func__, env->pc, debug_exit->hsr);
             return false;
         }
@@ -965,7 +965,7 @@ bool kvm_arm_handle_debug(CPUState *cs, struct kvm_debug_exit_arch *debug_exit)
         break;
     }
     default:
-        error_report("%s: unhandled debug exit (%"PRIx32", %"PRIx64")\n",
+        error_report("%s: unhandled debug exit (%"PRIx32", %"PRIx64")",
                      __func__, debug_exit->hsr, env->pc);
     }
 
-- 
2.7.4

Re: [Qemu-devel] [PATCH] Removed trailing newline from error_report()

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 901 bytes --]

On Sat, Apr 08, 2017 at 11:09:47AM +0530, Ishani Chugh wrote:
> Signed-off-by: Ishani Chugh <chugh.ishani@research.iiit.ac.in>
> ---
>  target/arm/kvm64.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks for the patch!

I have CCed Peter Maydell who maintains this source file.  I also added
the trivial patches mailing list - a patch queue for small patches.

Conventially QEMU commit messages are written like this:

  target-arm: remove trailing newline from error_report()

The "target-arm:" prefix names the subsystem that is affected.  It makes
it easier for maintainer or people searching through patches to find
relevant results.

The commit message is written in the present imperative - "remove X"
instead of "removed X".

You do not need to resend the patch.  The maintainer can fix up the
commit message if they like.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [Qemu-devel] [PATCH] Removed trailing newline from error_report()

[Peter Maydell]

On 10 April 2017 at 11:22, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Sat, Apr 08, 2017 at 11:09:47AM +0530, Ishani Chugh wrote:
>> Signed-off-by: Ishani Chugh <chugh.ishani@research.iiit.ac.in>
>> ---
>>  target/arm/kvm64.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Thanks for the patch!
>
> I have CCed Peter Maydell who maintains this source file.  I also added
> the trivial patches mailing list - a patch queue for small patches.

I've applied this patch to my target-arm queue (with commit message
tweak as Stefan suggests) -- thanks!

-- PMM