[LTP] [PATCH v1 1/1] syscalls/splice05: add test for splice() between pipe and socket

[LTP] [PATCH v1 1/1] syscalls/splice05: add test for splice() between pipe and socket

[bxue]

From: Boyang Xue <bxue@redhat.com>

This test case covers splice operation between pipe and socket.

Signed-off-by: Boyang Xue <bxue@redhat.com>
---
 runtest/syscalls                            |   1 +
 testcases/kernel/syscalls/splice/splice05.c | 113 ++++++++++++++++++++++++++++
 2 files changed, 114 insertions(+)
 create mode 100644 testcases/kernel/syscalls/splice/splice05.c

diff --git a/runtest/syscalls b/runtest/syscalls
index 15ae66e..48b32d6 100644
--- a/runtest/syscalls
+++ b/runtest/syscalls
@@ -1222,6 +1222,7 @@ sockioctl01 sockioctl01
 splice01 splice01
 splice02 seq 1 20000 | splice02 splice02-temp
 splice03 splice03
+splice05 splice05
 
 tee01 tee01
 tee02 tee02
diff --git a/testcases/kernel/syscalls/splice/splice05.c b/testcases/kernel/syscalls/splice/splice05.c
new file mode 100644
index 0000000..7db4c31
--- /dev/null
+++ b/testcases/kernel/syscalls/splice/splice05.c
@@ -0,0 +1,113 @@
+/*
+ * Copyright (c) 2017 Red Hat, Inc.
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Author: Boyang Xue <bxue@redhat.com>
+ */
+
+/*
+ * Functional test for splice(2): pipe <-> socket
+ *
+ * This test case tests splice(2) from a pipe to a socket and vice versa
+ */
+
+#define _GNU_SOURCE
+#include <sys/types.h>
+#include <sys/socket.h>
+#include <sys/stat.h>
+#include <sys/wait.h>
+#include <fcntl.h>
+#include <stdlib.h>
+#include <unistd.h>
+#include "tst_test.h"
+
+#define MAX_DATA_LEN (64*1024)
+
+static void setup(void);
+static void cleanup(void);
+static void pipe_socket(void);
+
+static char *arr_in, *arr_out;
+static char *str_len_data;
+static int num_len_data = MAX_DATA_LEN;
+static int pp0[2], pp1[2], sv[2];
+
+static struct tst_option options[] = {
+	{"l:", &str_len_data, "-l <num> Length of test data (in bytes)"},
+	{NULL, NULL, NULL},
+};
+
+static void setup(void)
+{
+	int i;
+
+	if (tst_parse_int(str_len_data, &num_len_data, 1, MAX_DATA_LEN))
+		tst_brk(TBROK, "Invalid length of data: '%s'", str_len_data);
+	tst_res(TINFO, "splice size = %d\n", num_len_data);
+
+	arr_in = SAFE_MALLOC(num_len_data);
+	for (i = 0; i < num_len_data; i++)
+		arr_in[i] = i & 0xff;
+}
+
+static void cleanup(void)
+{
+	int i;
+
+	free(arr_in);
+	free(arr_out);
+
+	for (i = 0; i < 2; i++) {
+		SAFE_CLOSE(pp0[i]);
+		SAFE_CLOSE(pp1[i]);
+		SAFE_CLOSE(sv[i]);
+	}
+}
+
+static void pipe_socket(void)
+{
+	int i;
+
+	SAFE_PIPE(pp0);
+	SAFE_PIPE(pp1);
+	if (socketpair(AF_UNIX, SOCK_STREAM, 0, sv))
+		tst_brk(TBROK, "fail to create socket pair.");
+
+	SAFE_WRITE(1, pp0[1], arr_in, num_len_data);
+	if (splice(pp0[0], NULL, sv[0], 0, num_len_data, SPLICE_F_MOVE) != num_len_data)
+		tst_res(TFAIL, "incomplete splice operation.");
+	if (splice(sv[1], 0, pp1[1], NULL, num_len_data, SPLICE_F_MOVE) != num_len_data)
+		tst_res(TFAIL, "incomplete splice operation.");
+	arr_out = SAFE_MALLOC(num_len_data);
+	SAFE_READ(1, pp1[0], arr_out, num_len_data);
+
+	for (i = 0; i < num_len_data; i++) {
+		if (arr_in[i] != arr_out[i]) {
+			tst_res(TFAIL, "splice(2): pipe <-> socket fails.");
+			return;
+		}
+	}
+	tst_res(TPASS, "splice(2): pipe <-> socket run pass.");
+	return;
+}
+
+static struct tst_test test = {
+	.tid = "splice05",
+	.test_all = pipe_socket,
+	.setup = setup,
+	.cleanup = cleanup,
+	.options = options,
+	.min_kver = "2.6.17"
+};
-- 
1.8.3.1

[LTP] [PATCH v1 1/1] syscalls/splice05: add test for splice() between pipe and socket

[Cyril Hrubis]

Hi!
> +#define MAX_DATA_LEN (64*1024)
> +
> +static void setup(void);
> +static void cleanup(void);
> +static void pipe_socket(void);

These function prototypes are useless.

> +static char *arr_in, *arr_out;
> +static char *str_len_data;
> +static int num_len_data = MAX_DATA_LEN;
> +static int pp0[2], pp1[2], sv[2];
> +
> +static struct tst_option options[] = {
> +	{"l:", &str_len_data, "-l <num> Length of test data (in bytes)"},
> +	{NULL, NULL, NULL},
> +};
> +
> +static void setup(void)
> +{
> +	int i;
> +
> +	if (tst_parse_int(str_len_data, &num_len_data, 1, MAX_DATA_LEN))
> +		tst_brk(TBROK, "Invalid length of data: '%s'", str_len_data);
> +	tst_res(TINFO, "splice size = %d\n", num_len_data);
                                         ^
					 Second newline here as well.

> +	arr_in = SAFE_MALLOC(num_len_data);
> +	for (i = 0; i < num_len_data; i++)
> +		arr_in[i] = i & 0xff;
> +}
> +
> +static void cleanup(void)
> +{
> +	int i;
> +
> +	free(arr_in);
> +	free(arr_out);
> +
> +	for (i = 0; i < 2; i++) {
> +		SAFE_CLOSE(pp0[i]);
> +		SAFE_CLOSE(pp1[i]);
> +		SAFE_CLOSE(sv[i]);
> +	}

If you open the pipes/sockets in the test function you have to close it
there in case that the test function is executed in a loop. Otherwise
the test may fail when file descriptors are used up.

> +}
> +
> +static void pipe_socket(void)
> +{
> +	int i;
> +
> +	SAFE_PIPE(pp0);
> +	SAFE_PIPE(pp1);
> +	if (socketpair(AF_UNIX, SOCK_STREAM, 0, sv))
> +		tst_brk(TBROK, "fail to create socket pair.");
                         ^
			 We should print errno with TERRNO here.

> +	SAFE_WRITE(1, pp0[1], arr_in, num_len_data);
> +	if (splice(pp0[0], NULL, sv[0], 0, num_len_data, SPLICE_F_MOVE) != num_len_data)
> +		tst_res(TFAIL, "incomplete splice operation.");
> +	if (splice(sv[1], 0, pp1[1], NULL, num_len_data, SPLICE_F_MOVE) != num_len_data)
> +		tst_res(TFAIL, "incomplete splice operation.");

Here as well we should print the splice return value and errno.

> +	arr_out = SAFE_MALLOC(num_len_data);

Why do we allocate the arr_out here insetad of setup?

> +	SAFE_READ(1, pp1[0], arr_out, num_len_data);
> +
> +	for (i = 0; i < num_len_data; i++) {
> +		if (arr_in[i] != arr_out[i]) {
> +			tst_res(TFAIL, "splice(2): pipe <-> socket fails.");

Here as well you may print more info about the buffer.

> +			return;
> +		}
> +	}
> +	tst_res(TPASS, "splice(2): pipe <-> socket run pass.");
> +	return;

Useless return here as well.

> +}
> +
> +static struct tst_test test = {
> +	.tid = "splice05",
> +	.test_all = pipe_socket,
> +	.setup = setup,
> +	.cleanup = cleanup,
> +	.options = options,
> +	.min_kver = "2.6.17"
> +};
> -- 
> 1.8.3.1
> 
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp

-- 
Cyril Hrubis
chrubis@suse.cz