* [PATCH] input: soc_button_array: Properly map usage-page 7 usage 0xe3 to KEY_LEFTMETA
@ 2017-04-10 19:36 Hans de Goede
2017-04-11 3:36 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2017-04-10 19:36 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Hans de Goede, linux-input, russianneuromancer
When submitting the support for the ACPI0011 windows tablet keys device
I mapped the "windows" logo homekey to KEY_HOMEPAGE. But this is
inconsistent with how it is done on windows tablets using the
old PNP0C40 ACPI device and it does not match the Hut spec, which says
that usage-page 7 usage 0xe3 is "Keyboard Left GUI".
This commit maps usage-page 7 usage 0xe3 to KEY_LEFTMETA fixing this.
Cc: russianneuromancer@ya.ru
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/input/misc/soc_button_array.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c
index d75a8a3..e1d42f1 100644
--- a/drivers/input/misc/soc_button_array.c
+++ b/drivers/input/misc/soc_button_array.c
@@ -187,7 +187,7 @@ static int soc_button_parse_btn_desc(struct device *dev,
info->wakeup = true;
} else if (upage == 0x07 && usage == 0xe3) {
info->name = "home";
- info->event_code = KEY_HOMEPAGE;
+ info->event_code = KEY_LEFTMETA;
info->wakeup = true;
} else if (upage == 0x0c && usage == 0xe9) {
info->name = "volume_up";
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] input: soc_button_array: Properly map usage-page 7 usage 0xe3 to KEY_LEFTMETA
2017-04-10 19:36 [PATCH] input: soc_button_array: Properly map usage-page 7 usage 0xe3 to KEY_LEFTMETA Hans de Goede
@ 2017-04-11 3:36 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2017-04-11 3:36 UTC (permalink / raw)
To: Hans de Goede; +Cc: linux-input, russianneuromancer
On Mon, Apr 10, 2017 at 09:36:45PM +0200, Hans de Goede wrote:
> When submitting the support for the ACPI0011 windows tablet keys device
> I mapped the "windows" logo homekey to KEY_HOMEPAGE. But this is
> inconsistent with how it is done on windows tablets using the
> old PNP0C40 ACPI device and it does not match the Hut spec, which says
> that usage-page 7 usage 0xe3 is "Keyboard Left GUI".
>
> This commit maps usage-page 7 usage 0xe3 to KEY_LEFTMETA fixing this.
>
> Cc: russianneuromancer@ya.ru
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Applied, thank you.
> ---
> drivers/input/misc/soc_button_array.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c
> index d75a8a3..e1d42f1 100644
> --- a/drivers/input/misc/soc_button_array.c
> +++ b/drivers/input/misc/soc_button_array.c
> @@ -187,7 +187,7 @@ static int soc_button_parse_btn_desc(struct device *dev,
> info->wakeup = true;
> } else if (upage == 0x07 && usage == 0xe3) {
> info->name = "home";
> - info->event_code = KEY_HOMEPAGE;
> + info->event_code = KEY_LEFTMETA;
> info->wakeup = true;
> } else if (upage == 0x0c && usage == 0xe9) {
> info->name = "volume_up";
> --
> 2.9.3
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-11 3:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-10 19:36 [PATCH] input: soc_button_array: Properly map usage-page 7 usage 0xe3 to KEY_LEFTMETA Hans de Goede
2017-04-11 3:36 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.