All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Todd Poynor <toddpoynor@gmail.com>
Cc: Li Zefan <lizefan@huawei.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	cgroups@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org, kernel-team@android.com,
	Todd Poynor <toddpoynor@google.com>
Subject: Re: [PATCH v2] cgroup: move cgroup_subsys_state parent field for cache locality
Date: Tue, 11 Apr 2017 09:05:23 +0900	[thread overview]
Message-ID: <20170411000523.GD28603@wtj.duckdns.org> (raw)
In-Reply-To: <1491529677-707-1-git-send-email-todd@tjlinux.dyndns.org>

Hello,

On Thu, Apr 06, 2017 at 06:47:57PM -0700, Todd Poynor wrote:
> From: Todd Poynor <toddpoynor@google.com>
> 
> Various structures embed a struct cgroup_subsys_state, typically at
> the top of the containing structure.  It is common for code that
> accesses the structures to perform operations that iterate over the
> chain of parent css pointers, also accessing data in each containing
> structure.  In particular, struct cpuacct is used by fairly hot code
> paths in the scheduler such as cpuacct_charge().
> 
> Move the parent css pointer field to the end of the structure to
> increase the chances of residing in the same cache line as the data
> from the containing structure.
> 
> Signed-off-by: Todd Poynor <toddpoynor@google.com>

Applied to cgroup/for-4.12.

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Todd Poynor <toddpoynor-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kernel-team-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org,
	Todd Poynor <toddpoynor-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v2] cgroup: move cgroup_subsys_state parent field for cache locality
Date: Tue, 11 Apr 2017 09:05:23 +0900	[thread overview]
Message-ID: <20170411000523.GD28603@wtj.duckdns.org> (raw)
In-Reply-To: <1491529677-707-1-git-send-email-todd-PpDmNYGCFmmZ9vWoFJJngh2eb7JE58TQ@public.gmane.org>

Hello,

On Thu, Apr 06, 2017 at 06:47:57PM -0700, Todd Poynor wrote:
> From: Todd Poynor <toddpoynor-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
> 
> Various structures embed a struct cgroup_subsys_state, typically at
> the top of the containing structure.  It is common for code that
> accesses the structures to perform operations that iterate over the
> chain of parent css pointers, also accessing data in each containing
> structure.  In particular, struct cpuacct is used by fairly hot code
> paths in the scheduler such as cpuacct_charge().
> 
> Move the parent css pointer field to the end of the structure to
> increase the chances of residing in the same cache line as the data
> from the containing structure.
> 
> Signed-off-by: Todd Poynor <toddpoynor-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>

Applied to cgroup/for-4.12.

Thanks.

-- 
tejun

  reply	other threads:[~2017-04-11  0:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-07  1:47 [PATCH v2] cgroup: move cgroup_subsys_state parent field for cache locality Todd Poynor
2017-04-07  1:47 ` Todd Poynor
2017-04-11  0:05 ` Tejun Heo [this message]
2017-04-11  0:05   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170411000523.GD28603@wtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=toddpoynor@gmail.com \
    --cc=toddpoynor@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.