* [PATCH] staging: rtl8723bs: Add missing include <linux/of.h> to fix compile error
@ 2017-04-10 19:13 Hans de Goede
2017-04-11 0:03 ` Stephen Rothwell
2017-04-11 5:17 ` Greg Kroah-Hartman
0 siblings, 2 replies; 3+ messages in thread
From: Hans de Goede @ 2017-04-10 19:13 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Hans de Goede, Bastien Nocera, Larry Finger, linux-wireless,
Stephen Rothwell
As reported by Stephen Rothwell when merging staging-next,
drivers/staging/rtl8723bs/core/rtw_ieee80211.c does not compile due
to of_get_property not being declared.
Explicitly include <linux/of.h> to fix this compile error.
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
index af44a8c..74f5ee0 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
@@ -16,7 +16,7 @@
#include <drv_types.h>
#include <rtw_debug.h>
-
+#include <linux/of.h>
u8 RTW_WPA_OUI_TYPE[] = { 0x00, 0x50, 0xf2, 1 };
u16 RTW_WPA_VERSION = 1;
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8723bs: Add missing include <linux/of.h> to fix compile error
2017-04-10 19:13 [PATCH] staging: rtl8723bs: Add missing include <linux/of.h> to fix compile error Hans de Goede
@ 2017-04-11 0:03 ` Stephen Rothwell
2017-04-11 5:17 ` Greg Kroah-Hartman
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2017-04-11 0:03 UTC (permalink / raw)
To: Hans de Goede
Cc: Greg Kroah-Hartman, Bastien Nocera, Larry Finger, linux-wireless
Hi Hans,
On Mon, 10 Apr 2017 21:13:07 +0200 Hans de Goede <hdegoede@redhat.com> wrote:
>
> As reported by Stephen Rothwell when merging staging-next,
> drivers/staging/rtl8723bs/core/rtw_ieee80211.c does not compile due
> to of_get_property not being declared.
>
> Explicitly include <linux/of.h> to fix this compile error.
>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> index af44a8c..74f5ee0 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> @@ -16,7 +16,7 @@
>
> #include <drv_types.h>
> #include <rtw_debug.h>
> -
> +#include <linux/of.h>
>
> u8 RTW_WPA_OUI_TYPE[] = { 0x00, 0x50, 0xf2, 1 };
> u16 RTW_WPA_VERSION = 1;
> --
> 2.9.3
I will add this to linux-next today.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8723bs: Add missing include <linux/of.h> to fix compile error
2017-04-10 19:13 [PATCH] staging: rtl8723bs: Add missing include <linux/of.h> to fix compile error Hans de Goede
2017-04-11 0:03 ` Stephen Rothwell
@ 2017-04-11 5:17 ` Greg Kroah-Hartman
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2017-04-11 5:17 UTC (permalink / raw)
To: Hans de Goede
Cc: Bastien Nocera, Larry Finger, linux-wireless, Stephen Rothwell
On Mon, Apr 10, 2017 at 09:13:07PM +0200, Hans de Goede wrote:
> As reported by Stephen Rothwell when merging staging-next,
> drivers/staging/rtl8723bs/core/rtw_ieee80211.c does not compile due
> to of_get_property not being declared.
>
> Explicitly include <linux/of.h> to fix this compile error.
>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
You should use "Reported-by:" here in the future...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-11 5:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-10 19:13 [PATCH] staging: rtl8723bs: Add missing include <linux/of.h> to fix compile error Hans de Goede
2017-04-11 0:03 ` Stephen Rothwell
2017-04-11 5:17 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.