* [PATCH] Make PPS into a menuconfig to ease disabling
@ 2017-04-11 14:26 Vincent Legoll
2017-05-06 10:33 ` Vincent Legoll
2017-05-09 12:06 ` Rodolfo Giometti
0 siblings, 2 replies; 3+ messages in thread
From: Vincent Legoll @ 2017-04-11 14:26 UTC (permalink / raw)
To: Rodolfo Giometti, gregkh, linux-kernel; +Cc: Vincent Legoll
So that there's no need to get into the submenu to disable all related config
entries.
The BROKEN PPS_GENERATOR_PARPORT now also depends on PPS
Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
---
drivers/pps/Kconfig | 12 +++---------
drivers/pps/clients/Kconfig | 6 ++----
drivers/pps/generators/Kconfig | 3 ++-
3 files changed, 7 insertions(+), 14 deletions(-)
diff --git a/drivers/pps/Kconfig b/drivers/pps/Kconfig
index 564a51a..4b29a71 100644
--- a/drivers/pps/Kconfig
+++ b/drivers/pps/Kconfig
@@ -2,9 +2,7 @@
# PPS support configuration
#
-menu "PPS support"
-
-config PPS
+menuconfig PPS
tristate "PPS support"
---help---
PPS (Pulse Per Second) is a special pulse provided by some GPS
@@ -20,10 +18,10 @@ config PPS
To compile this driver as a module, choose M here: the module
will be called pps_core.ko.
-if PPS
config PPS_DEBUG
bool "PPS debugging messages"
+ depends on PPS
help
Say Y here if you want the PPS support to produce a bunch of debug
messages to the system log. Select this if you are having a
@@ -31,17 +29,13 @@ config PPS_DEBUG
config NTP_PPS
bool "PPS kernel consumer support"
- depends on !NO_HZ_COMMON
+ depends on PPS && !NO_HZ_COMMON
help
This option adds support for direct in-kernel time
synchronization using an external PPS signal.
It doesn't work on tickless systems at the moment.
-endif
-
source drivers/pps/clients/Kconfig
source drivers/pps/generators/Kconfig
-
-endmenu
diff --git a/drivers/pps/clients/Kconfig b/drivers/pps/clients/Kconfig
index 0c9f280..efec021 100644
--- a/drivers/pps/clients/Kconfig
+++ b/drivers/pps/clients/Kconfig
@@ -2,12 +2,12 @@
# PPS clients configuration
#
-if PPS
-
comment "PPS clients support"
+ depends on PPS
config PPS_CLIENT_KTIMER
tristate "Kernel timer client (Testing client, use for debug)"
+ depends on PPS
help
If you say yes here you get support for a PPS debugging client
which uses a kernel timer to generate the PPS signal.
@@ -37,5 +37,3 @@ config PPS_CLIENT_GPIO
GPIO. To be useful you must also register a platform device
specifying the GPIO pin and other options, usually in your board
setup.
-
-endif
diff --git a/drivers/pps/generators/Kconfig b/drivers/pps/generators/Kconfig
index e4c4f3d..86b5937 100644
--- a/drivers/pps/generators/Kconfig
+++ b/drivers/pps/generators/Kconfig
@@ -3,10 +3,11 @@
#
comment "PPS generators support"
+ depends on PPS
config PPS_GENERATOR_PARPORT
tristate "Parallel port PPS signal generator"
- depends on PARPORT && BROKEN
+ depends on PPS && PARPORT && BROKEN
help
If you say yes here you get support for a PPS signal generator which
utilizes STROBE pin of a parallel port to send PPS signals. It uses
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Make PPS into a menuconfig to ease disabling
2017-04-11 14:26 [PATCH] Make PPS into a menuconfig to ease disabling Vincent Legoll
@ 2017-05-06 10:33 ` Vincent Legoll
2017-05-09 12:06 ` Rodolfo Giometti
1 sibling, 0 replies; 3+ messages in thread
From: Vincent Legoll @ 2017-05-06 10:33 UTC (permalink / raw)
To: Rodolfo Giometti, Greg Kroah-Hartman, Linux Kernel ML; +Cc: Vincent Legoll
Hello,
Any feedback on this ?
Should I forward it to someone else ?
Thanks
--
Vincent Legoll
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Make PPS into a menuconfig to ease disabling
2017-04-11 14:26 [PATCH] Make PPS into a menuconfig to ease disabling Vincent Legoll
2017-05-06 10:33 ` Vincent Legoll
@ 2017-05-09 12:06 ` Rodolfo Giometti
1 sibling, 0 replies; 3+ messages in thread
From: Rodolfo Giometti @ 2017-05-09 12:06 UTC (permalink / raw)
To: Vincent Legoll, gregkh, linux-kernel
On 04/11/17 16:26, Vincent Legoll wrote:
> So that there's no need to get into the submenu to disable all related config
> entries.
>
> The BROKEN PPS_GENERATOR_PARPORT now also depends on PPS
>
> Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
Acked-by: Rodolfo Giometti <giometti@enneenne.com>
--
HCE Engineering e-mail: giometti@hce-engineering.com
GNU/Linux Solutions giometti@enneenne.com
Linux Device Driver giometti@linux.it
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti
Cosino Project - the quick prototyping embedded system - www.cosino.io
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-09 12:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-11 14:26 [PATCH] Make PPS into a menuconfig to ease disabling Vincent Legoll
2017-05-06 10:33 ` Vincent Legoll
2017-05-09 12:06 ` Rodolfo Giometti
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.