* [PATCH v1]] lib/btree.c: optimise the code by previously getpos function
@ 2017-04-11 6:53 Leno Hou
2017-04-11 16:20 ` Christoph Hellwig
2017-04-28 16:40 ` Andy Shevchenko
0 siblings, 2 replies; 5+ messages in thread
From: Leno Hou @ 2017-04-11 6:53 UTC (permalink / raw)
To: linux-kernel; +Cc: Leno Hou
This patch optimized the code by previously getpos function call.
Therefore, It's takes the convenience to understand logic of code.
Signed-off-by: Leno Hou <lenohou@gmail.com>
---
lib/btree.c | 41 +++++++++++++++++------------------------
1 file changed, 17 insertions(+), 24 deletions(-)
diff --git a/lib/btree.c b/lib/btree.c
index f93a945..87d690f 100644
--- a/lib/btree.c
+++ b/lib/btree.c
@@ -238,6 +238,19 @@ static int keyzero(struct btree_geo *geo, unsigned long *key)
return 1;
}
+static int getpos(struct btree_geo *geo, unsigned long *node,
+ unsigned long *key)
+{
+ int i;
+
+ for (i = 0; i < geo->no_pairs; i++) {
+ if (keycmp(geo, node, i, key) <= 0)
+ break;
+ }
+ return i;
+}
+
+
void *btree_lookup(struct btree_head *head, struct btree_geo *geo,
unsigned long *key)
{
@@ -248,9 +261,7 @@ void *btree_lookup(struct btree_head *head, struct btree_geo *geo,
return NULL;
for ( ; height > 1; height--) {
- for (i = 0; i < geo->no_pairs; i++)
- if (keycmp(geo, node, i, key) <= 0)
- break;
+ i = getpos(geo, node, key);
if (i == geo->no_pairs)
return NULL;
node = bval(geo, node, i);
@@ -278,9 +289,7 @@ int btree_update(struct btree_head *head, struct btree_geo *geo,
return -ENOENT;
for ( ; height > 1; height--) {
- for (i = 0; i < geo->no_pairs; i++)
- if (keycmp(geo, node, i, key) <= 0)
- break;
+ i = getpos(geo, node, key);
if (i == geo->no_pairs)
return -ENOENT;
node = bval(geo, node, i);
@@ -326,9 +335,7 @@ void *btree_get_prev(struct btree_head *head, struct btree_geo *geo,
node = head->node;
for (height = head->height ; height > 1; height--) {
- for (i = 0; i < geo->no_pairs; i++)
- if (keycmp(geo, node, i, key) <= 0)
- break;
+ i = getpos(geo, node, key);
if (i == geo->no_pairs)
goto miss;
oldnode = node;
@@ -360,18 +367,6 @@ void *btree_get_prev(struct btree_head *head, struct btree_geo *geo,
}
EXPORT_SYMBOL_GPL(btree_get_prev);
-static int getpos(struct btree_geo *geo, unsigned long *node,
- unsigned long *key)
-{
- int i;
-
- for (i = 0; i < geo->no_pairs; i++) {
- if (keycmp(geo, node, i, key) <= 0)
- break;
- }
- return i;
-}
-
static int getfill(struct btree_geo *geo, unsigned long *node, int start)
{
int i;
@@ -392,9 +387,7 @@ static unsigned long *find_level(struct btree_head *head, struct btree_geo *geo,
int i, height;
for (height = head->height; height > level; height--) {
- for (i = 0; i < geo->no_pairs; i++)
- if (keycmp(geo, node, i, key) <= 0)
- break;
+ i = getpos(geo, node, key);
if ((i == geo->no_pairs) || !bval(geo, node, i)) {
/* right-most key is too large, update it */
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1]] lib/btree.c: optimise the code by previously getpos function
2017-04-11 6:53 [PATCH v1]] lib/btree.c: optimise the code by previously getpos function Leno Hou
@ 2017-04-11 16:20 ` Christoph Hellwig
[not found] ` <CAGQVrL_2EanSVKkMEP_fBaeWSwu=tZYSq79nzOy-wXQ9m1WOuQ@mail.gmail.com>
2017-04-28 16:40 ` Andy Shevchenko
1 sibling, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2017-04-11 16:20 UTC (permalink / raw)
To: Leno Hou; +Cc: linux-kernel
On Tue, Apr 11, 2017 at 02:53:56AM -0400, Leno Hou wrote:
> This patch optimized the code by previously getpos function call.
> Therefore, It's takes the convenience to understand logic of code.
How did you test this change?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1]] lib/btree.c: optimise the code by previously getpos function
2017-04-11 6:53 [PATCH v1]] lib/btree.c: optimise the code by previously getpos function Leno Hou
2017-04-11 16:20 ` Christoph Hellwig
@ 2017-04-28 16:40 ` Andy Shevchenko
1 sibling, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2017-04-28 16:40 UTC (permalink / raw)
To: Leno Hou; +Cc: linux-kernel
On Tue, Apr 11, 2017 at 9:53 AM, Leno Hou <lenohou@gmail.com> wrote:
> This patch optimized the code by previously getpos function call.
> Therefore, It's takes the convenience to understand logic of code.
Besides what Christoph told you (I agree with him, writing test suites
/ modules is quite good exercise for newbies) my 2 cents for below
code that you may consider in the future as a technique of cleaning
up,
> +static int getpos(struct btree_geo *geo, unsigned long *node,
> + unsigned long *key)
> +{
> + int i;
unsigned int i;
> +
> + for (i = 0; i < geo->no_pairs; i++) {
> + if (keycmp(geo, node, i, key) <= 0)
> + break;
Here you return directly
return i;
> + }
> + return i;
And here is the best to return negative error code instead, like
return -ENOENT;
> +}
> for ( ; height > 1; height--) {
> - for (i = 0; i < geo->no_pairs; i++)
> - if (keycmp(geo, node, i, key) <= 0)
> - break;
> + i = getpos(geo, node, key);
> if (i == geo->no_pairs)
> return NULL;
Taking above into consideration you may do
i = getpos(geo, node, key);
if (i < 0)
return NULL;
Rationale behind that:
1) getpos() return value may be directly used whenever we need return
code to return;
2) you hide implementation details in your helper function
(geo->no_pairs dereference).
Though here both of them kinda minors you may use such technique in
the future for more complex code.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-28 16:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-11 6:53 [PATCH v1]] lib/btree.c: optimise the code by previously getpos function Leno Hou
2017-04-11 16:20 ` Christoph Hellwig
[not found] ` <CAGQVrL_2EanSVKkMEP_fBaeWSwu=tZYSq79nzOy-wXQ9m1WOuQ@mail.gmail.com>
2017-04-12 17:32 ` Christoph Hellwig
2017-04-19 14:48 ` Leno Hou
2017-04-28 16:40 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.