* [PATCH] drm/i915: Don't mark an execlists context-switch when idle
@ 2017-04-11 9:18 Chris Wilson
2017-04-11 9:20 ` ✗ Fi.CI.BAT: failure for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Chris Wilson @ 2017-04-11 9:18 UTC (permalink / raw)
To: intel-gfx
If we *know* that the engine is idle, i.e. we have not more contexts in
lift, we can skip any spurious CSB idle interrupts. These spurious
interrupts seem to arrive long after we assert that the engines are
completely idle, triggering later assertions:
[ 178.896646] intel_engine_is_idle(bcs): interrupt not handled, irq_posted=2
[ 178.896655] ------------[ cut here ]------------
[ 178.896658] kernel BUG at drivers/gpu/drm/i915/intel_engine_cs.c:226!
[ 178.896661] invalid opcode: 0000 [#1] SMP
[ 178.896663] Modules linked in: i915(E) x86_pkg_temp_thermal(E) crct10dif_pclmul(E) crc32_pclmul(E) crc32c_intel(E) ghash_clmulni_intel(E) nls_ascii(E) nls_cp437(E) vfat(E) fat(E) intel_gtt(E) i2c_algo_bit(E) drm_kms_helper(E) syscopyarea(E) sysfillrect(E) sysimgblt(E) fb_sys_fops(E) aesni_intel(E) prime_numbers(E) evdev(E) aes_x86_64(E) drm(E) crypto_simd(E) cryptd(E) glue_helper(E) mei_me(E) mei(E) lpc_ich(E) efivars(E) mfd_core(E) battery(E) video(E) acpi_pad(E) button(E) tpm_tis(E) tpm_tis_core(E) tpm(E) autofs4(E) i2c_i801(E) fan(E) thermal(E) i2c_designware_platform(E) i2c_designware_core(E)
[ 178.896694] CPU: 1 PID: 522 Comm: gem_exec_whispe Tainted: G E 4.11.0-rc5+ #14
[ 178.896702] task: ffff88040aba8d40 task.stack: ffffc900003f0000
[ 178.896722] RIP: 0010:intel_engine_init_global_seqno+0x1db/0x1f0 [i915]
[ 178.896725] RSP: 0018:ffffc900003f3ab0 EFLAGS: 00010246
[ 178.896728] RAX: 0000000000000000 RBX: ffff88040af54000 RCX: 0000000000000000
[ 178.896731] RDX: ffff88041ec933e0 RSI: ffff88041ec8cc48 RDI: ffff88041ec8cc48
[ 178.896734] RBP: ffffc900003f3ac8 R08: 0000000000000000 R09: 000000000000047d
[ 178.896736] R10: 0000000000000040 R11: ffff88040b344f80 R12: 0000000000000000
[ 178.896739] R13: ffff88040bce0000 R14: ffff88040bce52d8 R15: ffff88040bce0000
[ 178.896742] FS: 00007f2cccc2d8c0(0000) GS:ffff88041ec80000(0000) knlGS:0000000000000000
[ 178.896746] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 178.896749] CR2: 00007f41ddd8f000 CR3: 000000040bb03000 CR4: 00000000001406e0
[ 178.896752] Call Trace:
[ 178.896768] reset_all_global_seqno.part.33+0x4e/0xd0 [i915]
[ 178.896782] i915_gem_request_alloc+0x304/0x330 [i915]
[ 178.896795] i915_gem_do_execbuffer+0x8a1/0x17d0 [i915]
[ 178.896799] ? remove_wait_queue+0x48/0x50
[ 178.896812] ? i915_wait_request+0x300/0x590 [i915]
[ 178.896816] ? wake_up_q+0x70/0x70
[ 178.896819] ? refcount_dec_and_test+0x11/0x20
[ 178.896823] ? reservation_object_add_excl_fence+0xa5/0x100
[ 178.896835] i915_gem_execbuffer2+0xab/0x1f0 [i915]
[ 178.896844] drm_ioctl+0x1e6/0x460 [drm]
[ 178.896858] ? i915_gem_execbuffer+0x260/0x260 [i915]
[ 178.896862] ? dput+0xcf/0x250
[ 178.896866] ? full_proxy_release+0x66/0x80
[ 178.896869] ? mntput+0x1f/0x30
[ 178.896872] do_vfs_ioctl+0x8f/0x5b0
[ 178.896875] ? ____fput+0x9/0x10
[ 178.896878] ? task_work_run+0x80/0xa0
[ 178.896881] SyS_ioctl+0x3c/0x70
[ 178.896885] entry_SYSCALL_64_fastpath+0x17/0x98
[ 178.896888] RIP: 0033:0x7f2ccb455ca7
[ 178.896890] RSP: 002b:00007ffcabec72d8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
[ 178.896894] RAX: ffffffffffffffda RBX: 000055f897a44b90 RCX: 00007f2ccb455ca7
[ 178.896897] RDX: 00007ffcabec74a0 RSI: 0000000040406469 RDI: 0000000000000003
[ 178.896900] RBP: 00007f2ccb70a440 R08: 00007f2ccb70d0a4 R09: 0000000000000000
[ 178.896903] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
[ 178.896905] R13: 000055f89782d71a R14: 00007ffcabecf838 R15: 0000000000000003
[ 178.896908] Code: 00 31 d2 4c 89 ef 8d 70 48 41 ff 95 f8 06 00 00 e9 68 fe ff ff be 0f 00 00 00 48 c7 c7 48 dc 37 a0 e8 fa 33 d6 e0 e9 0b ff ff ff <0f> 0b 0f 0b 0f 0b 0f 0b 0f 1f 00 66 2e 0f 1f 84 00 00 00 00 00
On the other hand, by ignoring the interrupt do we risk running out of
space in CSB ring? Testing for a few hours suggests not, i.e. that we
only seem to get the odd delayed CSB idle notification.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
drivers/gpu/drm/i915/i915_irq.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 1da5b85a4295..e3ea6c008425 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -1363,8 +1363,10 @@ gen8_cs_irq_handler(struct intel_engine_cs *engine, u32 iir, int test_shift)
bool tasklet = false;
if (iir & (GT_CONTEXT_SWITCH_INTERRUPT << test_shift)) {
- set_bit(ENGINE_IRQ_EXECLIST, &engine->irq_posted);
- tasklet = true;
+ if (port_count(&engine->execlist_port[0])) {
+ set_bit(ENGINE_IRQ_EXECLIST, &engine->irq_posted);
+ tasklet = true;
+ }
}
if (iir & (GT_RENDER_USER_INTERRUPT << test_shift)) {
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Don't mark an execlists context-switch when idle
2017-04-11 9:18 [PATCH] drm/i915: Don't mark an execlists context-switch when idle Chris Wilson
@ 2017-04-11 9:20 ` Patchwork
2017-04-11 10:54 ` [PATCH] " kbuild test robot
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-04-11 9:20 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Don't mark an execlists context-switch when idle
URL : https://patchwork.freedesktop.org/series/22841/
State : failure
== Summary ==
CC [M] drivers/gpu/drm/i915/gvt/firmware.o
CC [M] drivers/gpu/drm/i915/gvt/interrupt.o
CC [M] drivers/gpu/drm/i915/gvt/gtt.o
CC [M] drivers/gpu/drm/i915/gvt/cfg_space.o
LD drivers/thermal/thermal_sys.o
CC [M] drivers/gpu/drm/i915/gvt/opregion.o
CC [M] drivers/gpu/drm/i915/gvt/mmio.o
CC [M] drivers/gpu/drm/i915/gvt/display.o
CC [M] drivers/gpu/drm/i915/gvt/edid.o
CC [M] drivers/gpu/drm/i915/gvt/execlist.o
LD drivers/thermal/built-in.o
CC [M] drivers/gpu/drm/i915/gvt/scheduler.o
CC [M] drivers/gpu/drm/i915/gvt/sched_policy.o
CC [M] drivers/gpu/drm/i915/gvt/render.o
CC [M] drivers/gpu/drm/i915/intel_lpe_audio.o
CC [M] drivers/gpu/drm/i915/gvt/cmd_parser.o
LD drivers/video/fbdev/built-in.o
LD drivers/mmc/core/mmc_block.o
LD drivers/mmc/core/built-in.o
LD drivers/mmc/built-in.o
LD kernel/sched/built-in.o
LD [M] drivers/gpu/drm/vgem/vgem.o
LD lib/lz4/built-in.o
LD drivers/pci/pcie/aer/aerdriver.o
LD kernel/built-in.o
LD drivers/usb/storage/usb-storage.o
LD drivers/pci/pcie/aer/built-in.o
LD drivers/usb/storage/built-in.o
LD drivers/pci/pcie/built-in.o
LD [M] drivers/misc/mei/mei-me.o
drivers/gpu/drm/i915/i915_irq.c: In function ‘gen8_cs_irq_handler’:
drivers/gpu/drm/i915/i915_irq.c:1362:7: error: implicit declaration of function ‘port_count’ [-Werror=implicit-function-declaration]
if (port_count(&engine->execlist_port[0])) {
^
LD drivers/misc/built-in.o
LD drivers/usb/gadget/libcomposite.o
LD drivers/tty/serial/8250/8250.o
LD drivers/iommu/built-in.o
LD drivers/spi/built-in.o
LD net/xfrm/built-in.o
LD drivers/video/console/built-in.o
LD drivers/video/built-in.o
LD drivers/usb/gadget/udc/udc-core.o
LD drivers/gpu/drm/drm.o
LD drivers/usb/gadget/udc/built-in.o
LD drivers/usb/gadget/built-in.o
LD drivers/tty/serial/8250/8250_base.o
LD drivers/tty/serial/8250/built-in.o
LD net/ipv6/ipv6.o
LD [M] drivers/net/ethernet/intel/e1000/e1000.o
LD drivers/tty/serial/built-in.o
AR lib/lib.a
EXPORTS lib/lib-ksyms.o
LD net/ipv6/built-in.o
LD drivers/scsi/scsi_mod.o
LD drivers/pci/built-in.o
LD lib/built-in.o
LD [M] sound/pci/hda/snd-hda-codec-generic.o
LD sound/pci/built-in.o
LD drivers/tty/vt/built-in.o
LD drivers/tty/built-in.o
LD sound/built-in.o
LD [M] drivers/net/ethernet/intel/igbvf/igbvf.o
LD fs/btrfs/btrfs.o
LD fs/btrfs/built-in.o
LD drivers/scsi/sd_mod.o
LD drivers/scsi/built-in.o
CC arch/x86/kernel/cpu/capflags.o
LD arch/x86/kernel/cpu/built-in.o
LD net/ipv4/built-in.o
LD arch/x86/kernel/built-in.o
LD drivers/usb/core/usbcore.o
LD drivers/usb/core/built-in.o
LD arch/x86/built-in.o
LD drivers/usb/host/xhci-hcd.o
LD drivers/md/md-mod.o
LD drivers/md/built-in.o
LD net/core/built-in.o
cc1: all warnings being treated as errors
LD net/built-in.o
scripts/Makefile.build:294: recipe for target 'drivers/gpu/drm/i915/i915_irq.o' failed
make[4]: *** [drivers/gpu/drm/i915/i915_irq.o] Error 1
make[4]: *** Waiting for unfinished jobs....
LD fs/ext4/ext4.o
LD fs/ext4/built-in.o
LD [M] drivers/net/ethernet/intel/e1000e/e1000e.o
LD fs/built-in.o
LD [M] drivers/net/ethernet/intel/igb/igb.o
LD drivers/usb/host/built-in.o
LD drivers/usb/built-in.o
LD drivers/net/ethernet/built-in.o
LD drivers/net/built-in.o
scripts/Makefile.build:553: recipe for target 'drivers/gpu/drm/i915' failed
make[3]: *** [drivers/gpu/drm/i915] Error 2
scripts/Makefile.build:553: recipe for target 'drivers/gpu/drm' failed
make[2]: *** [drivers/gpu/drm] Error 2
scripts/Makefile.build:553: recipe for target 'drivers/gpu' failed
make[1]: *** [drivers/gpu] Error 2
Makefile:1002: recipe for target 'drivers' failed
make: *** [drivers] Error 2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Don't mark an execlists context-switch when idle
2017-04-11 9:18 [PATCH] drm/i915: Don't mark an execlists context-switch when idle Chris Wilson
2017-04-11 9:20 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2017-04-11 10:54 ` kbuild test robot
2017-04-11 11:04 ` kbuild test robot
2017-04-11 11:29 ` Chris Wilson
3 siblings, 0 replies; 5+ messages in thread
From: kbuild test robot @ 2017-04-11 10:54 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx, kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]
Hi Chris,
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20170410]
[cannot apply to v4.11-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Don-t-mark-an-execlists-context-switch-when-idle/20170411-183510
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-x070-201715 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/gpu/drm/i915/i915_irq.c: In function 'gen8_cs_irq_handler':
>> drivers/gpu/drm/i915/i915_irq.c:1362:7: error: implicit declaration of function 'port_count' [-Werror=implicit-function-declaration]
if (port_count(&engine->execlist_port[0])) {
^~~~~~~~~~
cc1: some warnings being treated as errors
vim +/port_count +1362 drivers/gpu/drm/i915/i915_irq.c
1356 static __always_inline void
1357 gen8_cs_irq_handler(struct intel_engine_cs *engine, u32 iir, int test_shift)
1358 {
1359 bool tasklet = false;
1360
1361 if (iir & (GT_CONTEXT_SWITCH_INTERRUPT << test_shift)) {
> 1362 if (port_count(&engine->execlist_port[0])) {
1363 set_bit(ENGINE_IRQ_EXECLIST, &engine->irq_posted);
1364 tasklet = true;
1365 }
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 24805 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Don't mark an execlists context-switch when idle
2017-04-11 9:18 [PATCH] drm/i915: Don't mark an execlists context-switch when idle Chris Wilson
2017-04-11 9:20 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-04-11 10:54 ` [PATCH] " kbuild test robot
@ 2017-04-11 11:04 ` kbuild test robot
2017-04-11 11:29 ` Chris Wilson
3 siblings, 0 replies; 5+ messages in thread
From: kbuild test robot @ 2017-04-11 11:04 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx, kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2801 bytes --]
Hi Chris,
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20170411]
[cannot apply to v4.11-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Don-t-mark-an-execlists-context-switch-when-idle/20170411-183510
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-x003-201715 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
In file included from include/uapi/linux/stddef.h:1:0,
from include/linux/stddef.h:4,
from include/uapi/linux/posix_types.h:4,
from include/uapi/linux/types.h:13,
from include/linux/types.h:5,
from include/linux/sysrq.h:18,
from drivers/gpu/drm/i915/i915_irq.c:31:
drivers/gpu/drm/i915/i915_irq.c: In function 'gen8_cs_irq_handler':
drivers/gpu/drm/i915/i915_irq.c:1362:7: error: implicit declaration of function 'port_count' [-Werror=implicit-function-declaration]
if (port_count(&engine->execlist_port[0])) {
^
include/linux/compiler.h:160:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> drivers/gpu/drm/i915/i915_irq.c:1362:3: note: in expansion of macro 'if'
if (port_count(&engine->execlist_port[0])) {
^~
cc1: some warnings being treated as errors
vim +/if +1362 drivers/gpu/drm/i915/i915_irq.c
1346
1347 if (gt_iir & (GT_BLT_CS_ERROR_INTERRUPT |
1348 GT_BSD_CS_ERROR_INTERRUPT |
1349 GT_RENDER_CS_MASTER_ERROR_INTERRUPT))
1350 DRM_DEBUG("Command parser error, gt_iir 0x%08x\n", gt_iir);
1351
1352 if (gt_iir & GT_PARITY_ERROR(dev_priv))
1353 ivybridge_parity_error_irq_handler(dev_priv, gt_iir);
1354 }
1355
1356 static __always_inline void
1357 gen8_cs_irq_handler(struct intel_engine_cs *engine, u32 iir, int test_shift)
1358 {
1359 bool tasklet = false;
1360
1361 if (iir & (GT_CONTEXT_SWITCH_INTERRUPT << test_shift)) {
> 1362 if (port_count(&engine->execlist_port[0])) {
1363 set_bit(ENGINE_IRQ_EXECLIST, &engine->irq_posted);
1364 tasklet = true;
1365 }
1366 }
1367
1368 if (iir & (GT_RENDER_USER_INTERRUPT << test_shift)) {
1369 notify_ring(engine);
1370 tasklet |= i915.enable_guc_submission;
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 25878 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Don't mark an execlists context-switch when idle
2017-04-11 9:18 [PATCH] drm/i915: Don't mark an execlists context-switch when idle Chris Wilson
` (2 preceding siblings ...)
2017-04-11 11:04 ` kbuild test robot
@ 2017-04-11 11:29 ` Chris Wilson
3 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2017-04-11 11:29 UTC (permalink / raw)
To: intel-gfx
On Tue, Apr 11, 2017 at 10:18:56AM +0100, Chris Wilson wrote:
> If we *know* that the engine is idle, i.e. we have not more contexts in
> lift, we can skip any spurious CSB idle interrupts. These spurious
> interrupts seem to arrive long after we assert that the engines are
> completely idle, triggering later assertions:
>
> [ 178.896646] intel_engine_is_idle(bcs): interrupt not handled, irq_posted=2
> [ 178.896655] ------------[ cut here ]------------
> [ 178.896658] kernel BUG at drivers/gpu/drm/i915/intel_engine_cs.c:226!
> [ 178.896661] invalid opcode: 0000 [#1] SMP
> [ 178.896663] Modules linked in: i915(E) x86_pkg_temp_thermal(E) crct10dif_pclmul(E) crc32_pclmul(E) crc32c_intel(E) ghash_clmulni_intel(E) nls_ascii(E) nls_cp437(E) vfat(E) fat(E) intel_gtt(E) i2c_algo_bit(E) drm_kms_helper(E) syscopyarea(E) sysfillrect(E) sysimgblt(E) fb_sys_fops(E) aesni_intel(E) prime_numbers(E) evdev(E) aes_x86_64(E) drm(E) crypto_simd(E) cryptd(E) glue_helper(E) mei_me(E) mei(E) lpc_ich(E) efivars(E) mfd_core(E) battery(E) video(E) acpi_pad(E) button(E) tpm_tis(E) tpm_tis_core(E) tpm(E) autofs4(E) i2c_i801(E) fan(E) thermal(E) i2c_designware_platform(E) i2c_designware_core(E)
> [ 178.896694] CPU: 1 PID: 522 Comm: gem_exec_whispe Tainted: G E 4.11.0-rc5+ #14
> [ 178.896702] task: ffff88040aba8d40 task.stack: ffffc900003f0000
> [ 178.896722] RIP: 0010:intel_engine_init_global_seqno+0x1db/0x1f0 [i915]
> [ 178.896725] RSP: 0018:ffffc900003f3ab0 EFLAGS: 00010246
> [ 178.896728] RAX: 0000000000000000 RBX: ffff88040af54000 RCX: 0000000000000000
> [ 178.896731] RDX: ffff88041ec933e0 RSI: ffff88041ec8cc48 RDI: ffff88041ec8cc48
> [ 178.896734] RBP: ffffc900003f3ac8 R08: 0000000000000000 R09: 000000000000047d
> [ 178.896736] R10: 0000000000000040 R11: ffff88040b344f80 R12: 0000000000000000
> [ 178.896739] R13: ffff88040bce0000 R14: ffff88040bce52d8 R15: ffff88040bce0000
> [ 178.896742] FS: 00007f2cccc2d8c0(0000) GS:ffff88041ec80000(0000) knlGS:0000000000000000
> [ 178.896746] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 178.896749] CR2: 00007f41ddd8f000 CR3: 000000040bb03000 CR4: 00000000001406e0
> [ 178.896752] Call Trace:
> [ 178.896768] reset_all_global_seqno.part.33+0x4e/0xd0 [i915]
> [ 178.896782] i915_gem_request_alloc+0x304/0x330 [i915]
> [ 178.896795] i915_gem_do_execbuffer+0x8a1/0x17d0 [i915]
> [ 178.896799] ? remove_wait_queue+0x48/0x50
> [ 178.896812] ? i915_wait_request+0x300/0x590 [i915]
> [ 178.896816] ? wake_up_q+0x70/0x70
> [ 178.896819] ? refcount_dec_and_test+0x11/0x20
> [ 178.896823] ? reservation_object_add_excl_fence+0xa5/0x100
> [ 178.896835] i915_gem_execbuffer2+0xab/0x1f0 [i915]
> [ 178.896844] drm_ioctl+0x1e6/0x460 [drm]
> [ 178.896858] ? i915_gem_execbuffer+0x260/0x260 [i915]
> [ 178.896862] ? dput+0xcf/0x250
> [ 178.896866] ? full_proxy_release+0x66/0x80
> [ 178.896869] ? mntput+0x1f/0x30
> [ 178.896872] do_vfs_ioctl+0x8f/0x5b0
> [ 178.896875] ? ____fput+0x9/0x10
> [ 178.896878] ? task_work_run+0x80/0xa0
> [ 178.896881] SyS_ioctl+0x3c/0x70
> [ 178.896885] entry_SYSCALL_64_fastpath+0x17/0x98
> [ 178.896888] RIP: 0033:0x7f2ccb455ca7
> [ 178.896890] RSP: 002b:00007ffcabec72d8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
> [ 178.896894] RAX: ffffffffffffffda RBX: 000055f897a44b90 RCX: 00007f2ccb455ca7
> [ 178.896897] RDX: 00007ffcabec74a0 RSI: 0000000040406469 RDI: 0000000000000003
> [ 178.896900] RBP: 00007f2ccb70a440 R08: 00007f2ccb70d0a4 R09: 0000000000000000
> [ 178.896903] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
> [ 178.896905] R13: 000055f89782d71a R14: 00007ffcabecf838 R15: 0000000000000003
> [ 178.896908] Code: 00 31 d2 4c 89 ef 8d 70 48 41 ff 95 f8 06 00 00 e9 68 fe ff ff be 0f 00 00 00 48 c7 c7 48 dc 37 a0 e8 fa 33 d6 e0 e9 0b ff ff ff <0f> 0b 0f 0b 0f 0b 0f 0b 0f 1f 00 66 2e 0f 1f 84 00 00 00 00 00
>
> On the other hand, by ignoring the interrupt do we risk running out of
> space in CSB ring? Testing for a few hours suggests not, i.e. that we
> only seem to get the odd delayed CSB idle notification.
The alternative is not to report upon engine->irq_posted from within
intel_engine_is_idle() but that loses us an important safety check for
e.g. suspend.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-11 11:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-11 9:18 [PATCH] drm/i915: Don't mark an execlists context-switch when idle Chris Wilson
2017-04-11 9:20 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-04-11 10:54 ` [PATCH] " kbuild test robot
2017-04-11 11:04 ` kbuild test robot
2017-04-11 11:29 ` Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.