From: David Miller <davem@davemloft.net>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@kernel.org, bigeasy@linutronix.de,
benh@kernel.crashing.org, fenghua.yu@intel.com,
herbert@gondor.apana.org.au, jiangshanlai@gmail.com,
lenb@kernel.org, mpe@ellerman.id.au, rjw@rjwysocki.net,
tj@kernel.org, tony.luck@intel.com, viresh.kumar@linaro.org,
sparclinux@vger.kernel.org
Subject: Re: [patch 06/13] sparc/sysfs: Replace racy task affinity logic
Date: Wed, 12 Apr 2017 21:52:06 -0400 (EDT) [thread overview]
Message-ID: <20170412.215206.1568460664651298892.davem@davemloft.net> (raw)
In-Reply-To: <20170412201042.612462984@linutronix.de>
From: Thomas Gleixner <tglx@linutronix.de>
Date: Wed, 12 Apr 2017 22:07:32 +0200
> @@ -142,7 +122,8 @@ static unsigned long write_mmustat_enabl
> static ssize_t show_mmustat_enable(struct device *s,
> struct device_attribute *attr, char *buf)
> {
> - unsigned long val = run_on_cpu(s->id, read_mmustat_enable, 0);
> + long val = work_on_cpu(s->id, read_mmustat_enable, 0);
Last argument to work_on_cpu() should be NULL since it's a pointer
I guess.
But otherwise I have no problems with this:
Acked-by: David S. Miller <davem@davemloft.net>
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@kernel.org, bigeasy@linutronix.de,
benh@kernel.crashing.org, fenghua.yu@intel.com,
herbert@gondor.apana.org.au, jiangshanlai@gmail.com,
lenb@kernel.org, mpe@ellerman.id.au, rjw@rjwysocki.net,
tj@kernel.org, tony.luck@intel.com, viresh.kumar@linaro.org,
sparclinux@vger.kernel.org
Subject: Re: [patch 06/13] sparc/sysfs: Replace racy task affinity logic
Date: Thu, 13 Apr 2017 01:52:06 +0000 [thread overview]
Message-ID: <20170412.215206.1568460664651298892.davem@davemloft.net> (raw)
In-Reply-To: <20170412201042.612462984@linutronix.de>
From: Thomas Gleixner <tglx@linutronix.de>
Date: Wed, 12 Apr 2017 22:07:32 +0200
> @@ -142,7 +122,8 @@ static unsigned long write_mmustat_enabl
> static ssize_t show_mmustat_enable(struct device *s,
> struct device_attribute *attr, char *buf)
> {
> - unsigned long val = run_on_cpu(s->id, read_mmustat_enable, 0);
> + long val = work_on_cpu(s->id, read_mmustat_enable, 0);
Last argument to work_on_cpu() should be NULL since it's a pointer
I guess.
But otherwise I have no problems with this:
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2017-04-13 1:52 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 20:07 [patch 00/13] sched/treewide: Clean up various racy task affinity issues Thomas Gleixner
2017-04-12 20:07 ` [patch 01/13] ia64/topology: Remove cpus_allowed manipulation Thomas Gleixner
2017-04-12 20:07 ` Thomas Gleixner
2017-04-15 14:15 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-04-12 20:07 ` [patch 02/13] workqueue: Provide work_on_cpu_safe() Thomas Gleixner
2017-04-13 11:11 ` Dou Liyang
2017-04-13 21:28 ` Thomas Gleixner
2017-04-14 4:18 ` Tejun Heo
2017-04-14 8:54 ` Peter Zijlstra
2017-04-14 9:51 ` Thomas Gleixner
2017-04-14 9:56 ` Peter Zijlstra
2017-04-15 14:16 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-04-12 20:07 ` [patch 03/13] ia64/salinfo: Replace racy task affinity logic Thomas Gleixner
2017-04-12 20:07 ` Thomas Gleixner
2017-04-15 14:17 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-04-12 20:07 ` [patch 04/13] ia64/sn/hwperf: " Thomas Gleixner
2017-04-12 20:07 ` Thomas Gleixner
2017-04-12 20:53 ` [patch V 2 " Thomas Gleixner
2017-04-12 20:53 ` Thomas Gleixner
2017-04-15 14:17 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-04-12 20:07 ` [patch 05/13] powerpc/smp: Replace open coded " Thomas Gleixner
2017-04-12 20:07 ` Thomas Gleixner
2017-04-13 5:47 ` Michael Ellerman
2017-04-15 14:18 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-04-12 20:07 ` [patch 06/13] sparc/sysfs: Replace racy " Thomas Gleixner
2017-04-12 20:07 ` Thomas Gleixner
2017-04-13 1:52 ` David Miller [this message]
2017-04-13 1:52 ` David Miller
2017-04-13 8:17 ` [patch V2 " Thomas Gleixner
2017-04-13 8:17 ` Thomas Gleixner
2017-04-15 14:18 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-04-12 20:07 ` [patch 07/13] ACPI/processor: Fix error handling in __acpi_processor_start() Thomas Gleixner
2017-04-15 14:19 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-04-12 20:07 ` [patch 08/13] ACPI/processor: Replace racy task affinity logic Thomas Gleixner
2017-04-13 11:39 ` Peter Zijlstra
2017-04-13 12:01 ` Thomas Gleixner
2017-04-13 12:52 ` Peter Zijlstra
2017-04-15 14:19 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-04-12 20:07 ` [patch 09/13] cpufreq/ia64: " Thomas Gleixner
2017-04-12 20:55 ` [patch V2 " Thomas Gleixner
2017-04-15 14:20 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-04-13 2:42 ` [patch 09/13] " Viresh Kumar
2017-04-12 20:07 ` [patch 10/13] cpufreq/sh: " Thomas Gleixner
2017-04-13 2:46 ` Viresh Kumar
2017-04-15 14:20 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-04-12 20:07 ` [patch 11/13] cpufreq/sparc-us3: " Thomas Gleixner
2017-04-13 2:48 ` Viresh Kumar
2017-04-15 14:21 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-04-12 20:07 ` [patch 12/13] cpufreq/sparc-us2e: " Thomas Gleixner
2017-04-13 2:50 ` Viresh Kumar
2017-04-13 8:19 ` [patch V2 " Thomas Gleixner
2017-04-13 8:22 ` [patch V3 " Thomas Gleixner
2017-04-15 14:21 ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-04-13 14:50 ` [patch V2 12/13] " David Miller
2017-04-12 20:07 ` [patch 13/13] crypto: n2 - " Thomas Gleixner
2017-04-13 4:56 ` Herbert Xu
2017-04-13 8:20 ` [patch V2 " Thomas Gleixner
2017-04-13 14:51 ` David Miller
2017-04-15 14:22 ` [tip:sched/core] crypto: N2 " tip-bot for Thomas Gleixner
2017-04-13 9:02 ` [patch 00/13] sched/treewide: Clean up various racy task affinity issues Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412.215206.1568460664651298892.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benh@kernel.crashing.org \
--cc=bigeasy@linutronix.de \
--cc=fenghua.yu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=jiangshanlai@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.