From: Dan Carpenter <dan.carpenter@oracle.com> To: Daniel Vetter <daniel.vetter@intel.com>, David Airlie <airlied@linux.ie> Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH] drm/edid: checking for NULL instead of IS_ERR Date: Wed, 12 Apr 2017 08:33:50 +0000 [thread overview] Message-ID: <20170412083350.GD3250@mwanda> (raw) drm_mode_create_tile_group() uses error pointers, it doesn't return NULL. I re-arranged it a tiny bit to be more clear. Fixes: 40d9b043a89e ("drm/connector: store tile information from displayid (v3)") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index fad3d44e4642..c6bc21673885 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -4522,9 +4522,9 @@ static int drm_parse_tiled_block(struct drm_connector *connector, tg = drm_mode_get_tile_group(connector->dev, tile->topology_id); if (!tg) { tg = drm_mode_create_tile_group(connector->dev, tile->topology_id); + if (IS_ERR(tg)) + return PTR_ERR(tg); } - if (!tg) - return -ENOMEM; if (connector->tile_group != tg) { /* if we haven't got a pointer,
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com> To: Daniel Vetter <daniel.vetter@intel.com>, David Airlie <airlied@linux.ie> Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH] drm/edid: checking for NULL instead of IS_ERR Date: Wed, 12 Apr 2017 11:33:50 +0300 [thread overview] Message-ID: <20170412083350.GD3250@mwanda> (raw) drm_mode_create_tile_group() uses error pointers, it doesn't return NULL. I re-arranged it a tiny bit to be more clear. Fixes: 40d9b043a89e ("drm/connector: store tile information from displayid (v3)") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index fad3d44e4642..c6bc21673885 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -4522,9 +4522,9 @@ static int drm_parse_tiled_block(struct drm_connector *connector, tg = drm_mode_get_tile_group(connector->dev, tile->topology_id); if (!tg) { tg = drm_mode_create_tile_group(connector->dev, tile->topology_id); + if (IS_ERR(tg)) + return PTR_ERR(tg); } - if (!tg) - return -ENOMEM; if (connector->tile_group != tg) { /* if we haven't got a pointer, _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2017-04-12 8:33 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-12 8:33 Dan Carpenter [this message] 2017-04-12 8:33 ` [PATCH] drm/edid: checking for NULL instead of IS_ERR Dan Carpenter 2017-04-12 9:01 ` Daniel Vetter 2017-04-12 9:01 ` Daniel Vetter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170412083350.GD3250@mwanda \ --to=dan.carpenter@oracle.com \ --cc=airlied@linux.ie \ --cc=daniel.vetter@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=kernel-janitors@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.