[Buildroot] [PATCH 1/2] phytool: new package

[Buildroot] [PATCH 1/2] phytool: new package

[yegorslists at googlemail.com]

From: Yegor Yefremov <yegorslists@googlemail.com>

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 package/Config.in            |  1 +
 package/phytool/Config.in    |  6 ++++++
 package/phytool/phytool.hash |  2 ++
 package/phytool/phytool.mk   | 22 ++++++++++++++++++++++
 4 files changed, 31 insertions(+)
 create mode 100644 package/phytool/Config.in
 create mode 100644 package/phytool/phytool.hash
 create mode 100644 package/phytool/phytool.mk

diff --git a/package/Config.in b/package/Config.in
index c12e5b56f..bdad62267 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1639,6 +1639,7 @@ endif
 	source "package/openvpn/Config.in"
 	source "package/p910nd/Config.in"
 	source "package/phidgetwebservice/Config.in"
+	source "package/phytool/Config.in"
 	source "package/pound/Config.in"
 	source "package/pppd/Config.in"
 	source "package/pptp-linux/Config.in"
diff --git a/package/phytool/Config.in b/package/phytool/Config.in
new file mode 100644
index 000000000..7dca31dda
--- /dev/null
+++ b/package/phytool/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_PHYTOOL
+	bool "phytool"
+	help
+	  Linux MDIO register access utility.
+
+	  https://github.com/wkz/phytool
diff --git a/package/phytool/phytool.hash b/package/phytool/phytool.hash
new file mode 100644
index 000000000..f4a395f5e
--- /dev/null
+++ b/package/phytool/phytool.hash
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256  a002712580ba57e0216e5b984a52322b6b2f0bbb029bc79ebe73a6ee9f2a19bb  phytool-3149bfdb4f513e2f0da0a7d0bc5d0873578696f2.tar.gz
diff --git a/package/phytool/phytool.mk b/package/phytool/phytool.mk
new file mode 100644
index 000000000..6115cb837
--- /dev/null
+++ b/package/phytool/phytool.mk
@@ -0,0 +1,22 @@
+################################################################################
+#
+# phytool
+#
+################################################################################
+
+PHYTOOL_VERSION = 3149bfdb4f513e2f0da0a7d0bc5d0873578696f2
+PHYTOOL_SITE = $(call github,wkz,phytool,$(PHYTOOL_VERSION))
+PHYTOOL_LICENSE = GPL-2.0
+PHYTOOL_LICENSE_FILES = LICENSE
+
+define PHYTOOL_BUILD_CMDS
+	$(TARGET_MAKE_ENV) CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)" \
+		LDFLAGS="$(TARGET_LDFLAGS)" $(MAKE) -C $(@D)
+endef
+
+define PHYTOOL_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" \
+		PREFIX="usr" install
+endef
+
+$(eval $(generic-package))
-- 
2.11.0

[Buildroot] [PATCH 2/2] DEVELOPERS: add entry for phytool

[yegorslists at googlemail.com]

From: Yegor Yefremov <yegorslists@googlemail.com>

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 DEVELOPERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/DEVELOPERS b/DEVELOPERS
index a298669ab..e4582b615 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1739,6 +1739,7 @@ F:	package/linux-firmware/
 F:	package/modem-manager/
 F:	package/nuttcp/
 F:	package/parted/
+F:	package/phytool/
 F:	package/python*
 F:	package/ser2net/
 F:	package/socketcand/
-- 
2.11.0

[Buildroot] [PATCH 1/2] phytool: new package

[Arnout Vandecappelle]

On 12-04-17 14:16, yegorslists at googlemail.com wrote:
[snip]
> diff --git a/package/phytool/phytool.mk b/package/phytool/phytool.mk
> new file mode 100644
> index 000000000..6115cb837
> --- /dev/null
> +++ b/package/phytool/phytool.mk
> @@ -0,0 +1,22 @@
> +################################################################################
> +#
> +# phytool
> +#
> +################################################################################
> +
> +PHYTOOL_VERSION = 3149bfdb4f513e2f0da0a7d0bc5d0873578696f2
> +PHYTOOL_SITE = $(call github,wkz,phytool,$(PHYTOOL_VERSION))

 There's an uploaded tarball including md5 sum of v1.0.1. There is only one
commit difference, and htat just adds LDFLAGS support. But that can be overcome
by using LDLIBS instead of LDFLAGS.

> +PHYTOOL_LICENSE = GPL-2.0

 I see GPL-2.0+ in all source files, did I miss anything?

> +PHYTOOL_LICENSE_FILES = LICENSE
> +
> +define PHYTOOL_BUILD_CMDS
> +	$(TARGET_MAKE_ENV) CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)" \
> +		LDFLAGS="$(TARGET_LDFLAGS)" $(MAKE) -C $(@D)

 We prefer using TARGET_CONF_OPTS, like

	$(TARGET_MAKE_ENV) $(TARGET_CONF_OPTS) $(MAKE) -C $(@D) \
		LDLIBS="$(TARGET_LDFLAGS)"

> +endef
> +
> +define PHYTOOL_INSTALL_TARGET_CMDS
> +	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" \
> +		PREFIX="usr" install

 We also generally prefer to use as much as possible the same command line for
the install commands, so including the extra flags.


 Regards,
 Arnout


> +endef
> +
> +$(eval $(generic-package))
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH 1/2] phytool: new package

[Thomas Petazzoni]

Hello,

On Wed, 12 Apr 2017 14:16:33 +0200, yegorslists at googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  package/Config.in            |  1 +
>  package/phytool/Config.in    |  6 ++++++
>  package/phytool/phytool.hash |  2 ++
>  package/phytool/phytool.mk   | 22 ++++++++++++++++++++++
>  4 files changed, 31 insertions(+)
>  create mode 100644 package/phytool/Config.in
>  create mode 100644 package/phytool/phytool.hash
>  create mode 100644 package/phytool/phytool.mk

Following Arnout comments, I've marked your patch as Changes Requested
in patchwork. Also, please merge PATCH 2/2 into PATCH 1/2, the change
to the DEVELOPERS should now be done in the patch adding the package.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com