From: David Sterba <dsterba@suse.cz>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
tglx@linutronix.de, viro@zeniv.linux.org.uk,
gregkh@linuxfoundation.org, andreas.dilger@intel.com,
arnd@arndb.de, bfields@fieldses.org, clm@fb.com,
davem@davemloft.net, dsterba@suse.com, dushistov@mail.ru,
eparis@redhat.com, jaegeuk@kernel.org, jbacik@fb.com,
jlayton@poochiereds.net, john.stultz@linaro.org,
jsimmons@infradead.org, mingo@redhat.com, oleg.drokin@intel.com,
paul@paul-moore.com, rostedt@goodmis.org, yuchao0@huawei.com,
ceph-devel@vger.kernel.org, devel@driverdev.osuosl.org,
linux-audit@redhat.com, linux-btrfs@vger.kernel.org,
linux-cifs@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-security-module@vger.kernel.org,
lustre-devel@lists.lustre.org, netdev@vger.kernel.org,
samba-technical@lists.samba.org, y2038@lists.linaro.org
Subject: Re: [PATCH 07/12] fs: btrfs: Use ktime_get_real_ts for root ctime
Date: Wed, 12 Apr 2017 15:42:45 +0200 [thread overview]
Message-ID: <20170412134245.GK4781@twin.jikos.cz> (raw)
In-Reply-To: <1491613030-11599-8-git-send-email-deepa.kernel@gmail.com>
On Fri, Apr 07, 2017 at 05:57:05PM -0700, Deepa Dinamani wrote:
> btrfs_root_item maintains the ctime for root updates.
> This is not part of vfs_inode.
>
> Since current_time() uses struct inode* as an argument
> as Linus suggested, this cannot be used to update root
> times unless, we modify the signature to use inode.
>
> Since btrfs uses nanosecond time granularity, it can also
> use ktime_get_real_ts directly to obtain timestamp for
> the root. It is necessary to use the timespec time api
> here because the same btrfs_set_stack_timespec_*() apis
> are used for vfs inode times as well. These can be
> transitioned to using timespec64 when btrfs internally
> changes to use timespec64 as well.
>
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> Acked-by: David Sterba <dsterba@suse.com>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
I'm going to add the patch to my 4.12 queue and will let Andrew know.
WARNING: multiple messages have this Message-ID (diff)
From: David Sterba <dsterba@suse.cz>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: yuchao0@huawei.com, bfields@fieldses.org, clm@fb.com,
linux-mtd@lists.infradead.org, dushistov@mail.ru,
jlayton@poochiereds.net, ceph-devel@vger.kernel.org,
devel@driverdev.osuosl.org, linux-cifs@vger.kernel.org,
paul@paul-moore.com, y2038@lists.linaro.org, mingo@redhat.com,
jsimmons@infradead.org, arnd@arndb.de, rostedt@goodmis.org,
oleg.drokin@intel.com, john.stultz@linaro.org,
viro@zeniv.linux.org.uk, dsterba@suse.com, jaegeuk@kernel.org,
tglx@linutronix.de, andreas.dilger@intel.com, jbacik@fb.com,
gregkh@linuxfoundation.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org, eparis@redhat.com,
linux-f2fs-devel@lists.sourceforge.net,
linux-security-module@vger.kernel.org, linux-audit@redhat.com,
netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org,
akpm@linux-foundation.org, davem@davemloft.net,
linux-btrfs@vger.kernel.org, lustre-devel@lists.lustre.org
Subject: Re: [PATCH 07/12] fs: btrfs: Use ktime_get_real_ts for root ctime
Date: Wed, 12 Apr 2017 15:42:45 +0200 [thread overview]
Message-ID: <20170412134245.GK4781@twin.jikos.cz> (raw)
In-Reply-To: <1491613030-11599-8-git-send-email-deepa.kernel@gmail.com>
On Fri, Apr 07, 2017 at 05:57:05PM -0700, Deepa Dinamani wrote:
> btrfs_root_item maintains the ctime for root updates.
> This is not part of vfs_inode.
>
> Since current_time() uses struct inode* as an argument
> as Linus suggested, this cannot be used to update root
> times unless, we modify the signature to use inode.
>
> Since btrfs uses nanosecond time granularity, it can also
> use ktime_get_real_ts directly to obtain timestamp for
> the root. It is necessary to use the timespec time api
> here because the same btrfs_set_stack_timespec_*() apis
> are used for vfs inode times as well. These can be
> transitioned to using timespec64 when btrfs internally
> changes to use timespec64 as well.
>
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> Acked-by: David Sterba <dsterba@suse.com>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
I'm going to add the patch to my 4.12 queue and will let Andrew know.
_______________________________________________
Y2038 mailing list
Y2038@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/y2038
WARNING: multiple messages have this Message-ID (diff)
From: dsterba@suse.cz (David Sterba)
To: linux-security-module@vger.kernel.org
Subject: [PATCH 07/12] fs: btrfs: Use ktime_get_real_ts for root ctime
Date: Wed, 12 Apr 2017 15:42:45 +0200 [thread overview]
Message-ID: <20170412134245.GK4781@twin.jikos.cz> (raw)
In-Reply-To: <1491613030-11599-8-git-send-email-deepa.kernel@gmail.com>
On Fri, Apr 07, 2017 at 05:57:05PM -0700, Deepa Dinamani wrote:
> btrfs_root_item maintains the ctime for root updates.
> This is not part of vfs_inode.
>
> Since current_time() uses struct inode* as an argument
> as Linus suggested, this cannot be used to update root
> times unless, we modify the signature to use inode.
>
> Since btrfs uses nanosecond time granularity, it can also
> use ktime_get_real_ts directly to obtain timestamp for
> the root. It is necessary to use the timespec time api
> here because the same btrfs_set_stack_timespec_*() apis
> are used for vfs inode times as well. These can be
> transitioned to using timespec64 when btrfs internally
> changes to use timespec64 as well.
>
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> Acked-by: David Sterba <dsterba@suse.com>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
I'm going to add the patch to my 4.12 queue and will let Andrew know.
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: David Sterba <dsterba@suse.cz>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: yuchao0@huawei.com, bfields@fieldses.org, clm@fb.com,
linux-mtd@lists.infradead.org, dushistov@mail.ru,
jlayton@poochiereds.net, ceph-devel@vger.kernel.org,
devel@driverdev.osuosl.org, linux-cifs@vger.kernel.org,
paul@paul-moore.com, y2038@lists.linaro.org, mingo@redhat.com,
jsimmons@infradead.org, arnd@arndb.de, rostedt@goodmis.org,
oleg.drokin@intel.com, john.stultz@linaro.org,
viro@zeniv.linux.org.uk, dsterba@suse.com, jaegeuk@kernel.org,
tglx@linutronix.de, andreas.dilger@intel.com, jbacik@fb.com,
gregkh@linuxfoundation.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org, eparis@redhat.com,
linux-f2fs-devel@lists.sourceforge.net,
linux-security-module@vger.kernel.org, linux-audit@redhat.com,
netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org,
akpm@linux-foundation.org, davem@davemloft.net,
linux-btrfs@vger.kernel.org, lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH 07/12] fs: btrfs: Use ktime_get_real_ts for root ctime
Date: Wed, 12 Apr 2017 15:42:45 +0200 [thread overview]
Message-ID: <20170412134245.GK4781@twin.jikos.cz> (raw)
In-Reply-To: <1491613030-11599-8-git-send-email-deepa.kernel@gmail.com>
On Fri, Apr 07, 2017 at 05:57:05PM -0700, Deepa Dinamani wrote:
> btrfs_root_item maintains the ctime for root updates.
> This is not part of vfs_inode.
>
> Since current_time() uses struct inode* as an argument
> as Linus suggested, this cannot be used to update root
> times unless, we modify the signature to use inode.
>
> Since btrfs uses nanosecond time granularity, it can also
> use ktime_get_real_ts directly to obtain timestamp for
> the root. It is necessary to use the timespec time api
> here because the same btrfs_set_stack_timespec_*() apis
> are used for vfs inode times as well. These can be
> transitioned to using timespec64 when btrfs internally
> changes to use timespec64 as well.
>
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> Acked-by: David Sterba <dsterba@suse.com>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
I'm going to add the patch to my 4.12 queue and will let Andrew know.
next prev parent reply other threads:[~2017-04-12 13:42 UTC|newest]
Thread overview: 166+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 0:56 [PATCH 00/12] Delete CURRENT_TIME, CURRENT_TIME_SEC and current_fs_time Deepa Dinamani
2017-04-08 0:56 ` [lustre-devel] " Deepa Dinamani
2017-04-08 0:56 ` Deepa Dinamani
2017-04-08 0:56 ` Deepa Dinamani
2017-04-08 0:56 ` [PATCH 01/12] fs: f2fs: Use ktime_get_real_seconds for sit_info times Deepa Dinamani
2017-04-08 0:56 ` [lustre-devel] " Deepa Dinamani
2017-04-08 0:56 ` Deepa Dinamani
2017-04-08 0:56 ` Deepa Dinamani
2017-04-08 0:57 ` [PATCH 02/12] trace: Make trace_hwlat timestamp y2038 safe Deepa Dinamani
2017-04-08 0:57 ` [lustre-devel] " Deepa Dinamani
2017-04-08 0:57 ` Deepa Dinamani
2017-04-08 0:57 ` Deepa Dinamani
2017-04-08 1:30 ` Steven Rostedt
2017-04-08 1:30 ` Steven Rostedt
2017-04-08 1:30 ` Steven Rostedt
2017-04-08 2:16 ` Deepa Dinamani
2017-04-08 2:16 ` [lustre-devel] " Deepa Dinamani
2017-04-08 2:16 ` Deepa Dinamani
2017-04-08 2:16 ` Deepa Dinamani
2017-04-08 2:16 ` Deepa Dinamani
2017-04-08 2:16 ` Deepa Dinamani
2017-04-08 0:57 ` [PATCH 03/12] fs: cifs: Replace CURRENT_TIME by other appropriate apis Deepa Dinamani
2017-04-08 0:57 ` [lustre-devel] " Deepa Dinamani
2017-04-08 0:57 ` Deepa Dinamani
2017-04-08 0:57 ` Deepa Dinamani
2017-04-08 0:57 ` [PATCH 04/12] fs: ceph: CURRENT_TIME with ktime_get_real_ts() Deepa Dinamani
2017-04-08 0:57 ` [lustre-devel] " Deepa Dinamani
2017-04-08 0:57 ` Deepa Dinamani
2017-04-08 0:57 ` Deepa Dinamani
2017-06-01 9:56 ` Yan, Zheng
2017-06-01 9:56 ` Yan, Zheng
2017-06-01 9:56 ` Yan, Zheng
2017-06-01 10:22 ` Arnd Bergmann
2017-06-01 10:22 ` [lustre-devel] " Arnd Bergmann
2017-06-01 10:22 ` Arnd Bergmann
2017-06-01 10:22 ` Arnd Bergmann
2017-06-01 10:22 ` Arnd Bergmann
2017-06-01 10:22 ` Arnd Bergmann
2017-06-02 0:26 ` Yan, Zheng
2017-06-02 0:26 ` Yan, Zheng
2017-06-02 0:26 ` Yan, Zheng
2017-06-02 0:26 ` Yan, Zheng
2017-06-02 0:26 ` Yan, Zheng
2017-06-02 0:36 ` John Stultz
2017-06-02 0:36 ` John Stultz
2017-06-02 0:36 ` John Stultz
2017-06-02 0:36 ` John Stultz
2017-06-02 0:36 ` John Stultz
2017-06-02 0:36 ` John Stultz
2017-06-02 0:57 ` Deepa Dinamani
2017-06-02 0:57 ` [lustre-devel] " Deepa Dinamani
2017-06-02 0:57 ` Deepa Dinamani
2017-06-02 0:57 ` Deepa Dinamani
2017-06-02 0:57 ` Deepa Dinamani
2017-06-02 0:57 ` Deepa Dinamani
2017-06-02 2:09 ` Yan, Zheng
2017-06-02 2:09 ` Yan, Zheng
2017-06-02 2:09 ` Yan, Zheng
2017-06-02 2:09 ` Yan, Zheng
2017-06-02 9:45 ` Arnd Bergmann
2017-06-02 9:45 ` [lustre-devel] " Arnd Bergmann
2017-06-02 9:45 ` Arnd Bergmann
2017-06-02 9:45 ` Arnd Bergmann
2017-06-02 9:45 ` Arnd Bergmann
2017-06-02 9:45 ` Arnd Bergmann
2017-06-02 10:10 ` Yan, Zheng
2017-06-02 10:10 ` Yan, Zheng
2017-06-02 10:10 ` Yan, Zheng
2017-06-02 10:10 ` Yan, Zheng
2017-06-02 10:10 ` Yan, Zheng
2017-06-02 10:51 ` Arnd Bergmann
2017-06-02 10:51 ` [lustre-devel] " Arnd Bergmann
2017-06-02 10:51 ` Arnd Bergmann
2017-06-02 10:51 ` Arnd Bergmann
2017-06-02 10:51 ` Arnd Bergmann
2017-06-02 10:51 ` Arnd Bergmann
2017-06-02 11:18 ` Yan, Zheng
2017-06-02 11:18 ` Yan, Zheng
2017-06-02 11:18 ` Yan, Zheng
2017-06-02 11:18 ` Yan, Zheng
2017-06-02 11:18 ` Yan, Zheng
2017-06-02 11:33 ` Arnd Bergmann
2017-06-02 11:33 ` [lustre-devel] " Arnd Bergmann
2017-06-02 11:33 ` Arnd Bergmann
2017-06-02 11:33 ` Arnd Bergmann
2017-06-02 11:33 ` Arnd Bergmann
2017-06-02 11:33 ` Arnd Bergmann
2017-06-02 12:18 ` Yan, Zheng
2017-06-02 12:18 ` Yan, Zheng
2017-06-02 12:18 ` Yan, Zheng
2017-06-02 12:18 ` Yan, Zheng
2017-06-02 12:18 ` Yan, Zheng
2017-06-02 14:18 ` Arnd Bergmann
2017-06-02 14:18 ` [lustre-devel] " Arnd Bergmann
2017-06-02 14:18 ` Arnd Bergmann
2017-06-02 14:18 ` Arnd Bergmann
2017-06-02 14:18 ` Arnd Bergmann
2017-06-02 14:18 ` Arnd Bergmann
2017-06-04 7:54 ` Yan, Zheng
2017-06-04 7:54 ` Yan, Zheng
2017-06-04 7:54 ` Yan, Zheng
2017-06-04 7:54 ` Yan, Zheng
2017-06-04 7:54 ` Yan, Zheng
2017-06-02 0:35 ` Yan, Zheng
2017-06-02 0:35 ` Yan, Zheng
2017-06-02 0:35 ` Yan, Zheng
2017-06-02 0:35 ` Yan, Zheng
2017-06-02 0:35 ` Yan, Zheng
2017-04-08 0:57 ` [PATCH 05/12] fs: ufs: Use ktime_get_real_ts64() for birthtime Deepa Dinamani
2017-04-08 0:57 ` [lustre-devel] " Deepa Dinamani
2017-04-08 0:57 ` Deepa Dinamani
2017-04-08 0:57 ` Deepa Dinamani
2017-04-08 0:57 ` [PATCH 06/12] audit: Use timespec64 to represent audit timestamps Deepa Dinamani
2017-04-08 0:57 ` [lustre-devel] " Deepa Dinamani
2017-04-08 0:57 ` Deepa Dinamani
2017-04-08 0:57 ` Deepa Dinamani
2017-04-08 12:40 ` Paul Moore
2017-04-08 12:40 ` Paul Moore
2017-04-08 12:40 ` Paul Moore
2017-04-08 17:58 ` Deepa Dinamani
2017-04-08 17:58 ` [lustre-devel] " Deepa Dinamani
2017-04-08 17:58 ` Deepa Dinamani
2017-04-08 17:58 ` Deepa Dinamani
2017-04-08 17:58 ` Deepa Dinamani
2017-04-08 17:58 ` Deepa Dinamani
2017-04-11 20:12 ` Paul Moore
2017-04-11 20:12 ` Paul Moore
2017-04-11 20:12 ` Paul Moore
2017-04-11 20:12 ` Paul Moore
2017-04-11 20:12 ` Paul Moore
2017-04-15 10:29 ` Arnd Bergmann
2017-04-15 10:29 ` [lustre-devel] " Arnd Bergmann
2017-04-15 10:29 ` Arnd Bergmann
2017-04-15 10:29 ` Arnd Bergmann
2017-04-15 10:29 ` Arnd Bergmann
2017-04-08 0:57 ` [PATCH 07/12] fs: btrfs: Use ktime_get_real_ts for root ctime Deepa Dinamani
2017-04-08 0:57 ` [lustre-devel] " Deepa Dinamani
2017-04-08 0:57 ` Deepa Dinamani
2017-04-08 0:57 ` Deepa Dinamani
2017-04-12 13:42 ` David Sterba [this message]
2017-04-12 13:42 ` [lustre-devel] " David Sterba
2017-04-12 13:42 ` David Sterba
2017-04-12 13:42 ` David Sterba
2017-04-08 0:57 ` [PATCH 08/12] fs: ubifs: Replace CURRENT_TIME_SEC with current_time Deepa Dinamani
2017-04-08 0:57 ` [lustre-devel] " Deepa Dinamani
2017-04-08 0:57 ` Deepa Dinamani
2017-04-08 0:57 ` Deepa Dinamani
2017-04-08 0:57 ` [PATCH 09/12] lustre: Replace CURRENT_TIME macro Deepa Dinamani
2017-04-08 0:57 ` [lustre-devel] " Deepa Dinamani
2017-04-08 0:57 ` Deepa Dinamani
2017-04-08 0:57 ` Deepa Dinamani
2017-04-08 0:57 ` [PATCH 10/12] apparmorfs: Replace CURRENT_TIME with current_time() Deepa Dinamani
2017-04-08 0:57 ` [lustre-devel] " Deepa Dinamani
2017-04-08 0:57 ` Deepa Dinamani
2017-04-08 0:57 ` Deepa Dinamani
2017-06-02 7:29 ` John Johansen
2017-06-02 7:29 ` John Johansen
2017-06-02 7:29 ` John Johansen
2017-04-08 0:57 ` [PATCH 11/12] time: Delete CURRENT_TIME_SEC and CURRENT_TIME Deepa Dinamani
2017-04-08 0:57 ` [lustre-devel] " Deepa Dinamani
2017-04-08 0:57 ` Deepa Dinamani
2017-04-08 0:57 ` Deepa Dinamani
2017-04-08 0:57 ` [PATCH 12/12] time: Delete current_fs_time() function Deepa Dinamani
2017-04-08 0:57 ` [lustre-devel] " Deepa Dinamani
2017-04-08 0:57 ` Deepa Dinamani
2017-04-08 0:57 ` Deepa Dinamani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412134245.GK4781@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=andreas.dilger@intel.com \
--cc=arnd@arndb.de \
--cc=bfields@fieldses.org \
--cc=ceph-devel@vger.kernel.org \
--cc=clm@fb.com \
--cc=davem@davemloft.net \
--cc=deepa.kernel@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=dsterba@suse.com \
--cc=dushistov@mail.ru \
--cc=eparis@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jaegeuk@kernel.org \
--cc=jbacik@fb.com \
--cc=jlayton@poochiereds.net \
--cc=john.stultz@linaro.org \
--cc=jsimmons@infradead.org \
--cc=linux-audit@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=paul@paul-moore.com \
--cc=rostedt@goodmis.org \
--cc=samba-technical@lists.samba.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=y2038@lists.linaro.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.