All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] irssi: fix attributes ordering in Config.in
@ 2017-04-12 14:23 Rodrigo Rebello
  2017-04-12 19:02 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Rodrigo Rebello @ 2017-04-12 14:23 UTC (permalink / raw)
  To: buildroot

According to the Buildroot convention, 'depends on' attributes shall
come before 'select' ones in Kconfig files.

Detected by check-package.

Signed-off-by: Rodrigo Rebello <rprebello@gmail.com>
---
 package/irssi/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/irssi/Config.in b/package/irssi/Config.in
index 2cdd06c87..6361cff31 100644
--- a/package/irssi/Config.in
+++ b/package/irssi/Config.in
@@ -1,11 +1,11 @@
 config BR2_PACKAGE_IRSSI
 	bool "irssi"
-	select BR2_PACKAGE_LIBGLIB2
-	select BR2_PACKAGE_NCURSES
-	select BR2_PACKAGE_OPENSSL
 	depends on BR2_USE_WCHAR # libglib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
 	depends on BR2_USE_MMU # fork()
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_NCURSES
+	select BR2_PACKAGE_OPENSSL
 	help
 	  Irssi is a terminal based IRC client for UNIX systems.
 
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] irssi: fix attributes ordering in Config.in
  2017-04-12 14:23 [Buildroot] [PATCH] irssi: fix attributes ordering in Config.in Rodrigo Rebello
@ 2017-04-12 19:02 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2017-04-12 19:02 UTC (permalink / raw)
  To: buildroot

Hello,

On Wed, 12 Apr 2017 11:23:55 -0300, Rodrigo Rebello wrote:
> According to the Buildroot convention, 'depends on' attributes shall
> come before 'select' ones in Kconfig files.
> 
> Detected by check-package.
> 
> Signed-off-by: Rodrigo Rebello <rprebello@gmail.com>
> ---
>  package/irssi/Config.in | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-12 19:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-12 14:23 [Buildroot] [PATCH] irssi: fix attributes ordering in Config.in Rodrigo Rebello
2017-04-12 19:02 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.