From: Borislav Petkov <bp@suse.de>
To: "Verma, Vishal L" <vishal.l.verma@intel.com>
Cc: "Luck, Tony" <tony.luck@intel.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from 'atomic'
Date: Wed, 12 Apr 2017 23:13:03 +0200 [thread overview]
Message-ID: <20170412211302.3d2cxe34sgiu3dag@pd.tnic> (raw)
In-Reply-To: <1492028744.2738.14.camel@intel.com>
On Wed, Apr 12, 2017 at 08:27:05PM +0000, Verma, Vishal L wrote:
> But isn't the atomic notifier call chain always called in atomic
> context?
No, it isn't. We're calling it in normal process context in
mce_gen_pool_process() too.
So this early exit will avoid any sleeping in atomic context. And since
there's nothing you can do about the errors reported in atomic context,
we can actually use that fact.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@suse.de>
To: "Verma, Vishal L" <vishal.l.verma@intel.com>
Cc: "Williams, Dan J" <dan.j.williams@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
"Luck, Tony" <tony.luck@intel.com>,
"ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from 'atomic'
Date: Wed, 12 Apr 2017 23:13:03 +0200 [thread overview]
Message-ID: <20170412211302.3d2cxe34sgiu3dag@pd.tnic> (raw)
In-Reply-To: <1492028744.2738.14.camel@intel.com>
On Wed, Apr 12, 2017 at 08:27:05PM +0000, Verma, Vishal L wrote:
> But isn't the atomic notifier call chain always called in atomic
> context?
No, it isn't. We're calling it in normal process context in
mce_gen_pool_process() too.
So this early exit will avoid any sleeping in atomic context. And since
there's nothing you can do about the errors reported in atomic context,
we can actually use that fact.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
next prev parent reply other threads:[~2017-04-12 21:13 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 22:44 [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from 'atomic' Vishal Verma
2017-04-11 22:44 ` Vishal Verma
2017-04-12 9:14 ` Borislav Petkov
2017-04-12 9:14 ` Borislav Petkov
2017-04-12 19:59 ` Vishal Verma
2017-04-12 19:59 ` Vishal Verma
2017-04-12 20:22 ` Borislav Petkov
2017-04-12 20:22 ` Borislav Petkov
2017-04-12 20:27 ` Verma, Vishal L
2017-04-12 20:27 ` Verma, Vishal L
2017-04-12 20:52 ` Luck, Tony
2017-04-12 20:52 ` Luck, Tony
2017-04-12 20:55 ` Dan Williams
2017-04-12 20:55 ` Dan Williams
2017-04-12 21:12 ` Thomas Gleixner
2017-04-12 21:12 ` Thomas Gleixner
2017-04-12 21:19 ` Luck, Tony
2017-04-12 21:19 ` Luck, Tony
2017-04-12 21:47 ` Borislav Petkov
2017-04-12 21:47 ` Borislav Petkov
2017-04-12 22:16 ` Borislav Petkov
2017-04-12 22:16 ` Borislav Petkov
2017-04-12 22:26 ` Luck, Tony
2017-04-12 22:26 ` Luck, Tony
2017-04-12 22:29 ` Borislav Petkov
2017-04-12 22:29 ` Borislav Petkov
2017-04-13 11:31 ` Borislav Petkov
2017-04-13 11:31 ` Borislav Petkov
2017-04-13 12:12 ` Borislav Petkov
2017-04-13 12:12 ` Borislav Petkov
2017-04-18 16:28 ` Luck, Tony
2017-04-18 16:28 ` Luck, Tony
[not found] ` <20170413113159.rc32ebiswn64nzrr-fF5Pk5pvG8Y@public.gmane.org>
2017-04-21 21:39 ` Verma, Vishal L
2017-04-21 21:39 ` Verma, Vishal L
2017-04-12 21:13 ` Borislav Petkov [this message]
2017-04-12 21:13 ` Borislav Petkov
2017-04-12 21:50 ` Thomas Gleixner
2017-04-12 21:50 ` Thomas Gleixner
2017-04-12 22:42 ` Paul E. McKenney
2017-04-12 22:42 ` Paul E. McKenney
2017-04-12 23:45 ` Paul E. McKenney
2017-04-12 23:45 ` Paul E. McKenney
2017-04-13 14:34 ` Paul E. McKenney
2017-04-13 14:34 ` Paul E. McKenney
2017-04-18 20:27 ` [tip:ras/urgent] x86/mce: Make the MCE notifier a blocking one tip-bot for Vishal Verma
2017-04-18 20:27 ` tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412211302.3d2cxe34sgiu3dag@pd.tnic \
--to=bp@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=tony.luck@intel.com \
--cc=vishal.l.verma@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.