* [PATCH] gpio: dwapb: use dwapb_read instead of readl_relaxed
@ 2017-04-13 9:46 ` Jisheng Zhang
0 siblings, 0 replies; 3+ messages in thread
From: Jisheng Zhang @ 2017-04-13 9:46 UTC (permalink / raw)
To: linus.walleij, gnurou; +Cc: linux-gpio, linux-kernel, Jisheng Zhang
Commit 67809b974a07 ("GPIO: gpio-dwapb: Change readl&writel to
dwapb_read&dwapb_write") missed this readl_relaxed() usage, I'm not
sure the reason, maybe for performance reason? But if we do care
the performance, we could use the relaxed io in dwapb_read and
dwapb_write.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
drivers/gpio/gpio-dwapb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index 9c15ee4ef4e9..fe6cdb5d03d9 100644
--- a/drivers/gpio/gpio-dwapb.c
+++ b/drivers/gpio/gpio-dwapb.c
@@ -128,7 +128,7 @@ static void dwapb_toggle_trigger(struct dwapb_gpio *gpio, unsigned int offs)
static u32 dwapb_do_irq(struct dwapb_gpio *gpio)
{
- u32 irq_status = readl_relaxed(gpio->regs + GPIO_INTSTATUS);
+ u32 irq_status = dwapb_read(gpio, GPIO_INTSTATUS);
u32 ret = irq_status;
while (irq_status) {
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] gpio: dwapb: use dwapb_read instead of readl_relaxed
@ 2017-04-13 9:46 ` Jisheng Zhang
0 siblings, 0 replies; 3+ messages in thread
From: Jisheng Zhang @ 2017-04-13 9:46 UTC (permalink / raw)
To: linus.walleij, gnurou; +Cc: linux-gpio, linux-kernel, Jisheng Zhang
Commit 67809b974a07 ("GPIO: gpio-dwapb: Change readl&writel to
dwapb_read&dwapb_write") missed this readl_relaxed() usage, I'm not
sure the reason, maybe for performance reason? But if we do care
the performance, we could use the relaxed io in dwapb_read and
dwapb_write.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
drivers/gpio/gpio-dwapb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index 9c15ee4ef4e9..fe6cdb5d03d9 100644
--- a/drivers/gpio/gpio-dwapb.c
+++ b/drivers/gpio/gpio-dwapb.c
@@ -128,7 +128,7 @@ static void dwapb_toggle_trigger(struct dwapb_gpio *gpio, unsigned int offs)
static u32 dwapb_do_irq(struct dwapb_gpio *gpio)
{
- u32 irq_status = readl_relaxed(gpio->regs + GPIO_INTSTATUS);
+ u32 irq_status = dwapb_read(gpio, GPIO_INTSTATUS);
u32 ret = irq_status;
while (irq_status) {
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: dwapb: use dwapb_read instead of readl_relaxed
2017-04-13 9:46 ` Jisheng Zhang
(?)
@ 2017-04-24 13:09 ` Linus Walleij
-1 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2017-04-24 13:09 UTC (permalink / raw)
To: Jisheng Zhang; +Cc: Alexandre Courbot, linux-gpio, linux-kernel
On Thu, Apr 13, 2017 at 11:46 AM, Jisheng Zhang <jszhang@marvell.com> wrote:
> Commit 67809b974a07 ("GPIO: gpio-dwapb: Change readl&writel to
> dwapb_read&dwapb_write") missed this readl_relaxed() usage, I'm not
> sure the reason, maybe for performance reason? But if we do care
> the performance, we could use the relaxed io in dwapb_read and
> dwapb_write.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-24 13:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-13 9:46 [PATCH] gpio: dwapb: use dwapb_read instead of readl_relaxed Jisheng Zhang
2017-04-13 9:46 ` Jisheng Zhang
2017-04-24 13:09 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.