From: Michal Hocko <mhocko@kernel.org> To: Vlastimil Babka <vbabka@suse.cz> Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>, Mel Gorman <mgorman@suse.de>, Andrea Arcangeli <aarcange@redhat.com>, Jerome Glisse <jglisse@redhat.com>, Reza Arbab <arbab@linux.vnet.ibm.com>, Yasuaki Ishimatsu <yasu.isimatu@gmail.com>, qiuxishi@huawei.com, Kani Toshimitsu <toshi.kani@hpe.com>, slaoub@gmail.com, Joonsoo Kim <js1304@gmail.com>, Andi Kleen <ak@linux.intel.com>, David Rientjes <rientjes@google.com>, Daniel Kiper <daniel.kiper@oracle.com>, Igor Mammedov <imammedo@redhat.com>, Vitaly Kuznetsov <vkuznets@redhat.com>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 5/9] mm, memory_hotplug: split up register_one_node Date: Thu, 13 Apr 2017 16:13:16 +0200 [thread overview] Message-ID: <20170413141316.GC11795@dhcp22.suse.cz> (raw) In-Reply-To: <a06d1e36-f8ae-c8c5-dd2c-e535cf740ed6@suse.cz> On Thu 13-04-17 16:05:17, Vlastimil Babka wrote: > On 04/10/2017 01:03 PM, Michal Hocko wrote: > > From: Michal Hocko <mhocko@suse.com> > > > > Memory hotplug (add_memory_resource) has to reinitialize node > > infrastructure if the node is offline (one which went through the > > complete add_memory(); remove_memory() cycle). That involves node > > registration to the kobj infrastructure (register_node), the proper > > association with cpus (register_cpu_under_node) and finally creation of > > node<->memblock symlinks (link_mem_sections). > > > > The last part requires to know node_start_pfn and node_spanned_pages > > which we currently have but a leter patch will postpone this > > initialization to the onlining phase which happens later. In fact we do > > not need to rely on the early pgdat initialization even now because the > > currently hot added pfn range is currently known. > > > > Split register_one_node into core which does all the common work for > > the boot time NUMA initialization and the hotplug (__register_one_node). > > register_one_node keeps the full initialization while hotplug calls > > __register_one_node and manually calls link_mem_sections for the proper > > range. > > > > This shouldn't introduce any functional change. > > > > Signed-off-by: Michal Hocko <mhocko@suse.com> > > Acked-by: Vlastimil Babka <vbabka@suse.cz> Thanks! > nit: > > @@ -1387,7 +1387,22 @@ int __ref add_memory_resource(int nid, struct resource *res, bool online) > > node_set_online(nid); > > > > if (new_node) { > > - ret = register_one_node(nid); > > + unsigned long start_pfn = start >> PAGE_SHIFT; > > + unsigned long nr_pages = size >> PAGE_SHIFT; > > + > > + ret = __register_one_node(nid); > > + if (ret) > > + goto register_fail; > > + > > + /* > > + * link memory sections under this node. This is already > > + * done when creatig memory section in register_new_memory > > + * but that depends to have the node registered so offline > > + * nodes have to go through register_node. > > + * TODO clean up this mess. > > Is this a work-in-progress or final TODO? :) I do not plan to address it in this series, but I will revisit it later. There are more like this in other patches. -- Michal Hocko SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org> To: Vlastimil Babka <vbabka@suse.cz> Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>, Mel Gorman <mgorman@suse.de>, Andrea Arcangeli <aarcange@redhat.com>, Jerome Glisse <jglisse@redhat.com>, Reza Arbab <arbab@linux.vnet.ibm.com>, Yasuaki Ishimatsu <yasu.isimatu@gmail.com>, qiuxishi@huawei.com, Kani Toshimitsu <toshi.kani@hpe.com>, slaoub@gmail.com, Joonsoo Kim <js1304@gmail.com>, Andi Kleen <ak@linux.intel.com>, David Rientjes <rientjes@google.com>, Daniel Kiper <daniel.kiper@oracle.com>, Igor Mammedov <imammedo@redhat.com>, Vitaly Kuznetsov <vkuznets@redhat.com>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 5/9] mm, memory_hotplug: split up register_one_node Date: Thu, 13 Apr 2017 16:13:16 +0200 [thread overview] Message-ID: <20170413141316.GC11795@dhcp22.suse.cz> (raw) In-Reply-To: <a06d1e36-f8ae-c8c5-dd2c-e535cf740ed6@suse.cz> On Thu 13-04-17 16:05:17, Vlastimil Babka wrote: > On 04/10/2017 01:03 PM, Michal Hocko wrote: > > From: Michal Hocko <mhocko@suse.com> > > > > Memory hotplug (add_memory_resource) has to reinitialize node > > infrastructure if the node is offline (one which went through the > > complete add_memory(); remove_memory() cycle). That involves node > > registration to the kobj infrastructure (register_node), the proper > > association with cpus (register_cpu_under_node) and finally creation of > > node<->memblock symlinks (link_mem_sections). > > > > The last part requires to know node_start_pfn and node_spanned_pages > > which we currently have but a leter patch will postpone this > > initialization to the onlining phase which happens later. In fact we do > > not need to rely on the early pgdat initialization even now because the > > currently hot added pfn range is currently known. > > > > Split register_one_node into core which does all the common work for > > the boot time NUMA initialization and the hotplug (__register_one_node). > > register_one_node keeps the full initialization while hotplug calls > > __register_one_node and manually calls link_mem_sections for the proper > > range. > > > > This shouldn't introduce any functional change. > > > > Signed-off-by: Michal Hocko <mhocko@suse.com> > > Acked-by: Vlastimil Babka <vbabka@suse.cz> Thanks! > nit: > > @@ -1387,7 +1387,22 @@ int __ref add_memory_resource(int nid, struct resource *res, bool online) > > node_set_online(nid); > > > > if (new_node) { > > - ret = register_one_node(nid); > > + unsigned long start_pfn = start >> PAGE_SHIFT; > > + unsigned long nr_pages = size >> PAGE_SHIFT; > > + > > + ret = __register_one_node(nid); > > + if (ret) > > + goto register_fail; > > + > > + /* > > + * link memory sections under this node. This is already > > + * done when creatig memory section in register_new_memory > > + * but that depends to have the node registered so offline > > + * nodes have to go through register_node. > > + * TODO clean up this mess. > > Is this a work-in-progress or final TODO? :) I do not plan to address it in this series, but I will revisit it later. There are more like this in other patches. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-04-13 14:13 UTC|newest] Thread overview: 169+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-10 11:03 [PATCH -v2 0/9] mm: make movable onlining suck less Michal Hocko 2017-04-10 11:03 ` Michal Hocko 2017-04-10 11:03 ` [PATCH 1/9] mm: remove return value from init_currently_empty_zone Michal Hocko 2017-04-10 11:03 ` Michal Hocko 2017-04-11 8:10 ` Balbir Singh 2017-04-11 8:10 ` Balbir Singh 2017-04-13 12:03 ` Vlastimil Babka 2017-04-13 12:03 ` Vlastimil Babka 2017-04-13 19:43 ` YASUAKI ISHIMATSU 2017-04-13 19:43 ` YASUAKI ISHIMATSU 2017-04-10 11:03 ` [PATCH 2/9] mm, memory_hotplug: use node instead of zone in can_online_high_movable Michal Hocko 2017-04-10 11:03 ` Michal Hocko 2017-04-13 12:46 ` Vlastimil Babka 2017-04-13 12:46 ` Vlastimil Babka 2017-04-13 19:45 ` YASUAKI ISHIMATSU 2017-04-13 19:45 ` YASUAKI ISHIMATSU 2017-04-10 11:03 ` [PATCH 3/9] mm: drop page_initialized check from get_nid_for_pfn Michal Hocko 2017-04-10 11:03 ` Michal Hocko 2017-04-13 12:59 ` Vlastimil Babka 2017-04-13 12:59 ` Vlastimil Babka 2017-04-10 11:03 ` [PATCH 4/9] mm, memory_hotplug: get rid of is_zone_device_section Michal Hocko 2017-04-10 11:03 ` Michal Hocko 2017-04-10 16:20 ` Jerome Glisse 2017-04-10 16:20 ` Jerome Glisse 2017-04-10 16:31 ` Michal Hocko 2017-04-10 16:31 ` Michal Hocko 2017-04-13 13:05 ` Vlastimil Babka 2017-04-13 13:05 ` Vlastimil Babka 2017-04-17 20:12 ` Jerome Glisse 2017-04-17 20:12 ` Jerome Glisse 2017-04-18 7:19 ` Michal Hocko 2017-04-18 7:19 ` Michal Hocko 2017-04-10 11:03 ` [PATCH 5/9] mm, memory_hotplug: split up register_one_node Michal Hocko 2017-04-10 11:03 ` Michal Hocko 2017-04-13 14:05 ` Vlastimil Babka 2017-04-13 14:05 ` Vlastimil Babka 2017-04-13 14:13 ` Michal Hocko [this message] 2017-04-13 14:13 ` Michal Hocko 2017-04-10 11:03 ` [PATCH 6/9] mm, memory_hotplug: do not associate hotadded memory to zones until online Michal Hocko 2017-04-10 11:03 ` Michal Hocko 2017-04-10 16:25 ` [PATCH v3 " Michal Hocko 2017-04-10 16:25 ` Michal Hocko 2017-04-20 8:25 ` Vlastimil Babka 2017-04-20 8:25 ` Vlastimil Babka 2017-04-20 9:06 ` Michal Hocko 2017-04-20 9:06 ` Michal Hocko 2017-04-20 10:51 ` Vlastimil Babka 2017-04-20 10:51 ` Vlastimil Babka 2017-04-10 11:03 ` [PATCH 7/9] mm, memory_hotplug: replace for_device by want_memblock in arch_add_memory Michal Hocko 2017-04-10 11:03 ` Michal Hocko 2017-04-20 8:29 ` Vlastimil Babka 2017-04-20 8:29 ` Vlastimil Babka 2017-04-10 11:03 ` [PATCH 8/9] mm, memory_hotplug: fix the section mismatch warning Michal Hocko 2017-04-10 11:03 ` Michal Hocko 2017-04-10 11:03 ` [PATCH 9/9] mm, memory_hotplug: remove unused cruft after memory hotplug rework Michal Hocko 2017-04-10 11:03 ` Michal Hocko 2017-04-20 8:38 ` Vlastimil Babka 2017-04-20 8:38 ` Vlastimil Babka 2017-04-10 14:27 ` [PATCH -v2 0/9] mm: make movable onlining suck less Igor Mammedov 2017-04-10 14:27 ` Igor Mammedov 2017-04-10 14:56 ` Michal Hocko 2017-04-10 14:56 ` Michal Hocko 2017-04-10 15:22 ` Michal Hocko 2017-04-10 15:22 ` Michal Hocko 2017-04-10 15:31 ` Michal Hocko 2017-04-10 15:31 ` Michal Hocko 2017-04-11 8:01 ` Igor Mammedov 2017-04-11 8:01 ` Igor Mammedov 2017-04-11 8:41 ` Michal Hocko 2017-04-11 8:41 ` Michal Hocko 2017-04-11 9:53 ` Igor Mammedov 2017-04-11 9:53 ` Igor Mammedov 2017-04-11 10:47 ` Michal Hocko 2017-04-11 10:47 ` Michal Hocko 2017-04-10 16:02 ` Michal Hocko 2017-04-10 16:02 ` Michal Hocko 2017-04-18 8:23 ` Vlastimil Babka 2017-04-18 8:23 ` Vlastimil Babka 2017-04-10 16:09 ` Michal Hocko 2017-04-10 16:09 ` Michal Hocko 2017-04-11 6:38 ` Igor Mammedov 2017-04-11 6:38 ` Igor Mammedov 2017-04-11 9:23 ` Michal Hocko 2017-04-11 9:23 ` Michal Hocko 2017-04-11 9:59 ` Igor Mammedov 2017-04-11 9:59 ` Igor Mammedov 2017-04-11 11:01 ` Michal Hocko 2017-04-11 11:01 ` Michal Hocko 2017-04-11 11:38 ` Michal Hocko 2017-04-11 11:38 ` Michal Hocko 2017-04-11 12:38 ` Michal Hocko 2017-04-11 12:38 ` Michal Hocko 2017-04-10 15:43 ` Reza Arbab 2017-04-10 15:43 ` Reza Arbab 2017-04-11 8:59 ` Michal Hocko 2017-04-11 8:59 ` Michal Hocko 2017-04-10 16:35 ` Jerome Glisse 2017-04-10 16:35 ` Jerome Glisse 2017-04-10 17:53 ` Michal Hocko 2017-04-10 17:53 ` Michal Hocko 2017-04-11 2:51 ` Balbir Singh 2017-04-11 2:51 ` Balbir Singh 2017-04-11 17:03 ` Michal Hocko 2017-04-11 17:03 ` Michal Hocko 2017-04-17 21:51 ` Dan Williams 2017-04-17 21:51 ` Dan Williams 2017-04-18 7:14 ` Michal Hocko 2017-04-18 7:14 ` Michal Hocko 2017-04-18 16:42 ` Dan Williams 2017-04-18 16:42 ` Dan Williams 2017-04-18 19:54 ` Michal Hocko 2017-04-18 19:54 ` Michal Hocko 2017-04-20 3:37 ` Dan Williams 2017-04-20 3:37 ` Dan Williams 2017-04-15 12:17 ` Michal Hocko 2017-04-15 12:17 ` Michal Hocko 2017-04-15 12:17 ` [PATCH 1/3] mm: consider zone which is not fully populated to have holes Michal Hocko 2017-04-15 12:17 ` Michal Hocko 2017-04-18 8:45 ` Vlastimil Babka 2017-04-18 8:45 ` Vlastimil Babka 2017-04-18 9:27 ` Michal Hocko 2017-04-18 9:27 ` Michal Hocko 2017-04-19 11:59 ` Vlastimil Babka 2017-04-19 11:59 ` Vlastimil Babka 2017-04-19 12:16 ` Michal Hocko 2017-04-19 12:16 ` Michal Hocko 2017-04-19 12:34 ` Vlastimil Babka 2017-04-19 12:34 ` Vlastimil Babka 2017-04-19 12:50 ` Michal Hocko 2017-04-19 12:50 ` Michal Hocko 2017-04-15 12:17 ` [PATCH 2/3] mm, compaction: skip over holes in __reset_isolation_suitable Michal Hocko 2017-04-15 12:17 ` Michal Hocko 2017-04-15 12:17 ` [PATCH 3/3] mm: __first_valid_page skip over offline pages Michal Hocko 2017-04-15 12:17 ` Michal Hocko 2017-04-17 5:47 ` your mail Joonsoo Kim 2017-04-17 5:47 ` Joonsoo Kim 2017-04-17 8:15 ` Michal Hocko 2017-04-17 8:15 ` Michal Hocko 2017-04-20 1:27 ` Joonsoo Kim 2017-04-20 1:27 ` Joonsoo Kim 2017-04-20 7:28 ` Michal Hocko 2017-04-20 7:28 ` Michal Hocko 2017-04-20 8:49 ` Michal Hocko 2017-04-20 8:49 ` Michal Hocko 2017-04-20 11:56 ` Vlastimil Babka 2017-04-20 11:56 ` Vlastimil Babka 2017-04-20 12:13 ` Michal Hocko 2017-04-20 12:13 ` Michal Hocko 2017-04-21 2:46 ` [lkp-robot] 73821bb516: WARNING:at_mm/memblock.c:#memblock_virt_alloc_internal kernel test robot 2017-04-21 2:46 ` kernel test robot 2017-04-21 8:05 ` Michal Hocko 2017-04-21 8:05 ` Michal Hocko 2017-04-21 8:05 ` Michal Hocko 2017-04-21 4:38 ` your mail Joonsoo Kim 2017-04-21 4:38 ` Joonsoo Kim 2017-04-21 7:16 ` Michal Hocko 2017-04-21 7:16 ` Michal Hocko 2017-04-24 1:44 ` Joonsoo Kim 2017-04-24 1:44 ` Joonsoo Kim 2017-04-24 7:53 ` Michal Hocko 2017-04-24 7:53 ` Michal Hocko 2017-04-25 2:50 ` Joonsoo Kim 2017-04-25 2:50 ` Joonsoo Kim 2017-04-26 9:19 ` Michal Hocko 2017-04-26 9:19 ` Michal Hocko 2017-04-27 2:08 ` Joonsoo Kim 2017-04-27 2:08 ` Joonsoo Kim 2017-04-27 15:10 ` Michal Hocko 2017-04-27 15:10 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170413141316.GC11795@dhcp22.suse.cz \ --to=mhocko@kernel.org \ --cc=aarcange@redhat.com \ --cc=ak@linux.intel.com \ --cc=akpm@linux-foundation.org \ --cc=arbab@linux.vnet.ibm.com \ --cc=daniel.kiper@oracle.com \ --cc=imammedo@redhat.com \ --cc=jglisse@redhat.com \ --cc=js1304@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=qiuxishi@huawei.com \ --cc=rientjes@google.com \ --cc=slaoub@gmail.com \ --cc=toshi.kani@hpe.com \ --cc=vbabka@suse.cz \ --cc=vkuznets@redhat.com \ --cc=yasu.isimatu@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.