All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: David Carrillo-Cisneros <davidcc@google.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Andi Kleen <ak@linux.intel.com>, Simon Que <sque@chromium.org>,
	Wang Nan <wangnan0@huawei.com>, Jiri Olsa <jolsa@kernel.org>,
	He Kuang <hekuang@huawei.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Stephane Eranian <eranian@google.com>,
	Paul Turner <pjt@google.com>
Subject: Re: [PATCH 4/6] perf report: hint .perfconfig error when invalid sorting key
Date: Thu, 13 Apr 2017 11:53:50 -0300	[thread overview]
Message-ID: <20170413145350.GR3275@kernel.org> (raw)
In-Reply-To: <CALcN6mhCpTBvcO2Xt4388HMY0a1KLoJFM=4N2mQ3E91rp3g2fg@mail.gmail.com>

Em Wed, Apr 12, 2017 at 09:34:37AM -0700, David Carrillo-Cisneros escreveu:
> > On Tue, Apr 11, 2017 at 11:49:17PM -0700, David Carrillo-Cisneros wrote:
> >> My fat-fingering of sort keys in .perfconfig was a common cause of
> >> perf report silently terminating without apparent error.
> >>
> >> This was because 1) error in setup_sorting in cmd_report was ignored
> >> and 2) no message was log in UI browser that would prevent UI from
> >> exit before user prompt. Fix both.
> >
> > there's UI init ahead of this code.. I had to move it
> > below your code to spot any error message
> >
> > there's other errors further on.. perhaps we should move it even further ;-)
> > or cancel the ui before the error is printed
> 
> Probably canceling ui on error is the more robust way to go. I will
> look into it.

So I'll wait for a v2 for this specific patch.

  reply	other threads:[~2017-04-13 14:54 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-12  6:49 [PATCH 0/6] perf tool: build and usage hints David Carrillo-Cisneros
2017-04-12  6:49 ` [PATCH 1/6] perf tools: pass PYTHON config to feature detection David Carrillo-Cisneros
2017-04-17  8:33   ` [tip:perf/core] perf tools: Pass " tip-bot for David Carrillo-Cisneros
2017-04-12  6:49 ` [PATCH 2/6] tools build: fix feature detection redefinion of build flags David Carrillo-Cisneros
2017-04-17  8:35   ` [tip:perf/core] tools build: Fix " tip-bot for David Carrillo-Cisneros
2017-04-12  6:49 ` [PATCH 2/6] tools build: fix feature redefine " David Carrillo-Cisneros
2017-04-12  7:56   ` Jiri Olsa
2017-04-12 16:30     ` David Carrillo-Cisneros
2017-04-13 14:52       ` Arnaldo Carvalho de Melo
2017-04-12  6:49 ` [PATCH 3/6] perf util: hint missing file when tool tips fail to load David Carrillo-Cisneros
2017-04-17  8:36   ` [tip:perf/core] perf util: Hint " tip-bot for David Carrillo-Cisneros
2017-04-12  6:49 ` [PATCH 4/6] perf report: hint .perfconfig error when invalid sorting key David Carrillo-Cisneros
2017-04-12  8:17   ` Jiri Olsa
2017-04-12 16:34     ` David Carrillo-Cisneros
2017-04-13 14:53       ` Arnaldo Carvalho de Melo [this message]
2017-04-12  6:49 ` [PATCH 5/6] perf tools: disable JVMTI if no ELF support available David Carrillo-Cisneros
2017-04-12  8:19   ` Jiri Olsa
2017-04-12 17:07     ` David Carrillo-Cisneros
2017-04-12 17:33       ` Jiri Olsa
2017-04-13 14:47         ` Arnaldo Carvalho de Melo
2017-04-17  8:35       ` [tip:perf/core] perf tools: Disable " tip-bot for David Carrillo-Cisneros
2017-04-13 11:40   ` [PATCH 5/6] perf tools: disable " Kim Phillips
2017-04-12  6:49 ` [PATCH 6/6] Revert "perf tools: Fix include of linux/mman.h" David Carrillo-Cisneros
2017-04-17  8:36   ` [tip:perf/core] " tip-bot for David Carrillo-Cisneros
2017-04-12  8:20 ` [PATCH 0/6] perf tool: build and usage hints Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170413145350.GR3275@kernel.org \
    --to=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=davidcc@google.com \
    --cc=eranian@google.com \
    --cc=hekuang@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=sque@chromium.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.