From: tip-bot for David Carrillo-Cisneros <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: mingo@kernel.org, acme@redhat.com, jolsa@kernel.org,
eranian@google.com, hpa@zytor.com, tglx@linutronix.de,
davidcc@google.com, pjt@google.com, peterz@infradead.org,
linux-kernel@vger.kernel.org, sque@chromium.org,
wangnan0@huawei.com, ak@linux.intel.com, mhiramat@kernel.org,
alexander.shishkin@linux.intel.com, hekuang@huawei.com
Subject: [tip:perf/core] perf util: Hint missing file when tool tips fail to load
Date: Mon, 17 Apr 2017 01:36:27 -0700 [thread overview]
Message-ID: <tip-570eda03213a216a88566c0da7bfe175832cfaa4@git.kernel.org> (raw)
In-Reply-To: <20170412064919.92449-5-davidcc@google.com>
Commit-ID: 570eda03213a216a88566c0da7bfe175832cfaa4
Gitweb: http://git.kernel.org/tip/570eda03213a216a88566c0da7bfe175832cfaa4
Author: David Carrillo-Cisneros <davidcc@google.com>
AuthorDate: Tue, 11 Apr 2017 23:49:16 -0700
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 13 Apr 2017 11:52:51 -0300
perf util: Hint missing file when tool tips fail to load
Besides memory allocation failure, tips.txt may fail to load because the
file is not found (a more likely cause).
Communicate that to the user in tips failure warning.
Signed-off-by: David Carrillo-Cisneros <davidcc@google.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: He Kuang <hekuang@huawei.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Paul Turner <pjt@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Simon Que <sque@chromium.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/20170412064919.92449-5-davidcc@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/util.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index d8b45ce..6097d87 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -696,7 +696,8 @@ const char *perf_tip(const char *dirpath)
tips = strlist__new("tips.txt", &conf);
if (tips == NULL)
- return errno == ENOENT ? NULL : "Tip: get more memory! ;-p";
+ return errno == ENOENT ? NULL :
+ "Tip: check path of tips.txt or get more memory! ;-p";
if (strlist__nr_entries(tips) == 0)
goto out;
next prev parent reply other threads:[~2017-04-17 8:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 6:49 [PATCH 0/6] perf tool: build and usage hints David Carrillo-Cisneros
2017-04-12 6:49 ` [PATCH 1/6] perf tools: pass PYTHON config to feature detection David Carrillo-Cisneros
2017-04-17 8:33 ` [tip:perf/core] perf tools: Pass " tip-bot for David Carrillo-Cisneros
2017-04-12 6:49 ` [PATCH 2/6] tools build: fix feature detection redefinion of build flags David Carrillo-Cisneros
2017-04-17 8:35 ` [tip:perf/core] tools build: Fix " tip-bot for David Carrillo-Cisneros
2017-04-12 6:49 ` [PATCH 2/6] tools build: fix feature redefine " David Carrillo-Cisneros
2017-04-12 7:56 ` Jiri Olsa
2017-04-12 16:30 ` David Carrillo-Cisneros
2017-04-13 14:52 ` Arnaldo Carvalho de Melo
2017-04-12 6:49 ` [PATCH 3/6] perf util: hint missing file when tool tips fail to load David Carrillo-Cisneros
2017-04-17 8:36 ` tip-bot for David Carrillo-Cisneros [this message]
2017-04-12 6:49 ` [PATCH 4/6] perf report: hint .perfconfig error when invalid sorting key David Carrillo-Cisneros
2017-04-12 8:17 ` Jiri Olsa
2017-04-12 16:34 ` David Carrillo-Cisneros
2017-04-13 14:53 ` Arnaldo Carvalho de Melo
2017-04-12 6:49 ` [PATCH 5/6] perf tools: disable JVMTI if no ELF support available David Carrillo-Cisneros
2017-04-12 8:19 ` Jiri Olsa
2017-04-12 17:07 ` David Carrillo-Cisneros
2017-04-12 17:33 ` Jiri Olsa
2017-04-13 14:47 ` Arnaldo Carvalho de Melo
2017-04-17 8:35 ` [tip:perf/core] perf tools: Disable " tip-bot for David Carrillo-Cisneros
2017-04-13 11:40 ` [PATCH 5/6] perf tools: disable " Kim Phillips
2017-04-12 6:49 ` [PATCH 6/6] Revert "perf tools: Fix include of linux/mman.h" David Carrillo-Cisneros
2017-04-17 8:36 ` [tip:perf/core] " tip-bot for David Carrillo-Cisneros
2017-04-12 8:20 ` [PATCH 0/6] perf tool: build and usage hints Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-570eda03213a216a88566c0da7bfe175832cfaa4@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=davidcc@google.com \
--cc=eranian@google.com \
--cc=hekuang@huawei.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=sque@chromium.org \
--cc=tglx@linutronix.de \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.