* [PATCH] net/virtio-user: fix net status report
@ 2017-04-13 10:50 Jianfeng Tan
2017-04-13 14:16 ` [PATCH v2] " Jianfeng Tan
0 siblings, 1 reply; 3+ messages in thread
From: Jianfeng Tan @ 2017-04-13 10:50 UTC (permalink / raw)
To: dev; +Cc: yuanhan.liu, Jianfeng Tan
We only enabled LSC when using vhost-user as the backend, but it is
reported even when using vhost-kernel as the backend.
Fix it by only reportting LSC support when using vhost-user as the
backend.
Fixes: 37a7eb2ae816("net/virtio-user: support to report net status")
Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
---
drivers/net/virtio/virtio_user/virtio_user_dev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c
index 299ee16..c9e8ac5 100644
--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
@@ -379,7 +379,8 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,
}
/* The backend will not report this feature, we add it explicitly */
- dev->device_features |= (1ull << VIRTIO_NET_F_STATUS);
+ if (is_vhost_user_by_type(dev->path))
+ dev->device_features |= (1ull << VIRTIO_NET_F_STATUS);
dev->device_features &= VIRTIO_USER_SUPPORTED_FEATURES;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2] net/virtio-user: fix net status report
2017-04-13 10:50 [PATCH] net/virtio-user: fix net status report Jianfeng Tan
@ 2017-04-13 14:16 ` Jianfeng Tan
2017-04-14 4:37 ` Yuanhan Liu
0 siblings, 1 reply; 3+ messages in thread
From: Jianfeng Tan @ 2017-04-13 14:16 UTC (permalink / raw)
To: dev; +Cc: yuanhan.liu, Jianfeng Tan
We only enabled LSC when using vhost-user as the backend, but it is
reported even when using vhost-kernel as the backend.
Fix it by only reportting LSC support when using vhost-user as the
backend.
Fixes: 35c4f8554833 ("net/virtio-user: support to report net status")
Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
---
v2: Correct the wrong commit number in Fixes line.
drivers/net/virtio/virtio_user/virtio_user_dev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c
index 299ee16..c9e8ac5 100644
--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
@@ -379,7 +379,8 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,
}
/* The backend will not report this feature, we add it explicitly */
- dev->device_features |= (1ull << VIRTIO_NET_F_STATUS);
+ if (is_vhost_user_by_type(dev->path))
+ dev->device_features |= (1ull << VIRTIO_NET_F_STATUS);
dev->device_features &= VIRTIO_USER_SUPPORTED_FEATURES;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net/virtio-user: fix net status report
2017-04-13 14:16 ` [PATCH v2] " Jianfeng Tan
@ 2017-04-14 4:37 ` Yuanhan Liu
0 siblings, 0 replies; 3+ messages in thread
From: Yuanhan Liu @ 2017-04-14 4:37 UTC (permalink / raw)
To: Jianfeng Tan; +Cc: dev
On Thu, Apr 13, 2017 at 02:16:24PM +0000, Jianfeng Tan wrote:
> We only enabled LSC when using vhost-user as the backend, but it is
> reported even when using vhost-kernel as the backend.
>
> Fix it by only reportting LSC support when using vhost-user as the
> backend.
>
> Fixes: 35c4f8554833 ("net/virtio-user: support to report net status")
>
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
Applied to dpdk-next-virtio.
Thanks.
--yliu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-14 4:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-13 10:50 [PATCH] net/virtio-user: fix net status report Jianfeng Tan
2017-04-13 14:16 ` [PATCH v2] " Jianfeng Tan
2017-04-14 4:37 ` Yuanhan Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.